)]}'
{"id":"openstack%2Fbifrost~858389","triplet_id":"openstack%2Fbifrost~stable%2Fyoga~Ieb35391fae5bd24ab420dc4239117e045f8b35ed","project":"openstack/bifrost","branch":"stable/yoga","topic":"no-install-grub-yoga","attention_set":{},"removed_from_attention_set":{"10239":{"account":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"last_update":"2022-09-19 15:52:22.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ieb35391fae5bd24ab420dc4239117e045f8b35ed","subject":"Simplify bifrost-ironic-install required_defaults","status":"ABANDONED","created":"2022-09-19 14:28:43.000000000","updated":"2022-09-19 15:52:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d95bd8df43e9cb5feb244a5bdb99c9c68ed7de28","_number":858389,"virtual_id_number":858389,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-09-19 15:41:08.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-19 14:28:43.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"state":"CC"},{"updated":"2022-09-19 15:41:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1ef1639981f731e26b38cb0989af0fc15b74a18d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-09-19 14:28:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cf28de4ebf306a567c806a359c2f2891c3e63303","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-19 15:41:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/764f51748d044e9a8e09f6eedce6552e\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8cc4add40c1c44ae8b6da5ebd746b5e9 : SUCCESS in 3m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f1626cc482d24588ae4135b49546b66b : SUCCESS in 4m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ffaae35de7a14dd7bc8314ccd2e3e7e2 : SUCCESS in 4m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f01c73a8c03c434dbb728e98b3d4a499 : SUCCESS in 6m 54s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/dd1b35a719974bb5b0ee58b1680cac81 : SUCCESS in 7m 06s\n- bifrost-integration-tinyipa-centos-9 https://zuul.opendev.org/t/openstack/build/9d9dfeff673a44679942360fb8d8aa52 : SUCCESS in 34m 58s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bd3196015de44bb1a81553dd5bdfaa07 : SUCCESS in 31m 40s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/d87a99b95707456da7f7542462c85b0b : SUCCESS in 32m 22s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7e0e72822e234634adfd076da5b4334b : SUCCESS in 33m 09s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/5cfe54324d45409cb4b42559a90e9a5d : SUCCESS in 37m 20s\n- bifrost-integration-tinyipa-keystone-centos-9 https://zuul.opendev.org/t/openstack/build/32e4a4a6ef45421fa08985d162ae060c : SUCCESS in 33m 03s\n- bifrost-integration-tinyipa-debian-bullseye https://zuul.opendev.org/t/openstack/build/7bbd3c16c73a4a6e9dd4efecd4654dbf : FAILURE in 11m 00s\n- bifrost-integration-redfish-vmedia-uefi-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5b848c7df4c641749c0ea474dd1fd315 : SUCCESS in 27m 06s\n- bifrost-integration-redfish-vmedia-uefi-centos-8 https://zuul.opendev.org/t/openstack/build/133efe09cc484aeaa09dd12205936e96 : SUCCESS in 32m 11s\n- bifrost-integration-redfish-vmedia-uefi-centos-9 https://zuul.opendev.org/t/openstack/build/6fa44eae1f46467392cd057b4e97a123 : SUCCESS in 33m 08s\n- bifrost-upgrade-ubuntu-focal https://zuul.opendev.org/t/openstack/build/cb3099f08fa846b68ac25e5d537b8e5e : SUCCESS in 54m 49s\n- bifrost-upgrade-keystone-centos8 https://zuul.opendev.org/t/openstack/build/91ebecda06f0448c93b0d67f063bfe39 : SUCCESS in 1h 06m 14s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/99955af10bf245beac9e99cf949b85a5 : SUCCESS in 35m 31s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/2e28029ff920476e85fc81334f76ef7f : SUCCESS in 30m 11s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/6e5ce73e91d141d286496ea73e9a9752 : NODE_FAILURE in 0s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/f56ae8d988b04c4d9bcfc9259c714419 : FAILURE in 10m 10s (non-voting)\n- bifrost-integration-redfish-uefi-fedora-latest https://zuul.opendev.org/t/openstack/build/26adc7d918284606ac1aefe676f83c3c : NODE_FAILURE in 0s (non-voting)\n- bifrost-integration-dhcp-ubuntu-focal https://zuul.opendev.org/t/openstack/build/656a99b083ab40d4aab397112d267e8c : SUCCESS in 36m 09s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/bfdd499bfc39432380b56924802132ab : SUCCESS in 42m 11s (non-voting)\n- bifrost-integration-dhcp-centos-9 https://zuul.opendev.org/t/openstack/build/94456a92e5c74b14a4af741f1bb35191 : SUCCESS in 39m 13s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6c468d24c50d40c1ab522646b99f5f0f : SUCCESS in 28m 08s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/da343c60fe354d6b90bfa680005e7663 : SUCCESS in 45m 53s (non-voting)\n- bifrost-integration-dibipa-debian-centos-9 https://zuul.opendev.org/t/openstack/build/28ac95a5613140a38c8c580d059e7d72 : FAILURE in 12m 21s (non-voting)\n- bifrost-cli-ubuntu-focal https://zuul.opendev.org/t/openstack/build/16d00e12aa64409fa358c7bcf5238154 : SUCCESS in 33m 19s (non-voting)\n- kolla-ansible-centos8s-source-bifrost https://zuul.opendev.org/t/openstack/build/56a1c62cb4754db2ba936da0411267b2 : SUCCESS in 45m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d95bd8df43e9cb5feb244a5bdb99c9c68ed7de28","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-09-19 15:52:22.000000000","message":"Abandoned\n\nMerged into https://review.opendev.org/c/openstack/bifrost/+/858391","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cc2057e490b5699fd82bc18e935f448ecb1a26d1","revisions":{"cc2057e490b5699fd82bc18e935f448ecb1a26d1":{"kind":"REWORK","_number":1,"created":"2022-09-19 14:28:43.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/89/858389/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/89/858389/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/89/858389/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/89/858389/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/89/858389/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/89/858389/1"}}},"commit":{"parents":[{"commit":"e26344070c3dc96e22e4f329ab0db02173f7729f","subject":"Merge \"Prevent the enroll/deploy commands from running without venv\" into stable/yoga","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/e26344070c3dc96e22e4f329ab0db02173f7729f"}]}],"author":{"name":"Erik Berg","email":"openstack@slipsprogrammor.no","date":"2022-04-10 14:31:34.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2022-09-19 14:28:07.000000000","tz":120},"subject":"Simplify bifrost-ironic-install required_defaults","message":"Simplify bifrost-ironic-install required_defaults\n\nremoving required_defaults_RedHat.yml;\nefi_distro seems to only get used for grub_config_path, and \u0027rhel\u0027\nis not the correct path on my UEFI rhel8 system. It\u0027s \u0027redhat\u0027, and\naccording to the only documentation [1] I found on a quick search,\nit\u0027s probably been this since EL6. Which means we can use\n\u0027redhat\u0027 all over the board.\n\nThe unique values in efi_distro, grub_efi_binary and shim_efi_binary\ncorrespond to ansible_facts[\u0027distribution\u0027], which holds true for\ncentos and fedora aswell, so we can put all these in RedHat_family\n\nremoving required_defaults_CentOS.yml;\nThe common values from required_defaults_RedHat_family.yml should\nsuffice.\n\nremoving required_defaults_Fedora.yml;\nSupport for fedora has been deprecated [2], but since it\u0027s in the\nos_family of redhat, we\u0027re only missing \u0027qemu-kvm\u0027 and\n\u0027policycoreutils-python-utils\u0027 from \u0027required_packages\u0027, so\ndeployment will probably still work.\n\n[1] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/installation_guide/s2-grub-whatis-booting-uefi\n[2] https://review.opendev.org/c/openstack/bifrost/+/818780\n\nChange-Id: Ieb35391fae5bd24ab420dc4239117e045f8b35ed\n(cherry picked from commit 3ed6ba0264035055457fbbfe3e667c230fb86502)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/cc2057e490b5699fd82bc18e935f448ecb1a26d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/cc2057e490b5699fd82bc18e935f448ecb1a26d1"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[],"submit_requirements":[]}