)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ab3e0009b6ecdbf5003a9f7a5035a1cfef45f524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"01d916ad_54894a5f","updated":"2022-09-30 17:23:37.000000000","message":"Marked work-in-progress because it should be merged after https://review.opendev.org/c/openstack/bifrost/+/859984","commit_id":"84ef4f7009b1f46406b164f03d525ee71a497252"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"2e02d36c057613466fec6301d45f04837698088d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"51cb92fa_eb9ae00e","updated":"2022-10-06 08:22:53.000000000","message":"Patch [1] has been merged, hence this is ready for review.\n\n[1] https://review.opendev.org/c/openstack/bifrost/+/859984","commit_id":"84ef4f7009b1f46406b164f03d525ee71a497252"}],"playbooks/roles/bifrost-configdrives-dynamic/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6ef9a16537cb3eddce4f7e4d6c1e6d23545bf1ec","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    auth_type: \"{{ auth_type | default(omit) }}\""},{"line_number":34,"context_line":"    auth: \"{{ auth | default(omit) }}\""},{"line_number":35,"context_line":"    ca_cert: \"{{ tls_certificate_path | default(omit) }}\""},{"line_number":36,"context_line":"    node: \"{{ node_info.baremetal_nodes[0].id }}\""},{"line_number":37,"context_line":"  register: port_info"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: \"Set UUID from Ironic\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"59b0e6ac_d8941e4e","line":36,"updated":"2022-10-07 10:42:37.000000000","message":"Needs to account for uuid like below?","commit_id":"84ef4f7009b1f46406b164f03d525ee71a497252"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"fbbf5ab81462e0a3a9a9dae8cd04ec148a61ce50","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    auth_type: \"{{ auth_type | default(omit) }}\""},{"line_number":34,"context_line":"    auth: \"{{ auth | default(omit) }}\""},{"line_number":35,"context_line":"    ca_cert: \"{{ tls_certificate_path | default(omit) }}\""},{"line_number":36,"context_line":"    node: \"{{ node_info.baremetal_nodes[0].id }}\""},{"line_number":37,"context_line":"  register: port_info"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: \"Set UUID from Ironic\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5668cd43_0b0273b2","line":36,"in_reply_to":"59b0e6ac_d8941e4e","updated":"2022-10-07 11:22:47.000000000","message":"True 😆","commit_id":"84ef4f7009b1f46406b164f03d525ee71a497252"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6ef9a16537cb3eddce4f7e4d6c1e6d23545bf1ec","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: \"Set UUID from Ironic\""},{"line_number":40,"context_line":"  set_fact:"},{"line_number":41,"context_line":"    uuid: \"{{ node_info.baremetal_nodes[0].id"},{"line_number":42,"context_line":"              if \u0027id\u0027 in node_info.baremetal_nodes[0]"},{"line_number":43,"context_line":"              else node_info.baremetal_nodes[0].uuid }}\""},{"line_number":44,"context_line":"  when: uuid is undefined"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b2ec80fd_bdfc87d3","line":41,"updated":"2022-10-07 10:42:37.000000000","message":"Won\u0027t it be a bit more ansibly to use |default instead?\n\n node_info.baremetal_nodes[0].id | default(node_info.baremetal_nodes[0].uuid)","commit_id":"84ef4f7009b1f46406b164f03d525ee71a497252"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"fbbf5ab81462e0a3a9a9dae8cd04ec148a61ce50","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: \"Set UUID from Ironic\""},{"line_number":40,"context_line":"  set_fact:"},{"line_number":41,"context_line":"    uuid: \"{{ node_info.baremetal_nodes[0].id"},{"line_number":42,"context_line":"              if \u0027id\u0027 in node_info.baremetal_nodes[0]"},{"line_number":43,"context_line":"              else node_info.baremetal_nodes[0].uuid }}\""},{"line_number":44,"context_line":"  when: uuid is undefined"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"106e485f_90e00194","line":41,"in_reply_to":"b2ec80fd_bdfc87d3","updated":"2022-10-07 11:22:47.000000000","message":"Definitely much more ansible\u0027ish and also shorter. Thanks!","commit_id":"84ef4f7009b1f46406b164f03d525ee71a497252"}]}
