)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"908e4d6ce71c987e464f9954e3bf308269cf4868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7be61f99_bdc6feb5","updated":"2022-11-02 13:55:39.000000000","message":"I guess this was overlooked because the dependency is present already in bindep.txt as the package git\nshould we remove it from there?\notherwiese we\u0027ll have a duplicate whenever we use bindep","commit_id":"25186efa669f649d8879619324b28fece6e49be9"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"92af54a164d0fadd4c260ecb485399bccb3073b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f4787f9_bae225e9","in_reply_to":"7be61f99_bdc6feb5","updated":"2022-11-02 23:38:16.000000000","message":"I think the difference is that bindep installs on the host bifrost-cli is running on, but if you\u0027re using the playbooks directly[1] to target a remote system then bindep isn\u0027t used, nor installing anything.\n\n [1] ansible-playbook -i inventory/target install.yaml","commit_id":"25186efa669f649d8879619324b28fece6e49be9"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"de741c3a3f757e829a958f921522ee942e6db1f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1320850c_2a1b6492","updated":"2022-11-03 06:44:44.000000000","message":"My mistake, it\u0027s a virtual package on ubuntu/debian.","commit_id":"402c6b71e81699c098c6a52a0f239b52237d8864"}],"playbooks/roles/bifrost-prep-for-install/tasks/main.yml":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6ca6fd5b97d3b2b1e533c82419770cfe43065907","unresolved":true,"context_lines":[{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- name: install dependencies for this role"},{"line_number":17,"context_line":"  package:"},{"line_number":18,"context_line":"    name: git-core"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: ensure installation root folder exists"},{"line_number":21,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bb531d00_fe5067c9","line":18,"updated":"2022-11-03 01:21:25.000000000","message":"There is no git-core in ubuntu, lets just do the same thing as bindep and install package \"git\" here","commit_id":"25186efa669f649d8879619324b28fece6e49be9"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"de741c3a3f757e829a958f921522ee942e6db1f0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- name: install dependencies for this role"},{"line_number":17,"context_line":"  package:"},{"line_number":18,"context_line":"    name: git-core"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: ensure installation root folder exists"},{"line_number":21,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e19e3248_accefb5f","line":18,"in_reply_to":"bb531d00_fe5067c9","updated":"2022-11-03 06:44:44.000000000","message":"Done","commit_id":"25186efa669f649d8879619324b28fece6e49be9"}]}