)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e74483d18df330af417ec8f89e80f870202a97c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"526d9365_f6d89f65","updated":"2023-01-18 13:09:13.000000000","message":"@rpittau could you remove your W-1?","commit_id":"c807372f4d223e2a5aef094e095fc9dcbfc05a6e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4594b2a2e4175f6eefd116c214733f8bd08d9425","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00bc39b6_147f6493","updated":"2022-12-21 13:07:16.000000000","message":"please do not recheck again, failures do not depend from this patch, we\u0027re troubleshooting the issues and provide a fix as soon as possible","commit_id":"c807372f4d223e2a5aef094e095fc9dcbfc05a6e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"661de83005193692b2d2eaaf24cceec00581070e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"21ebeb9a_1940c70b","updated":"2022-12-20 15:45:50.000000000","message":"recheck (No space left on device ??)","commit_id":"c807372f4d223e2a5aef094e095fc9dcbfc05a6e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"96b1f3c8ea5a51a86bc907829cdcec5acfca1c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dbd210c2_7402ac3e","updated":"2023-01-18 11:04:16.000000000","message":"recheck - CI should be fixed now","commit_id":"c807372f4d223e2a5aef094e095fc9dcbfc05a6e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"27e4d90e908939c2c697ea22147f17358ac62d2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7cfc50c9_b9de22f0","updated":"2022-12-21 08:51:53.000000000","message":"recheck virtualmedia redfish error?","commit_id":"c807372f4d223e2a5aef094e095fc9dcbfc05a6e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"82a5b8d93f572f8d3081540e4e425e957b2a57fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96c7ec82_18dcfff7","updated":"2022-12-21 13:08:18.000000000","message":"yes, I saw you patch from today. thx.","commit_id":"c807372f4d223e2a5aef094e095fc9dcbfc05a6e"}],"playbooks/roles/bifrost-ironic-install/templates/systemd_template.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2bb586e119b7044c65738e238acab9541f4b5fd1","unresolved":true,"context_lines":[{"line_number":6,"context_line":"ExecStart\u003d{{ service_path }}/{{ service_name }} --config-file {{ config_file }}"},{"line_number":7,"context_line":"User\u003dironic"},{"line_number":8,"context_line":"RuntimeDirectory\u003dironic"},{"line_number":9,"context_line":"RuntimeDirectoryMode\u003d750"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Install]"},{"line_number":12,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"09b987f1_a4011622","line":9,"updated":"2022-12-20 13:26:56.000000000","message":"We probably also need RuntimeDirectoryPreserve\u003dyes to avoid the shared directory being removed when any of the services stop.","commit_id":"4824882bcb645f8314d01464e7027c772ca5b31f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"7e0b783b21fab8b82a3a1d910fb0095729db9f6e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ExecStart\u003d{{ service_path }}/{{ service_name }} --config-file {{ config_file }}"},{"line_number":7,"context_line":"User\u003dironic"},{"line_number":8,"context_line":"RuntimeDirectory\u003dironic"},{"line_number":9,"context_line":"RuntimeDirectoryMode\u003d750"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Install]"},{"line_number":12,"context_line":"WantedBy\u003dmulti-user.target"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"58656c50_8dab9eb3","line":9,"in_reply_to":"09b987f1_a4011622","updated":"2022-12-20 13:37:24.000000000","message":"Done","commit_id":"4824882bcb645f8314d01464e7027c772ca5b31f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2bb586e119b7044c65738e238acab9541f4b5fd1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"User\u003dironic"},{"line_number":8,"context_line":"RuntimeDirectory\u003dironic"},{"line_number":9,"context_line":"RuntimeDirectoryMode\u003d750"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Install]"},{"line_number":12,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":13,"context_line":"Alias\u003d{{ service_name }}.service"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f02cbabd_9d3ad13f","line":10,"updated":"2022-12-20 13:26:56.000000000","message":"We lose the ironic:nginx ownership here. Is nginx still able to write to the socket? And if so can other users do the same?","commit_id":"4824882bcb645f8314d01464e7027c772ca5b31f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"318d1346c090f1b961fe0633233e22f7b189f496","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User\u003dironic"},{"line_number":8,"context_line":"RuntimeDirectory\u003dironic"},{"line_number":9,"context_line":"RuntimeDirectoryMode\u003d750"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Install]"},{"line_number":12,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":13,"context_line":"Alias\u003d{{ service_name }}.service"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bf052e21_323bf3e5","line":10,"in_reply_to":"39aa1c49_3ab93dd7","updated":"2022-12-20 13:40:06.000000000","message":"Ack. Was looking for something like that but didn\u0027t see it.","commit_id":"4824882bcb645f8314d01464e7027c772ca5b31f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"7e0b783b21fab8b82a3a1d910fb0095729db9f6e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"User\u003dironic"},{"line_number":8,"context_line":"RuntimeDirectory\u003dironic"},{"line_number":9,"context_line":"RuntimeDirectoryMode\u003d750"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[Install]"},{"line_number":12,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":13,"context_line":"Alias\u003d{{ service_name }}.service"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"39aa1c49_3ab93dd7","line":10,"in_reply_to":"f02cbabd_9d3ad13f","updated":"2022-12-20 13:37:24.000000000","message":"nginx (and www-data on ubuntu) is a member of ironic group, so only is those users can reach it:\nhttps://opendev.org/openstack/bifrost/src/branch/master/playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml#L124-L131","commit_id":"4824882bcb645f8314d01464e7027c772ca5b31f"}]}