)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"05d1d2b7063ef987720033666b637bcdab9c9e73","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afdc1243_4bb69d30","updated":"2023-04-25 07:27:18.000000000","message":"I\u0027m fine with most of the stuff, but vote to ditch the `name[template]` rule with fixin\u0027s.\n\nI\u0027m on the fence on `name[missing]` rule, but I suppose adding a useless name section to import_tasks is worth the ability to enforce name sections where it actually matters.","commit_id":"1046b80fbf974c5cb4d98ff2eac572303c0a0785"}],"playbooks/roles/bifrost-create-dib-image/tasks/main.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"05d1d2b7063ef987720033666b637bcdab9c9e73","unresolved":true,"context_lines":[{"line_number":18,"context_line":"- name: \"Test if image is present\""},{"line_number":19,"context_line":"  ansible.builtin.stat: path\u003d{{ dib_imagename }}"},{"line_number":20,"context_line":"  register: test_image_present"},{"line_number":21,"context_line":"- name: \"Test if image is present - {{ dib_imagename ~ \u0027.\u0027 ~ dib_imagetype | default(\u0027qcow2\u0027) }}\""},{"line_number":22,"context_line":"  ansible.builtin.stat: path\u003d{{ dib_imagename ~ \u0027.\u0027 ~ dib_imagetype | default(\u0027qcow2\u0027) }}"},{"line_number":23,"context_line":"  register: test_image_dib_present"},{"line_number":24,"context_line":"  when: not test_image_present.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cbe3b9be_e65b8350","line":21,"updated":"2023-04-25 07:27:18.000000000","message":"Do we know the reasoning behind `Jinja templates should only be at the end of \u0027name\u0027`? It looks correct, but personally I think this looks worse. And I don\u0027t think I agree with the ansible-lint team on this one.","commit_id":"1046b80fbf974c5cb4d98ff2eac572303c0a0785"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"993f10d58657ba14327207cb99c7fe054ff6b692","unresolved":true,"context_lines":[{"line_number":18,"context_line":"- name: \"Test if image is present\""},{"line_number":19,"context_line":"  ansible.builtin.stat: path\u003d{{ dib_imagename }}"},{"line_number":20,"context_line":"  register: test_image_present"},{"line_number":21,"context_line":"- name: \"Test if image is present - {{ dib_imagename ~ \u0027.\u0027 ~ dib_imagetype | default(\u0027qcow2\u0027) }}\""},{"line_number":22,"context_line":"  ansible.builtin.stat: path\u003d{{ dib_imagename ~ \u0027.\u0027 ~ dib_imagetype | default(\u0027qcow2\u0027) }}"},{"line_number":23,"context_line":"  register: test_image_dib_present"},{"line_number":24,"context_line":"  when: not test_image_present.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9e013b10_54211991","line":21,"in_reply_to":"cbe3b9be_e65b8350","updated":"2023-04-25 21:04:40.000000000","message":"I\u0027ve seen ansible logging environments which don\u0027t render the template part of the name. This is pure speculation, but maybe these environments would render correctly if the template is at the end, as per rule name[template]?","commit_id":"1046b80fbf974c5cb4d98ff2eac572303c0a0785"}],"playbooks/roles/bifrost-create-vm-nodes/tasks/main.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"05d1d2b7063ef987720033666b637bcdab9c9e73","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    group: \"{{ ansible_user_gid }}\""},{"line_number":93,"context_line":"  when: copy_from_local_path | bool"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Import prepare_libvirt tasks"},{"line_number":96,"context_line":"  ansible.builtin.import_tasks: prepare_libvirt.yml"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Truncate explicit list of vm names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ebf56e69_acec7bd1","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":36},"updated":"2023-04-25 07:27:18.000000000","message":"This is also one of those places where ansible-lint overreaches. The `name` section on `import_tasks` is never displayed during play. And the name section here adds no new information of value when reading the playbook.","commit_id":"1046b80fbf974c5cb4d98ff2eac572303c0a0785"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"993f10d58657ba14327207cb99c7fe054ff6b692","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    group: \"{{ ansible_user_gid }}\""},{"line_number":93,"context_line":"  when: copy_from_local_path | bool"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Import prepare_libvirt tasks"},{"line_number":96,"context_line":"  ansible.builtin.import_tasks: prepare_libvirt.yml"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Truncate explicit list of vm names"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f4904a88_0f859a1b","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":36},"in_reply_to":"ebf56e69_acec7bd1","updated":"2023-04-25 21:04:40.000000000","message":"There is relatively few imports so I don\u0027t think it is too onerous to maintain names for them","commit_id":"1046b80fbf974c5cb4d98ff2eac572303c0a0785"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"05d1d2b7063ef987720033666b637bcdab9c9e73","unresolved":true,"context_lines":[{"line_number":115,"context_line":"    testvm_json_data: {}"},{"line_number":116,"context_line":"    testvm_nodes_json: []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: Run create_vm tasks for each vm"},{"line_number":119,"context_line":"  ansible.builtin.include_tasks: create_vm.yml"},{"line_number":120,"context_line":"  loop: \"{{ test_vm_node_names }}\""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7662f482_fee62134","line":118,"updated":"2023-04-25 07:27:18.000000000","message":"`include_tasks` however does display the `name` section, so this is fine 👍\n\nWould we dare make this name section even more concise? Perhaps something like,\n`- name: \"Creating {{ test_vm_node_names | length }} vms\"`?\n\nAgain, here I\u0027m showing a blatant disregard for the `name[template]` rule, because it just sucks.","commit_id":"1046b80fbf974c5cb4d98ff2eac572303c0a0785"}]}