)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"e7e1207f8784e721536f41fbb7c199a25762dbf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aee0e7aa_e9dbfeb6","updated":"2023-05-30 11:23:50.000000000","message":"recheck","commit_id":"e309db9786b6b00c27e559fa293fcc988cf185b0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8549a66a4535825f89f8856405acd0d1d92dd150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dea441ce_c7409962","updated":"2023-06-08 10:36:52.000000000","message":"Needs a release note, but otherwise looks good.","commit_id":"53d8d1e25b818cdbf7c28cb05fdc6d609a3df30a"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"789617da4ac92ce8653c650ce73e0c5b643b6e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ccebe399_49f0f05a","in_reply_to":"dea441ce_c7409962","updated":"2023-06-21 15:04:08.000000000","message":"Done","commit_id":"53d8d1e25b818cdbf7c28cb05fdc6d609a3df30a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c55d128c5a53f288e1710faa5085d7debac5c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c62161d0_83b9807e","updated":"2023-08-10 10:03:50.000000000","message":"Nearly there I think","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e2a34e0ab66bcadf4fcaa8d0d86913d3dae398ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"63a9eac1_d15f3512","updated":"2023-08-24 10:48:22.000000000","message":"recheck\n\nCI fixed","commit_id":"a6ce28314677557427aec77053c0107923822b70"}],"playbooks/inventory/group_vars/localhost":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c55d128c5a53f288e1710faa5085d7debac5c16","unresolved":true,"context_lines":[{"line_number":51,"context_line":"# deploy_image: \"{{http_boot_folder}}/{{deploy_image_filename}}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."},{"line_number":54,"context_line":"create_image_via_dib: \"{{ not (download_custom_deploy_image | default(false)) }}\""},{"line_number":55,"context_line":"dib_image_type: vm"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Create IPA image instead of downloading an pre-made IPA image."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3aa09f2c_9774a055","line":54,"updated":"2023-08-10 10:03:50.000000000","message":"The group_vars are in a different scope than the roles, so we need to replicate the use_cirros default here. e.g.\n\n  \"{{ not (download_custom_deploy_image | default(use_cirros) | default(false) | bool) }}\"","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"1135e62c3aef07b952e4789abc1c303452a58037","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# deploy_image: \"{{http_boot_folder}}/{{deploy_image_filename}}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."},{"line_number":54,"context_line":"create_image_via_dib: \"{{ not (download_custom_deploy_image | default(false)) }}\""},{"line_number":55,"context_line":"dib_image_type: vm"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Create IPA image instead of downloading an pre-made IPA image."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"2bc86bd8_c3312145","line":54,"in_reply_to":"3aa09f2c_9774a055","updated":"2023-08-10 10:41:56.000000000","message":"Done","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"}],"playbooks/inventory/group_vars/target":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c55d128c5a53f288e1710faa5085d7debac5c16","unresolved":true,"context_lines":[{"line_number":51,"context_line":"# deploy_image: \"{{http_boot_folder}}/{{deploy_image_filename}}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."},{"line_number":54,"context_line":"create_image_via_dib: \"{{ not (download_custom_deploy_image | default(false)) }}\""},{"line_number":55,"context_line":"dib_image_type: vm"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Create IPA image instead of downloading an pre-made IPA image."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"041b075a_e80e370c","line":54,"updated":"2023-08-10 10:03:50.000000000","message":"As before","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"1135e62c3aef07b952e4789abc1c303452a58037","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# deploy_image: \"{{http_boot_folder}}/{{deploy_image_filename}}\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."},{"line_number":54,"context_line":"create_image_via_dib: \"{{ not (download_custom_deploy_image | default(false)) }}\""},{"line_number":55,"context_line":"dib_image_type: vm"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Create IPA image instead of downloading an pre-made IPA image."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5c90591c_359944f3","line":54,"in_reply_to":"041b075a_e80e370c","updated":"2023-08-10 10:41:56.000000000","message":"Done","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"}],"playbooks/roles/bifrost-configdrives-dynamic/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc5e98ba6c91e49e314db4a53358b610727cc289","unresolved":true,"context_lines":[{"line_number":17,"context_line":"testing: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Build images by default"},{"line_number":20,"context_line":"download_custom_deploy_image: false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# write_interfaces_file is intended for utilizing base logic to write"},{"line_number":23,"context_line":"# a debian style interfaces file into the configuration drive file"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"be9a5224_9456dfe7","line":20,"updated":"2023-08-01 12:58:57.000000000","message":"I\u0027d suggest setting this to:\n\n \"{{ use_cirros | default(false) }}\"\n \nThen reference download_custom_deploy_image everywhere.","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"47f6044033b4d0b8c5ca48e86d5f0be0c46ba548","unresolved":false,"context_lines":[{"line_number":17,"context_line":"testing: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Build images by default"},{"line_number":20,"context_line":"download_custom_deploy_image: false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# write_interfaces_file is intended for utilizing base logic to write"},{"line_number":23,"context_line":"# a debian style interfaces file into the configuration drive file"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"104a450d_bd02df98","line":20,"in_reply_to":"be9a5224_9456dfe7","updated":"2023-08-09 16:13:31.000000000","message":"Done","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc5e98ba6c91e49e314db4a53358b610727cc289","unresolved":true,"context_lines":[{"line_number":23,"context_line":"# a debian style interfaces file into the configuration drive file"},{"line_number":24,"context_line":"# such that cirros will receive basic network configuration when"},{"line_number":25,"context_line":"# performing basic testing."},{"line_number":26,"context_line":"write_interfaces_file: \"{{ download_custom_deploy_image or use_cirros }}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Basic networking defaults"},{"line_number":29,"context_line":"ipv4_subnet_mask: 255.255.255.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f814aa38_fad54080","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":69},"updated":"2023-08-01 12:58:57.000000000","message":"This is undefined","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"47f6044033b4d0b8c5ca48e86d5f0be0c46ba548","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# a debian style interfaces file into the configuration drive file"},{"line_number":24,"context_line":"# such that cirros will receive basic network configuration when"},{"line_number":25,"context_line":"# performing basic testing."},{"line_number":26,"context_line":"write_interfaces_file: \"{{ download_custom_deploy_image or use_cirros }}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Basic networking defaults"},{"line_number":29,"context_line":"ipv4_subnet_mask: 255.255.255.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c1494cff_123467aa","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":69},"in_reply_to":"f814aa38_fad54080","updated":"2023-08-09 16:13:31.000000000","message":"Done","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc5e98ba6c91e49e314db4a53358b610727cc289","unresolved":true,"context_lines":[{"line_number":107,"context_line":"esp_image: \"{{ http_boot_folder }}/esp.img\""},{"line_number":108,"context_line":"esp_image_url: \"{{ ipa_file_protocol }}://{{ internal_ip }}:{{ file_url_port }}/esp.img\""},{"line_number":109,"context_line":"# Download a deployment image (default cirros) instead of building an image via diskimage-builder"},{"line_number":110,"context_line":"download_custom_deploy_image: false"},{"line_number":111,"context_line":"# Download IPA by default"},{"line_number":112,"context_line":"download_ipa: true"},{"line_number":113,"context_line":"update_repos: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e097feb1_0302b600","line":110,"updated":"2023-08-01 12:58:57.000000000","message":"As before","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"47f6044033b4d0b8c5ca48e86d5f0be0c46ba548","unresolved":false,"context_lines":[{"line_number":107,"context_line":"esp_image: \"{{ http_boot_folder }}/esp.img\""},{"line_number":108,"context_line":"esp_image_url: \"{{ ipa_file_protocol }}://{{ internal_ip }}:{{ file_url_port }}/esp.img\""},{"line_number":109,"context_line":"# Download a deployment image (default cirros) instead of building an image via diskimage-builder"},{"line_number":110,"context_line":"download_custom_deploy_image: false"},{"line_number":111,"context_line":"# Download IPA by default"},{"line_number":112,"context_line":"download_ipa: true"},{"line_number":113,"context_line":"update_repos: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fc90548c_2db715de","line":110,"in_reply_to":"e097feb1_0302b600","updated":"2023-08-09 16:13:31.000000000","message":"Done","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc5e98ba6c91e49e314db4a53358b610727cc289","unresolved":true,"context_lines":[{"line_number":118,"context_line":"# favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":119,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":120,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":121,"context_line":"cirros_deploy_image_upstream_url: https://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img"},{"line_number":122,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":123,"context_line":"# server. If you already have a DHCP server or do not need DHCP/TFTP at all,"},{"line_number":124,"context_line":"# you can pass --disable-dhcp to the bifrost-cli install command to disable it."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"06aaca28_5d84aed3","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":32},"updated":"2023-08-01 12:58:57.000000000","message":"As before:\n\n custom_deploy_image_upstream_url: \"{{ cirros_deploy_image_upstream_url | default(\u0027cirros_deploy_image_upstream_url\u0027) }}\"","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"47f6044033b4d0b8c5ca48e86d5f0be0c46ba548","unresolved":false,"context_lines":[{"line_number":118,"context_line":"# favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":119,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":120,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":121,"context_line":"cirros_deploy_image_upstream_url: https://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img"},{"line_number":122,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":123,"context_line":"# server. If you already have a DHCP server or do not need DHCP/TFTP at all,"},{"line_number":124,"context_line":"# you can pass --disable-dhcp to the bifrost-cli install command to disable it."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0b128ac3_60dcbae4","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":32},"in_reply_to":"06aaca28_5d84aed3","updated":"2023-08-09 16:13:31.000000000","message":"Done","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c55d128c5a53f288e1710faa5085d7debac5c16","unresolved":true,"context_lines":[{"line_number":24,"context_line":"staging_drivers_source_install: true"},{"line_number":25,"context_line":"prometheus_exporter_source_install: true"},{"line_number":26,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."},{"line_number":27,"context_line":"create_image_via_dib: \"{{ not (download_custom_deploy_image | default(false)) }}\""},{"line_number":28,"context_line":"create_ipa_image: false"},{"line_number":29,"context_line":"dib_image_type: vm"},{"line_number":30,"context_line":"dib_os_element: \"debian\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"849bb08f_71b7b03b","line":27,"updated":"2023-08-10 10:03:50.000000000","message":"nit: no need for default here since download_custom_deploy_image is defined in this file.","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"1135e62c3aef07b952e4789abc1c303452a58037","unresolved":false,"context_lines":[{"line_number":24,"context_line":"staging_drivers_source_install: true"},{"line_number":25,"context_line":"prometheus_exporter_source_install: true"},{"line_number":26,"context_line":"# Setting to utilize diskimage-builder to create a bootable image."},{"line_number":27,"context_line":"create_image_via_dib: \"{{ not (download_custom_deploy_image | default(false)) }}\""},{"line_number":28,"context_line":"create_ipa_image: false"},{"line_number":29,"context_line":"dib_image_type: vm"},{"line_number":30,"context_line":"dib_os_element: \"debian\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f0ac4455_76135197","line":27,"in_reply_to":"849bb08f_71b7b03b","updated":"2023-08-10 10:41:56.000000000","message":"Done","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"}],"releasenotes/notes/generalise-use_cirros-be75f2c5452491a1.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc5e98ba6c91e49e314db4a53358b610727cc289","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `use_cirros` and `cirros_deploy_image_upstream_url` have been renamed"},{"line_number":5,"context_line":"    `download_custom_deploy_image` and `custom_deploy_image_upstream_url`"},{"line_number":6,"context_line":"    respectively, to better reflect their OS-agnositic nature. The"},{"line_number":7,"context_line":"    functionality of the old variables will remain until the Bobcat cycle."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b509b7f4_629d7f19","line":4,"updated":"2023-08-01 12:58:57.000000000","message":"Strictly these have been deprecated in favour of the others, and will be removed in a future release.","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"47f6044033b4d0b8c5ca48e86d5f0be0c46ba548","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `use_cirros` and `cirros_deploy_image_upstream_url` have been renamed"},{"line_number":5,"context_line":"    `download_custom_deploy_image` and `custom_deploy_image_upstream_url`"},{"line_number":6,"context_line":"    respectively, to better reflect their OS-agnositic nature. The"},{"line_number":7,"context_line":"    functionality of the old variables will remain until the Bobcat cycle."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6a0ddc4a_08239708","line":4,"in_reply_to":"b509b7f4_629d7f19","updated":"2023-08-09 16:13:31.000000000","message":"Done","commit_id":"fbcd5d727170c9e09f8323f8d1e6445e22457f62"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1c55d128c5a53f288e1710faa5085d7debac5c16","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `use_cirros` and `cirros_deploy_image_upstream_url` have been deprecated in"},{"line_number":5,"context_line":"    favour of `download_custom_deploy_image` and"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c224d9ac_9135d2c8","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2023-08-10 10:03:50.000000000","message":"deprecations","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"1135e62c3aef07b952e4789abc1c303452a58037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `use_cirros` and `cirros_deploy_image_upstream_url` have been deprecated in"},{"line_number":5,"context_line":"    favour of `download_custom_deploy_image` and"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4b7d83e7_2f17164e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"c224d9ac_9135d2c8","updated":"2023-08-10 10:41:56.000000000","message":"Done","commit_id":"cb385ce90c6b288d8acf26cac3512c6dacf98339"}]}