)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"61f6fe64a558c99b32852d5e1d512d5124474f78","unresolved":true,"context_lines":[{"line_number":18,"context_line":"The deployment image will not be re-downloaded if it already exists, and"},{"line_number":19,"context_line":"its checksum matches"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/bifrost/+/883943"},{"line_number":22,"context_line":"Change-Id: Ib0a1dac2bd0c4c3cf721bcf3042dbd34e2ab2dbd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"011f61ef_92a6cbcb","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":67},"updated":"2023-09-13 14:01:20.000000000","message":"drop it since it merged already","commit_id":"8affbe6fba55830537d9755ebf3564723b192dad"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"c3ab6a681b27d151251e4ee7a208dcb47c6b2573","unresolved":false,"context_lines":[{"line_number":18,"context_line":"The deployment image will not be re-downloaded if it already exists, and"},{"line_number":19,"context_line":"its checksum matches"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Depends-On: https://review.opendev.org/c/openstack/bifrost/+/883943"},{"line_number":22,"context_line":"Change-Id: Ib0a1dac2bd0c4c3cf721bcf3042dbd34e2ab2dbd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"621ce925_80808df1","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":67},"in_reply_to":"011f61ef_92a6cbcb","updated":"2023-10-20 12:08:16.000000000","message":"Done","commit_id":"8affbe6fba55830537d9755ebf3564723b192dad"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"8e126947016c5463142c6c95c1d7837ca1804354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cdc35cfe_95b81463","updated":"2023-05-31 13:59:46.000000000","message":"I\u0027m happy to add to the docs to explain this but I\u0027m not sure where to include it. There hasn\u0027t ever been an explanation for use_cirros which is what this replaces.","commit_id":"21ff1ef07cb85caefc5e904aecc774f5a87082eb"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"44c66a86b3189b7dbbb1a9a916c15ea1833f70b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"07130b48_ff93b384","updated":"2023-06-01 09:09:14.000000000","message":"recheck","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fa83419b58f0ee4b2083d48200970c6caa82a56c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a56fa6d9_5b45442f","updated":"2023-09-06 12:53:35.000000000","message":"anyway my -1 about ugly custom_deploy_image_upstream_url variable","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"24ec35c9f15167aaefd0ef38be27ec02995da23b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6e474c0a_36a237cf","updated":"2023-09-13 13:58:24.000000000","message":"almost perfect","commit_id":"8affbe6fba55830537d9755ebf3564723b192dad"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"34a482566d36447da5cee56cd1d4028683b58b20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"69e77315_9ed69e42","updated":"2023-10-20 12:08:49.000000000","message":"recheck","commit_id":"66d681a0d0b8f53707fcf7853435dea612cb30c4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a637ea619c818d59a131e8788449cb22d1abb464","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ff64762d_7b75e740","updated":"2024-02-29 11:43:15.000000000","message":"There\u0027s also a lint failure","commit_id":"48d3c8e76b90d6fcac38a447d1872584e0b8e24d"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"3b6163b278aeef35b967596f752bb710df1a092f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4c08d17e_b2433e25","in_reply_to":"ff64762d_7b75e740","updated":"2024-03-07 16:47:12.000000000","message":"Fixed","commit_id":"48d3c8e76b90d6fcac38a447d1872584e0b8e24d"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":118,"context_line":"# favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":119,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":120,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":121,"context_line":"cirros_deploy_image_upstream_url: https://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img"},{"line_number":122,"context_line":"upstream_deploy_image_distribution: \"undefined\""},{"line_number":123,"context_line":"upstream_deploy_image_release: \"undefined\""},{"line_number":124,"context_line":"custom_deploy_image_upstream_url: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"29348140_000f80d6","line":121,"updated":"2023-08-01 13:21:27.000000000","message":"If we want to default to cirros, we could remove this variable and set the default distribution to cirros.","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"# favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":119,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":120,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":121,"context_line":"cirros_deploy_image_upstream_url: https://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img"},{"line_number":122,"context_line":"upstream_deploy_image_distribution: \"undefined\""},{"line_number":123,"context_line":"upstream_deploy_image_release: \"undefined\""},{"line_number":124,"context_line":"custom_deploy_image_upstream_url: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"033425b8_7e600d18","line":121,"in_reply_to":"29348140_000f80d6","updated":"2023-09-06 12:36:11.000000000","message":"I\u0027ve rearranged things so it should still default to cirros and maintain functionality for users that have overridden cirros_deploy_image_upstream_url","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":119,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":120,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":121,"context_line":"cirros_deploy_image_upstream_url: https://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img"},{"line_number":122,"context_line":"upstream_deploy_image_distribution: \"undefined\""},{"line_number":123,"context_line":"upstream_deploy_image_release: \"undefined\""},{"line_number":124,"context_line":"custom_deploy_image_upstream_url: \u003e-"},{"line_number":125,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"187fb3fe_6c152b21","line":122,"updated":"2023-08-01 13:21:27.000000000","message":"I suppose cirros would provide full backwards compatibility, but unsure if that\u0027s important here.","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":120,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":121,"context_line":"cirros_deploy_image_upstream_url: https://download.cirros-cloud.net/0.5.1/cirros-0.5.1-x86_64-disk.img"},{"line_number":122,"context_line":"upstream_deploy_image_distribution: \"undefined\""},{"line_number":123,"context_line":"upstream_deploy_image_release: \"undefined\""},{"line_number":124,"context_line":"custom_deploy_image_upstream_url: \u003e-"},{"line_number":125,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"37126d17_d26384b8","line":122,"in_reply_to":"187fb3fe_6c152b21","updated":"2023-09-06 12:36:11.000000000","message":"Done","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ed72a29a09ee42363b59c650f16e79cb511234d1","unresolved":true,"context_lines":[{"line_number":121,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":122,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":123,"context_line":"custom_deploy_image_upstream_url: \u003e-"},{"line_number":124,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":125,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CentOS-Stream-GenericCloud-8-20230501.0.x86_64.qcow2"},{"line_number":126,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":127,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/Rocky-8-GenericCloud.latest.x86_64.qcow2"},{"line_number":128,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":129,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":130,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":131,"context_line":"  https://cloud-images.ubuntu.com/focal/current/focal-server-cloudimg-amd64.img"},{"line_number":132,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":133,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64.img"},{"line_number":134,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"cirros\" -%}"},{"line_number":135,"context_line":"  {{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}"},{"line_number":136,"context_line":"  {%- endif -%}"},{"line_number":137,"context_line":"deploy_image_checksum_url: \u003e-"},{"line_number":138,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":139,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CHECKSUM"},{"line_number":140,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":141,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/CHECKSUM"},{"line_number":142,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":143,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/CHECKSUM"},{"line_number":144,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":145,"context_line":"  https://cloud-images.ubuntu.com/focal/current/SHA256SUMS"},{"line_number":146,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":147,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/SHA256SUMS"},{"line_number":148,"context_line":"  {%- else -%}"},{"line_number":149,"context_line":"  none"},{"line_number":150,"context_line":"  {%- endif -%}"},{"line_number":151,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":152,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":153,"context_line":"  sha256"},{"line_number":154,"context_line":"  {%- else -%}"},{"line_number":155,"context_line":"  none"},{"line_number":156,"context_line":"  {%- endif -%}"},{"line_number":157,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":158,"context_line":"# server. If you already have a DHCP server or do not need DHCP/TFTP at all,"},{"line_number":159,"context_line":"# you can pass --disable-dhcp to the bifrost-cli install command to disable it."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b74352f4_41b8bd91","line":156,"range":{"start_line":124,"start_character":0,"end_line":156,"end_character":15},"updated":"2023-09-06 12:44:07.000000000","message":"this could be more human readable and easy to change if this wold be separate dictionary from which the right files chosen by the key (centos/rocky/ubuntu)","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":true,"context_lines":[{"line_number":121,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":122,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":123,"context_line":"custom_deploy_image_upstream_url: \u003e-"},{"line_number":124,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":125,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CentOS-Stream-GenericCloud-8-20230501.0.x86_64.qcow2"},{"line_number":126,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":127,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/Rocky-8-GenericCloud.latest.x86_64.qcow2"},{"line_number":128,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":129,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":130,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":131,"context_line":"  https://cloud-images.ubuntu.com/focal/current/focal-server-cloudimg-amd64.img"},{"line_number":132,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":133,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64.img"},{"line_number":134,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"cirros\" -%}"},{"line_number":135,"context_line":"  {{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}"},{"line_number":136,"context_line":"  {%- endif -%}"},{"line_number":137,"context_line":"deploy_image_checksum_url: \u003e-"},{"line_number":138,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":139,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CHECKSUM"},{"line_number":140,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":141,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/CHECKSUM"},{"line_number":142,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":143,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/CHECKSUM"},{"line_number":144,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":145,"context_line":"  https://cloud-images.ubuntu.com/focal/current/SHA256SUMS"},{"line_number":146,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":147,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/SHA256SUMS"},{"line_number":148,"context_line":"  {%- else -%}"},{"line_number":149,"context_line":"  none"},{"line_number":150,"context_line":"  {%- endif -%}"},{"line_number":151,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":152,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":153,"context_line":"  sha256"},{"line_number":154,"context_line":"  {%- else -%}"},{"line_number":155,"context_line":"  none"},{"line_number":156,"context_line":"  {%- endif -%}"},{"line_number":157,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":158,"context_line":"# server. If you already have a DHCP server or do not need DHCP/TFTP at all,"},{"line_number":159,"context_line":"# you can pass --disable-dhcp to the bifrost-cli install command to disable it."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b542b2d8_27a6e10d","line":156,"range":{"start_line":124,"start_character":0,"end_line":156,"end_character":15},"in_reply_to":"6751e051_4f1ca088","updated":"2023-09-06 15:03:14.000000000","message":"I like the idea, I\u0027m not sure on the exact best way to format it. I\u0027ve uploaded a patchset but I\u0027d be interested to hear your feedback on it.","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"e8b6be91a7a81896e6098212d7b2e2a21357e984","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":122,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":123,"context_line":"custom_deploy_image_upstream_url: \u003e-"},{"line_number":124,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":125,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CentOS-Stream-GenericCloud-8-20230501.0.x86_64.qcow2"},{"line_number":126,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":127,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/Rocky-8-GenericCloud.latest.x86_64.qcow2"},{"line_number":128,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":129,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":130,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":131,"context_line":"  https://cloud-images.ubuntu.com/focal/current/focal-server-cloudimg-amd64.img"},{"line_number":132,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":133,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64.img"},{"line_number":134,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"cirros\" -%}"},{"line_number":135,"context_line":"  {{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}"},{"line_number":136,"context_line":"  {%- endif -%}"},{"line_number":137,"context_line":"deploy_image_checksum_url: \u003e-"},{"line_number":138,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":139,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CHECKSUM"},{"line_number":140,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":141,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/CHECKSUM"},{"line_number":142,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":143,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/CHECKSUM"},{"line_number":144,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":145,"context_line":"  https://cloud-images.ubuntu.com/focal/current/SHA256SUMS"},{"line_number":146,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":147,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/SHA256SUMS"},{"line_number":148,"context_line":"  {%- else -%}"},{"line_number":149,"context_line":"  none"},{"line_number":150,"context_line":"  {%- endif -%}"},{"line_number":151,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":152,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":153,"context_line":"  sha256"},{"line_number":154,"context_line":"  {%- else -%}"},{"line_number":155,"context_line":"  none"},{"line_number":156,"context_line":"  {%- endif -%}"},{"line_number":157,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":158,"context_line":"# server. If you already have a DHCP server or do not need DHCP/TFTP at all,"},{"line_number":159,"context_line":"# you can pass --disable-dhcp to the bifrost-cli install command to disable it."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ad61e069_19d7d37e","line":156,"range":{"start_line":124,"start_character":0,"end_line":156,"end_character":15},"in_reply_to":"b542b2d8_27a6e10d","updated":"2023-09-13 10:13:39.000000000","message":"Done","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"98f908bd0d911fb19793dca19ef7f19a7b2ec786","unresolved":true,"context_lines":[{"line_number":121,"context_line":"# compatability. It should be swapped permanently to"},{"line_number":122,"context_line":"# custom_deploy_image_upstream_url in the next major release."},{"line_number":123,"context_line":"custom_deploy_image_upstream_url: \u003e-"},{"line_number":124,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":125,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CentOS-Stream-GenericCloud-8-20230501.0.x86_64.qcow2"},{"line_number":126,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":127,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/Rocky-8-GenericCloud.latest.x86_64.qcow2"},{"line_number":128,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":129,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":130,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":131,"context_line":"  https://cloud-images.ubuntu.com/focal/current/focal-server-cloudimg-amd64.img"},{"line_number":132,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":133,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/jammy-server-cloudimg-amd64.img"},{"line_number":134,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"cirros\" -%}"},{"line_number":135,"context_line":"  {{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}"},{"line_number":136,"context_line":"  {%- endif -%}"},{"line_number":137,"context_line":"deploy_image_checksum_url: \u003e-"},{"line_number":138,"context_line":"  {%- if upstream_deploy_image_distribution \u003d\u003d \"centos\" -%}"},{"line_number":139,"context_line":"  https://cloud.centos.org/centos/8-stream/x86_64/images/CHECKSUM"},{"line_number":140,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"8\" -%}"},{"line_number":141,"context_line":"  https://dl.rockylinux.org/pub/rocky/8/images/x86_64/CHECKSUM"},{"line_number":142,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"rocky\" and upstream_deploy_image_release \u003d\u003d \"9\" -%}"},{"line_number":143,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/CHECKSUM"},{"line_number":144,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"focal\" -%}"},{"line_number":145,"context_line":"  https://cloud-images.ubuntu.com/focal/current/SHA256SUMS"},{"line_number":146,"context_line":"  {%- elif upstream_deploy_image_distribution \u003d\u003d \"ubuntu\" and upstream_deploy_image_release \u003d\u003d \"jammy\" -%}"},{"line_number":147,"context_line":"  https://cloud-images.ubuntu.com/jammy/current/SHA256SUMS"},{"line_number":148,"context_line":"  {%- else -%}"},{"line_number":149,"context_line":"  none"},{"line_number":150,"context_line":"  {%- endif -%}"},{"line_number":151,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":152,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":153,"context_line":"  sha256"},{"line_number":154,"context_line":"  {%- else -%}"},{"line_number":155,"context_line":"  none"},{"line_number":156,"context_line":"  {%- endif -%}"},{"line_number":157,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":158,"context_line":"# server. If you already have a DHCP server or do not need DHCP/TFTP at all,"},{"line_number":159,"context_line":"# you can pass --disable-dhcp to the bifrost-cli install command to disable it."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6751e051_4f1ca088","line":156,"range":{"start_line":124,"start_character":0,"end_line":156,"end_character":15},"in_reply_to":"b74352f4_41b8bd91","updated":"2023-09-06 13:09:31.000000000","message":"something like\n\ncustom_deploy_image_upstream_url: custom_deploy_image_upstream_urls[upstream_deploy_image_distribution]\n\ncustom_deploy_image_upstream_urls:\n  centos: \u0027htpps://....\u0027\n  rocky: ...","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2bbf0b57f99a17ec4c7ed75fc5a739e95cd31cbf","unresolved":true,"context_lines":[{"line_number":114,"context_line":"update_ipa: \"{{ update_repos }}\""},{"line_number":115,"context_line":"# Use the DIB dynamic-login element to insert the SSH key"},{"line_number":116,"context_line":"ipa_add_ssh_key: false"},{"line_number":117,"context_line":"upstream_deploy_image_distribution: \"cirros\"  "},{"line_number":118,"context_line":"upstream_deploy_image_release: \"0.5.3\""},{"line_number":119,"context_line":"deploy_image_sources:"},{"line_number":120,"context_line":"  ubuntu:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2fef721a_e2c7df10","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":46},"updated":"2023-09-06 14:38:51.000000000","message":"whitespace","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"update_ipa: \"{{ update_repos }}\""},{"line_number":115,"context_line":"# Use the DIB dynamic-login element to insert the SSH key"},{"line_number":116,"context_line":"ipa_add_ssh_key: false"},{"line_number":117,"context_line":"upstream_deploy_image_distribution: \"cirros\"  "},{"line_number":118,"context_line":"upstream_deploy_image_release: \"0.5.3\""},{"line_number":119,"context_line":"deploy_image_sources:"},{"line_number":120,"context_line":"  ubuntu:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f64e4fbb_d08f3e58","line":117,"range":{"start_line":117,"start_character":44,"end_line":117,"end_character":46},"in_reply_to":"2fef721a_e2c7df10","updated":"2023-09-06 15:03:14.000000000","message":"Done","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2bbf0b57f99a17ec4c7ed75fc5a739e95cd31cbf","unresolved":true,"context_lines":[{"line_number":143,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c9cbaa57_e6c35df4","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":32},"updated":"2023-09-06 14:38:51.000000000","message":"deploy_image_upstream_url: custom_deploy_image_upstream_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2bbf0b57f99a17ec4c7ed75fc5a739e95cd31cbf","unresolved":true,"context_lines":[{"line_number":143,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0380f1a4_89d13040","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":7},"updated":"2023-09-06 14:38:51.000000000","message":"why this prefix here?","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a01c206_6e2b6966","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":7},"in_reply_to":"0380f1a4_89d13040","updated":"2023-09-06 15:03:14.000000000","message":"Done","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4c22b719_392b7e9a","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":32},"in_reply_to":"c9cbaa57_e6c35df4","updated":"2023-09-06 15:03:14.000000000","message":"Done","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2bbf0b57f99a17ec4c7ed75fc5a739e95cd31cbf","unresolved":true,"context_lines":[{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e51a6ec_ed4278dd","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":25},"updated":"2023-09-06 14:38:51.000000000","message":"deploy_image_checksum_url: custom_deploy_image_checksum_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2bbf0b57f99a17ec4c7ed75fc5a739e95cd31cbf","unresolved":true,"context_lines":[{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9d5bf0ed_8ec78b96","line":147,"updated":"2023-09-06 14:38:51.000000000","message":"why here is no custom_ prefix?","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"669a9d6c_88485960","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":25},"in_reply_to":"8e51a6ec_ed4278dd","updated":"2023-09-06 15:03:14.000000000","message":"Done","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"custom_deploy_image_upstream_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":147,"context_line":"deploy_image_checksum_url: deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ade58759_34390248","line":147,"in_reply_to":"9d5bf0ed_8ec78b96","updated":"2023-09-06 15:03:14.000000000","message":"Done","commit_id":"e52c43c721c61f8db4a93a0456a5d03d063c6170"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"deploy_image_upstream_url: custom_deploy_image_upstream_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":147,"context_line":"deploy_image_checksum_url: custom_deploy_image_checksum_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1174f44e_b52a4f6f","line":147,"range":{"start_line":147,"start_character":157,"end_line":147,"end_character":163},"updated":"2023-09-06 15:38:24.000000000","message":"checksum","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"deploy_image_upstream_url: custom_deploy_image_upstream_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":147,"context_line":"deploy_image_checksum_url: custom_deploy_image_checksum_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dff540dc_be872afc","line":147,"range":{"start_line":147,"start_character":157,"end_line":147,"end_character":163},"in_reply_to":"1174f44e_b52a4f6f","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"deploy_image_upstream_url: custom_deploy_image_upstream_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":147,"context_line":"deploy_image_checksum_url: custom_deploy_image_checksum_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"},{"line_number":151,"context_line":"  {%- else -%}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7212a99b_21d32a99","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":31},"updated":"2023-09-06 15:38:24.000000000","message":"lets move this to the deploy_image_sources too and add custom_deploy_image_checksum_algorithm override too.","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"      checksum: \"none\""},{"line_number":146,"context_line":"deploy_image_upstream_url: custom_deploy_image_upstream_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":147,"context_line":"deploy_image_checksum_url: custom_deploy_image_checksum_url | default(deploy_image_sources[upstream_deploy_image_distribution][upstream_deploy_image_release].image)"},{"line_number":148,"context_line":"deploy_image_checksum_algorithm: \u003e-"},{"line_number":149,"context_line":"  {%- if upstream_deploy_image_distribution in [\"centos\", \"rocky\", \"ubuntu\"] -%}"},{"line_number":150,"context_line":"  sha256"},{"line_number":151,"context_line":"  {%- else -%}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"70a101ad_f5e7870e","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":31},"in_reply_to":"7212a99b_21d32a99","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7089245add00dbf922e711be95f22a3d83ce1351","unresolved":true,"context_lines":[{"line_number":118,"context_line":"# Deployment image distribution, for selecting a default upstream image. Valid"},{"line_number":119,"context_line":"# options are \"cirros\", \"centos\", \"rocky\", \"ubuntu\". Default is \"cirros\"."},{"line_number":120,"context_line":"upstream_deploy_image_distribution: \"cirros\""},{"line_number":121,"context_line":"# Deployment image release, for selecting a default upstream image. Valid"},{"line_number":122,"context_line":"# options are:"},{"line_number":123,"context_line":"# \"0.5.3\" if upstream_deploy_image_distribution \u003d\u003d \"cirros\","},{"line_number":124,"context_line":"# \"8-stream\" if upstream_deploy_image_distribution \u003d\u003d \"centos\","},{"line_number":125,"context_line":"# \"8\" or \"9\" if upstream_deploy_image_distribution \u003d\u003d \"rocky\","},{"line_number":126,"context_line":"# \"focal\" or \"jammy\" if upstream_deploy_image_distribution \u003d\u003d \"ubuntu\"."},{"line_number":127,"context_line":"# Default is \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027"},{"line_number":128,"context_line":"upstream_deploy_image_release: \"{{ \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027 }}\""},{"line_number":129,"context_line":"deploy_image_sources:"},{"line_number":130,"context_line":"  ubuntu:"},{"line_number":131,"context_line":"    focal:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"82a56fa3_cab84773","line":128,"range":{"start_line":121,"start_character":0,"end_line":128,"end_character":168},"updated":"2023-09-13 10:03:58.000000000","message":"\\# Deployment image releases and valid defaults.\nupstream_deploy_image_releases:\n  \u0027cirros\u0027: \u00270.5.3\u0027\n  \u0027centos\u0027: \u00278-stream\u0027\n  \u0027rocky\u0027: \u00279\u0027\n  \u0027ubuntu\u0027: \u0027jammy\u0027\n\\# Deployment image release, for selecting a default upstream image.\nupstream_deploy_image_release: \"{{ upstream_deploy_image_releases[upstream_deploy_image_distribution] }}\"","commit_id":"6339e0e832a92d02b11ddbe9452958bff9e1d76f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"da5123ea4f6c156c7d969a78f5fa0ed01d2a082e","unresolved":true,"context_lines":[{"line_number":118,"context_line":"# Deployment image distribution, for selecting a default upstream image. Valid"},{"line_number":119,"context_line":"# options are \"cirros\", \"centos\", \"rocky\", \"ubuntu\". Default is \"cirros\"."},{"line_number":120,"context_line":"upstream_deploy_image_distribution: \"cirros\""},{"line_number":121,"context_line":"# Deployment image release, for selecting a default upstream image. Valid"},{"line_number":122,"context_line":"# options are:"},{"line_number":123,"context_line":"# \"0.5.3\" if upstream_deploy_image_distribution \u003d\u003d \"cirros\","},{"line_number":124,"context_line":"# \"8-stream\" if upstream_deploy_image_distribution \u003d\u003d \"centos\","},{"line_number":125,"context_line":"# \"8\" or \"9\" if upstream_deploy_image_distribution \u003d\u003d \"rocky\","},{"line_number":126,"context_line":"# \"focal\" or \"jammy\" if upstream_deploy_image_distribution \u003d\u003d \"ubuntu\"."},{"line_number":127,"context_line":"# Default is \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027"},{"line_number":128,"context_line":"upstream_deploy_image_release: \"{{ \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027 }}\""},{"line_number":129,"context_line":"deploy_image_sources:"},{"line_number":130,"context_line":"  ubuntu:"},{"line_number":131,"context_line":"    focal:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"854c899c_c55a3fc3","line":128,"range":{"start_line":121,"start_character":0,"end_line":128,"end_character":168},"in_reply_to":"82a56fa3_cab84773","updated":"2023-09-13 10:11:32.000000000","message":"This would stop us from providing multiple release options for each distribution","commit_id":"6339e0e832a92d02b11ddbe9452958bff9e1d76f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"af14f6448159ff242e2d88b6ecddf2a243f5a1cd","unresolved":true,"context_lines":[{"line_number":118,"context_line":"# Deployment image distribution, for selecting a default upstream image. Valid"},{"line_number":119,"context_line":"# options are \"cirros\", \"centos\", \"rocky\", \"ubuntu\". Default is \"cirros\"."},{"line_number":120,"context_line":"upstream_deploy_image_distribution: \"cirros\""},{"line_number":121,"context_line":"# Deployment image release, for selecting a default upstream image. Valid"},{"line_number":122,"context_line":"# options are:"},{"line_number":123,"context_line":"# \"0.5.3\" if upstream_deploy_image_distribution \u003d\u003d \"cirros\","},{"line_number":124,"context_line":"# \"8-stream\" if upstream_deploy_image_distribution \u003d\u003d \"centos\","},{"line_number":125,"context_line":"# \"8\" or \"9\" if upstream_deploy_image_distribution \u003d\u003d \"rocky\","},{"line_number":126,"context_line":"# \"focal\" or \"jammy\" if upstream_deploy_image_distribution \u003d\u003d \"ubuntu\"."},{"line_number":127,"context_line":"# Default is \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027"},{"line_number":128,"context_line":"upstream_deploy_image_release: \"{{ \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027 }}\""},{"line_number":129,"context_line":"deploy_image_sources:"},{"line_number":130,"context_line":"  ubuntu:"},{"line_number":131,"context_line":"    focal:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f00bc115_3efcfb33","line":128,"range":{"start_line":121,"start_character":0,"end_line":128,"end_character":168},"in_reply_to":"854c899c_c55a3fc3","updated":"2023-09-13 10:25:46.000000000","message":"why? you always can provide \u0027upstream_deploy_image_release\u0027 with any value you want. anyway the code I propose is the same as yours, but its more readable and also covers all cases. your long if case not cover \u0027centos\u0027 and if \u0027upstream_deploy_image_distribution\u0027 will be \u0027centos\u0027 the \u0027upstream_deploy_image_release\u0027 would set to \u00279\u0027 instead of \u00278-stream\u0027.","commit_id":"6339e0e832a92d02b11ddbe9452958bff9e1d76f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"a79e26556f50ae93a68af11a46069ec20918b598","unresolved":false,"context_lines":[{"line_number":118,"context_line":"# Deployment image distribution, for selecting a default upstream image. Valid"},{"line_number":119,"context_line":"# options are \"cirros\", \"centos\", \"rocky\", \"ubuntu\". Default is \"cirros\"."},{"line_number":120,"context_line":"upstream_deploy_image_distribution: \"cirros\""},{"line_number":121,"context_line":"# Deployment image release, for selecting a default upstream image. Valid"},{"line_number":122,"context_line":"# options are:"},{"line_number":123,"context_line":"# \"0.5.3\" if upstream_deploy_image_distribution \u003d\u003d \"cirros\","},{"line_number":124,"context_line":"# \"8-stream\" if upstream_deploy_image_distribution \u003d\u003d \"centos\","},{"line_number":125,"context_line":"# \"8\" or \"9\" if upstream_deploy_image_distribution \u003d\u003d \"rocky\","},{"line_number":126,"context_line":"# \"focal\" or \"jammy\" if upstream_deploy_image_distribution \u003d\u003d \"ubuntu\"."},{"line_number":127,"context_line":"# Default is \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027"},{"line_number":128,"context_line":"upstream_deploy_image_release: \"{{ \u00270.5.3\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027cirros\u0027 else \u0027jammy\u0027 if upstream_deploy_image_distribution \u003d\u003d \u0027ubuntu\u0027 else \u00279\u0027 }}\""},{"line_number":129,"context_line":"deploy_image_sources:"},{"line_number":130,"context_line":"  ubuntu:"},{"line_number":131,"context_line":"    focal:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"babf538d_90663202","line":128,"range":{"start_line":121,"start_character":0,"end_line":128,"end_character":168},"in_reply_to":"f00bc115_3efcfb33","updated":"2023-09-13 13:33:36.000000000","message":"I misunderstood, now changed.","commit_id":"6339e0e832a92d02b11ddbe9452958bff9e1d76f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d011534738f05f91b44ced646eef11e3271477e8","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    \"0.5.3\":"},{"line_number":159,"context_line":"      # NOTE(Alex-Welsh): cirros_deploy_image_upstream_url has been deprecated in"},{"line_number":160,"context_line":"      # favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":161,"context_line":"      # compatability. It should be swapped permanently to"},{"line_number":162,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":163,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":164,"context_line":"      checksum: \"https://download.cirros-cloud.net/0.5.3/MD5SUMS\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1d887b47_b6121afe","line":161,"updated":"2024-03-08 10:54:29.000000000","message":"codespell is complaining about compatability, which was previously spelled correctly :D","commit_id":"a666a0f745fcd78145f96dfa2143fb6657225f58"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"5450a8670a877c2574a91dd5d84036bcb6d0b5a1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    \"0.5.3\":"},{"line_number":159,"context_line":"      # NOTE(Alex-Welsh): cirros_deploy_image_upstream_url has been deprecated in"},{"line_number":160,"context_line":"      # favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":161,"context_line":"      # compatability. It should be swapped permanently to"},{"line_number":162,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":163,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":164,"context_line":"      checksum: \"https://download.cirros-cloud.net/0.5.3/MD5SUMS\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"277e2980_ffd515d7","line":161,"in_reply_to":"1d887b47_b6121afe","updated":"2024-03-08 14:34:59.000000000","message":"The biggest advantage Github has over Opendev/Gerrit is that I can use :facepalm:","commit_id":"a666a0f745fcd78145f96dfa2143fb6657225f58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a9d654788ea1708459a44730bdcbc293e15d670b","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Deployment image distribution, for selecting a default upstream image. Valid"},{"line_number":119,"context_line":"# options are \"cirros\", \"centos\", \"rocky\", \"ubuntu\". Default is \"cirros\"."},{"line_number":120,"context_line":"upstream_deploy_image_distribution: \"cirros\""},{"line_number":121,"context_line":"# Deployment image releases and default values."},{"line_number":122,"context_line":"default_upstream_deploy_image_releases:"},{"line_number":123,"context_line":"  cirros: \"0.5.3\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4b663619_10793183","line":120,"updated":"2024-04-27 15:16:57.000000000","message":"Not sure what upstream_ even means here, I\u0027d strip it from all new parameters.","commit_id":"ba394546e232c234c09e2a42573945d7360cbf00"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a9d654788ea1708459a44730bdcbc293e15d670b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"      # NOTE(Alex-Welsh): cirros_deploy_image_upstream_url has been deprecated in"},{"line_number":160,"context_line":"      # favor of custom_deploy_image_upstream_url but is included for backwards"},{"line_number":161,"context_line":"      # compatibility. It should be swapped permanently to"},{"line_number":162,"context_line":"      # custom_deploy_image_upstream_url in the next major release."},{"line_number":163,"context_line":"      image: \"{{ cirros_deploy_image_upstream_url | default(\u0027https://download.cirros-cloud.net/0.5.3/cirros-0.5.3-x86_64-disk.img\u0027) }}\""},{"line_number":164,"context_line":"      checksum: \"https://download.cirros-cloud.net/0.5.3/MD5SUMS\""},{"line_number":165,"context_line":"      checksum_algorithm: \"md5\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"cb89f121_63516239","line":162,"updated":"2024-04-27 15:16:57.000000000","message":"This no longer applies in the new version. If we do remove it, then no longer in favor of the mentioned variable","commit_id":"ba394546e232c234c09e2a42573945d7360cbf00"}],"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"539bf27a2d76ae1094bf97cfa086773efa4837fb","unresolved":true,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"- name: \"Download deployment image\""},{"line_number":405,"context_line":"  include_tasks: download_deployment_image.yml"},{"line_number":406,"context_line":"  when: (download_custom_deploy_image | bool) or (use_cirros | bool)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"- name: \"Bootstrap Nginx\""},{"line_number":409,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7dc1c0ca_27d4b825","line":406,"updated":"2023-11-02 12:00:42.000000000","message":"use_cirros is not necessary","commit_id":"1d43cb08c45a70badc55f8dde58cf25af1c8a0fa"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"b863329ddd950e9cb66960361e98c8a35db90ca7","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"- name: \"Download deployment image\""},{"line_number":405,"context_line":"  include_tasks: download_deployment_image.yml"},{"line_number":406,"context_line":"  when: (download_custom_deploy_image | bool) or (use_cirros | bool)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"- name: \"Bootstrap Nginx\""},{"line_number":409,"context_line":"  import_role:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b70d5943_229321b2","line":406,"in_reply_to":"7dc1c0ca_27d4b825","updated":"2024-02-21 11:51:01.000000000","message":"Done","commit_id":"1d43cb08c45a70badc55f8dde58cf25af1c8a0fa"}],"playbooks/roles/bifrost-ironic-install/tasks/download_deployment_image.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: \"Gather details of existing deployment image\""},{"line_number":3,"context_line":"  stat:"},{"line_number":4,"context_line":"    path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}\""},{"line_number":5,"context_line":"    checksum_algorithm: \"{{ \u0027md5\u0027 if deploy_image_checksum_algorithm \u003d\u003d \u0027none\u0027 else deploy_image_checksum_algorithm }}\""},{"line_number":6,"context_line":"    get_checksum: \"{{ deploy_image_checksum_algorithm !\u003d \u0027none\u0027 }}\""},{"line_number":7,"context_line":"  register: deploy_image_stat"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a65f34f_122c1bdd","line":5,"updated":"2023-08-01 13:21:27.000000000","message":"Could use omit (no quotes) rather than \u0027md5\u0027 if you don\u0027t want to provide the argument.","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"Gather details of existing deployment image\""},{"line_number":3,"context_line":"  stat:"},{"line_number":4,"context_line":"    path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}\""},{"line_number":5,"context_line":"    checksum_algorithm: \"{{ \u0027md5\u0027 if deploy_image_checksum_algorithm \u003d\u003d \u0027none\u0027 else deploy_image_checksum_algorithm }}\""},{"line_number":6,"context_line":"    get_checksum: \"{{ deploy_image_checksum_algorithm !\u003d \u0027none\u0027 }}\""},{"line_number":7,"context_line":"  register: deploy_image_stat"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ad87d070_4dbf1773","line":5,"in_reply_to":"9a65f34f_122c1bdd","updated":"2023-09-06 12:36:11.000000000","message":"Done","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"668a71b6_e52bd3c8","line":20,"updated":"2023-08-01 13:21:27.000000000","message":"Looking at this again, I notice that for the IPA image we added support for headers via ipa_download_headers, which could be used to pass the basic auth header.","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"38106640511223d909ed5dfec43024ef9859fedc","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6eedd30d_cc2496ef","line":20,"in_reply_to":"668a71b6_e52bd3c8","updated":"2023-09-06 09:39:07.000000000","message":"If I remember correctly, the issue was not that it needed additional headers, it was that it would apply them after a redirect, which could cause an error with basic auth. What we need is unredirected_headers, but that is only available with ansible 2.12. At the time that wasn\u0027t really an option because we wanted cherrypickability, but we could switch that now","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"395c9b18d66240d59186d5d3fa4470a069a0e48d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"aef70043_5a98b889","line":20,"in_reply_to":"6eedd30d_cc2496ef","updated":"2023-09-13 10:26:25.000000000","message":"Ack","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        group: ironic"},{"line_number":57,"context_line":"        mode: \"0644\""},{"line_number":58,"context_line":"  when: \u003e-"},{"line_number":59,"context_line":"    (deploy_image_stat.stat.checksum | default(\"none\") not in checksum_file_contents.stdout | default(\"\")) or"},{"line_number":60,"context_line":"    (not deploy_image_stat.stat.exists) or"},{"line_number":61,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":62,"context_line":"    (deploy_image_checksum_url !\u003d \"none\")"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b324dbe9_46c23c06","line":59,"updated":"2023-08-01 13:21:27.000000000","message":"The checksum files contain multiple checksums, so could this match against the wrong image? e.g. if we download CentOS 9 image then change the variable to point to a new version of the image, it will skip the download.\n\nCan we use the awk pattern from the IPA download?","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        group: ironic"},{"line_number":57,"context_line":"        mode: \"0644\""},{"line_number":58,"context_line":"  when: \u003e-"},{"line_number":59,"context_line":"    (deploy_image_stat.stat.checksum | default(\"none\") not in checksum_file_contents.stdout | default(\"\")) or"},{"line_number":60,"context_line":"    (not deploy_image_stat.stat.exists) or"},{"line_number":61,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":62,"context_line":"    (deploy_image_checksum_url !\u003d \"none\")"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"48f1c3d0_c3aaa8dd","line":59,"in_reply_to":"b324dbe9_46c23c06","updated":"2023-09-06 12:36:11.000000000","message":"Done","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    (deploy_image_stat.stat.checksum | default(\"none\") not in checksum_file_contents.stdout | default(\"\")) or"},{"line_number":60,"context_line":"    (not deploy_image_stat.stat.exists) or"},{"line_number":61,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":62,"context_line":"    (deploy_image_checksum_url !\u003d \"none\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- block:"},{"line_number":65,"context_line":"    - name: \"Create a checksum file for the custom deployment image\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"25072043_3c109d17","line":62,"updated":"2023-08-01 13:21:27.000000000","message":"\u003d\u003d ?","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    (deploy_image_stat.stat.checksum | default(\"none\") not in checksum_file_contents.stdout | default(\"\")) or"},{"line_number":60,"context_line":"    (not deploy_image_stat.stat.exists) or"},{"line_number":61,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":62,"context_line":"    (deploy_image_checksum_url !\u003d \"none\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- block:"},{"line_number":65,"context_line":"    - name: \"Create a checksum file for the custom deployment image\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"289cabb5_627f67c7","line":62,"in_reply_to":"25072043_3c109d17","updated":"2023-09-06 12:36:11.000000000","message":"Done","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":62,"context_line":"    (deploy_image_checksum_url !\u003d \"none\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- block:"},{"line_number":65,"context_line":"    - name: \"Create a checksum file for the custom deployment image\""},{"line_number":66,"context_line":"      shell: md5sum {{ http_boot_folder }}/{{ deploy_image_filename }} \u003e {{ deploy_image_filename }}.CHECKSUMS"},{"line_number":67,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ac17647a_1b3245ec","line":64,"updated":"2023-08-01 13:21:27.000000000","message":"Unsure what this part is for.","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":62,"context_line":"    (deploy_image_checksum_url !\u003d \"none\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- block:"},{"line_number":65,"context_line":"    - name: \"Create a checksum file for the custom deployment image\""},{"line_number":66,"context_line":"      shell: md5sum {{ http_boot_folder }}/{{ deploy_image_filename }} \u003e {{ deploy_image_filename }}.CHECKSUMS"},{"line_number":67,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b143c0cd_c7a315f1","line":64,"in_reply_to":"ac17647a_1b3245ec","updated":"2023-09-06 12:36:11.000000000","message":"Transcription error, removed.","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ed72a29a09ee42363b59c650f16e79cb511234d1","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5ba3de19_827e5b23","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":13},"updated":"2023-09-06 12:44:07.000000000","message":"why not use ansible module instead of external command?","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"22b7c2a04031b04f98c398135f1fa2c399a9c41a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ee3541e6_edc0c426","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":13},"in_reply_to":"5ba3de19_827e5b23","updated":"2023-09-06 12:49:46.000000000","message":"That was added in this patch: https://review.opendev.org/c/openstack/bifrost/+/868387","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"058499cfc49f937a72b27cf194e416d04bf76509","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c0f046ab_2605afc5","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":13},"in_reply_to":"81f204d5_28ad5aa9","updated":"2023-09-06 15:40:18.000000000","message":"imho this piece of change should be in the separate patchset.","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9e3f88ed3fcb8cee2873e6765c95dd072438b99f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"81f204d5_28ad5aa9","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":13},"in_reply_to":"8ecafc31_5e4499d2","updated":"2023-09-06 15:03:14.000000000","message":"Retries might be nice, but the solve a different problem. Quoting the commit message of that change:\nget_url will currently by default include authorization headers after redirection which can in some circumstances can cause 400 errors.\nBoth get_url and uri have an unredirected_headers parameter, but only after ansible-core 2.12, making curl the next best\noption.\n\nI think ansible-core 2.12 is now supported in this release so it might be time to update it.","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fa83419b58f0ee4b2083d48200970c6caa82a56c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"    - name: Set checksum file permissions"},{"line_number":22,"context_line":"      file:"},{"line_number":23,"context_line":"        path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8ecafc31_5e4499d2","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":13},"in_reply_to":"ee3541e6_edc0c426","updated":"2023-09-06 12:53:35.000000000","message":"I see, my concern is why get_url should fail but curl succeed? may be we need retries instead of rescue block?","commit_id":"43f0b026e654a2d9ef854a677b65159a0e137595"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        mode: \"0644\""},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - deploy_image_stat.stat.exists"},{"line_number":29,"context_line":"    - deploy_image_checksum_algorithm !\u003d \"none\""},{"line_number":30,"context_line":"    - deploy_image_checksum_url !\u003d \"none\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Extract deployment image checksum\""},{"line_number":33,"context_line":"  command: awk \u0027/{{ deploy_image_upstream_url | basename }}|^[a-z0-9]+$/{print $1}\u0027 {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"877dcdfb_65ad0955","line":30,"range":{"start_line":29,"start_character":6,"end_line":30,"end_character":41},"updated":"2023-09-06 15:38:24.000000000","message":"not needed because we have defaults","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        mode: \"0644\""},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - deploy_image_stat.stat.exists"},{"line_number":29,"context_line":"    - deploy_image_checksum_algorithm !\u003d \"none\""},{"line_number":30,"context_line":"    - deploy_image_checksum_url !\u003d \"none\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Extract deployment image checksum\""},{"line_number":33,"context_line":"  command: awk \u0027/{{ deploy_image_upstream_url | basename }}|^[a-z0-9]+$/{print $1}\u0027 {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"486b1421_98346d5b","line":30,"range":{"start_line":29,"start_character":6,"end_line":30,"end_character":41},"in_reply_to":"877dcdfb_65ad0955","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"               or not parsed_deployment_image_checksum.stdout"},{"line_number":37,"context_line":"  when:"},{"line_number":38,"context_line":"    - deploy_image_stat.stat.exists"},{"line_number":39,"context_line":"    - deploy_image_checksum_algorithm !\u003d \"none\""},{"line_number":40,"context_line":"    - deploy_image_checksum_url !\u003d \"none\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- block:"},{"line_number":43,"context_line":"    - name: \"Download a deployment image if requested\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"6519cf9a_1a3704ad","line":40,"range":{"start_line":39,"start_character":6,"end_line":40,"end_character":41},"updated":"2023-09-06 15:38:24.000000000","message":"ditto","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               or not parsed_deployment_image_checksum.stdout"},{"line_number":37,"context_line":"  when:"},{"line_number":38,"context_line":"    - deploy_image_stat.stat.exists"},{"line_number":39,"context_line":"    - deploy_image_checksum_algorithm !\u003d \"none\""},{"line_number":40,"context_line":"    - deploy_image_checksum_url !\u003d \"none\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- block:"},{"line_number":43,"context_line":"    - name: \"Download a deployment image if requested\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e6c0a8f1_ec0462de","line":40,"range":{"start_line":39,"start_character":6,"end_line":40,"end_character":41},"in_reply_to":"6519cf9a_1a3704ad","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":59,"context_line":"  when: \u003e-"},{"line_number":60,"context_line":"    (deploy_image_stat.stat.checksum | default(\"none\") not in parsed_deployment_image_checksum.stdout | default(\"\")) or"},{"line_number":61,"context_line":"    (not deploy_image_stat.stat.exists) or"},{"line_number":62,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":63,"context_line":"    (deploy_image_checksum_url \u003d\u003d \"none\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: \"Create a checksum file for the custom deployment image\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fef41efc_0545e3f8","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":48},"updated":"2023-09-06 15:38:24.000000000","message":"ditto","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  when: \u003e-"},{"line_number":60,"context_line":"    (deploy_image_stat.stat.checksum | default(\"none\") not in parsed_deployment_image_checksum.stdout | default(\"\")) or"},{"line_number":61,"context_line":"    (not deploy_image_stat.stat.exists) or"},{"line_number":62,"context_line":"    (deploy_image_checksum_algorithm \u003d\u003d \"none\") or"},{"line_number":63,"context_line":"    (deploy_image_checksum_url \u003d\u003d \"none\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: \"Create a checksum file for the custom deployment image\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a322b8f9_d5f652c9","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":48},"in_reply_to":"fef41efc_0545e3f8","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"539bf27a2d76ae1094bf97cfa086773efa4837fb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  register: deploy_image_stat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- when:"},{"line_number":10,"context_line":"    - deploy_image_stat.stat.exists"},{"line_number":11,"context_line":"  block:"},{"line_number":12,"context_line":"    - name: \"Download checksum file for custom deployment image\""},{"line_number":13,"context_line":"      get_url:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff97d4da_479aac06","line":10,"updated":"2023-11-02 12:00:42.000000000","message":"We should download the checksums unconditionally. We can use them to \n\n1. check whether we need to download a new image\n2. verify the content of a downloaded image (use the checksum argument of get_url)\n\nSee playbooks/roles/bifrost-ironic-install/tasks/download_ipa_image.yml for what we do with IPA kernel/ramdisk.","commit_id":"1d43cb08c45a70badc55f8dde58cf25af1c8a0fa"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"b863329ddd950e9cb66960361e98c8a35db90ca7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  register: deploy_image_stat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- when:"},{"line_number":10,"context_line":"    - deploy_image_stat.stat.exists"},{"line_number":11,"context_line":"  block:"},{"line_number":12,"context_line":"    - name: \"Download checksum file for custom deployment image\""},{"line_number":13,"context_line":"      get_url:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f98e1a67_61b01133","line":10,"in_reply_to":"ff97d4da_479aac06","updated":"2024-02-21 11:51:01.000000000","message":"Done","commit_id":"1d43cb08c45a70badc55f8dde58cf25af1c8a0fa"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"539bf27a2d76ae1094bf97cfa086773efa4837fb","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        group: ironic"},{"line_number":57,"context_line":"        mode: \"0644\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: \"Create a checksum file for the custom deployment image\""},{"line_number":60,"context_line":"  shell: md5sum {{ deploy_image_filename }} \u003e {{ deploy_image_filename }}.CHECKSUMS"},{"line_number":61,"context_line":"  args:"},{"line_number":62,"context_line":"    chdir: \"{{ http_boot_folder }}\""},{"line_number":63,"context_line":"- name: \"Ensure the checksum file is readable\""},{"line_number":64,"context_line":"  file:"},{"line_number":65,"context_line":"    path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}.CHECKSUMS\""},{"line_number":66,"context_line":"    owner: ironic"},{"line_number":67,"context_line":"    group: ironic"},{"line_number":68,"context_line":"    mode: \"0644\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"629b6f53_4e481e46","line":68,"range":{"start_line":59,"start_character":0,"end_line":68,"end_character":16},"updated":"2023-11-02 12:00:42.000000000","message":"Is this is necessary now that we have proper checksum support?","commit_id":"1d43cb08c45a70badc55f8dde58cf25af1c8a0fa"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"b863329ddd950e9cb66960361e98c8a35db90ca7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        group: ironic"},{"line_number":57,"context_line":"        mode: \"0644\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: \"Create a checksum file for the custom deployment image\""},{"line_number":60,"context_line":"  shell: md5sum {{ deploy_image_filename }} \u003e {{ deploy_image_filename }}.CHECKSUMS"},{"line_number":61,"context_line":"  args:"},{"line_number":62,"context_line":"    chdir: \"{{ http_boot_folder }}\""},{"line_number":63,"context_line":"- name: \"Ensure the checksum file is readable\""},{"line_number":64,"context_line":"  file:"},{"line_number":65,"context_line":"    path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}.CHECKSUMS\""},{"line_number":66,"context_line":"    owner: ironic"},{"line_number":67,"context_line":"    group: ironic"},{"line_number":68,"context_line":"    mode: \"0644\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f207a4b1_80cf45e0","line":68,"range":{"start_line":59,"start_character":0,"end_line":68,"end_character":16},"in_reply_to":"629b6f53_4e481e46","updated":"2024-02-21 11:51:01.000000000","message":"Probably not, I was thinking that they may be used somewhere else but I don\u0027t think they are.","commit_id":"1d43cb08c45a70badc55f8dde58cf25af1c8a0fa"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9744f7c0bedf0d9b7b6b6bc25b72bfa9fdd69754","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        owner: ironic"},{"line_number":47,"context_line":"        group: ironic"},{"line_number":48,"context_line":"        mode: \"0644\""},{"line_number":49,"context_line":"        checksum: deployment_image_checksum"},{"line_number":50,"context_line":"  rescue:"},{"line_number":51,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":52,"context_line":"      command: \"curl -L --output {{ deploy_image }} {{ deploy_image_upstream_url }}\" # noqa: command-instead-of-module"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7c54f150_63219b16","line":49,"updated":"2024-02-29 11:42:05.000000000","message":"\"{{ deployment_image_checksum }}\"","commit_id":"48d3c8e76b90d6fcac38a447d1872584e0b8e24d"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"3b6163b278aeef35b967596f752bb710df1a092f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        owner: ironic"},{"line_number":47,"context_line":"        group: ironic"},{"line_number":48,"context_line":"        mode: \"0644\""},{"line_number":49,"context_line":"        checksum: deployment_image_checksum"},{"line_number":50,"context_line":"  rescue:"},{"line_number":51,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":52,"context_line":"      command: \"curl -L --output {{ deploy_image }} {{ deploy_image_upstream_url }}\" # noqa: command-instead-of-module"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"83f12999_393a59ae","line":49,"in_reply_to":"7c54f150_63219b16","updated":"2024-03-07 16:47:12.000000000","message":"Done","commit_id":"48d3c8e76b90d6fcac38a447d1872584e0b8e24d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a9d654788ea1708459a44730bdcbc293e15d670b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"Gather details of existing deployment image\""},{"line_number":3,"context_line":"  stat:"},{"line_number":4,"context_line":"    path: \"{{ http_boot_folder }}/{{ deploy_image_filename }}\""},{"line_number":5,"context_line":"    checksum_algorithm: \"{{ omit if deploy_image_checksum_algorithm \u003d\u003d \u0027none\u0027 else deploy_image_checksum_algorithm }}\""},{"line_number":6,"context_line":"    get_checksum: \"{{ deploy_image_checksum_algorithm !\u003d \u0027none\u0027 }}\""},{"line_number":7,"context_line":"  register: deploy_image_stat"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"2c9766f9_a99dd8b0","line":5,"updated":"2024-04-27 15:16:57.000000000","message":"I\u0027d prefer using \"is undefined\" instead of the custom \u0027none\u0027 value","commit_id":"ba394546e232c234c09e2a42573945d7360cbf00"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a9d654788ea1708459a44730bdcbc293e15d670b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        mode: \"0644\""},{"line_number":18,"context_line":"  rescue:"},{"line_number":19,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":20,"context_line":"      command: \"curl -L --output {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS {{ deploy_image_checksum_url }}\" # noqa: command-instead-of-module"},{"line_number":21,"context_line":"      no_log: true"},{"line_number":22,"context_line":"    - name: Set checksum file permissions"},{"line_number":23,"context_line":"      file:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3b0b280e_1619b6c0","line":20,"updated":"2024-04-27 15:16:57.000000000","message":"Side note: need to use -f with curl, otherwise you risk saving an HTTP 404 page. A follow-up welcome.","commit_id":"ba394546e232c234c09e2a42573945d7360cbf00"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a9d654788ea1708459a44730bdcbc293e15d670b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        checksum: \"{{ deployment_image_checksum }}\""},{"line_number":50,"context_line":"  rescue:"},{"line_number":51,"context_line":"    - name: \"Attempt to use curl if get_url fails\""},{"line_number":52,"context_line":"      command: \"curl -L --output {{ deploy_image }} {{ deploy_image_upstream_url }}\" # noqa: command-instead-of-module"},{"line_number":53,"context_line":"    - name: Set file permissions"},{"line_number":54,"context_line":"      file:"},{"line_number":55,"context_line":"        path: \"{{ deploy_image }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"e70fc491_4d57a698","line":52,"updated":"2024-04-27 15:16:57.000000000","message":"same re -f","commit_id":"ba394546e232c234c09e2a42573945d7360cbf00"}],"releasenotes/notes/downloaded-deploy-image-improvements-2563ffb57a41ab20.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1be860f99cdc3a5e706c5ee918fcb6d1531fc6e2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Default images for Centos 8 Stream, Ubuntu 20.04, Ubuntu 22.04, Rocky"},{"line_number":5,"context_line":"    Linux 8, and Rocky Linux 9 have all been added. These can be selected by"},{"line_number":6,"context_line":"    setting upstream_deploy_image_distribution and"},{"line_number":7,"context_line":"    upstream_deploy_image_release."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5e4cb75d_c387a243","line":7,"updated":"2023-08-01 13:21:27.000000000","message":"Also need to set download flag","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"9324bb4657d888c0ac2dcb001e31da77486e24c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Default images for Centos 8 Stream, Ubuntu 20.04, Ubuntu 22.04, Rocky"},{"line_number":5,"context_line":"    Linux 8, and Rocky Linux 9 have all been added. These can be selected by"},{"line_number":6,"context_line":"    setting upstream_deploy_image_distribution and"},{"line_number":7,"context_line":"    upstream_deploy_image_release."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"12658fc8_18e17284","line":7,"in_reply_to":"5e4cb75d_c387a243","updated":"2023-09-06 12:36:11.000000000","message":"Done","commit_id":"1d79db6a709dbd7d3f484fc68710c605ec5197cf"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    upstream_deploy_image_distribution and upstream_deploy_image_release, and"},{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f9f06c4_d24d8593","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":52},"updated":"2023-09-06 15:38:24.000000000","message":"``custom_deploy_image_checksum_url``, ``custom_deploy_image_upstream_url``","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    upstream_deploy_image_distribution and upstream_deploy_image_release, and"},{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cbe2c476_2e1be6bd","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":13},"updated":"2023-09-06 15:38:24.000000000","message":"new","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    upstream_deploy_image_distribution and upstream_deploy_image_release, and"},{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"580b20e2_0196df9c","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":52},"in_reply_to":"1f9f06c4_d24d8593","updated":"2023-09-13 09:54:42.000000000","message":"custom_deploy_image_upstream_url already existed. This change only adds the checksum variables.","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    upstream_deploy_image_distribution and upstream_deploy_image_release, and"},{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f9014870_2f40a18d","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":13},"in_reply_to":"cbe2c476_2e1be6bd","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"46d5d02a_09802a5c","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":37},"updated":"2023-09-06 15:38:24.000000000","message":"and ``custom_deploy_image_checksum_algorithm`` to override defaults selected by the distribution and release.","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"af14f6448159ff242e2d88b6ecddf2a243f5a1cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"225bfdfa_e4cc4e5d","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":37},"in_reply_to":"1d0114b2_8b98d897","updated":"2023-09-13 10:25:46.000000000","message":"no, all clear. you should provide all the new variables not only two of them.","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"5fb471529c5a8bec90c4cedd08b9354f936af2e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ac3ea7f6_4e49dacd","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":37},"in_reply_to":"225bfdfa_e4cc4e5d","updated":"2023-09-13 10:34:18.000000000","message":"anyway the usage logic of the of \u0027custom_deploy_image_upstream_url\u0027 slightly changed, so this should be covered in the notes.","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"e8b6be91a7a81896e6098212d7b2e2a21357e984","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1d0114b2_8b98d897","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":37},"in_reply_to":"46d5d02a_09802a5c","updated":"2023-09-13 10:13:39.000000000","message":"I think this would make it less clear","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"a79e26556f50ae93a68af11a46069ec20918b598","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    are deployed when download_custom_deploy_image is true."},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a8adeab_6d98689e","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":37},"in_reply_to":"ac3ea7f6_4e49dacd","updated":"2023-09-13 13:33:36.000000000","message":"I\u0027ve reworded the paragraph, should be more clear now","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"12504bd8445fcde61452b1ca95da540a5e8dd90d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"98855aa0_465a2e7c","line":13,"range":{"start_line":12,"start_character":13,"end_line":13,"end_character":40},"updated":"2023-09-06 15:38:24.000000000","message":"matches.","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"f0cac5b0fcd19f3a8c4902e3822c6bf1c6db063e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    Added two variables, ``deploy_image_checksum_url`` and"},{"line_number":10,"context_line":"    ``deploy_image_checksum_algorithm``. Deployment images that have been"},{"line_number":11,"context_line":"    downloaded will not be re-downloaded if they already exist and their"},{"line_number":12,"context_line":"    checksum matches that provided by ``deploy_image_checksum_url`` for a given"},{"line_number":13,"context_line":"    ``deploy_image_checksum_algorithm``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"730c8f90_6a00ddbd","line":13,"range":{"start_line":12,"start_character":13,"end_line":13,"end_character":40},"in_reply_to":"98855aa0_465a2e7c","updated":"2023-09-13 09:54:42.000000000","message":"Done","commit_id":"38fbf037e0a265a87869c6e26e9c0007b4b1c63f"}]}