)]}'
{"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cbc524148b51c961dd6476e99b002d59d06fe064","unresolved":true,"context_lines":[{"line_number":406,"context_line":"# Internal variables"},{"line_number":407,"context_line":"pxe_kernel_params: \u003e-"},{"line_number":408,"context_line":"  nofb nomodeset systemd.journald.forward_to_console\u003dyes"},{"line_number":409,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":410,"context_line":"  ipa-insecure\u003d1"},{"line_number":411,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":412,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cbf1fbac_1963d9db","side":"PARENT","line":409,"updated":"2023-09-27 14:01:28.000000000","message":"I think you lost this part?","commit_id":"912893ae83e6d60e8067dc1509d77b4c8cc80a32"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e2baf961dc17d530d0a4519fbb90ceed880ffc5","unresolved":true,"context_lines":[{"line_number":406,"context_line":"# Internal variables"},{"line_number":407,"context_line":"pxe_kernel_params: \u003e-"},{"line_number":408,"context_line":"  nofb nomodeset systemd.journald.forward_to_console\u003dyes"},{"line_number":409,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":410,"context_line":"  ipa-insecure\u003d1"},{"line_number":411,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":412,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0d86575b_58f2e4e7","side":"PARENT","line":409,"in_reply_to":"82e6a422_2c0edfd2","updated":"2023-12-11 11:00:19.000000000","message":"\"if testing\" is the code that runs in the testing case: in the CI or locally. The console value is correct for these since we need to be able to collect the logs. I now I see that at least the current patch has the right bit on line 412 (maybe I overlooked it earlier).","commit_id":"912893ae83e6d60e8067dc1509d77b4c8cc80a32"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b535532ca36f8d03967a1ff0d7ccab957b2b19e9","unresolved":true,"context_lines":[{"line_number":406,"context_line":"# Internal variables"},{"line_number":407,"context_line":"pxe_kernel_params: \u003e-"},{"line_number":408,"context_line":"  nofb nomodeset systemd.journald.forward_to_console\u003dyes"},{"line_number":409,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":410,"context_line":"  ipa-insecure\u003d1"},{"line_number":411,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":412,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da95a082_a5073c41","side":"PARENT","line":409,"in_reply_to":"cbf1fbac_1963d9db","updated":"2023-09-27 14:19:56.000000000","message":"do you think this should be enabled always? what if some operator want ttyS1 or whatever by default?","commit_id":"912893ae83e6d60e8067dc1509d77b4c8cc80a32"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9f89ac7eba178b105f02c580717b416745cfe98a","unresolved":true,"context_lines":[{"line_number":406,"context_line":"# Internal variables"},{"line_number":407,"context_line":"pxe_kernel_params: \u003e-"},{"line_number":408,"context_line":"  nofb nomodeset systemd.journald.forward_to_console\u003dyes"},{"line_number":409,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":410,"context_line":"  ipa-insecure\u003d1"},{"line_number":411,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":412,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"82e6a422_2c0edfd2","side":"PARENT","line":409,"in_reply_to":"ce60c6c1_d88e3a9f","updated":"2023-10-18 22:15:46.000000000","message":"do you mean this needed always and breaks CI? or should we add testing in CI scripts?","commit_id":"912893ae83e6d60e8067dc1509d77b4c8cc80a32"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"12ac7eb4985e7dfed2378252f03ce793fd61ca09","unresolved":true,"context_lines":[{"line_number":406,"context_line":"# Internal variables"},{"line_number":407,"context_line":"pxe_kernel_params: \u003e-"},{"line_number":408,"context_line":"  nofb nomodeset systemd.journald.forward_to_console\u003dyes"},{"line_number":409,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":410,"context_line":"  ipa-insecure\u003d1"},{"line_number":411,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":412,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ce60c6c1_d88e3a9f","side":"PARENT","line":409,"in_reply_to":"da95a082_a5073c41","updated":"2023-09-29 11:56:54.000000000","message":"This is under \"if testing\". It\u0027s important to get ramdisk logs in the CI or when testing locally.","commit_id":"912893ae83e6d60e8067dc1509d77b4c8cc80a32"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cbc524148b51c961dd6476e99b002d59d06fe064","unresolved":true,"context_lines":[{"line_number":252,"context_line":"# String value containing extra kernel parameters for the inspector default"},{"line_number":253,"context_line":"# PXE configuration."},{"line_number":254,"context_line":"inspector_extra_kernel_default: \"ipa-inspection-collectors\u003ddefault,logs\""},{"line_number":255,"context_line":"inspector_extra_kernel_options: \"{{ pxe_kernel_params }} {{ inspector_extra_kernel_default }}\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"# Set inspector_processing_hooks to specify a non-default comma-separated"},{"line_number":258,"context_line":"# list of processing hooks for inspector."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0bfc0450_fb6ed228","line":255,"updated":"2023-09-27 14:01:28.000000000","message":"What if an operator already overrides this variable? Won\u0027t they lose pxe_kernel_params?","commit_id":"58239d5a89c3e4285a47dce80a39796eb3dc7ded"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b535532ca36f8d03967a1ff0d7ccab957b2b19e9","unresolved":true,"context_lines":[{"line_number":252,"context_line":"# String value containing extra kernel parameters for the inspector default"},{"line_number":253,"context_line":"# PXE configuration."},{"line_number":254,"context_line":"inspector_extra_kernel_default: \"ipa-inspection-collectors\u003ddefault,logs\""},{"line_number":255,"context_line":"inspector_extra_kernel_options: \"{{ pxe_kernel_params }} {{ inspector_extra_kernel_default }}\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"# Set inspector_processing_hooks to specify a non-default comma-separated"},{"line_number":258,"context_line":"# list of processing hooks for inspector."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e2ce410f_29e191d6","line":255,"in_reply_to":"0bfc0450_fb6ed228","updated":"2023-09-27 14:19:56.000000000","message":"if an operator overrides this, it will loose any values, even without my change. not really understand your question.","commit_id":"58239d5a89c3e4285a47dce80a39796eb3dc7ded"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9f89ac7eba178b105f02c580717b416745cfe98a","unresolved":true,"context_lines":[{"line_number":252,"context_line":"# String value containing extra kernel parameters for the inspector default"},{"line_number":253,"context_line":"# PXE configuration."},{"line_number":254,"context_line":"inspector_extra_kernel_default: \"ipa-inspection-collectors\u003ddefault,logs\""},{"line_number":255,"context_line":"inspector_extra_kernel_options: \"{{ pxe_kernel_params }} {{ inspector_extra_kernel_default }}\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"# Set inspector_processing_hooks to specify a non-default comma-separated"},{"line_number":258,"context_line":"# list of processing hooks for inspector."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b7ce3bc9_11375737","line":255,"in_reply_to":"c74106e8_ffafa217","updated":"2023-10-18 22:15:46.000000000","message":"sorry for late reply. lets dig deeper and discus this.","commit_id":"58239d5a89c3e4285a47dce80a39796eb3dc7ded"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"12ac7eb4985e7dfed2378252f03ce793fd61ca09","unresolved":true,"context_lines":[{"line_number":252,"context_line":"# String value containing extra kernel parameters for the inspector default"},{"line_number":253,"context_line":"# PXE configuration."},{"line_number":254,"context_line":"inspector_extra_kernel_default: \"ipa-inspection-collectors\u003ddefault,logs\""},{"line_number":255,"context_line":"inspector_extra_kernel_options: \"{{ pxe_kernel_params }} {{ inspector_extra_kernel_default }}\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"# Set inspector_processing_hooks to specify a non-default comma-separated"},{"line_number":258,"context_line":"# list of processing hooks for inspector."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c74106e8_ffafa217","line":255,"in_reply_to":"e2ce410f_29e191d6","updated":"2023-09-29 11:56:54.000000000","message":"Right now \"nofb nomodeset\" etc are hardcoded (which is bad, I agree here). With you changes, the operator overriding inspector_extra_kernel_options will lose them because they will get neither pxe_kernel_params nor the hardcoded values.\n\nI think you should leave inspector_extra_kernel_options as it is and just use pxe_kernel_params in the template file in addition to inspector_extra_kernel_options.","commit_id":"58239d5a89c3e4285a47dce80a39796eb3dc7ded"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cbc524148b51c961dd6476e99b002d59d06fe064","unresolved":true,"context_lines":[{"line_number":413,"context_line":"  - \"ipa-insecure\u003d1\""},{"line_number":414,"context_line":"  - \"{{ \u0027sshkey\u003d\u0027 ~ ssh_public_key if (ipa_add_ssh_key | bool and ssh_public_key is defined) else \u0027\u0027 }}\""},{"line_number":415,"context_line":"  - \"{{ extra_kernel_options | default(\u0027\u0027) }}\""},{"line_number":416,"context_line":"pxe_kernel_params: \"{{ pxe_kernel_params_default | join(\u0027 \u0027) }}\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"redfish_kernel_params: \"{{ pxe_kernel_params }}\""},{"line_number":419,"context_line":"ilo_kernel_params: \"{{ pxe_kernel_params }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"567a4fce_cda4e5eb","line":416,"range":{"start_line":416,"start_character":19,"end_line":416,"end_character":64},"updated":"2023-09-27 14:01:28.000000000","message":"This value is the default for pxe_kernel_params, right? And you create a variable that is the default for the default... This all feels a bit weird to me.","commit_id":"58239d5a89c3e4285a47dce80a39796eb3dc7ded"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b535532ca36f8d03967a1ff0d7ccab957b2b19e9","unresolved":false,"context_lines":[{"line_number":413,"context_line":"  - \"ipa-insecure\u003d1\""},{"line_number":414,"context_line":"  - \"{{ \u0027sshkey\u003d\u0027 ~ ssh_public_key if (ipa_add_ssh_key | bool and ssh_public_key is defined) else \u0027\u0027 }}\""},{"line_number":415,"context_line":"  - \"{{ extra_kernel_options | default(\u0027\u0027) }}\""},{"line_number":416,"context_line":"pxe_kernel_params: \"{{ pxe_kernel_params_default | join(\u0027 \u0027) }}\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"redfish_kernel_params: \"{{ pxe_kernel_params }}\""},{"line_number":419,"context_line":"ilo_kernel_params: \"{{ pxe_kernel_params }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"45c0baa1_81015111","line":416,"range":{"start_line":416,"start_character":19,"end_line":416,"end_character":64},"in_reply_to":"567a4fce_cda4e5eb","updated":"2023-09-27 14:19:56.000000000","message":"I\u0027ve did this only to make the code more human readable, and easy to manipulate within the code.","commit_id":"58239d5a89c3e4285a47dce80a39796eb3dc7ded"}]}