)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3d5ee1539244cb0c9ed88fde3f6f5da33ff58e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a1a7d09_b3d43a3b","updated":"2024-07-29 11:05:38.000000000","message":"I don\u0027t really mind this, but you\u0027re trying to hide a bug in your patch, and this is not the way to do it.","commit_id":"333dc86a013f1f4428f9e697e146054d6247cc70"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"23f443c489aeb94dab0cb8e4631c4f67acf57de6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc4b6b3d_89c19794","updated":"2024-08-07 08:51:54.000000000","message":"abandoning upon discussion with Dmitry. Can be revisited in the future if there is need/interest.","commit_id":"333dc86a013f1f4428f9e697e146054d6247cc70"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"3b8cc9cabea913d2222f14db93446fc6e206f080","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47d28c6d_8713f33f","in_reply_to":"0a1a7d09_b3d43a3b","updated":"2024-07-29 12:43:03.000000000","message":"Thank you for your review Dmitry. This is not an attempt to hide a bug but to avoid hitting the problem in the first place. If you\u0027re concerned about UpdateService implementation I am open to improving it. Having said that I would be much happier \navoiding  the redirects entirely hence proposing this patch - I find these are confusing and make troubleshooting much harder than it needs to be.","commit_id":"333dc86a013f1f4428f9e697e146054d6247cc70"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"275d297a93f3a7d7237dc59466f618b2f42b6971","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3203551a_6f0bedd5","in_reply_to":"3eadccfb_d01eb3be","updated":"2024-07-30 04:13:36.000000000","message":"I don\u0027t dislike the idea, I see your point around real hardware using names not UUIDs hence I\u0027ve done some quick research into the topic.\nRedirects were introduced around 6 years ago in https://opendev.org/openstack/sushy-tools/commit/499536afcb9a7cdf598cf707cacda8eb7b9735ca by Ilya and IIUC his intention to ensure consistency between libvirt and nova backends which is fair. While libvirt won\u0027t allow duplicate names (I just lab-tested this to validate my understanding) I am reasonably sure nova will (I no longer have an OpenStack handy to validate this, unfortunately) so lack of consistency there could be a concern.  What are your thoughts on this?","commit_id":"333dc86a013f1f4428f9e697e146054d6247cc70"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5370bbe4e053d8e76830ae259bfdb225e0946d44","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3eadccfb_d01eb3be","in_reply_to":"47d28c6d_8713f33f","updated":"2024-07-29 15:26:11.000000000","message":"I have mixed feelings about this topic. On one hand, I don\u0027t like the redirects either. However, first, real hardware tends to use names in URLs, not UUIDs. Second, in case of Bifrost specifically, names are much handier than the pretty opaque libvirt UUIDs.\n\nIf anything, I\u0027d rather make names the primary ID\u0027s.","commit_id":"333dc86a013f1f4428f9e697e146054d6247cc70"}]}