)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"8549c26c07ae226929b9cc7ff17a2ed40956fd79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de191ebf_87761dfe","updated":"2024-08-06 13:14:04.000000000","message":"Test commands with this patch in place:\n\nrm -rf bifrost\ngit clone https://opendev.org/openstack/bifrost.git\ncd bifrost\ngit fetch https://review.opendev.org/openstack/bifrost refs/changes/61/925761/1 \u0026\u0026 git checkout FETCH_HEAD\nvim playbooks/inventory/group_vars/baremetal # set redfish-virtualmedia boot_interface\n./bifrost-cli testenv --driver redfish\n./bifrost-cli install --testenv --hardware-types\u003dredfish\nsource /opt/stack/bifrost/bin/activate\nexport OS_CLOUD\u003dbifrost\n./bifrost-cli enroll baremetal-inventory.json \n./bifrost-cli deploy baremetal-inventory.json \nbaremetal node service --service-steps \u0027[{\"interface\": \"firmware\", \"step\":\"update\", \"args\":{\"settings\":[{\"component\": \"bmc\", \"url\":\"http://10.6.48.48:8080/ilo5278.bin\"}]}}]\u0027 testvm1\nbaremetal node service --service-steps \u0027[{\"interface\": \"firmware\", \"step\":\"update\", \"args\":{\"settings\":[{\"component\": \"bmc\", \"url\":\"http://10.6.48.48:8080/ilo5278.bin\"}]}}]\u0027 testvm2\n\nno need to adjust any ironic or instance settings (only inventory needs an edit before starting the install to switch to redfish-virtualmedia boot_interface)","commit_id":"4df5d78ceb081793815f09e0fcc01e63d6655396"}],"playbooks/roles/bifrost-ironic-install/tasks/hw_types.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"91199bf280dbc4295edad59ab8950c6a3c603b95","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    enabled_firmware_interfaces: \u003e- # noqa jinja var-spacing"},{"line_number":43,"context_line":"      no-firmware"},{"line_number":44,"context_line":"      {%- if \"redfish\" in enabled_hardware_types -%},redfish{%- endif -%}"},{"line_number":45,"context_line":"  when: not enabled_firmware_interfaces"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Configure management interfaces if required\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a589f6c_1ab039d8","line":44,"updated":"2024-08-07 08:51:55.000000000","message":"I think it\u0027s also used by \"idrac\", so we should check for it as well","commit_id":"4df5d78ceb081793815f09e0fcc01e63d6655396"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"22a4b4245377b86a6aa7bcfcfd5af7e959e472db","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    enabled_firmware_interfaces: \u003e- # noqa jinja var-spacing"},{"line_number":43,"context_line":"      no-firmware"},{"line_number":44,"context_line":"      {%- if \"redfish\" in enabled_hardware_types -%},redfish{%- endif -%}"},{"line_number":45,"context_line":"  when: not enabled_firmware_interfaces"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Configure management interfaces if required\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2a8752be_9ce8652a","line":44,"in_reply_to":"2a589f6c_1ab039d8","updated":"2024-08-08 01:44:14.000000000","message":"right, we should enable in the case of idrac!","commit_id":"4df5d78ceb081793815f09e0fcc01e63d6655396"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"664855afd9177a200e2cc648729d93d4beb2639d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  set_fact:"},{"line_number":42,"context_line":"    enabled_firmware_interfaces: \u003e- # noqa jinja var-spacing"},{"line_number":43,"context_line":"      no-firmware"},{"line_number":44,"context_line":"      {%- if \"redfish\" in enabled_hardware_types -%},redfish{%- endif -%}"},{"line_number":45,"context_line":"  when: not enabled_firmware_interfaces"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Configure management interfaces if required\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"84e973c1_bdd7fa44","line":44,"in_reply_to":"2a8752be_9ce8652a","updated":"2024-08-08 03:05:29.000000000","message":"Thanks Dmitry and Iury, good point, pushed an updated version.","commit_id":"4df5d78ceb081793815f09e0fcc01e63d6655396"}]}