)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"107820f512829ca03527369326918e5f9e26dab0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-19 10:21:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix checksum parsing for Rocky Linux"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For Rocky Linux, the checksum file format differs from Ubuntu and"},{"line_number":10,"context_line":"Cirros. The current awk expression failed to extract the correct"},{"line_number":11,"context_line":"checksum and would instead output SHA256. This caused checksum"},{"line_number":12,"context_line":"validation to fail."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will loop through all fields trying to find one that looks"},{"line_number":15,"context_line":"like a checksum. This should handle both formats."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2081031"},{"line_number":18,"context_line":"Change-Id: Id426db0ad418898a2ebe9f2b5001945520dc6b1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ae3c352a_7f5f906c","line":15,"range":{"start_line":7,"start_character":0,"end_line":15,"end_character":49},"updated":"2024-09-19 11:50:18.000000000","message":"this should be changed too, because:\n1. we have 3 formats\n2. MD5 alongside with SHA256.\n3. not only Rocky Linux but Cirros.","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae648105019ea031159fef4abbe6478fb29abb2c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Will Szumski \u003cwill@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-19 10:21:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix checksum parsing for Rocky Linux"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For Rocky Linux, the checksum file format differs from Ubuntu and"},{"line_number":10,"context_line":"Cirros. The current awk expression failed to extract the correct"},{"line_number":11,"context_line":"checksum and would instead output SHA256. This caused checksum"},{"line_number":12,"context_line":"validation to fail."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change will loop through all fields trying to find one that looks"},{"line_number":15,"context_line":"like a checksum. This should handle both formats."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #2081031"},{"line_number":18,"context_line":"Change-Id: Id426db0ad418898a2ebe9f2b5001945520dc6b1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9067d51e_8d67f7b1","line":15,"range":{"start_line":7,"start_character":0,"end_line":15,"end_character":49},"in_reply_to":"ae3c352a_7f5f906c","updated":"2024-10-23 20:02:16.000000000","message":"Done","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"05a7afe2a8104214ef969a62e0c5406c2eb7dbcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"260ff6b4_5eb8083f","updated":"2024-09-18 10:09:55.000000000","message":"Open to suggestions for more elegant ways to do this, but this seemed to work.","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ad64149626ab6f7dc5b561c3eca80e73a60dc253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31e899d8_4f9d7275","in_reply_to":"260ff6b4_5eb8083f","updated":"2024-09-18 17:59:15.000000000","message":"something like:\ngrep -E \"^[^#]{{ deploy_image_upstream_url | basename }}|^[a-z0-9]+$\"\nto sort out name not started with # symbol","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bb1c6aebb20f2011f1c110c511d802e896bfcb5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"919ad64b_7f7e7938","in_reply_to":"31e899d8_4f9d7275","updated":"2024-09-19 10:24:18.000000000","message":"We also have to account for the two formats. Any suggestions to do that?","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae648105019ea031159fef4abbe6478fb29abb2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"441ae722_1e1da410","in_reply_to":"65ecd5fb_d183b2f2","updated":"2024-10-23 20:02:16.000000000","message":"Done","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"b735426f3f3c5be1dfc21a60ff9ccd190f6e0c65","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65ecd5fb_d183b2f2","in_reply_to":"866d50d9_e9b859d4","updated":"2024-10-11 08:51:45.000000000","message":"Thanks, Maksim. Looks a lot cleaner!","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ea9e96fbb6a23475254b89d898fa660f0bb1283f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8786663_e9170c30","in_reply_to":"919ad64b_7f7e7938","updated":"2024-09-19 11:37:31.000000000","message":"piece of cake:\n\ngrep \"{{ deploy_image_upstream_url | basename }}\" | grep -owE \"[[:alnum:]]{32,64}\"\n\nhttps://paste.opendev.org/show/bbr7AyiMCQ4NZTNsQTgP/\n\nBTW please fix https://opendev.org/openstack/bifrost/src/branch/master/playbooks/roles/bifrost-ironic-install/defaults/main.yml#L143\n\nCentOS-Stream-GenericCloud-9-20230501.0.x86_64.qcow2 doesn\u0027t exist and should be changed to CentOS-Stream-GenericCloud-9-latest.x86_64.qcow2","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0dbd6e023e5d15dedfec7bb28efe4bc7d68f7e58","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"866d50d9_e9b859d4","in_reply_to":"e8786663_e9170c30","updated":"2024-09-19 11:46:59.000000000","message":"update: xdigit more preferable instead of alnum\n\nhttps://paste.opendev.org/show/bMVl60ecZHK2Op79jdTM/","commit_id":"57b68aeec3295243fabb8ade5986fa3d85dd18f5"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"dcb09f47c317c8481e60c956ecd6ecbabfccda00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4c547e2_e2006c91","updated":"2024-10-01 15:42:02.000000000","message":"For reference, I also came across this and tackled it in a different way.\nI just searched through the checksum file to see if the checksum exists in it anywhere: https://github.com/openstack/bifrost/commit/1b0dc4ae2e577fb0912e5624dd243135f85b119a\n\nThe advantage is that the formatting doesn\u0027t matter at all.\nThe disadvantage is that it then does not validate the filename.\n\nI\u0027m not sure which is preferable","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae648105019ea031159fef4abbe6478fb29abb2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f92414b8_d2b65f98","in_reply_to":"45b07b17_437cd44d","updated":"2024-10-23 20:02:16.000000000","message":"Done","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"83ac75de928f585accef063de6450d6039ce5fe3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45b07b17_437cd44d","in_reply_to":"d4c547e2_e2006c91","updated":"2024-10-01 15:47:29.000000000","message":"theoretically two different images can have the same checksum. but theoretically ;)\nits better to match filename and checksum (xdigit is enough to match any checksum, and never will match filename because of dashes, underlines, dots, etc).\nanyway thanks for another point of view.","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7d51c91789305495622fdc8cd8ea5050ea952ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"52d867ef_3955f1aa","updated":"2024-10-23 10:28:35.000000000","message":"recheck","commit_id":"7446da03e8390f16b95cf10acaf75af453d89d46"}],"playbooks/roles/bifrost-ironic-install/tasks/download_deployment_image.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1ea5827780a81bdf5ed2f3638202c96b4c9606e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"- name: \"Extract deployment image checksum\""},{"line_number":30,"context_line":"  shell:"},{"line_number":31,"context_line":"    cmd: |"},{"line_number":32,"context_line":"      set -o pipefail"},{"line_number":33,"context_line":"      grep \"{{ deploy_image_upstream_url | basename }}\" {{ http_boot_folder }}/{{ deploy_image_filename }}-checksum.CHECKSUMS | grep -owE \"[[:xdigit:]]{32,64}\""},{"line_number":34,"context_line":"    executable: /bin/bash"},{"line_number":35,"context_line":"  register: parsed_deployment_image_checksum"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0a160a66_2e4d51c7","line":32,"updated":"2024-11-05 12:05:21.000000000","message":"I wonder if you need to set -e as well","commit_id":"7446da03e8390f16b95cf10acaf75af453d89d46"}],"releasenotes/notes/fixes-rocky-linux-checksum-parsing-82c04ff1bb575c51.yaml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1771d3f17413ae1e6cf6bc7f8b6058bcd1ecd04b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with checksum verification when setting"},{"line_number":5,"context_line":"    ``upstream_deploy_image_distribution`` to ``rocky``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9adfd52a_eb70189c","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":56},"updated":"2024-09-19 11:51:07.000000000","message":"ditto. and relo filename too.","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7d51c91789305495622fdc8cd8ea5050ea952ebf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with checksum verification when setting"},{"line_number":5,"context_line":"    ``upstream_deploy_image_distribution`` to ``rocky``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e0756299_79fea72e","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":56},"in_reply_to":"9adfd52a_eb70189c","updated":"2024-10-23 10:28:35.000000000","message":"Fair. Missed this comment, will address now.","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"ae648105019ea031159fef4abbe6478fb29abb2c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue with checksum verification when setting"},{"line_number":5,"context_line":"    ``upstream_deploy_image_distribution`` to ``rocky``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f0331e50_ba281f2b","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":56},"in_reply_to":"e0756299_79fea72e","updated":"2024-10-23 20:02:16.000000000","message":"Done","commit_id":"10c4d15a45891f75f6f763066b18e6889d8c0558"}]}