)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3ff9339fa5edfaed11b7b12090e29d758a256b76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bcd4c9f2_4b2da289","updated":"2025-11-24 16:36:09.000000000","message":"recheck","commit_id":"754ce62a10b69b0d01231cf4e16a1f02bb93728b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"97dc49afa0c7dba43cb2ba3be931855f5575a497","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f9ad9411_e0c27fa6","updated":"2025-11-25 15:25:32.000000000","message":"Also needs a release note, and... maybe docs?","commit_id":"3e179f9a2d55a44ff1bc5ff4b1275a9942d2735d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a845924587323f9dd69a8d35db071da336f207c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3c070ad9_84a4cc9a","updated":"2025-12-18 18:38:21.000000000","message":"Largely my contribution to this started at patchset ?14?, which is minimal changes  on top, largely geared to get this feature moving. As such, I feel okay marking it +2. Given this is also coming from another reviewer, this should help lower the review burden to get this to land.","commit_id":"28c262f241b4fe725c4ba448b5c19abd9e49bc5f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7d41c885e9871ad2c89cdda96aab3a78b6631ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"666a4dc1_b18e5bbb","updated":"2026-01-05 15:34:39.000000000","message":"recheck centos10 uefi crash on boot","commit_id":"0630805510fdeef972cc9a753c28cd955536b17a"}],"playbooks/roles/bifrost-registry-install/meta/main.yml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"03637ce42f38f42385b1de71c68334fccad68304","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  platforms:"},{"line_number":9,"context_line":"  - name: Debian"},{"line_number":10,"context_line":"    versions:"},{"line_number":11,"context_line":"    - bullseye"},{"line_number":12,"context_line":"  - name: EL"},{"line_number":13,"context_line":"    versions:"},{"line_number":14,"context_line":"    - \"10\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"512c006d_ae6d9bfb","line":11,"updated":"2025-12-19 14:46:32.000000000","message":"we don\u0027t support bullseye anymore","commit_id":"28c262f241b4fe725c4ba448b5c19abd9e49bc5f"}],"playbooks/roles/bifrost-registry-install/tasks/bootstrap.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"70ec32261221966028143aad9048739001b9a762","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    group: \"{{ registry_group }}\""},{"line_number":76,"context_line":"    mode: \"0640\""},{"line_number":77,"context_line":"    remote_src: yes"},{"line_number":78,"context_line":"  when: not noauth_mode | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: \"Copy TLS certificate for registry (if TLS is enabled)\""},{"line_number":81,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ab530291_553eb19a","line":78,"updated":"2025-11-25 15:20:21.000000000","message":"so, this was constrained in base install to not occur when in keystone mode which is why the current revision is failing.","commit_id":"3e179f9a2d55a44ff1bc5ff4b1275a9942d2735d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"511130940fea945a8b9bc0b8edacc6ec078b4012","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    group: \"{{ registry_group }}\""},{"line_number":76,"context_line":"    mode: \"0640\""},{"line_number":77,"context_line":"    remote_src: yes"},{"line_number":78,"context_line":"  when: not noauth_mode | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: \"Copy TLS certificate for registry (if TLS is enabled)\""},{"line_number":81,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"78182300_ec879a11","line":78,"in_reply_to":"ab530291_553eb19a","updated":"2025-11-26 14:12:15.000000000","message":"Done","commit_id":"3e179f9a2d55a44ff1bc5ff4b1275a9942d2735d"}],"playbooks/roles/bifrost-registry-install/tasks/setup_firewalld.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9ea6bdbf74162901b4bebd0b385b4ee6855d8091","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    permanent: yes"},{"line_number":8,"context_line":"    state: enabled"},{"line_number":9,"context_line":"    immediate: yes"},{"line_number":10,"context_line":"  when: not testing | bool"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a20ed1e_03b19600","line":10,"updated":"2025-11-25 17:45:49.000000000","message":"I wonder if this is correct (I don\u0027t remember)","commit_id":"973932ef54efdf435a03c9aa41aec068750ed7da"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e6488b41b953bda85e731bafb04beae60e323f62","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    permanent: yes"},{"line_number":8,"context_line":"    state: enabled"},{"line_number":9,"context_line":"    immediate: yes"},{"line_number":10,"context_line":"  when: not testing | bool"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cf438377_a150e5a1","line":10,"in_reply_to":"37d4b9af_3a113e35","updated":"2025-12-04 00:28:09.000000000","message":"its not, we need to open it up. Otherwise the agent can\u0027t connect to it because in bifrost, the default mode is for the agent to download directly.","commit_id":"973932ef54efdf435a03c9aa41aec068750ed7da"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"511130940fea945a8b9bc0b8edacc6ec078b4012","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    permanent: yes"},{"line_number":8,"context_line":"    state: enabled"},{"line_number":9,"context_line":"    immediate: yes"},{"line_number":10,"context_line":"  when: not testing | bool"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"37d4b9af_3a113e35","line":10,"in_reply_to":"5a20ed1e_03b19600","updated":"2025-11-26 14:12:15.000000000","message":"I *suspect* it would need to be enabled by default and not only when not testing, then again that *should sort of just work.","commit_id":"973932ef54efdf435a03c9aa41aec068750ed7da"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6afffd23d5b62862fc323c8ffc749c3f4e163a2b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    permanent: yes"},{"line_number":8,"context_line":"    state: enabled"},{"line_number":9,"context_line":"    immediate: yes"},{"line_number":10,"context_line":"  when: not testing | bool"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"359100f7_b64b8ffc","line":10,"in_reply_to":"cf438377_a150e5a1","updated":"2025-12-16 16:14:37.000000000","message":"Done","commit_id":"973932ef54efdf435a03c9aa41aec068750ed7da"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ce0c1d39471510280d16e616b784b7ff4c682b0d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    port: \"{{ registry_port }}/tcp\""},{"line_number":7,"context_line":"    permanent: yes"},{"line_number":8,"context_line":"    state: enabled"},{"line_number":9,"context_line":"    immediate: yes"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"32bb0794_9dddc659","line":9,"updated":"2025-12-04 02:17:21.000000000","message":"TASK [bifrost-registry-install : Add registry port to bifrost firewalld zone] ***\ntask path: /home/zuul/src/opendev.org/openstack/bifrost/playbooks/roles/bifrost-registry-install/tasks/setup_firewalld.yml:2\nredirecting (type: modules) ansible.builtin.firewalld to ansible.posix.firewalld\n\u003c127.0.0.1\u003e ESTABLISH LOCAL CONNECTION FOR USER: zuul\n\u003c127.0.0.1\u003e EXEC /bin/sh -c \u0027echo ~zuul \u0026\u0026 sleep 0\u0027\n\u003c127.0.0.1\u003e EXEC /bin/sh -c \u0027( umask 77 \u0026\u0026 mkdir -p \"` echo /home/zuul/.ansible/tmp `\"\u0026\u0026 mkdir \"` echo /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698 `\" \u0026\u0026 echo ansible-tmp-1764809782.8208241-31060-245900207195698\u003d\"` echo /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698 `\" ) \u0026\u0026 sleep 0\u0027\nredirecting (type: modules) ansible.builtin.firewalld to ansible.posix.firewalld\nUsing module file /opt/stack/bifrost/lib64/python3.12/site-packages/ansible_collections/ansible/posix/plugins/modules/firewalld.py\n\u003c127.0.0.1\u003e PUT /home/zuul/.ansible/tmp/ansible-local-24030afb6gapd/tmpjt5_1c7b TO /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698/AnsiballZ_firewalld.py\n\u003c127.0.0.1\u003e EXEC /bin/sh -c \u0027chmod u+rwx /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698/ /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698/AnsiballZ_firewalld.py \u0026\u0026 sleep 0\u0027\n\u003c127.0.0.1\u003e EXEC /bin/sh -c \u0027sudo -H -S -n  -u root /bin/sh -c \u0027\"\u0027\"\u0027echo BECOME-SUCCESS-ujrvftnkglnhkidnpuevfropbyiimxhg ; http_proxy\u003d\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 https_proxy\u003d\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 no_proxy\u003d\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027\"\u0027 /opt/stack/bifrost/bin/python3 /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698/AnsiballZ_firewalld.py\u0027\"\u0027\"\u0027 \u0026\u0026 sleep 0\u0027\n\u003c127.0.0.1\u003e EXEC /bin/sh -c \u0027rm -f -r /home/zuul/.ansible/tmp/ansible-tmp-1764809782.8208241-31060-245900207195698/ \u003e /dev/null 2\u003e\u00261 \u0026\u0026 sleep 0\u0027\nThe full traceback is:\n  File \"/tmp/ansible_firewalld_payload_qrei5hht/ansible_firewalld_payload.zip/ansible_collections/ansible/posix/plugins/module_utils/firewalld.py\", line 113, in action_handler\n    return action_func(*action_func_args)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/tmp/ansible_firewalld_payload_qrei5hht/ansible_firewalld_payload.zip/ansible_collections/ansible/posix/plugins/modules/firewalld.py\", line 522, in get_enabled_permanent\n    dummy, fw_settings \u003d self.get_fw_zone_settings()\n                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/tmp/ansible_firewalld_payload_qrei5hht/ansible_firewalld_payload.zip/ansible_collections/ansible/posix/plugins/module_utils/firewalld.py\", line 135, in get_fw_zone_settings\n    fw_zone \u003d self.fw.config().getZoneByName(self.zone)\n              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/usr/lib/python3.12/site-packages/firewall/client.py\", line 46, in _impl\n    return func(*args, **kwargs)\n           ^^^^^^^^^^^^^^^^^^^^^\n  File \"/usr/lib/python3.12/site-packages/firewall/client.py\", line 2843, in getZoneByName\n    path \u003d dbus_to_python(self.fw_config.getZoneByName(name))\n                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/usr/lib64/python3.12/site-packages/dbus/proxies.py\", line 72, in __call__\n    return self._proxy_method(*args, **keywords)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/usr/lib64/python3.12/site-packages/dbus/proxies.py\", line 141, in __call__\n    return self._connection.call_blocking(self._named_service,\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/usr/lib64/python3.12/site-packages/dbus/connection.py\", line 634, in call_blocking\n    reply_message \u003d self.send_message_with_reply_and_block(\n                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nfatal: [127.0.0.1]: FAILED! \u003d\u003e {\n    \"changed\": false,\n    \"invocation\": {\n        \"module_args\": {\n            \"forward\": null,\n            \"icmp_block\": null,\n            \"icmp_block_inversion\": null,\n            \"immediate\": true,\n            \"interface\": null,\n            \"masquerade\": null,\n            \"offline\": false,\n            \"permanent\": true,\n            \"port\": \"5500/tcp\",\n            \"port_forward\": null,\n            \"protocol\": null,\n            \"rich_rule\": null,\n            \"service\": null,\n            \"source\": null,\n            \"state\": \"enabled\",\n            \"target\": null,\n            \"timeout\": 0,\n            \"zone\": \"bifrost\"\n        }\n    },\n    \"msg\": \"ERROR: Exception caught: org.fedoraproject.FirewallD1.Exception: INVALID_ZONE: bifrost\"\n}","commit_id":"ecf014a44ee672ae6fdd3c20b0969a7d389d8d14"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6afffd23d5b62862fc323c8ffc749c3f4e163a2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    port: \"{{ registry_port }}/tcp\""},{"line_number":7,"context_line":"    permanent: yes"},{"line_number":8,"context_line":"    state: enabled"},{"line_number":9,"context_line":"    immediate: yes"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7c94dc52_d0d97a25","line":9,"in_reply_to":"32bb0794_9dddc659","updated":"2025-12-16 16:14:37.000000000","message":"Done","commit_id":"ecf014a44ee672ae6fdd3c20b0969a7d389d8d14"}],"playbooks/roles/bifrost-registry-install/vars/debian.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"af69e361a0604a4b9ebc7f7e0716b42dabe5e755","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"registry_required_packages:"},{"line_number":3,"context_line":"  - podman"},{"line_number":4,"context_line":"  - uidmap"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9375aa5e_f0222bb0","line":4,"updated":"2025-11-25 14:24:58.000000000","message":"looks like slirp4netns is needed","commit_id":"69758fbeb46ac5a5199c9f205e5c62f0029e9072"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"70ec32261221966028143aad9048739001b9a762","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"registry_required_packages:"},{"line_number":3,"context_line":"  - podman"},{"line_number":4,"context_line":"  - uidmap"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a722322_1443f55d","line":4,"in_reply_to":"9375aa5e_f0222bb0","updated":"2025-11-25 15:20:21.000000000","message":"Done","commit_id":"69758fbeb46ac5a5199c9f205e5c62f0029e9072"}]}
