)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"14f9a4cc6225791dbe0c844a8b4bc403ab9f3a2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06e32672_40fd09fc","updated":"2025-11-26 19:26:20.000000000","message":"The failure on this one just appears to be run of the mill boot/network failure ons tart. I\u0027m tempted to just revise the wip label and give it a spin separately.","commit_id":"23185cf2e1a4e2ab74bae650bf886d1fb54c29aa"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"1f7f053c003bd772f1e301ceefa804da54cada96","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ade6bf45_842108ea","updated":"2026-03-03 04:23:47.000000000","message":"+ sudo cp /usr/share/libvirt/cpu_map.xml /home/zuul/logs/libvirt_cpu_map.xml\ncp: cannot stat \u0027/usr/share/libvirt/cpu_map.xml\u0027: No such file or directory","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"832dc14c8dcb617851cb99070a5f09f87bc616c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"17a622f7_05f5308e","updated":"2026-03-03 14:02:22.000000000","message":"recheck cannot recheck and vote at the same time","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"790e849a37ad15a5adee399cdf98945b0f3832ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"308abc5d_b3fbed67","updated":"2026-03-03 16:46:27.000000000","message":"recheck infra hiccup","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"31de84de90254cbdac80f04530d8caf9cb2f57c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"07aa04eb_79b058e4","updated":"2026-03-03 18:16:17.000000000","message":"recheck opendev.org outage","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9256751e0680280767317265de57c411cdbd4e65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c95a3e68_ce7aeae4","updated":"2026-03-02 17:09:17.000000000","message":"recheck shoulde b fixed","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f2316f4fff0991e5126935058f5aaec89949dc17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"900bef43_d0529691","updated":"2026-03-03 13:50:05.000000000","message":"recheck transient error unrelated","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"}],"playbooks/roles/bifrost-create-dib-image/README.md":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71a1758f39dce487483b178223ceec9d03507109","unresolved":true,"context_lines":[{"line_number":110,"context_line":"| Variable                     | Default (Fallback)             | Description                                      |"},{"line_number":111,"context_line":"|------------------------------|--------------------------------|--------------------------------------------------|"},{"line_number":112,"context_line":"| enable_oci_registry_upload   | false                          | Enable upload to OCI registry                    |"},{"line_number":113,"context_line":"| oci_registry_port            | {{ registry_port }} (5500)     | Registry port                                    |"},{"line_number":114,"context_line":"| oci_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"6686e4d0_6e4041f7","line":113,"updated":"2026-02-02 14:11:49.000000000","message":"These names don\u0027t match what is in the defaults.","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":110,"context_line":"| Variable                     | Default (Fallback)             | Description                                      |"},{"line_number":111,"context_line":"|------------------------------|--------------------------------|--------------------------------------------------|"},{"line_number":112,"context_line":"| enable_oci_registry_upload   | false                          | Enable upload to OCI registry                    |"},{"line_number":113,"context_line":"| oci_registry_port            | {{ registry_port }} (5500)     | Registry port                                    |"},{"line_number":114,"context_line":"| oci_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"96f3ccfe_5488876f","line":113,"updated":"2026-02-24 15:59:07.000000000","message":"upload_registry_port","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":111,"context_line":"|------------------------------|--------------------------------|--------------------------------------------------|"},{"line_number":112,"context_line":"| enable_oci_registry_upload   | false                          | Enable upload to OCI registry                    |"},{"line_number":113,"context_line":"| oci_registry_port            | {{ registry_port }} (5500)     | Registry port                                    |"},{"line_number":114,"context_line":"| oci_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"},{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"0521c0a6_1a37419a","line":114,"updated":"2026-02-24 15:59:07.000000000","message":"upload_registry_enable_tls","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":112,"context_line":"| enable_oci_registry_upload   | false                          | Enable upload to OCI registry                    |"},{"line_number":113,"context_line":"| oci_registry_port            | {{ registry_port }} (5500)     | Registry port                                    |"},{"line_number":114,"context_line":"| oci_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"},{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"},{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"baa461ae_bed3c210","line":115,"updated":"2026-02-24 15:59:07.000000000","message":"upload_registry_insecure","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":113,"context_line":"| oci_registry_port            | {{ registry_port }} (5500)     | Registry port                                    |"},{"line_number":114,"context_line":"| oci_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"},{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"},{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"},{"line_number":119,"context_line":"| oci_registry_username        | {{ default_username }}         | Authentication username (bifrost_user)           |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"9958a57b_3e4b291e","line":116,"updated":"2026-02-24 15:59:07.000000000","message":"not used","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":114,"context_line":"| oci_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"},{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"},{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"},{"line_number":119,"context_line":"| oci_registry_username        | {{ default_username }}         | Authentication username (bifrost_user)           |"},{"line_number":120,"context_line":"| oci_registry_password        | {{ default_password }}         | Authentication password (auto-generated)         |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"0e7921a1_e624e515","line":117,"range":{"start_line":117,"start_character":2,"end_line":117,"end_character":18},"updated":"2026-02-24 15:59:07.000000000","message":"registry_url","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":115,"context_line":"| oci_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"},{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"},{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"},{"line_number":119,"context_line":"| oci_registry_username        | {{ default_username }}         | Authentication username (bifrost_user)           |"},{"line_number":120,"context_line":"| oci_registry_password        | {{ default_password }}         | Authentication password (auto-generated)         |"},{"line_number":121,"context_line":"| oci_registry_tag_suffix      | {{ ansible_date_time.epoch }}  | Tag suffix (timestamp by default)                |"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"23b08e6e_270aeefe","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":25},"updated":"2026-02-24 15:59:07.000000000","message":"registry_repository","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":116,"context_line":"| oci_registry_protocol        | {{ registry_protocol }}        | Protocol (http/https) based on TLS setting       |"},{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"},{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"},{"line_number":119,"context_line":"| oci_registry_username        | {{ default_username }}         | Authentication username (bifrost_user)           |"},{"line_number":120,"context_line":"| oci_registry_password        | {{ default_password }}         | Authentication password (auto-generated)         |"},{"line_number":121,"context_line":"| oci_registry_tag_suffix      | {{ ansible_date_time.epoch }}  | Tag suffix (timestamp by default)                |"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":18,"id":"360f1928_3251eea2","line":119,"updated":"2026-02-24 15:59:07.000000000","message":"registry_username","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":117,"context_line":"| oci_registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"},{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"},{"line_number":119,"context_line":"| oci_registry_username        | {{ default_username }}         | Authentication username (bifrost_user)           |"},{"line_number":120,"context_line":"| oci_registry_password        | {{ default_password }}         | Authentication password (auto-generated)         |"},{"line_number":121,"context_line":"| oci_registry_tag_suffix      | {{ ansible_date_time.epoch }}  | Tag suffix (timestamp by default)                |"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"### Upload Behavior"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"6a10de68_5afe30bd","line":120,"updated":"2026-02-24 15:59:07.000000000","message":"registry_password","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":118,"context_line":"| oci_registry_repository      | bifrost/images                 | Repository path in registry                      |"},{"line_number":119,"context_line":"| oci_registry_username        | {{ default_username }}         | Authentication username (bifrost_user)           |"},{"line_number":120,"context_line":"| oci_registry_password        | {{ default_password }}         | Authentication password (auto-generated)         |"},{"line_number":121,"context_line":"| oci_registry_tag_suffix      | {{ ansible_date_time.epoch }}  | Tag suffix (timestamp by default)                |"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"### Upload Behavior"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":18,"id":"c2eac238_d63c684c","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":25},"updated":"2026-02-24 15:59:07.000000000","message":"registry_tag_suffix","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":148,"context_line":"      roles:"},{"line_number":149,"context_line":"        - role: bifrost-create-dib-image"},{"line_number":150,"context_line":"          enable_oci_registry_upload: true"},{"line_number":151,"context_line":"          oci_registry_username: \"admin\""},{"line_number":152,"context_line":"          oci_registry_password: \"secret\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Using cloud-init"}],"source_content_type":"text/x-gfm","patch_set":18,"id":"21b661b0_0b305597","line":151,"updated":"2026-02-24 15:59:07.000000000","message":"drop oci from these.","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b717f654d6cb1e103a1dc8d5fa02a56c8f498267","unresolved":true,"context_lines":[{"line_number":110,"context_line":"| Variable                     | Default (Fallback)             | Description                                      |"},{"line_number":111,"context_line":"|------------------------------|--------------------------------|--------------------------------------------------|"},{"line_number":112,"context_line":"| enable_oci_registry_upload   | false                          | Enable upload to OCI registry                    |"},{"line_number":113,"context_line":"| upload_registry_port            | {{ registry_port }} (5500)     | Registry port                                    |"},{"line_number":114,"context_line":"| upload_registry_use_tls         | {{ registry_enable_tls }}      | Use HTTPS for registry connection                |"},{"line_number":115,"context_line":"| upload_registry_insecure        | true                           | Skip TLS certificate verification                |"},{"line_number":116,"context_line":"| registry_url             | {{ internal_ip }}:{{ port }}   | Full registry URL                                |"}],"source_content_type":"text/x-gfm","patch_set":19,"id":"a8f46910_8a5b825d","line":113,"updated":"2026-03-03 19:00:37.000000000","message":"nit: not aligned","commit_id":"024a7bd8c337c67ab63f1fc4d1b009e3e46e4a30"}],"playbooks/roles/bifrost-create-dib-image/defaults/main.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d8ae5fb02e79b72cf246f8194b86bbd1b4c58d2c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"oci_registry_port: \"{{ registry_port | default(5500) }}\""},{"line_number":35,"context_line":"oci_registry_use_tls: \"{{ registry_enable_tls | default(false) }}\""},{"line_number":36,"context_line":"oci_registry_insecure: true"},{"line_number":37,"context_line":"oci_registry_protocol: \"{{ registry_protocol | default(\u0027http\u0027) }}\""},{"line_number":38,"context_line":"oci_registry_url: \"{{ internal_ip | default(\u0027127.0.0.1\u0027) }}:{{ oci_registry_port }}\""},{"line_number":39,"context_line":"oci_registry_repository: \"bifrost/images\""},{"line_number":40,"context_line":"oci_registry_username: \"{{ default_username | default(\u0027\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f8e0c27_ece835b2","line":37,"updated":"2025-12-02 15:01:02.000000000","message":"No wonder we\u0027re having problems later on....  It works with http but expects https.","commit_id":"23185cf2e1a4e2ab74bae650bf886d1fb54c29aa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"35d2bf04d8d0a269226093f6f6cf5a152a472814","unresolved":false,"context_lines":[{"line_number":34,"context_line":"oci_registry_port: \"{{ registry_port | default(5500) }}\""},{"line_number":35,"context_line":"oci_registry_use_tls: \"{{ registry_enable_tls | default(false) }}\""},{"line_number":36,"context_line":"oci_registry_insecure: true"},{"line_number":37,"context_line":"oci_registry_protocol: \"{{ registry_protocol | default(\u0027http\u0027) }}\""},{"line_number":38,"context_line":"oci_registry_url: \"{{ internal_ip | default(\u0027127.0.0.1\u0027) }}:{{ oci_registry_port }}\""},{"line_number":39,"context_line":"oci_registry_repository: \"bifrost/images\""},{"line_number":40,"context_line":"oci_registry_username: \"{{ default_username | default(\u0027\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1375c86a_7932a338","line":37,"in_reply_to":"5f8e0c27_ece835b2","updated":"2025-12-02 19:19:40.000000000","message":"Confirmed the default settings are http as well for the prior code.","commit_id":"23185cf2e1a4e2ab74bae650bf886d1fb54c29aa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e180e28a69757b64c0b3dce55f559ebf0f15ada5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# OCI Registry upload configuration"},{"line_number":32,"context_line":"# These variables fallback to bifrost-registry-install role defaults when available"},{"line_number":33,"context_line":"enable_oci_registry_upload: false"},{"line_number":34,"context_line":"oci_registry_port: \"{{ registry_port | default(5500) }}\""},{"line_number":35,"context_line":"oci_registry_use_tls: \"{{ registry_enable_tls | default(false) }}\""},{"line_number":36,"context_line":"oci_registry_insecure: true"},{"line_number":37,"context_line":"oci_registry_protocol: \"{{ registry_protocol | default(\u0027http\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e0264f0f_669b7a67","line":34,"updated":"2025-12-03 12:40:19.000000000","message":"Could you synchronize option names with https://review.opendev.org/c/openstack/bifrost/+/961388/15/playbooks/roles/bifrost-registry-install/defaults/main.yml (I\u0027m fine changing the latter as well)","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"12d31da3fcc9b35569f862810409e668fbe35d9a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# OCI Registry upload configuration"},{"line_number":32,"context_line":"# These variables fallback to bifrost-registry-install role defaults when available"},{"line_number":33,"context_line":"enable_oci_registry_upload: false"},{"line_number":34,"context_line":"oci_registry_port: \"{{ registry_port | default(5500) }}\""},{"line_number":35,"context_line":"oci_registry_use_tls: \"{{ registry_enable_tls | default(false) }}\""},{"line_number":36,"context_line":"oci_registry_insecure: true"},{"line_number":37,"context_line":"oci_registry_protocol: \"{{ registry_protocol | default(\u0027http\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ce5c342d_fbe0e99f","line":34,"in_reply_to":"e0264f0f_669b7a67","updated":"2025-12-03 18:40:12.000000000","message":"Done","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2a30fd1cedb6ef5988ac6d44eed07e8c51023fba","unresolved":true,"context_lines":[{"line_number":35,"context_line":"oci_registry_use_tls: \"{{ registry_enable_tls | default(false) }}\""},{"line_number":36,"context_line":"oci_registry_insecure: true"},{"line_number":37,"context_line":"oci_registry_protocol: \"{{ registry_protocol | default(\u0027http\u0027) }}\""},{"line_number":38,"context_line":"oci_registry_url: \"{{ internal_ip | default(\u0027127.0.0.1\u0027) }}:{{ oci_registry_port }}\""},{"line_number":39,"context_line":"oci_registry_repository: \"bifrost/images\""},{"line_number":40,"context_line":"oci_registry_username: \"{{ default_username | default(\u0027\u0027) }}\""},{"line_number":41,"context_line":"oci_registry_password: \"{{ default_password | default(\u0027\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7bac7f79_b7b2f095","line":38,"updated":"2025-12-03 15:25:04.000000000","message":"This may require /v2/ added to it.  That is, if the base support is *correct*","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"12d31da3fcc9b35569f862810409e668fbe35d9a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"oci_registry_use_tls: \"{{ registry_enable_tls | default(false) }}\""},{"line_number":36,"context_line":"oci_registry_insecure: true"},{"line_number":37,"context_line":"oci_registry_protocol: \"{{ registry_protocol | default(\u0027http\u0027) }}\""},{"line_number":38,"context_line":"oci_registry_url: \"{{ internal_ip | default(\u0027127.0.0.1\u0027) }}:{{ oci_registry_port }}\""},{"line_number":39,"context_line":"oci_registry_repository: \"bifrost/images\""},{"line_number":40,"context_line":"oci_registry_username: \"{{ default_username | default(\u0027\u0027) }}\""},{"line_number":41,"context_line":"oci_registry_password: \"{{ default_password | default(\u0027\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"018a7280_d79824e0","line":38,"in_reply_to":"7bac7f79_b7b2f095","updated":"2025-12-03 18:40:12.000000000","message":"registry clients seem to figure this out actually.","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"}],"playbooks/roles/bifrost-create-dib-image/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71a1758f39dce487483b178223ceec9d03507109","unresolved":true,"context_lines":[{"line_number":215,"context_line":"  when: (ansible_os_family \u003d\u003d \u0027RedHat\u0027 or ansible_os_family \u003d\u003d \u0027Suse\u0027) and"},{"line_number":216,"context_line":"         ansible_selinux.status \u003d\u003d \u0027enabled\u0027"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"- name: \"Upload image to OCI registry\""},{"line_number":219,"context_line":"  include_tasks: upload_to_registry.yml"},{"line_number":220,"context_line":"  when:"},{"line_number":221,"context_line":"    - enable_oci_registry_upload | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"554c8c35_ede40221","line":218,"updated":"2026-02-02 14:11:49.000000000","message":"nit: in the next patch, you move this step higher","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":true,"context_lines":[{"line_number":215,"context_line":"  when: (ansible_os_family \u003d\u003d \u0027RedHat\u0027 or ansible_os_family \u003d\u003d \u0027Suse\u0027) and"},{"line_number":216,"context_line":"         ansible_selinux.status \u003d\u003d \u0027enabled\u0027"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"- name: \"Upload image to OCI registry\""},{"line_number":219,"context_line":"  include_tasks: upload_to_registry.yml"},{"line_number":220,"context_line":"  when:"},{"line_number":221,"context_line":"    - enable_oci_registry_upload | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"567bd2ad_19013c74","line":218,"in_reply_to":"554c8c35_ede40221","updated":"2026-02-24 15:59:07.000000000","message":"I think yo meant the line, moving it a step higher seems wrong because wer\u0027re then putting it in the middle of access control/permissions stuffs.","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"}],"playbooks/roles/bifrost-create-dib-image/tasks/upload_to_registry.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31b9ea1d34bbf9899d58437796b9eee33ef82fd1","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    echo \"Uploading ${IMAGE_FILE} to {{ oci_registry_full_url }}/${IMAGE_TAG}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    {% if oci_registry_username and oci_registry_password %}"},{"line_number":48,"context_line":"    echo \"{{ oci_registry_password }}\" | {{ bifrost_venv_dir }}/bin/oras login \\"},{"line_number":49,"context_line":"      {{ oci_registry_url }} \\"},{"line_number":50,"context_line":"      --username \"{{ oci_registry_username }}\" \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"af537cf5_766ba006","line":47,"updated":"2025-12-03 12:41:47.000000000","message":"If we really need to use bash, let\u0027s at least split the login and upload steps into separate tasks?","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"12d31da3fcc9b35569f862810409e668fbe35d9a","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    echo \"Uploading ${IMAGE_FILE} to {{ oci_registry_full_url }}/${IMAGE_TAG}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    {% if oci_registry_username and oci_registry_password %}"},{"line_number":48,"context_line":"    echo \"{{ oci_registry_password }}\" | {{ bifrost_venv_dir }}/bin/oras login \\"},{"line_number":49,"context_line":"      {{ oci_registry_url }} \\"},{"line_number":50,"context_line":"      --username \"{{ oci_registry_username }}\" \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ec434970_fb6a0c31","line":47,"in_reply_to":"9b712409_6140e833","updated":"2025-12-03 18:40:12.000000000","message":"Done in the next revision.","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"96e551bcbe7cf6f485ecd7962790a2292820886f","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    echo \"Uploading ${IMAGE_FILE} to {{ oci_registry_full_url }}/${IMAGE_TAG}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    {% if oci_registry_username and oci_registry_password %}"},{"line_number":48,"context_line":"    echo \"{{ oci_registry_password }}\" | {{ bifrost_venv_dir }}/bin/oras login \\"},{"line_number":49,"context_line":"      {{ oci_registry_url }} \\"},{"line_number":50,"context_line":"      --username \"{{ oci_registry_username }}\" \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9b712409_6140e833","line":47,"in_reply_to":"af537cf5_766ba006","updated":"2025-12-03 14:34:46.000000000","message":"I\u0027m not sure the login is actually doing anything in that registries will always accept logins. I can\u0027t verify that ORAS is actually storing any credentials either for storage between tasks. But concur with your review feedback.","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b003440eac53d8fdd436966f9e22565a57828c7e","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    {% endif %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    {{ bifrost_venv_dir }}/bin/oras push \\"},{"line_number":57,"context_line":"      {{ oci_registry_full_url }}/${IMAGE_TAG} \\"},{"line_number":58,"context_line":"      \"${IMAGE_FILE}:application/octet-stream\" \\"},{"line_number":59,"context_line":"      --annotation \"org.opencontainers.image.title\u003d${IMAGE_BASENAME}\" \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6b8d5268_bb3cc22e","line":56,"updated":"2025-12-03 15:36:22.000000000","message":"if the logs are to be believed, oras is just not pushing anything up to the registry nor is it connecting. Likely because the registry is responding with http.","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"12d31da3fcc9b35569f862810409e668fbe35d9a","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    {% endif %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    {{ bifrost_venv_dir }}/bin/oras push \\"},{"line_number":57,"context_line":"      {{ oci_registry_full_url }}/${IMAGE_TAG} \\"},{"line_number":58,"context_line":"      \"${IMAGE_FILE}:application/octet-stream\" \\"},{"line_number":59,"context_line":"      --annotation \"org.opencontainers.image.title\u003d${IMAGE_BASENAME}\" \\"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0d7f8a15_119e9766","line":56,"in_reply_to":"6b8d5268_bb3cc22e","updated":"2025-12-03 18:40:12.000000000","message":"Done","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"12d31da3fcc9b35569f862810409e668fbe35d9a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      {% if oci_registry_insecure | bool %}--insecure{% endif %} \\"},{"line_number":64,"context_line":"      --verbose"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    echo \"OCI_ARTIFACT_URL\u003d{{ oci_registry_url }}/${IMAGE_TAG}\""},{"line_number":67,"context_line":"  args:"},{"line_number":68,"context_line":"    executable: /bin/bash"},{"line_number":69,"context_line":"  environment: \"{{ bifrost_venv_env }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9398272c_847dbf79","line":66,"updated":"2025-12-03 18:40:12.000000000","message":"oci:// should be here, a later rev touches this aspect and we should move it up.","commit_id":"71d5b20c8c97b65855ffd3ac2664102610e99f29"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7cc7aea9c4ac6d67b8996bcb3f752f2a0f3ee048","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    echo \"{{ registry_password }}\" | {{ bifrost_venv_dir }}/bin/oras push \\"},{"line_number":56,"context_line":"      {{ registry_url }}/${IMAGE_TAG} \\"},{"line_number":57,"context_line":"      \"${IMAGE_FILE}:application/octet-stream\" \\"},{"line_number":58,"context_line":"      --username \"{{ registry_username }}\" \\"},{"line_number":59,"context_line":"      --password-stdin \\"},{"line_number":60,"context_line":"      --annotation \"org.opencontainers.image.title\u003d${IMAGE_BASENAME}\" \\"},{"line_number":61,"context_line":"      --annotation \"org.opencontainers.image.created\u003d{{ ansible_date_time.iso8601 }}\" \\"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"05a1d79b_6d0c3587","line":58,"updated":"2025-12-03 20:28:16.000000000","message":"we may want to annotate with the disk_type value (-a disktype\u003dqcow2) in our examples, but that also shouldn\u0027t be needed\n\nhttps://docs.openstack.org/ironic/latest/admin/oci-container-registry.html","commit_id":"2ae29c212cf882cd7c35681625640176559b348b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"71a1758f39dce487483b178223ceec9d03507109","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Upload image files to OCI registry\""},{"line_number":48,"context_line":"  shell: |"},{"line_number":49,"context_line":"    set -o pipefail"},{"line_number":50,"context_line":"    IMAGE_FILE\u003d\"{{ item }}\""},{"line_number":51,"context_line":"    IMAGE_BASENAME\u003d$(basename \"${IMAGE_FILE}\")"},{"line_number":52,"context_line":"    IMAGE_TAG\u003d\"{{ registry_repository }}:${IMAGE_BASENAME}-{{ registry_tag_suffix }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f9f45f2d_80d79099","line":49,"updated":"2026-02-02 14:11:49.000000000","message":"I think you want to add `-e` here, otherwise any failure in oras will be hidden by echo that follows it","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e14cba200486648d9bd8c4f90b642b0d72875ac9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Upload image files to OCI registry\""},{"line_number":48,"context_line":"  shell: |"},{"line_number":49,"context_line":"    set -o pipefail"},{"line_number":50,"context_line":"    IMAGE_FILE\u003d\"{{ item }}\""},{"line_number":51,"context_line":"    IMAGE_BASENAME\u003d$(basename \"${IMAGE_FILE}\")"},{"line_number":52,"context_line":"    IMAGE_TAG\u003d\"{{ registry_repository }}:${IMAGE_BASENAME}-{{ registry_tag_suffix }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"8600235d_3e6e9dd9","line":49,"in_reply_to":"f9f45f2d_80d79099","updated":"2026-02-24 15:59:07.000000000","message":"Done","commit_id":"8d9c77ff5e9163f635d3289ea5d3c054a029946b"}],"playbooks/roles/bifrost-ironic-install/templates/ironic.conf.j2":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"74c7aba3cae12a9a347dd192132782a1bc7d6dfe","unresolved":true,"context_lines":[{"line_number":223,"context_line":"{% endif %}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"[oci]"},{"line_number":226,"context_line":"authentication_config \u003d {{ oci_auth_config_dir }}/config.json"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"e9a7dd51_c9bdb5a3","line":226,"updated":"2025-12-03 15:24:24.000000000","message":"This can be dropped, it doesn\u0027t work for basic auth which is how the registry is installed.","commit_id":"50bccf5043a9cea6824cfc709a9ef7c7fd21b84d"}]}
