)]}'
{"blazar_dashboard/content/hosts/tables.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"59773960289ae7bae32597ab21a058552fd9f34a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            count"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def delete(self, request, host_id):"},{"line_number":44,"context_line":"        api.client.host_delete(request, host_id)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class HostsTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_31f0ee90","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":48},"updated":"2017-10-19 07:21:17.000000000","message":"I\u0027m not sure this methos is good place to comment, but if it fails to delete a host, it\u0027s better to show host name instead of host id.  The Hosts panel only show host names now.","commit_id":"c586e62b5cd402046c639dbb595b1661c22f6289"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"be2792eb99c421662b5f44d036eed09f7abb597d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            count"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def delete(self, request, host_id):"},{"line_number":44,"context_line":"        api.client.host_delete(request, host_id)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class HostsTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_9b879f62","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":48},"in_reply_to":"3f4b6375_31f0ee90","updated":"2017-10-20 08:45:49.000000000","message":"I agree with you but horizon does not provide a easy way for editing the\nerror message of table actions [1]. Of course it can be edited by \noverriding the handle() method but I think we should not take so much\neffort just for tweaking the message. Another approach is showing an\nnew message box that describes details of the error which include\nname of the host. In this approach, 2 error message boxes show up. \nWhat do you think?\n\n[1] https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L796","commit_id":"c586e62b5cd402046c639dbb595b1661c22f6289"}]}
