)]}'
{"blazarnova/scheduler/filters/blazar_filter.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"2416dd8989cd954b760994c3cb44c1b9bc1b46b2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return False"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            if requested_pools:"},{"line_number":140,"context_line":"                # Host is not in a Pool and Pool requested"},{"line_number":141,"context_line":"                LOG.debug(\"host_passes(): %s doesn\u0027t pass the blazar filter.\""},{"line_number":142,"context_line":"                          \"(not in requested pools)\", host_state.host)"},{"line_number":143,"context_line":"                return False"},{"line_number":144,"context_line":"            LOG.debug(\"host_passes(): %s passes the blazar filter.\","},{"line_number":145,"context_line":"                      host_state.host)"},{"line_number":146,"context_line":"            return True"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# For backward compatibility. This should be done in this way due to how Nova"},{"line_number":149,"context_line":"# imports the filters"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a71b18c_a5017a6c","line":146,"range":{"start_line":139,"start_character":0,"end_line":146,"end_character":23},"updated":"2016-12-05 12:41:52.000000000","message":"I think it\u0027s a coding style comment so don\u0027t feel offensive.\n\nIf we move the state to L94, we could remove long if-statement started from L95.","commit_id":"fcb5e3eb72853ac2ad39503205610f40674d90a1"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"d70111f88a9fe5ab8cd59364b755e87d16192637","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    cfg.CONF[\u0027blazar:physical:host\u0027].aggregate_freepool_name):"},{"line_number":93,"context_line":"                pools.append(agg)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not pools:"},{"line_number":96,"context_line":"            if requested_pools:"},{"line_number":97,"context_line":"                # Host is not in a Pool and Pool requested"},{"line_number":98,"context_line":"                LOG.debug(\"host_passes(): %s doesn\u0027t pass the blazar filter.\""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_c1ed67b8","line":95,"updated":"2016-12-06 03:21:01.000000000","message":"Sequence of conditon check was changed to remove long if-statement.","commit_id":"697ac635a4ad4da4f01322c4bcf356e5a01f0a87"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b8743ad98841d29a966dd8a93eedae0b3e3feaf3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Find which Pools the user wants to use (if any) from scheduler hints"},{"line_number":78,"context_line":"        requested_pools \u003d spec_obj.get_scheduler_hint(\u0027reservation\u0027)"},{"line_number":79,"context_line":"        if isinstance(requested_pools, six.text_type):"},{"line_number":80,"context_line":"            requested_pools \u003d [requested_pools]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_29c7a496","line":78,"updated":"2016-12-07 09:14:15.000000000","message":"please note that hints are not interoperable between clouds :\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-December/108591.html\n\nHere, that\u0027s fine for a short-term perspective because it doesn\u0027t change how we can get a reservation, but I\u0027d love to see a Blazar blueprint thinking how to not needing this scheduler filter and rather having something in the nova tree.","commit_id":"ebd5aa1493bd7700084ed3631214b872961572ac"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"2d860da0928adf1279d3da75f974895aebf8890a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Find which Pools the user wants to use (if any) from scheduler hints"},{"line_number":78,"context_line":"        requested_pools \u003d spec_obj.get_scheduler_hint(\u0027reservation\u0027)"},{"line_number":79,"context_line":"        if isinstance(requested_pools, six.text_type):"},{"line_number":80,"context_line":"            requested_pools \u003d [requested_pools]"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_3b941fe7","line":78,"in_reply_to":"3a71b18c_29c7a496","updated":"2016-12-08 01:01:35.000000000","message":"Thank you for your very helpful advice. I understand current implementation using customized scheduler filter should be avoided to improve interoperability, for a long-term perspective.\nI\u0027ve registered a blueprint thinking about it:\nhttps://blueprints.launchpad.net/blazar/+spec/stop-using-customized-filter","commit_id":"ebd5aa1493bd7700084ed3631214b872961572ac"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b8743ad98841d29a966dd8a93eedae0b3e3feaf3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    cfg.CONF[\u0027blazar:physical:host\u0027].aggregate_freepool_name):"},{"line_number":93,"context_line":"                pools.append(agg)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not pools:"},{"line_number":96,"context_line":"            if requested_pools:"},{"line_number":97,"context_line":"                # Host is not in a Pool and Pool requested"},{"line_number":98,"context_line":"                LOG.debug(\"host_passes(): %s doesn\u0027t pass the blazar filter.\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_89eb58db","line":95,"updated":"2016-12-07 09:14:15.000000000","message":"you\u0027re changing a lot of logic here in the same change, that makes it more difficult to review very quickly.\n\nI\u0027d have preferred to have only this change for using spec_obj, and maybe a separate change for changing the behaviour.","commit_id":"ebd5aa1493bd7700084ed3631214b872961572ac"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"2d860da0928adf1279d3da75f974895aebf8890a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    cfg.CONF[\u0027blazar:physical:host\u0027].aggregate_freepool_name):"},{"line_number":93,"context_line":"                pools.append(agg)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not pools:"},{"line_number":96,"context_line":"            if requested_pools:"},{"line_number":97,"context_line":"                # Host is not in a Pool and Pool requested"},{"line_number":98,"context_line":"                LOG.debug(\"host_passes(): %s doesn\u0027t pass the blazar filter.\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_9e452119","line":95,"in_reply_to":"3a71b18c_89eb58db","updated":"2016-12-08 01:01:35.000000000","message":"It looks like being changed so much because the sequence of condition checks in if-statement have been changed to improve readability.\nBut it has not been changed logically, e.g., Line 101-135 of former are much same as Line 106-146 of latter, and Line 137-142 of former are much same as Line 95-104 of latter except indent.\n\nSo, this patch contains only changes for using spec_obj.","commit_id":"ebd5aa1493bd7700084ed3631214b872961572ac"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7d665a309fe253dfd94c253db499b32b0ed051f6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    #  but later will possibly be blazar:tenant:{project_id}"},{"line_number":109,"context_line":"                    key \u003d spec_obj.project_id"},{"line_number":110,"context_line":"                    access \u003d pool.metadata.get(key)"},{"line_number":111,"context_line":"                    if access \u003d\u003d \u0027True\u0027:"},{"line_number":112,"context_line":"                        return True"},{"line_number":113,"context_line":"                    # NOTE(sbauza): We also need to check the blazar:owner key"},{"line_number":114,"context_line":"                    #  until we modify the reservation pool for including the"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a71b18c_1ac7c498","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":40},"updated":"2016-12-12 15:02:41.000000000","message":"This code is functionally different than the original.","commit_id":"b5d7de7eb2f3d53ed312f79e9cd2a9223a29c3e3"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"8e69532f41642079e6871403493a7ca7c6bc92db","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    #  but later will possibly be blazar:tenant:{project_id}"},{"line_number":109,"context_line":"                    key \u003d spec_obj.project_id"},{"line_number":110,"context_line":"                    access \u003d pool.metadata.get(key)"},{"line_number":111,"context_line":"                    if access \u003d\u003d \u0027True\u0027:"},{"line_number":112,"context_line":"                        return True"},{"line_number":113,"context_line":"                    # NOTE(sbauza): We also need to check the blazar:owner key"},{"line_number":114,"context_line":"                    #  until we modify the reservation pool for including the"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_3f409556","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":40},"in_reply_to":"3a71b18c_1ac7c498","updated":"2016-12-13 00:34:27.000000000","message":"Current version of aggregate object in nova has a dict of StringField named metadata[1], and it is used here.\nSo, it should be compared as not boolean but string.\nThat\u0027s why I have changed here and it passes the test based on the original.\n\n\n[1]https://github.com/openstack/nova/blob/master/nova/objects/aggregate.py#L246","commit_id":"b5d7de7eb2f3d53ed312f79e9cd2a9223a29c3e3"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"421f17bcdf07261e5f55cba92783d6611a97e553","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    #  but later will possibly be blazar:tenant:{project_id}"},{"line_number":109,"context_line":"                    key \u003d spec_obj.project_id"},{"line_number":110,"context_line":"                    access \u003d pool.metadata.get(key)"},{"line_number":111,"context_line":"                    if access:"},{"line_number":112,"context_line":"                        return True"},{"line_number":113,"context_line":"                    # NOTE(sbauza): We also need to check the blazar:owner key"},{"line_number":114,"context_line":"                    #  until we modify the reservation pool for including the"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a6eadb0_8fb2db04","line":111,"range":{"start_line":111,"start_character":20,"end_line":111,"end_character":30},"updated":"2016-12-15 06:52:32.000000000","message":"I found code for registering project ID to the metadata of aggregate[1] at add_project() method in blazar.However, I could not find any callpoint of the add_project() method in blazar codebase.\n\nTherefore, I think there is no situation in which this \"if access:\" check returns True, so this if-statement doesn\u0027t make sense.\n\nWe should discuss this if-statement to be removed or remained for new features. But this topic should not be included in this patch and I leave this if-statement as it is for now.\n\n[1] https://github.com/openstack/blazar/blob/15f20cb72107f2e98b928d794371f456d662f206/climate/plugins/oshosts/reservation_pool.py#L267","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":1894,"name":"Ryota MIBU","email":"r-mibu@cq.jp.nec.com","username":"r-mibu"},"change_message_id":"568872a19244b788a1c3cccddc618f5d6e9cdf3c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    #  but later will possibly be blazar:tenant:{project_id}"},{"line_number":109,"context_line":"                    key \u003d spec_obj.project_id"},{"line_number":110,"context_line":"                    access \u003d pool.metadata.get(key)"},{"line_number":111,"context_line":"                    if access:"},{"line_number":112,"context_line":"                        return True"},{"line_number":113,"context_line":"                    # NOTE(sbauza): We also need to check the blazar:owner key"},{"line_number":114,"context_line":"                    #  until we modify the reservation pool for including the"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a6eadb0_28948ee0","line":111,"range":{"start_line":111,"start_character":20,"end_line":111,"end_character":30},"in_reply_to":"1a6eadb0_8fb2db04","updated":"2016-12-20 15:52:53.000000000","message":"i suppose we can leave this line, as the similar code can be found in ReservationPool.create() .","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"}],"blazarnova/tests/scheduler/filters/test_blazar_filter.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"30b5784dc9f5ef07cc76138f0adfbcb4c7e62a87","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # A fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":42,"context_line":"        fake.FakeInstance(\u0027instance1\u0027, \u0027Running\u0027, \u0027123\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # And a base spec_pbj"},{"line_number":45,"context_line":"        self.spec_obj \u003d objects.RequestSpec("},{"line_number":46,"context_line":"            project_id\u003d\u0027fakepj\u0027,"},{"line_number":47,"context_line":"            scheduler_hints\u003d{}"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_b4cabc18","line":44,"range":{"start_line":44,"start_character":21,"end_line":44,"end_character":29},"updated":"2016-12-09 09:23:38.000000000","message":"spec_obj","commit_id":"f1e467eefc4c046ab7730cd1871c7ef9f6f7d661"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"106a9dce08b16ed6b9db44fb30ba79ab85bd9f06","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # A fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":42,"context_line":"        fake.FakeInstance(\u0027instance1\u0027, \u0027Running\u0027, \u0027123\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        # And a base spec_pbj"},{"line_number":45,"context_line":"        self.spec_obj \u003d objects.RequestSpec("},{"line_number":46,"context_line":"            project_id\u003d\u0027fakepj\u0027,"},{"line_number":47,"context_line":"            scheduler_hints\u003d{}"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_64a20ffe","line":44,"range":{"start_line":44,"start_character":21,"end_line":44,"end_character":29},"in_reply_to":"3a71b18c_b4cabc18","updated":"2016-12-10 01:46:12.000000000","message":"Done","commit_id":"f1e467eefc4c046ab7730cd1871c7ef9f6f7d661"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            fake_nova_db):"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        #Given the host is NOT authorized in the current tenant"},{"line_number":158,"context_line":"        #And thee pool name is NOT \u0027r-fakeres\u0027"},{"line_number":159,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d \\"},{"line_number":160,"context_line":"            [{\u0027name\u0027: \u0027r-fackers\u0027,"},{"line_number":161,"context_line":"              \u0027availability_zone\u0027: \u0027unknown\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_7a7d9fb0","side":"PARENT","line":158,"updated":"2017-01-03 18:17:44.000000000","message":"This line was lost in this patch.","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            fake_nova_db):"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        #Given the host is NOT authorized in the current tenant"},{"line_number":158,"context_line":"        #And thee pool name is NOT \u0027r-fakeres\u0027"},{"line_number":159,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d \\"},{"line_number":160,"context_line":"            [{\u0027name\u0027: \u0027r-fackers\u0027,"},{"line_number":161,"context_line":"              \u0027availability_zone\u0027: \u0027unknown\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_296b6cf2","side":"PARENT","line":158,"in_reply_to":"ba5201f7_7a7d9fb0","updated":"2017-01-06 02:15:50.000000000","message":"I restored this line. Tanks!","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d \\"},{"line_number":160,"context_line":"            [{\u0027name\u0027: \u0027r-fackers\u0027,"},{"line_number":161,"context_line":"              \u0027availability_zone\u0027: \u0027unknown\u0027,"},{"line_number":162,"context_line":"              \u0027metadetails\u0027: {self.fake_context.project_id: False}}]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        #And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":165,"context_line":"        self.filter_properties[\u0027scheduler_hints\u0027][\u0027reservation\u0027] \u003d \u0027r-fakeres\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_9a4a4382","side":"PARENT","line":162,"updated":"2017-01-03 18:17:44.000000000","message":"This value was lost in this patch.","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d \\"},{"line_number":160,"context_line":"            [{\u0027name\u0027: \u0027r-fackers\u0027,"},{"line_number":161,"context_line":"              \u0027availability_zone\u0027: \u0027unknown\u0027,"},{"line_number":162,"context_line":"              \u0027metadetails\u0027: {self.fake_context.project_id: False}}]"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        #And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":165,"context_line":"        self.filter_properties[\u0027scheduler_hints\u0027][\u0027reservation\u0027] \u003d \u0027r-fakeres\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_895d3849","side":"PARENT","line":162,"in_reply_to":"ba5201f7_9a4a4382","updated":"2017-01-06 02:15:50.000000000","message":"I restored this line. Thanks!","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            [{\u0027name\u0027: \u0027r-fakeres\u0027,"},{"line_number":203,"context_line":"              \u0027availability_zone\u0027:"},{"line_number":204,"context_line":"              cfg.CONF[\u0027blazar:physical:host\u0027].blazar_az_prefix,"},{"line_number":205,"context_line":"              \u0027metadetails\u0027: {self.fake_context.project_id: False,"},{"line_number":206,"context_line":"                              cfg.CONF[\u0027blazar:physical:host\u0027]."},{"line_number":207,"context_line":"                              blazar_owner: self.fake_context.project_id}}]"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_7a2bdf94","side":"PARENT","line":205,"updated":"2017-01-03 18:17:44.000000000","message":"This line was lost too.","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            [{\u0027name\u0027: \u0027r-fakeres\u0027,"},{"line_number":203,"context_line":"              \u0027availability_zone\u0027:"},{"line_number":204,"context_line":"              cfg.CONF[\u0027blazar:physical:host\u0027].blazar_az_prefix,"},{"line_number":205,"context_line":"              \u0027metadetails\u0027: {self.fake_context.project_id: False,"},{"line_number":206,"context_line":"                              cfg.CONF[\u0027blazar:physical:host\u0027]."},{"line_number":207,"context_line":"                              blazar_owner: self.fake_context.project_id}}]"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_e932440f","side":"PARENT","line":205,"in_reply_to":"ba5201f7_7a2bdf94","updated":"2017-01-06 02:15:50.000000000","message":"I restored this line. Thanks!","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.host.aggregates \u003d []"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":56,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # When the host goes through the filter"},{"line_number":59,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_5af37b9e","line":56,"updated":"2017-01-03 18:17:44.000000000","message":"The value of the \u0027reservation\u0027 scheduler hint was changed from string to list.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.host.aggregates \u003d []"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":56,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # When the host goes through the filter"},{"line_number":59,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_c9bf40a8","line":56,"in_reply_to":"ba5201f7_5af37b9e","updated":"2017-01-06 02:15:50.000000000","message":"A type of scheduler_hints field in RequestSpec object is \"fields.DictOfListOfStringsField\" now [1]. So the value of the \u0027reservation\u0027 scheduler hint should be list of string.\n\n[1] https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L69","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":130,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # When the host goes through the filter"},{"line_number":133,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_dad12bcf","line":130,"updated":"2017-01-03 18:17:44.000000000","message":"The value of the \u0027reservation\u0027 scheduler hint was changed from string to list.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":130,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # When the host goes through the filter"},{"line_number":133,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_29e52cdb","line":130,"in_reply_to":"ba5201f7_dad12bcf","updated":"2017-01-06 02:15:50.000000000","message":"Same with L56","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: \u0027unknown\u0027})]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":149,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # When the host goes through the filter"},{"line_number":152,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_5ae61bb5","line":149,"updated":"2017-01-03 18:17:44.000000000","message":"The value of the \u0027reservation\u0027 scheduler hint was changed from string to list.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: \u0027unknown\u0027})]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":149,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # When the host goes through the filter"},{"line_number":152,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_c9d660f0","line":149,"in_reply_to":"ba5201f7_5ae61bb5","updated":"2017-01-06 02:15:50.000000000","message":"Same with L56","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":187,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":188,"context_line":"                          .blazar_az_prefix,"},{"line_number":189,"context_line":"                          \u0027climate:owner\u0027: self.spec_obj.project_id})]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":192,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_9d379daf","line":189,"updated":"2017-01-03 18:17:44.000000000","message":"You replaced the use of a configuration value by a hardcoded \u0027climate:owner\u0027.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":187,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":188,"context_line":"                          .blazar_az_prefix,"},{"line_number":189,"context_line":"                          \u0027climate:owner\u0027: self.spec_obj.project_id})]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":192,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_c9f74057","line":189,"in_reply_to":"ba5201f7_9d379daf","updated":"2017-01-06 02:15:50.000000000","message":"Sorry, I mistook it. I replaced here with the original code.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                metadata\u003d{\u0027availability_zone\u0027:"},{"line_number":210,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":211,"context_line":"                          .blazar_az_prefix,"},{"line_number":212,"context_line":"                          \u0027climate:owner\u0027: \u0027another_project_id\u0027})]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":215,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_5de8d510","line":212,"updated":"2017-01-03 18:17:44.000000000","message":"You replaced the use of a configuration value by a hardcoded \u0027climate:owner\u0027.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                metadata\u003d{\u0027availability_zone\u0027:"},{"line_number":210,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":211,"context_line":"                          .blazar_az_prefix,"},{"line_number":212,"context_line":"                          \u0027climate:owner\u0027: \u0027another_project_id\u0027})]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":215,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_e9bde468","line":212,"in_reply_to":"ba5201f7_5de8d510","updated":"2017-01-06 02:15:50.000000000","message":"Same with L189","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                          \u0027climate:owner\u0027: \u0027another_project_id\u0027})]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":215,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # When the host goes through the filter"},{"line_number":218,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_1db00d43","line":215,"updated":"2017-01-03 18:17:44.000000000","message":"The value of the \u0027reservation\u0027 scheduler hint was changed from string to list.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                          \u0027climate:owner\u0027: \u0027another_project_id\u0027})]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":215,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        # When the host goes through the filter"},{"line_number":218,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_29fc4c71","line":215,"in_reply_to":"ba5201f7_1db00d43","updated":"2017-01-06 02:15:50.000000000","message":"Same with L56","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: \u0027unknown\u0027})]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":235,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # When the host goes through the filter"},{"line_number":238,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_3d64f1e3","line":235,"updated":"2017-01-03 18:17:44.000000000","message":"The value of the \u0027reservation\u0027 scheduler hint was changed from string to list.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: \u0027unknown\u0027})]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":235,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # When the host goes through the filter"},{"line_number":238,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_69fad476","line":235,"in_reply_to":"ba5201f7_3d64f1e3","updated":"2017-01-06 02:15:50.000000000","message":"Same with L56","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"992589f1c7794b63345eb3c94aa438d828b9c7e4","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # And the filter is requesting for a host with the same name (ucode)"},{"line_number":257,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [U\u0027r-fakeres\u0027]}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # When the host goes through the filter"},{"line_number":260,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_dd576500","line":257,"updated":"2017-01-03 18:17:44.000000000","message":"The value of the \u0027reservation\u0027 scheduler hint was changed from string to list.","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3a0e94f10bbfd90856a05c2471d1450d5763924d","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        # And the filter is requesting for a host with the same name (ucode)"},{"line_number":257,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [U\u0027r-fakeres\u0027]}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # When the host goes through the filter"},{"line_number":260,"context_line":"        self.host.passes \u003d self.f.host_passes("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_a9f03c92","line":257,"in_reply_to":"ba5201f7_dd576500","updated":"2017-01-06 02:15:50.000000000","message":"Same with L56","commit_id":"f5e19041bb62d0555a0dfce13eee69d1f208da70"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"040748490257b9b52baf85f94cda3d8f6bdf6711","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            objects.Aggregate("},{"line_number":105,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":106,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":107,"context_line":"                          .blazar_az_prefix + \u0027XX\u0027,"},{"line_number":108,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # And the filter doesn\u0027t require any pool (using filter as in setup())"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_ca5fd90c","line":107,"range":{"start_line":107,"start_character":26,"end_line":107,"end_character":50},"updated":"2017-01-12 14:29:58.000000000","message":"blazar_az_prefix is the variable of cfg.CONF[\u0027blazar:physical:host\u0027], right? If so, use bracket to connect the value. Don\u0027t align key and period in value.","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"969a27ff94beecd5df4b6086bb61cfb08156ac85","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            objects.Aggregate("},{"line_number":105,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":106,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":107,"context_line":"                          .blazar_az_prefix + \u0027XX\u0027,"},{"line_number":108,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # And the filter doesn\u0027t require any pool (using filter as in setup())"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_49ddc26f","line":107,"range":{"start_line":107,"start_character":26,"end_line":107,"end_character":50},"in_reply_to":"7a3c09a3_0bb012f4","updated":"2017-01-13 02:51:37.000000000","message":"It could be like following:\n\n  metadata \u003d {\n              \u0027availability_zone\u0027: (cfg.CONF[\u0027blazar:physical:host\u0027]\n                                   .blazar_az_prefix + XX),\n               self.spec_obj.project_id: True\n             }","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"40f2b3f339c3d584f233bd8fcba000cd3974a49f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            objects.Aggregate("},{"line_number":105,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":106,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":107,"context_line":"                          .blazar_az_prefix + \u0027XX\u0027,"},{"line_number":108,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # And the filter doesn\u0027t require any pool (using filter as in setup())"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_29e23604","line":107,"range":{"start_line":107,"start_character":26,"end_line":107,"end_character":50},"in_reply_to":"7a3c09a3_49ddc26f","updated":"2017-01-13 02:56:14.000000000","message":"Thank you! I understood and fixed it.","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"751874c52258438cbca6afb0acc0e931f825e032","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            objects.Aggregate("},{"line_number":105,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":106,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":107,"context_line":"                          .blazar_az_prefix + \u0027XX\u0027,"},{"line_number":108,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # And the filter doesn\u0027t require any pool (using filter as in setup())"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_0bb012f4","line":107,"range":{"start_line":107,"start_character":26,"end_line":107,"end_character":50},"in_reply_to":"9a57fde8_ca5fd90c","updated":"2017-01-13 02:21:09.000000000","message":"Isn\u0027t it a correct way to access config variables? I appreciate it if you could show me a sample code for modification of this sentence. Thanks.","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"040748490257b9b52baf85f94cda3d8f6bdf6711","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            objects.Aggregate("},{"line_number":167,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":168,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":169,"context_line":"                          .blazar_az_prefix,"},{"line_number":170,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_4aaa09d6","line":169,"range":{"start_line":169,"start_character":26,"end_line":169,"end_character":44},"updated":"2017-01-12 14:29:58.000000000","message":"same as above","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"40f2b3f339c3d584f233bd8fcba000cd3974a49f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            objects.Aggregate("},{"line_number":167,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":168,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":169,"context_line":"                          .blazar_az_prefix,"},{"line_number":170,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_097c9a71","line":169,"range":{"start_line":169,"start_character":26,"end_line":169,"end_character":44},"in_reply_to":"9a57fde8_4aaa09d6","updated":"2017-01-13 02:56:14.000000000","message":"Done","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"040748490257b9b52baf85f94cda3d8f6bdf6711","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.host.aggregates \u003d ["},{"line_number":187,"context_line":"            objects.Aggregate("},{"line_number":188,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":189,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":190,"context_line":"                          .blazar_az_prefix,"},{"line_number":191,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":192,"context_line":"                          .blazar_owner: self.spec_obj.project_id,"},{"line_number":193,"context_line":"                          self.spec_obj.project_id: False})]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_8a9311a3","line":192,"range":{"start_line":189,"start_character":27,"end_line":192,"end_character":66},"updated":"2017-01-12 14:29:58.000000000","message":"same as above","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"40f2b3f339c3d584f233bd8fcba000cd3974a49f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.host.aggregates \u003d ["},{"line_number":187,"context_line":"            objects.Aggregate("},{"line_number":188,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":189,"context_line":"                metadata\u003d{\u0027availability_zone\u0027: cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":190,"context_line":"                          .blazar_az_prefix,"},{"line_number":191,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":192,"context_line":"                          .blazar_owner: self.spec_obj.project_id,"},{"line_number":193,"context_line":"                          self.spec_obj.project_id: False})]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_89b96a31","line":192,"range":{"start_line":189,"start_character":27,"end_line":192,"end_character":66},"in_reply_to":"9a57fde8_8a9311a3","updated":"2017-01-13 02:56:14.000000000","message":"Done","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"040748490257b9b52baf85f94cda3d8f6bdf6711","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self.host.aggregates \u003d ["},{"line_number":211,"context_line":"            objects.Aggregate("},{"line_number":212,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":213,"context_line":"                metadata\u003d{\u0027availability_zone\u0027:"},{"line_number":214,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":215,"context_line":"                          .blazar_az_prefix,"},{"line_number":216,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":217,"context_line":"                          .blazar_owner: \u0027another_project_id\u0027})]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":220,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_ca8d197d","line":217,"range":{"start_line":213,"start_character":26,"end_line":217,"end_character":64},"updated":"2017-01-12 14:29:58.000000000","message":"same as above","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"40f2b3f339c3d584f233bd8fcba000cd3974a49f","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        self.host.aggregates \u003d ["},{"line_number":211,"context_line":"            objects.Aggregate("},{"line_number":212,"context_line":"                name\u003d\u0027r-fakeres\u0027,"},{"line_number":213,"context_line":"                metadata\u003d{\u0027availability_zone\u0027:"},{"line_number":214,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":215,"context_line":"                          .blazar_az_prefix,"},{"line_number":216,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":217,"context_line":"                          .blazar_owner: \u0027another_project_id\u0027})]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # And the \u0027r-fakeres\u0027 pool is requested in the filter"},{"line_number":220,"context_line":"        self.spec_obj.scheduler_hints \u003d {\u0027reservation\u0027: [\u0027r-fakeres\u0027]}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_a9b6263b","line":217,"range":{"start_line":213,"start_character":26,"end_line":217,"end_character":64},"in_reply_to":"9a57fde8_ca8d197d","updated":"2017-01-13 02:56:14.000000000","message":"Done","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"040748490257b9b52baf85f94cda3d8f6bdf6711","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self.host.aggregates \u003d ["},{"line_number":254,"context_line":"            objects.Aggregate("},{"line_number":255,"context_line":"                name\u003dU\u0027r-fakeres\u0027,"},{"line_number":256,"context_line":"                metadata\u003d{\u0027availability_zone\u0027:"},{"line_number":257,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":258,"context_line":"                          .blazar_az_prefix,"},{"line_number":259,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # And the filter is requesting for a host with the same name (ucode)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a57fde8_0aee4122","line":258,"range":{"start_line":256,"start_character":26,"end_line":258,"end_character":44},"updated":"2017-01-12 14:29:58.000000000","message":"same as above","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"40f2b3f339c3d584f233bd8fcba000cd3974a49f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self.host.aggregates \u003d ["},{"line_number":254,"context_line":"            objects.Aggregate("},{"line_number":255,"context_line":"                name\u003dU\u0027r-fakeres\u0027,"},{"line_number":256,"context_line":"                metadata\u003d{\u0027availability_zone\u0027:"},{"line_number":257,"context_line":"                          cfg.CONF[\u0027blazar:physical:host\u0027]"},{"line_number":258,"context_line":"                          .blazar_az_prefix,"},{"line_number":259,"context_line":"                          self.spec_obj.project_id: True})]"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # And the filter is requesting for a host with the same name (ucode)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a3c09a3_c981b24f","line":258,"range":{"start_line":256,"start_character":26,"end_line":258,"end_character":44},"in_reply_to":"9a57fde8_0aee4122","updated":"2017-01-13 02:56:14.000000000","message":"Done","commit_id":"fff041c386c80dc9878d20dd57eda760eff3b521"}],"tox.ini":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"14bd727b768cc5b8ca18cf6746ba43c90e44de89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d py27,pep8"},{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":8,"id":"3a71b18c_c85598c2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"updated":"2016-12-05 20:21:01.000000000","message":"This should really be in a separate change, which would not only remove Python 2.6, but also add Python 3 environments.","commit_id":"fcb5e3eb72853ac2ad39503205610f40674d90a1"}]}
