)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b589e7493446d697843f5f18696278a5ab7bdbdd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroaki Kobayashi \u003ckobayashi.hiroaki@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-06 10:29:22 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update legcy code depending on Nova V2 API plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blazar-nova uses Nova API plugin frameworks."},{"line_number":10,"context_line":"V2 of the framework is now frozen [1], however, some lines of V2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_dc466c20","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"updated":"2016-12-09 16:56:11.000000000","message":"legacy","commit_id":"878d6933eb778203769c38bb140809c305f3d976"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"65dca4df1a782ef2d314db08db5a63fcd855e5ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroaki Kobayashi \u003ckobayashi.hiroaki@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-06 10:29:22 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update legcy code depending on Nova V2 API plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blazar-nova uses Nova API plugin frameworks."},{"line_number":10,"context_line":"V2 of the framework is now frozen [1], however, some lines of V2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_5124da0b","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":12},"in_reply_to":"3a71b18c_dc466c20","updated":"2016-12-12 04:55:50.000000000","message":"Done","commit_id":"878d6933eb778203769c38bb140809c305f3d976"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b589e7493446d697843f5f18696278a5ab7bdbdd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"V2 of the framework is now frozen [1], however, some lines of V2"},{"line_number":11,"context_line":"dependent code were still included."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes the V2 dependent code."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://docs.openstack.org/developer/nova/api_plugins.html"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_3ca120aa","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":41},"updated":"2016-12-09 16:56:11.000000000","message":"It looks more like this patch updates version 2.0 code to 2.1, no?","commit_id":"878d6933eb778203769c38bb140809c305f3d976"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"65dca4df1a782ef2d314db08db5a63fcd855e5ff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"V2 of the framework is now frozen [1], however, some lines of V2"},{"line_number":11,"context_line":"dependent code were still included."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes the V2 dependent code."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://docs.openstack.org/developer/nova/api_plugins.html"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_f17fa6dc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":41},"in_reply_to":"3a71b18c_3ca120aa","updated":"2016-12-12 04:55:50.000000000","message":"Yes, it does. I changed commit messages.","commit_id":"878d6933eb778203769c38bb140809c305f3d976"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7c724ca38dd2d2ece5521079df753cb434306c2b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update legacy code depending on Nova V2 API plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blazar-nova uses Nova API plugin frameworks."},{"line_number":10,"context_line":"V2 of the framework is now frozen [1], however, some lines of V2"},{"line_number":11,"context_line":"dependent code were still included."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates the V2 dependent code to V2.1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_7a44bfb6","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":37},"updated":"2017-01-10 17:27:56.000000000","message":"I believe the documentation you link to is out of date: the V2 code has been removed from Nova in commit a31d917af0cc5ecb55424598e7b812e02afbf28c.","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"e885d30f3895e4d9f2edd499b022143186342065","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update legacy code depending on Nova V2 API plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Blazar-nova uses Nova API plugin frameworks."},{"line_number":10,"context_line":"V2 of the framework is now frozen [1], however, some lines of V2"},{"line_number":11,"context_line":"dependent code were still included."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates the V2 dependent code to V2.1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_06f6f1f8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":37},"in_reply_to":"ba5201f7_7a44bfb6","updated":"2017-01-11 00:30:07.000000000","message":"Thank you for updated information. V2 code has been not frozen but completely removed as you said. I have removed this wrong description.","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7c724ca38dd2d2ece5521079df753cb434306c2b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates the V2 dependent code to V2.1."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"NOTE: Plugin files in the blazarnova/api/extensions directory"},{"line_number":16,"context_line":"should live in the nova/api/openstack/compute directory[1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] http://docs.openstack.org/developer/nova/api_plugins.html"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_1a965394","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":59},"updated":"2017-01-10 17:27:56.000000000","message":"I would remove this part of the message, and instead say:\n\nThis commit fixes unit tests in order to unblock the gate, but doesn\u0027t restore instance reservation functionality due to major changes in support for Nova API extensions.","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"e885d30f3895e4d9f2edd499b022143186342065","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch updates the V2 dependent code to V2.1."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"NOTE: Plugin files in the blazarnova/api/extensions directory"},{"line_number":16,"context_line":"should live in the nova/api/openstack/compute directory[1]."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] http://docs.openstack.org/developer/nova/api_plugins.html"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_06cd11b7","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":59},"in_reply_to":"ba5201f7_1a965394","updated":"2017-01-11 00:30:07.000000000","message":"I agree with your revise which is more appropriate. I have replaced the part with it. thanks!","commit_id":"bccfc2a3051087cf43d6dbc1ee2345d99bb884a4"}],"blazarnova/api/extensions/default_reservation.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b2b4437227b3d1cddd2373c68f5cb72505493226","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        default_hints \u003d {\u0027lease_params\u0027: json.dumps(lease_params)}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        attr \u003d \u0027OS-SCH-HNT:scheduler_hints\u0027"},{"line_number":101,"context_line":"        if \u0027os:scheduler_hints\u0027 in body:"},{"line_number":102,"context_line":"            body[\u0027os:scheduler_hints\u0027].update(default_hints)"},{"line_number":103,"context_line":"        elif attr in body and \u0027lease_params\u0027 not in body[attr]:"},{"line_number":104,"context_line":"            body[attr].update(default_hints)"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            body[\u0027os:scheduler_hints\u0027] \u003d default_hints"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class Default_reservation(extensions.V21APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_05330ef7","line":106,"range":{"start_line":100,"start_character":0,"end_line":106,"end_character":54},"updated":"2016-12-05 12:29:21.000000000","message":"From my understand, original data remains only when following #3 is true, and in other cases body are overwritten by default_hints, right?\n\nI think we could implement the if-statemente more simple.\n\n | #  | os:schduler_hint | OS-SCHED-HNT | lease_params in OS-SCHED-HNT |\n | 1  |        F         |      F       |           F                  |\n | 2  |        F         |      F       |           T                  |\n | 3  |        F         |      T       |           F                  |\n | 4  |        F         |      T       |           T                  |\n | 5  |        T         |      F       |           F                  |\n | 6  |        T         |      F       |           T                  |\n | 7  |        T         |      T       |           F                  |\n | 8  |        T         |      T       |           T                  |","commit_id":"8284a9a97afebd2c431d3c763659abbaaab5699a"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"fe8123f4f92623ef8686027a9cf9a0df6f2ebb8d","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        default_hints \u003d {\u0027lease_params\u0027: json.dumps(lease_params)}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if \u0027os:scheduler_hints\u0027 in body:"},{"line_number":101,"context_line":"            body[\u0027os:scheduler_hints\u0027].update(default_hints)"},{"line_number":102,"context_line":"        elif \u0027OS-SCH-HNT:scheduler_hints\u0027 in body:"},{"line_number":103,"context_line":"            body[\u0027OS-SCH-HNT:scheduler_hints\u0027].update(default_hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_94d00ef8","line":100,"updated":"2016-12-06 02:00:46.000000000","message":"\u003e Masahito\nThank you for accurate feedback and I found the original code was logically wrong.\nActually, body should be updated in all cases including #3.\nAnd now its Modified.","commit_id":"878d6933eb778203769c38bb140809c305f3d976"}]}
