)]}'
{"blazarnova/api/extensions/reservation.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9a764fc23ed4b33f87b02c5118316613d34d9f78","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            raise exception.NotFound(_(\u0027No Blazar endpoint found in service \u0027"},{"line_number":129,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        blazar_endpoint \u003d None"},{"line_number":132,"context_line":"        if \u0027admin\u0027 in user_roles:"},{"line_number":133,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027adminURL\u0027)"},{"line_number":134,"context_line":"        if blazar_endpoint is None:"},{"line_number":135,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027publicURL\u0027)"},{"line_number":136,"context_line":"        if blazar_endpoint is None:"},{"line_number":137,"context_line":"            raise exception.NotFound(_(\u0027No Blazar URL found in service \u0027"},{"line_number":138,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_6dc95278","line":136,"range":{"start_line":131,"start_character":0,"end_line":136,"end_character":35},"updated":"2017-02-21 22:09:39.000000000","message":"Was there a specific reason for changing this variable name?","commit_id":"e7b76ae56d050fc80281b6e3067aa698d5678f09"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"96d9813fb7fe5956b303502e329d29bdcf61bf98","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            raise exception.NotFound(_(\u0027No Blazar endpoint found in service \u0027"},{"line_number":129,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        blazar_endpoint \u003d None"},{"line_number":132,"context_line":"        if \u0027admin\u0027 in user_roles:"},{"line_number":133,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027adminURL\u0027)"},{"line_number":134,"context_line":"        if blazar_endpoint is None:"},{"line_number":135,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027publicURL\u0027)"},{"line_number":136,"context_line":"        if blazar_endpoint is None:"},{"line_number":137,"context_line":"            raise exception.NotFound(_(\u0027No Blazar URL found in service \u0027"},{"line_number":138,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_c1a4b8a7","line":136,"range":{"start_line":131,"start_character":0,"end_line":136,"end_character":35},"in_reply_to":"da36d5c6_612a2c80","updated":"2017-02-22 13:37:31.000000000","message":"OK, then I follow the standard practice. Thanks Pierre!","commit_id":"e7b76ae56d050fc80281b6e3067aa698d5678f09"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"d2db1b85102be1ded3e5cbe377de6232c016c913","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            raise exception.NotFound(_(\u0027No Blazar endpoint found in service \u0027"},{"line_number":129,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        blazar_endpoint \u003d None"},{"line_number":132,"context_line":"        if \u0027admin\u0027 in user_roles:"},{"line_number":133,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027adminURL\u0027)"},{"line_number":134,"context_line":"        if blazar_endpoint is None:"},{"line_number":135,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027publicURL\u0027)"},{"line_number":136,"context_line":"        if blazar_endpoint is None:"},{"line_number":137,"context_line":"            raise exception.NotFound(_(\u0027No Blazar URL found in service \u0027"},{"line_number":138,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_dba4aaa7","line":136,"range":{"start_line":131,"start_character":0,"end_line":136,"end_character":35},"in_reply_to":"da36d5c6_6dc95278","updated":"2017-02-22 11:50:09.000000000","message":"The original variable name \u0027blazar_url\u0027 was the same with the argument name of blazar_client.Client() in L140. I changed the name because its confusing.","commit_id":"e7b76ae56d050fc80281b6e3067aa698d5678f09"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c3b2468a436f7df927ca93142f86e57196a381c4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            raise exception.NotFound(_(\u0027No Blazar endpoint found in service \u0027"},{"line_number":129,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        blazar_endpoint \u003d None"},{"line_number":132,"context_line":"        if \u0027admin\u0027 in user_roles:"},{"line_number":133,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027adminURL\u0027)"},{"line_number":134,"context_line":"        if blazar_endpoint is None:"},{"line_number":135,"context_line":"            blazar_endpoint \u003d blazar_endpoints.get(\u0027publicURL\u0027)"},{"line_number":136,"context_line":"        if blazar_endpoint is None:"},{"line_number":137,"context_line":"            raise exception.NotFound(_(\u0027No Blazar URL found in service \u0027"},{"line_number":138,"context_line":"                                       \u0027catalog.\u0027))"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_612a2c80","line":136,"range":{"start_line":131,"start_character":0,"end_line":136,"end_character":35},"in_reply_to":"da36d5c6_dba4aaa7","updated":"2017-02-22 13:17:38.000000000","message":"Personally I name variables using keyword arguments exactly like the corresponding keyword argument, unless a better name can be used.\n\nLooking through OpenStack code, there are many occurrences of auth_url\u003dauth_url, auth_token\u003dauth_token (including line 141 in this file), etc. This makes me think that this is a standard practice.","commit_id":"e7b76ae56d050fc80281b6e3067aa698d5678f09"}]}