)]}'
{"climatenova/scheduler/filters/climate_filter.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"1bfd04ff8eda44b3f435ba29d5f7f37d50a209b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import nova"},{"line_number":20,"context_line":"from nova.openstack.common.gettextutils import _  # noqa"},{"line_number":21,"context_line":"from nova.openstack.common import log as logging"},{"line_number":22,"context_line":"from nova.scheduler import filters"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2B6FQ%3D","line":19,"updated":"2014-03-11 14:26:09.000000000","message":"well, I guess you may leave here \"from nova import db\", because you don\u0027t need whole nova here, that\u0027s incorrect to import all tree here.\n\nin tests you need to mock not whole module, but needed method to get rid of that whole import here","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import nova"},{"line_number":20,"context_line":"from nova.openstack.common.gettextutils import _  # noqa"},{"line_number":21,"context_line":"from nova.openstack.common import log as logging"},{"line_number":22,"context_line":"from nova.scheduler import filters"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bh8%3D","line":19,"in_reply_to":"AAAAVn%2F%2B6FQ%3D","updated":"2014-03-12 15:49:46.000000000","message":"please take use of \"from nova import db\"","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import nova"},{"line_number":20,"context_line":"from nova.openstack.common.gettextutils import _  # noqa"},{"line_number":21,"context_line":"from nova.openstack.common import log as logging"},{"line_number":22,"context_line":"from nova.scheduler import filters"},{"line_number":23,"context_line":"from oslo.config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bh4%3D","line":20,"updated":"2014-03-12 15:49:46.000000000","message":"please take the opportunity to remove the noqa tag","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nova.openstack.common.gettextutils import _  # noqa"},{"line_number":21,"context_line":"from nova.openstack.common import log as logging"},{"line_number":22,"context_line":"from nova.scheduler import filters"},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bhk%3D","line":23,"updated":"2014-03-12 15:49:46.000000000","message":"bad placement here, should be in between six and nova imports","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"49fd5c1d51b51de62a16837c918956fe96ac3639","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nova.openstack.common.gettextutils import _  # noqa"},{"line_number":21,"context_line":"from nova.openstack.common import log as logging"},{"line_number":22,"context_line":"from nova.scheduler import filters"},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F4Ms%3D","line":23,"in_reply_to":"AAAAWH%2F%2F%2Bhk%3D","updated":"2014-03-13 07:37:54.000000000","message":"No, it should not if we\u0027ll merge other Diego\u0027s change adding some things to tox.ini","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            requested_pools \u003d [requested_pools]"},{"line_number":76,"context_line":"        # Get any reservation pools this host is part of"},{"line_number":77,"context_line":"        # Note this include possibly the freepool"},{"line_number":78,"context_line":"        aggregates \u003d nova.db.aggregate_get_by_host(context, host_state.host)"},{"line_number":79,"context_line":"        pools \u003d []"},{"line_number":80,"context_line":"        for agg in aggregates:"},{"line_number":81,"context_line":"            if agg[\u0027availability_zone\u0027].startswith("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2BhE%3D","line":78,"updated":"2014-03-12 15:49:46.000000000","message":"why is it necessary to import nova ?","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"629af4201ec492d13205172424c10c807eb57389","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova import db"},{"line_number":22,"context_line":"from nova.openstack.common.gettextutils import _"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F1aw%3D","line":19,"updated":"2014-03-13 14:14:53.000000000","message":"well, I loved you how placed oslo.config in previous change.... As I said in previous change comments, it\u0027ll work if we\u0027ll merge your second change.","commit_id":"a24c7fba3eb17364e3a3ad2ca3f3619107420b6b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c25c85a9bc17c476ec847eb88bd456495d70a7d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BOg0%3D","line":9,"updated":"2014-03-28 09:12:39.000000000","message":"the whole change for this file is not related to the patch, could ou please provide another patchset ?","commit_id":"e5b44e7c32182d15d26041cc424ce57ce61e5941"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"b01242e585e8eaace0361f9a54a79a0ca0609f51","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        requested_pools \u003d scheduler_hints.get(\u0027reservation\u0027, [])"},{"line_number":74,"context_line":"        if isinstance(requested_pools, six.text_type):"},{"line_number":75,"context_line":"            requested_pools \u003d [requested_pools]"},{"line_number":76,"context_line":"        # Get any reservation pools this host is part of"},{"line_number":77,"context_line":"        # Note this include possibly the freepool"},{"line_number":78,"context_line":"        aggregates \u003d db.aggregate_get_by_host(context, host_state.host)"},{"line_number":79,"context_line":"        pools \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2BYkI%3D","line":76,"updated":"2014-03-27 07:32:37.000000000","message":"I prefer not mixing \"whitespace changes\" with smth about bug/feature, but well, let\u0027s leave it as is.\n\nJust please keep that in mind further.","commit_id":"e5b44e7c32182d15d26041cc424ce57ce61e5941"}],"climatenova/tests/scheduler/filters/test_climate_filter.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"from climatenova.scheduler.filters import climate_filter"},{"line_number":15,"context_line":"from climatenova.tests.api import extensions"},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from nova import context"},{"line_number":18,"context_line":"from nova.openstack.common import log as logging"},{"line_number":19,"context_line":"from nova.tests.scheduler import fakes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bg8%3D","line":16,"updated":"2014-03-12 15:49:46.000000000","message":"bad placement, should be before climatenova imports\n\nbtw. mox is in use with nova, not mock","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"d92191725a412f449d6d6933f61fbcd7eaa74167","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"from climatenova.scheduler.filters import climate_filter"},{"line_number":15,"context_line":"from climatenova.tests.api import extensions"},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from nova import context"},{"line_number":18,"context_line":"from nova.openstack.common import log as logging"},{"line_number":19,"context_line":"from nova.tests.scheduler import fakes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F9MM%3D","line":16,"in_reply_to":"AAAAWH%2F%2F%2Bg8%3D","updated":"2014-03-12 21:00:29.000000000","message":"I asked whether to use mox or mock in https://bugs.launchpad.net/climate/+bug/1270183/comments/4 \n\nand I got \"use mock\" as an answer\n\nhttps://bugs.launchpad.net/climate/+bug/1270183/comments/5","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"49fd5c1d51b51de62a16837c918956fe96ac3639","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"from climatenova.scheduler.filters import climate_filter"},{"line_number":15,"context_line":"from climatenova.tests.api import extensions"},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from nova import context"},{"line_number":18,"context_line":"from nova.openstack.common import log as logging"},{"line_number":19,"context_line":"from nova.tests.scheduler import fakes"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F4Ks%3D","line":16,"in_reply_to":"AAAAWH%2F%2F9MM%3D","updated":"2014-03-13 07:37:54.000000000","message":"Sylvain, as I remember there were discussions to use mock for new nova tests, that\u0027s why I asked Diego to use mock","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from nova import context"},{"line_number":18,"context_line":"from nova.openstack.common import log as logging"},{"line_number":19,"context_line":"from nova.tests.scheduler import fakes"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2BeU%3D","line":20,"updated":"2014-03-12 15:49:46.000000000","message":"bad placement","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"49fd5c1d51b51de62a16837c918956fe96ac3639","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from nova import context"},{"line_number":18,"context_line":"from nova.openstack.common import log as logging"},{"line_number":19,"context_line":"from nova.tests.scheduler import fakes"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F4L8%3D","line":20,"in_reply_to":"AAAAWH%2F%2F%2BeU%3D","updated":"2014-03-13 07:37:54.000000000","message":"Why bad here? Both nova and Oslo are third side lobs here, so they look ok in one section in this order.","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ClimateFilterTestCase(extensions.BaseExtensionTestCase):"},{"line_number":27,"context_line":"    \"\"\"Filter test case."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This test case provides tests for the schedule filters available"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Be4%3D","line":26,"updated":"2014-03-12 15:49:46.000000000","message":"if the extensions class is used here, please move it to climatenova.tests and rebase tests.api.extensions","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"2e8dbad15929c98b384bd653129c500b22ccc091","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ClimateFilterTestCase(extensions.BaseExtensionTestCase):"},{"line_number":27,"context_line":"    \"\"\"Filter test case."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    This test case provides tests for the schedule filters available"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F1PQ%3D","line":26,"in_reply_to":"AAAAWH%2F%2F%2Be4%3D","updated":"2014-03-13 14:34:30.000000000","message":"Done","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        #And a fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":45,"context_line":"        fakes.FakeInstance(self.fake_context)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":48,"context_line":"    def test_climate_filter_no_pool_available_requested(self, fake_nova_db):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        #Given the host doesn\u0027t belong to any pool"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bd8%3D","line":47,"updated":"2014-03-12 15:49:46.000000000","message":"please patch methods other way by not using a deco\n\nthe whole module nova.db should not be patched, but only what is needed","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"49fd5c1d51b51de62a16837c918956fe96ac3639","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        #And a fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":45,"context_line":"        fakes.FakeInstance(self.fake_context)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":48,"context_line":"    def test_climate_filter_no_pool_available_requested(self, fake_nova_db):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        #Given the host doesn\u0027t belong to any pool"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F4LQ%3D","line":47,"in_reply_to":"AAAAWH%2F%2F%2Bd8%3D","updated":"2014-03-13 07:37:54.000000000","message":"I love decos :)","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"d92191725a412f449d6d6933f61fbcd7eaa74167","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        #And a fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":45,"context_line":"        fakes.FakeInstance(self.fake_context)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":48,"context_line":"    def test_climate_filter_no_pool_available_requested(self, fake_nova_db):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        #Given the host doesn\u0027t belong to any pool"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F8gk%3D","line":47,"in_reply_to":"AAAAWH%2F%2F%2Bd8%3D","updated":"2014-03-12 21:00:29.000000000","message":"The other tests in the climate nova component uses the decorator, that\u0027s why I used it here too. Shall I change it here and in the existing tests too?","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.assertFalse(self.host.passes)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":66,"context_line":"    def test_climate_fltr_no_pool_available_not_requested(self, fake_nova_db):"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        #Given the host doesn\u0027t belong to any pool"},{"line_number":69,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bcs%3D","line":66,"updated":"2014-03-12 15:49:46.000000000","message":"please use filter instead of filter.\nIf it\u0027s above 80chars, please indent correctly the args","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"2e8dbad15929c98b384bd653129c500b22ccc091","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.assertFalse(self.host.passes)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":66,"context_line":"    def test_climate_fltr_no_pool_available_not_requested(self, fake_nova_db):"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        #Given the host doesn\u0027t belong to any pool"},{"line_number":69,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F1OM%3D","line":66,"in_reply_to":"AAAAWH%2F%2F%2Bcs%3D","updated":"2014-03-13 14:34:30.000000000","message":"Done","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertTrue(self.host.passes)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":82,"context_line":"    def test_climate_fltr_host_in_freepool_none_requested(self, fake_nova_db):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        #Given the host is in the free pool (named \"freepool\")"},{"line_number":85,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bcg%3D","line":82,"updated":"2014-03-12 15:49:46.000000000","message":"ditto L66","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"2e8dbad15929c98b384bd653129c500b22ccc091","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertTrue(self.host.passes)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @mock.patch(\u0027nova.db\u0027)"},{"line_number":82,"context_line":"    def test_climate_fltr_host_in_freepool_none_requested(self, fake_nova_db):"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        #Given the host is in the free pool (named \"freepool\")"},{"line_number":85,"context_line":"        fake_nova_db.aggregate_get_by_host.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F1OA%3D","line":82,"in_reply_to":"AAAAWH%2F%2F%2Bcg%3D","updated":"2014-03-13 14:34:30.000000000","message":"Done","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"924654d1fac8a436265ad34ca097838f22255991","unresolved":false,"context_lines":[{"line_number":89,"context_line":"              \u0027metadetails\u0027: {self.fake_context.project_id: True}}]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        #And the filter doesn\u0027t require any pool"},{"line_number":92,"context_line":"        filter_properties \u003d {\"scheduler_hints\": {},"},{"line_number":93,"context_line":"                             \"context\": self.fake_context}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        #When the host goes through the filter"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Bbo%3D","line":92,"updated":"2014-03-12 15:49:46.000000000","message":"please factorize by putting filter_properties in setUp(), so that it would be overridden when needed","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"2e8dbad15929c98b384bd653129c500b22ccc091","unresolved":false,"context_lines":[{"line_number":89,"context_line":"              \u0027metadetails\u0027: {self.fake_context.project_id: True}}]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        #And the filter doesn\u0027t require any pool"},{"line_number":92,"context_line":"        filter_properties \u003d {\"scheduler_hints\": {},"},{"line_number":93,"context_line":"                             \"context\": self.fake_context}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        #When the host goes through the filter"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F1N8%3D","line":92,"in_reply_to":"AAAAWH%2F%2F%2Bbo%3D","updated":"2014-03-13 14:34:30.000000000","message":"Done","commit_id":"bfd3ea784db7c4bc9c39030fd110ad7087d23b4e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"629af4201ec492d13205172424c10c807eb57389","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        #A fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":48,"context_line":"        fakes.FakeInstance(self.fake_context)"},{"line_number":49,"context_line":"        "},{"line_number":50,"context_line":"        #And a base filter properties"},{"line_number":51,"context_line":"        self.filter_properties \u003d {"},{"line_number":52,"context_line":"            \"context\": self.fake_context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F1bw%3D","line":49,"updated":"2014-03-13 14:14:53.000000000","message":"tabs here :(","commit_id":"a24c7fba3eb17364e3a3ad2ca3f3619107420b6b"},{"author":{"_account_id":10217,"name":"Diego Pamio","email":"diego.pamio@intel.com","username":"dpamio"},"change_message_id":"442d3a5554372ffc09d5841d28a6c526e759b212","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        #A fake instance (which has a reservation id \u0027r-fakeres\u0027)"},{"line_number":48,"context_line":"        fakes.FakeInstance(self.fake_context)"},{"line_number":49,"context_line":"        "},{"line_number":50,"context_line":"        #And a base filter properties"},{"line_number":51,"context_line":"        self.filter_properties \u003d {"},{"line_number":52,"context_line":"            \"context\": self.fake_context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2F1Oc%3D","line":49,"in_reply_to":"AAAAWH%2F%2F1bw%3D","updated":"2014-03-13 14:33:29.000000000","message":"ouch! will fix.","commit_id":"a24c7fba3eb17364e3a3ad2ca3f3619107420b6b"}]}
