)]}'
{"blazar_tempest_plugin/tests/scenario/resource_reservation_scenario.py":[{"author":{"_account_id":13192,"name":"Souville","display_name":"Bertrand Souville","email":"souville@docomolab-euro.com","username":"bertys"},"change_message_id":"fab0bd0192e87c4545151ca6f5d13684a8d66bed","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        flavor \u003d self.flavors_client.show_flavor(flavor_id)[\u0027flavor\u0027]"},{"line_number":125,"context_line":"        return image[\u0027minDisk\u0027] \u003c\u003d flavor[\u0027disk\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def fetch_one_compute_host(self):"},{"line_number":128,"context_line":"        \"\"\"Returns the first host listed in nova-compute services.\"\"\""},{"line_number":129,"context_line":"        compute \u003d next(iter(self.os_admin.services_client."},{"line_number":130,"context_line":"                            list_services(binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]))"},{"line_number":131,"context_line":"        return compute"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _add_host_once(self):"},{"line_number":134,"context_line":"        host \u003d self.fetch_one_compute_host()"},{"line_number":135,"context_line":"        hosts \u003d self.reservation_client.list_host()[\u0027hosts\u0027]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            [h for h in hosts if h[\u0027hypervisor_hostname\u0027] \u003d\u003d host[\u0027host\u0027]][0]"},{"line_number":138,"context_line":"        except IndexError:"},{"line_number":139,"context_line":"            self.reservation_client.create_host({\u0027name\u0027: host[\u0027host\u0027]})"},{"line_number":140,"context_line":"        return host"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9a8b4dc0","line":140,"range":{"start_line":127,"start_character":4,"end_line":140,"end_character":19},"updated":"2018-10-17 07:16:05.000000000","message":"Shall we consider the case where/check whether scheduling for the compute service has been disabled?","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":13192,"name":"Souville","display_name":"Bertrand Souville","email":"souville@docomolab-euro.com","username":"bertys"},"change_message_id":"ded2e4d5ceefb4b616fee7991cd1435e1d934974","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        flavor \u003d self.flavors_client.show_flavor(flavor_id)[\u0027flavor\u0027]"},{"line_number":125,"context_line":"        return image[\u0027minDisk\u0027] \u003c\u003d flavor[\u0027disk\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def fetch_one_compute_host(self):"},{"line_number":128,"context_line":"        \"\"\"Returns the first host listed in nova-compute services.\"\"\""},{"line_number":129,"context_line":"        compute \u003d next(iter(self.os_admin.services_client."},{"line_number":130,"context_line":"                            list_services(binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]))"},{"line_number":131,"context_line":"        return compute"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _add_host_once(self):"},{"line_number":134,"context_line":"        host \u003d self.fetch_one_compute_host()"},{"line_number":135,"context_line":"        hosts \u003d self.reservation_client.list_host()[\u0027hosts\u0027]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            [h for h in hosts if h[\u0027hypervisor_hostname\u0027] \u003d\u003d host[\u0027host\u0027]][0]"},{"line_number":138,"context_line":"        except IndexError:"},{"line_number":139,"context_line":"            self.reservation_client.create_host({\u0027name\u0027: host[\u0027host\u0027]})"},{"line_number":140,"context_line":"        return host"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_99ee86fc","line":140,"range":{"start_line":127,"start_character":4,"end_line":140,"end_character":19},"in_reply_to":"3f79a3b5_264ab481","updated":"2018-10-23 10:04:24.000000000","message":"As just discussed during IRC weekly meeting, let\u0027s add a ToDo note and revisit this once we publicly start testing health monitoring","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b1a326d3de6652da822c143b5964773af1b952b3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        flavor \u003d self.flavors_client.show_flavor(flavor_id)[\u0027flavor\u0027]"},{"line_number":125,"context_line":"        return image[\u0027minDisk\u0027] \u003c\u003d flavor[\u0027disk\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def fetch_one_compute_host(self):"},{"line_number":128,"context_line":"        \"\"\"Returns the first host listed in nova-compute services.\"\"\""},{"line_number":129,"context_line":"        compute \u003d next(iter(self.os_admin.services_client."},{"line_number":130,"context_line":"                            list_services(binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]))"},{"line_number":131,"context_line":"        return compute"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _add_host_once(self):"},{"line_number":134,"context_line":"        host \u003d self.fetch_one_compute_host()"},{"line_number":135,"context_line":"        hosts \u003d self.reservation_client.list_host()[\u0027hosts\u0027]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            [h for h in hosts if h[\u0027hypervisor_hostname\u0027] \u003d\u003d host[\u0027host\u0027]][0]"},{"line_number":138,"context_line":"        except IndexError:"},{"line_number":139,"context_line":"            self.reservation_client.create_host({\u0027name\u0027: host[\u0027host\u0027]})"},{"line_number":140,"context_line":"        return host"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_eec1e0fe","line":140,"range":{"start_line":127,"start_character":4,"end_line":140,"end_character":19},"in_reply_to":"3f79a3b5_99ee86fc","updated":"2018-11-06 09:59:24.000000000","message":"Done","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9c57547bc09390e9253af72b48eae04ced2813bf","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        flavor \u003d self.flavors_client.show_flavor(flavor_id)[\u0027flavor\u0027]"},{"line_number":125,"context_line":"        return image[\u0027minDisk\u0027] \u003c\u003d flavor[\u0027disk\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def fetch_one_compute_host(self):"},{"line_number":128,"context_line":"        \"\"\"Returns the first host listed in nova-compute services.\"\"\""},{"line_number":129,"context_line":"        compute \u003d next(iter(self.os_admin.services_client."},{"line_number":130,"context_line":"                            list_services(binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]))"},{"line_number":131,"context_line":"        return compute"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _add_host_once(self):"},{"line_number":134,"context_line":"        host \u003d self.fetch_one_compute_host()"},{"line_number":135,"context_line":"        hosts \u003d self.reservation_client.list_host()[\u0027hosts\u0027]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            [h for h in hosts if h[\u0027hypervisor_hostname\u0027] \u003d\u003d host[\u0027host\u0027]][0]"},{"line_number":138,"context_line":"        except IndexError:"},{"line_number":139,"context_line":"            self.reservation_client.create_host({\u0027name\u0027: host[\u0027host\u0027]})"},{"line_number":140,"context_line":"        return host"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f165bf4b","line":140,"range":{"start_line":127,"start_character":4,"end_line":140,"end_character":19},"in_reply_to":"3f79a3b5_9a8b4dc0","updated":"2018-10-17 13:47:19.000000000","message":"Is this a failure that we\u0027ve seen in Zuul jobs?","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":13192,"name":"Souville","display_name":"Bertrand Souville","email":"souville@docomolab-euro.com","username":"bertys"},"change_message_id":"55baf5d752dc734b8ad059ca56f0bb1429f81b30","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        flavor \u003d self.flavors_client.show_flavor(flavor_id)[\u0027flavor\u0027]"},{"line_number":125,"context_line":"        return image[\u0027minDisk\u0027] \u003c\u003d flavor[\u0027disk\u0027]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def fetch_one_compute_host(self):"},{"line_number":128,"context_line":"        \"\"\"Returns the first host listed in nova-compute services.\"\"\""},{"line_number":129,"context_line":"        compute \u003d next(iter(self.os_admin.services_client."},{"line_number":130,"context_line":"                            list_services(binary\u003d\u0027nova-compute\u0027)[\u0027services\u0027]))"},{"line_number":131,"context_line":"        return compute"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _add_host_once(self):"},{"line_number":134,"context_line":"        host \u003d self.fetch_one_compute_host()"},{"line_number":135,"context_line":"        hosts \u003d self.reservation_client.list_host()[\u0027hosts\u0027]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            [h for h in hosts if h[\u0027hypervisor_hostname\u0027] \u003d\u003d host[\u0027host\u0027]][0]"},{"line_number":138,"context_line":"        except IndexError:"},{"line_number":139,"context_line":"            self.reservation_client.create_host({\u0027name\u0027: host[\u0027host\u0027]})"},{"line_number":140,"context_line":"        return host"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_264ab481","line":140,"range":{"start_line":127,"start_character":4,"end_line":140,"end_character":19},"in_reply_to":"3f79a3b5_f165bf4b","updated":"2018-10-23 07:18:13.000000000","message":"One of our plans is to implement scenario to test resource health monitoring (where we may disable a compute service) and as we run scenario tests in parallel, using the first host may not be the best strategy.","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"}],"blazar_tempest_plugin/tests/scenario/test_instance_reservation.py":[{"author":{"_account_id":13192,"name":"Souville","display_name":"Bertrand Souville","email":"souville@docomolab-euro.com","username":"bertys"},"change_message_id":"fab0bd0192e87c4545151ca6f5d13684a8d66bed","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestInstanceReservationScenario(rrs.ResourceReservationScenarioTest):"},{"line_number":35,"context_line":"    \"\"\"A scenario test class that checks the instance reservation feature.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestInstanceReservationScenario, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9aa58da3","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":77},"updated":"2018-10-17 07:16:05.000000000","message":"I personally would prefer to describe the \"scenario outline\" here, it will be easier to review once we start consuming the placement API","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b1a326d3de6652da822c143b5964773af1b952b3","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestInstanceReservationScenario(rrs.ResourceReservationScenarioTest):"},{"line_number":35,"context_line":"    \"\"\"A scenario test class that checks the instance reservation feature.\"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestInstanceReservationScenario, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2e46f8a9","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":77},"in_reply_to":"3f79a3b5_9aa58da3","updated":"2018-11-06 09:59:24.000000000","message":"You mean adding the list of test cases here? As I do in the following patch sets, this class has some test scenario not like the previous one.","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":13192,"name":"Souville","display_name":"Bertrand Souville","email":"souville@docomolab-euro.com","username":"bertys"},"change_message_id":"fab0bd0192e87c4545151ca6f5d13684a8d66bed","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    image\u003dself.image_ref, flavor\u003dself.flavor_ref"},{"line_number":49,"context_line":"                )"},{"line_number":50,"context_line":"            )"},{"line_number":51,"context_line":"        self.host \u003d self._add_host_once()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def tearDown(self):"},{"line_number":54,"context_line":"        super(TestInstanceReservationScenario, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_da9b0563","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":41},"updated":"2018-10-17 07:16:05.000000000","message":"remove _? Same to be done in resource_reservation_scenario.py\nL133?","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b1a326d3de6652da822c143b5964773af1b952b3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    image\u003dself.image_ref, flavor\u003dself.flavor_ref"},{"line_number":49,"context_line":"                )"},{"line_number":50,"context_line":"            )"},{"line_number":51,"context_line":"        self.host \u003d self._add_host_once()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def tearDown(self):"},{"line_number":54,"context_line":"        super(TestInstanceReservationScenario, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0e621c3e","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":41},"in_reply_to":"3f79a3b5_da9b0563","updated":"2018-11-06 09:59:24.000000000","message":"This method has \u0027_\u0027 prefix in resource_reservation_scenario.py L133.","commit_id":"df55452395684cb85ad9553e710968f0a0eb6063"}]}
