)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0663381da8ee100ec418a8fcd63d06f4646de7a9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-12-09 03:44:54 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added default values for min and max hosts"},{"line_number":8,"context_line":"Closes-Bug: 1400642"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib45f8343f5cb386013c482f38f12215c79f677f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_2e8079f6","line":8,"updated":"2014-12-19 09:21:25.000000000","message":"same problem mentioned, your commit msg is not good\n\nAlso, default values are already set, you\u0027re not adding them but rather modifying the logic","commit_id":"3ede95d921a95cc7ba3026f9f395eaac7c0bc9bd"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ee1451f41eb1e08314f3c98e2daa63eb190a9133","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.StrOpt(\u0027on_start\u0027,"},{"line_number":40,"context_line":"               default\u003d\u0027on_start\u0027,"},{"line_number":41,"context_line":"               help\u003d\u0027Actions which we will use at the start of the lease\u0027),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027default_min_hosts\u0027,"},{"line_number":43,"context_line":"               default\u003d1,"},{"line_number":44,"context_line":"               help\u003d\u0027Default value of the minimum number of hosts for the\u0027"},{"line_number":45,"context_line":"                    \u0027physical host reservation\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027default_max_hosts\u0027,"},{"line_number":47,"context_line":"               default\u003d1,"},{"line_number":48,"context_line":"               help\u003d\u0027Default value of the maximum number of hosts for the\u0027"},{"line_number":49,"context_line":"                    \u0027physical host reservation\u0027)"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_3577f3d5","line":49,"range":{"start_line":42,"start_character":0,"end_line":49,"end_character":48},"updated":"2017-03-07 06:52:34.000000000","message":"I don\u0027t think it\u0027s good to add default value to check the validation since it changes both min and max parameters in a API request body from \"Required\" to \"Optional\".\n\nIf we\u0027d like to add the default values, we need to add release note that says \"parameters in create host reservation API are changed.\".","commit_id":"92f8724bd8561c7dabd733b0edb2ef6d2efe42ad"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"e94f72ceae5d2b6765eda2e6f95ee4e3cec251e3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.StrOpt(\u0027on_start\u0027,"},{"line_number":40,"context_line":"               default\u003d\u0027on_start\u0027,"},{"line_number":41,"context_line":"               help\u003d\u0027Actions which we will use at the start of the lease\u0027),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027default_min_hosts\u0027,"},{"line_number":43,"context_line":"               default\u003d1,"},{"line_number":44,"context_line":"               help\u003d\u0027Default value of the minimum number of hosts for the\u0027"},{"line_number":45,"context_line":"                    \u0027physical host reservation\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027default_max_hosts\u0027,"},{"line_number":47,"context_line":"               default\u003d1,"},{"line_number":48,"context_line":"               help\u003d\u0027Default value of the maximum number of hosts for the\u0027"},{"line_number":49,"context_line":"                    \u0027physical host reservation\u0027)"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_ded505e5","line":49,"range":{"start_line":42,"start_character":0,"end_line":49,"end_character":48},"in_reply_to":"9a30ddce_3577f3d5","updated":"2017-03-13 04:39:25.000000000","message":"I agree with you. I\u0027ve removed the configs to keep \u0027min\u0027 and \u0027max\u0027 as \"Required\". I think that\u0027s better design because lease owner should explicitly specify min and max. Thanks!","commit_id":"92f8724bd8561c7dabd733b0edb2ef6d2efe42ad"}],"climate/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0663381da8ee100ec418a8fcd63d06f4646de7a9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027status\u0027: \u0027pending\u0027,"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        reservation \u003d db_api.reservation_create(reservation_values)"},{"line_number":73,"context_line":"        min_hosts \u003d values[\u0027min\u0027] or \u00271\u0027"},{"line_number":74,"context_line":"        max_hosts \u003d values[\u0027max\u0027] or \u00271\u0027"},{"line_number":75,"context_line":"        count_range \u003d str(min_hosts) + \u0027-\u0027 + str(max_hosts)"},{"line_number":76,"context_line":"        host_values \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8e932d5a","line":73,"updated":"2014-12-19 09:21:25.000000000","message":"I would rather propose a configuration opt if you\u0027re planning to modify this","commit_id":"3ede95d921a95cc7ba3026f9f395eaac7c0bc9bd"}]}