)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2df0b69b683d0cdbfd3f6b5830ee4688c3736af7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace tempest logging module with oslo_log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tempest doesn\u0027t support its logging module in master codes. Importing"},{"line_number":10,"context_line":"the module causes import error in blazar\u0027s tempest tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3bb9a832cd9c9c2b4136cb5ce20d06dbb8f2c837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_052f3c3f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":57},"updated":"2016-12-06 22:44:21.000000000","message":"I didn\u0027t understand this part of the commit message at first, I thought you meant that they still had a logging module, but where not exporting it anymore.\n\nI think it would be clearer to change this part of the message to something like:\n\nTempest removed the oslo-incubator logging module from their code base in March 2015. Our tempest tests were still using it, which was causing import errors.","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a97783e4f7f09ad5c629abe482238d425f56e1a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace tempest logging module with oslo_log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tempest doesn\u0027t support its logging module in master codes. Importing"},{"line_number":10,"context_line":"the module causes import error in blazar\u0027s tempest tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3bb9a832cd9c9c2b4136cb5ce20d06dbb8f2c837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_894dad74","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":57},"in_reply_to":"3a71b18c_052f3c3f","updated":"2016-12-09 10:24:28.000000000","message":"Done","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"}],"contrib/tempest/tempest/resource_reservation_client_manager.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2df0b69b683d0cdbfd3f6b5830ee4688c3736af7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import climateclient.client"},{"line_number":19,"context_line":"from tempest import clients as manager"},{"line_number":20,"context_line":"from tempest import config_resource_reservation as config"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_05b9fccb","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":57},"updated":"2016-12-06 22:44:21.000000000","message":"Looking at other tempest plugins, oslo and tempests imports are generally bundled together (no new line). When grouping them together, please keep the alphabetic order of imports.","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a97783e4f7f09ad5c629abe482238d425f56e1a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import climateclient.client"},{"line_number":19,"context_line":"from tempest import clients as manager"},{"line_number":20,"context_line":"from tempest import config_resource_reservation as config"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_89268db8","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":57},"in_reply_to":"3a71b18c_05b9fccb","updated":"2016-12-09 10:24:28.000000000","message":"Done","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"}],"contrib/tempest/tempest/scenario/resource_reservation_scenario.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2df0b69b683d0cdbfd3f6b5830ee4688c3736af7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config_resource_reservation as config"},{"line_number":19,"context_line":"from tempest import exceptions"},{"line_number":20,"context_line":"from tempest import resource_reservation_client_manager as clients"},{"line_number":21,"context_line":"from tempest.scenario import manager as clientTest"},{"line_number":22,"context_line":"import tempest.test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_c5ac648e","line":22,"range":{"start_line":16,"start_character":0,"end_line":22,"end_character":19},"updated":"2016-12-06 22:44:21.000000000","message":"Looking at other tempest plugins, oslo and tempests imports are generally bundled together (no new line). When grouping them together, please keep the alphabetic order of imports.","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a97783e4f7f09ad5c629abe482238d425f56e1a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_log import log"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config_resource_reservation as config"},{"line_number":19,"context_line":"from tempest import exceptions"},{"line_number":20,"context_line":"from tempest import resource_reservation_client_manager as clients"},{"line_number":21,"context_line":"from tempest.scenario import manager as clientTest"},{"line_number":22,"context_line":"import tempest.test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_09143d42","line":22,"range":{"start_line":16,"start_character":0,"end_line":22,"end_character":19},"in_reply_to":"3a71b18c_c5ac648e","updated":"2016-12-09 10:24:28.000000000","message":"Done","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"}],"contrib/tempest/tempest/scenario/test_resource_reservation.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2df0b69b683d0cdbfd3f6b5830ee4688c3736af7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import dateutil.parser"},{"line_number":21,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_e545e042","line":18,"updated":"2016-12-06 22:44:21.000000000","message":"The oslo_log import should not be with standard library imports, but with dateutil and tempest imports instead.","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a97783e4f7f09ad5c629abe482238d425f56e1a1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import dateutil.parser"},{"line_number":21,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a9026907","line":18,"in_reply_to":"3a71b18c_e545e042","updated":"2016-12-09 10:24:28.000000000","message":"Done","commit_id":"0d7030d115833f89463c26d8231a0372feafa94a"}]}