)]}'
{"climate/cmd/manager.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"aca3987bda1df8c6a5e742048bc2e08badcbe082","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from climate.openstack.common import service"},{"line_number":29,"context_line":"from climate.utils import service as service_utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027climate.config\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_44468224","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":41},"updated":"2017-01-19 10:27:28.000000000","message":"Do you really need this code? host is not used in this file. The same code is already in climate/manager/__init__.py.","commit_id":"3e08499d19b2e436d8806015f91a4b41b01d634b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"25c94ed5730b5fa2c1a4fc98d898ee2f81d7950d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from climate.openstack.common import service"},{"line_number":29,"context_line":"from climate.utils import service as service_utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027climate.config\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_468ecc2e","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":41},"updated":"2017-01-31 12:18:49.000000000","message":"Is this really needed? The same code is in climate/manager/__init__.py where CONF.host is accessed. Or is it for climate/openstack/common/notifier/api.py?","commit_id":"b561748b6839d358feb56b049bb99cdbf40dd580"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"7bc3348fd1f46746392bbaff573fc4f10d71c59f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from climate.openstack.common import service"},{"line_number":29,"context_line":"from climate.utils import service as service_utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027climate.config\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_2ad056c9","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":41},"in_reply_to":"3a461143_468ecc2e","updated":"2017-02-02 04:47:49.000000000","message":"I forgot removal in previous patch. Thanks!","commit_id":"b561748b6839d358feb56b049bb99cdbf40dd580"}],"climate/openstack/common/db/options.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"0e52a3bdb97bbb85b5a06ccfaa5765b106c815ba","unresolved":false,"context_lines":[{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_connection_debug\u0027,"},{"line_number":99,"context_line":"                                                  group\u003d\u0027DEFAULT\u0027)],"},{"line_number":100,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":101,"context_line":"               help\u003d\u0027Verbosity of SQL debugging information. 0\u003dNone, \u0027"},{"line_number":102,"context_line":"                    \u0027100\u003dEverything\u0027),"},{"line_number":103,"context_line":"    cfg.BoolOpt(\u0027connection_trace\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_a8cd9a32","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":43},"updated":"2016-12-16 06:02:04.000000000","message":"Is this change related to the topic of this patch?\nIf not, this would be better being separated from this patch, but OK to be as is, for time saving.","commit_id":"396da4efa23c9f2b6a1924330a0648e0611c8644"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"643621ad27b1fdeb9f6e1f9c3dac746e1f00b1e0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_connection_debug\u0027,"},{"line_number":99,"context_line":"                                                  group\u003d\u0027DEFAULT\u0027)],"},{"line_number":100,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":101,"context_line":"               help\u003d\u0027Verbosity of SQL debugging information. 0\u003dNone, \u0027"},{"line_number":102,"context_line":"                    \u0027100\u003dEverything\u0027),"},{"line_number":103,"context_line":"    cfg.BoolOpt(\u0027connection_trace\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_a1a95292","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":43},"in_reply_to":"1a6eadb0_a8cd9a32","updated":"2017-01-17 08:18:05.000000000","message":"This config is used in openstack/common/db and it\u0027s planed to removed because of migrating oslo.db, so I added the deprecated flag. Now that I\u0027m thinking about it, I should add the flag or remove it when we migrate common/db to oslo.db.\n\nI\u0027ll remove this change in next patch set.","commit_id":"396da4efa23c9f2b6a1924330a0648e0611c8644"}],"climate/openstack/common/db/sqlalchemy/session.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"155bdc13f2e1c9a920ff704dab325a69035c5508","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        \"pool_recycle\": idle_timeout,"},{"line_number":584,"context_line":"        \u0027convert_unicode\u0027: True,"},{"line_number":585,"context_line":"    }"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    logger \u003d logging.getLogger(\u0027sqlalchemy.engine\u0027)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    # Map SQL debug level to Python log level"},{"line_number":590,"context_line":"    if connection_debug \u003e\u003d 100:"},{"line_number":591,"context_line":"        logger.setLevel(logging.DEBUG)"},{"line_number":592,"context_line":"    elif connection_debug \u003e\u003d 50:"},{"line_number":593,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":594,"context_line":"    else:"},{"line_number":595,"context_line":"        logger.setLevel(logging.WARNING)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    if \"sqlite\" in connection_dict.drivername:"},{"line_number":598,"context_line":"        if sqlite_fk:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_121a827d","side":"PARENT","line":595,"range":{"start_line":586,"start_character":0,"end_line":595,"end_character":40},"updated":"2016-12-14 21:07:51.000000000","message":"Shouldn\u0027t this be kept?","commit_id":"a6f728a720334b75c966d5d1646691830fbb9033"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b3ba086e4927561e610e0ca1ebfd75ef81c16e65","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        \"pool_recycle\": idle_timeout,"},{"line_number":584,"context_line":"        \u0027convert_unicode\u0027: True,"},{"line_number":585,"context_line":"    }"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    logger \u003d logging.getLogger(\u0027sqlalchemy.engine\u0027)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    # Map SQL debug level to Python log level"},{"line_number":590,"context_line":"    if connection_debug \u003e\u003d 100:"},{"line_number":591,"context_line":"        logger.setLevel(logging.DEBUG)"},{"line_number":592,"context_line":"    elif connection_debug \u003e\u003d 50:"},{"line_number":593,"context_line":"        logger.setLevel(logging.INFO)"},{"line_number":594,"context_line":"    else:"},{"line_number":595,"context_line":"        logger.setLevel(logging.WARNING)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    if \"sqlite\" in connection_dict.drivername:"},{"line_number":598,"context_line":"        if sqlite_fk:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_17db3ded","side":"PARENT","line":595,"range":{"start_line":586,"start_character":0,"end_line":595,"end_character":40},"in_reply_to":"1a6eadb0_121a827d","updated":"2016-12-15 09:24:24.000000000","message":"Default logging level in oslo.log is WARN [1] and default connection_debug is \u00270\u0027 meaning WARNING. And this code would be removed by Ocata release since oslo.db takes over this codes. So I thought we don\u0027t need to keep it here and it cause some errors.\n\nHow do you think? If needed, I will resurrect it.\n\n1. https://github.com/openstack/oslo.log/blob/master/oslo_log/_options.py#L20","commit_id":"a6f728a720334b75c966d5d1646691830fbb9033"}],"climate/utils/service.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"155bdc13f2e1c9a920ff704dab325a69035c5508","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":100,"context_line":"                                         \u0027eventlet.wsgi.server\u003dWARN\u0027"},{"line_number":101,"context_line":"                                         ])"},{"line_number":102,"context_line":"    cfg.CONF(argv[1:], project\u003d\u0027climate\u0027)"},{"line_number":103,"context_line":"    logging.setup(\u0027climate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_1d7613a4","side":"PARENT","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":41},"updated":"2016-12-14 21:07:51.000000000","message":"This line was removed, is it still behaving the same without?","commit_id":"a6f728a720334b75c966d5d1646691830fbb9033"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b3ba086e4927561e610e0ca1ebfd75ef81c16e65","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":100,"context_line":"                                         \u0027eventlet.wsgi.server\u003dWARN\u0027"},{"line_number":101,"context_line":"                                         ])"},{"line_number":102,"context_line":"    cfg.CONF(argv[1:], project\u003d\u0027climate\u0027)"},{"line_number":103,"context_line":"    logging.setup(\u0027climate\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_3792f9f6","side":"PARENT","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":41},"in_reply_to":"1a6eadb0_1d7613a4","updated":"2016-12-15 09:24:24.000000000","message":"Same codes are executed in cmd/api.py or cmd/manager.py","commit_id":"a6f728a720334b75c966d5d1646691830fbb9033"}]}