)]}'
{"climate/policy.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"33d5a28766873cc74edd4f5f1c7c58aa77592fcf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from climate import exceptions"},{"line_number":26,"context_line":"from climate.i18n import _"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"policy_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027policy_file\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027policy.json\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\u0027JSON file containing policy\u0027)),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027policy_default_rule\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027default\u0027,"},{"line_number":34,"context_line":"               help\u003d_(\u0027Rule enforced when requested rule is not found\u0027)),"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":"CONF.register_opts(policy_opts)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a430d35_8fd495bd","line":35,"range":{"start_line":28,"start_character":0,"end_line":35,"end_character":1},"updated":"2017-02-07 07:31:21.000000000","message":"Other OpenStack projects don\u0027t define these, as they are already defined by oslo.policy.","commit_id":"1a3fa429ca8474b81789927c33ced83cc7038d49"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"17b7b60769383cda71b3ecab4df73bcfdec48684","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from climate import exceptions"},{"line_number":26,"context_line":"from climate.i18n import _"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"policy_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt(\u0027policy_file\u0027,"},{"line_number":30,"context_line":"               default\u003d\u0027policy.json\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\u0027JSON file containing policy\u0027)),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027policy_default_rule\u0027,"},{"line_number":33,"context_line":"               default\u003d\u0027default\u0027,"},{"line_number":34,"context_line":"               help\u003d_(\u0027Rule enforced when requested rule is not found\u0027)),"},{"line_number":35,"context_line":"]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":"CONF.register_opts(policy_opts)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a430d35_d3747f69","line":35,"range":{"start_line":28,"start_character":0,"end_line":35,"end_character":1},"in_reply_to":"1a430d35_8fd495bd","updated":"2017-02-07 11:01:03.000000000","message":"Done","commit_id":"1a3fa429ca8474b81789927c33ced83cc7038d49"}],"climate/tests/test_policy.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"3e704dcf2df9f9b2b3f57e002f2db8e06489f33a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d cfg.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class DefaultPolicyTestCase(tests.TestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(DefaultPolicyTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_1673c04e","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":44},"updated":"2017-02-02 07:38:28.000000000","message":"Do we need to remain this test class?  This class tests climate.openstack.common.policy.Enforcer class that\u0027s replaced with oslo_policy.Enforcer class.  Of course, there is no problem that it tests the class in oslo_policy, but seemed to be unnecessary.\n\nHow do you think?","commit_id":"cf2f8012c52998e78c436a3d043b0a1b44e14362"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"85e49822d32ff24a6ce18789add3dc9796c2e4c8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"CONF \u003d cfg.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class DefaultPolicyTestCase(tests.TestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(DefaultPolicyTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_9939a344","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":44},"in_reply_to":"3a461143_1673c04e","updated":"2017-02-02 08:25:03.000000000","message":"I completely agree with you. It\u0027s not needed to test the class in oslo_policy. I have deleted this class.","commit_id":"cf2f8012c52998e78c436a3d043b0a1b44e14362"}]}