)]}'
{"blazar/plugins/oshosts/__init__.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"f1743175d595c19aeda8cf7d206fee162b52bc92","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               help\u003d\u0027Project domain name of the account for admin operations\u0027),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cfg.CONF.register_opts(admin_opts, group\u003dRESOURCE_TYPE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_4e5bbe2e","line":38,"range":{"start_line":38,"start_character":41,"end_line":38,"end_character":54},"updated":"2017-03-08 06:15:31.000000000","message":"I noticed the strange thing here is one plugin represents one resource, not one project.  I was worried about when we have another resource plugin for Nova, instance or keypairs, we need to copy and paste all the config to each sections.\n\nAnyway, now that I\u0027m thinking about it capsuling the config here is a reasonable way to 0.2.0.","commit_id":"6f3ee51a785f09706ac4ec0f10826a68efb03525"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dffdce48fc48d543b006ad0b50b9d63355c9e87b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        super(PhysicalHostPlugin, self).__init__("},{"line_number":58,"context_line":"            username\u003dCONF.os_admin_username,"},{"line_number":59,"context_line":"            password\u003dCONF.os_admin_password,"},{"line_number":60,"context_line":"            user_domain_name\u003d\u0027Default\u0027,"},{"line_number":61,"context_line":"            project_name\u003dCONF.os_admin_project_name,"},{"line_number":62,"context_line":"            project_domain_name\u003d\u0027Default\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def create_reservation(self, values):"},{"line_number":65,"context_line":"        \"\"\"Create reservation.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_8434124c","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":41},"updated":"2017-03-31 08:23:52.000000000","message":"Why the domain name is hardcoaded with \u0027Default\u0027?  It\u0027s a default value in devstack[1] and a configurable domain in keystone[2].\n\n1. https://github.com/openstack-dev/devstack/blob/master/lib/keystone#L107\n2. https://github.com/openstack/keystone/blob/master/keystone/conf/identity.py#L19","commit_id":"66827f55d2c96ee2f86ed3a5bbd87add266dce0a"}],"blazar/utils/openstack/nova.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"bb7a37a9d54878d5bb01bedfb229f7a9a532e2e5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def __init__(self, **kwargs):"},{"line_number":46,"context_line":"        \"\"\"Description"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        ClimateNovaClient can be used in two ways: from context or kwargs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        :param version: service client version which we will use"},{"line_number":51,"context_line":"        :type version: str"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_12a331b4","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":25},"updated":"2017-03-28 02:39:07.000000000","message":"s/Blazar/Climate/","commit_id":"bebdc4a60febd2627864d54d4b5eca7189011404"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"290b553fe1f172533d0f75af8d117ed90c7315d5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def __init__(self, **kwargs):"},{"line_number":46,"context_line":"        \"\"\"Description"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        ClimateNovaClient can be used in two ways: from context or kwargs."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        :param version: service client version which we will use"},{"line_number":51,"context_line":"        :type version: str"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_521f79b6","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":25},"in_reply_to":"ffe62b97_12a331b4","updated":"2017-03-28 02:40:50.000000000","message":"Done","commit_id":"bebdc4a60febd2627864d54d4b5eca7189011404"}],"climate/plugins/oshosts/__init__.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RESOURCE_TYPE \u003d u\u0027physical:host\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_45c026e1","line":19,"updated":"2017-02-28 07:01:47.000000000","message":"Why isn\u0027t the config defined in utils/openstack/nova.py?","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RESOURCE_TYPE \u003d u\u0027physical:host\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_922b5994","line":19,"in_reply_to":"ba2be162_03bb96c5","updated":"2017-03-07 18:53:11.000000000","message":"Actually, it is because this is code specifically for the physical host plugin. The Nova client wrapper is more generic and doesn\u0027t have to know about Blazar configuration. These values could eventually be used to call other services than Nova. Keeping this code here also has the advantage of not changing the configuration file.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"859bbab865a575036c3703b87d246f01bc82187a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RESOURCE_TYPE \u003d u\u0027physical:host\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_03bb96c5","line":19,"in_reply_to":"da36d5c6_45c026e1","updated":"2017-02-28 20:34:58.000000000","message":"It was like this in the original code, but good point, I will move it.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_e5f03acc","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":36},"updated":"2017-02-28 07:01:47.000000000","message":"Where is the origin of the default value? If it comes from default value of default value[1], it needs to be \u0027blazar\u0027.\n\n1. https://github.com/openstack/blazar/blob/master/devstack/settings#L12","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_7e05a7c0","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":36},"in_reply_to":"ba2be162_e3dcc21a","updated":"2017-03-07 18:53:11.000000000","message":"Done","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"859bbab865a575036c3703b87d246f01bc82187a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_e3dcc21a","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":36},"in_reply_to":"da36d5c6_e5f03acc","updated":"2017-02-28 20:34:58.000000000","message":"This is from the original code, see this commit: http://git.openstack.org/cgit/openstack/blazar/commit/?id\u003d16d5f67ba7020701edbbf09a747f5683b0840c21\n\nI was thinking of updating DevStack separately to create this user, but I can include it in this patch.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027Password of the user for write operations\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_a5948244","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":58},"updated":"2017-02-28 07:01:47.000000000","message":"IMO, \u0027write operations\u0027 looks sbstract for the config help message.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027Password of the user for write operations\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_be0f1fe0","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":58},"in_reply_to":"ba2be162_23e7bae5","updated":"2017-03-07 18:53:11.000000000","message":"Done","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"859bbab865a575036c3703b87d246f01bc82187a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"admin_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027blazar_username\u0027,"},{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027Password of the user for write operations\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_23e7bae5","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":58},"in_reply_to":"da36d5c6_a5948244","updated":"2017-02-28 20:34:58.000000000","message":"OK I will improve.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               default\u003d\u0027blazar_admin\u0027,"},{"line_number":23,"context_line":"               help\u003d\u0027Name of the user for write operations\u0027),"},{"line_number":24,"context_line":"    cfg.StrOpt(\u0027blazar_password\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027blazar_password\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027Password of the user for write operations\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027blazar_user_domain_name\u0027,"},{"line_number":28,"context_line":"               default\u003d\u0027Default\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_45be66d5","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":39},"updated":"2017-02-28 07:01:47.000000000","message":"same as above.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"}],"climate/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Used by nova client"},{"line_number":61,"context_line":"        config \u003d CONF[plugin.RESOURCE_TYPE]"},{"line_number":62,"context_line":"        self.username \u003d config.blazar_username"},{"line_number":63,"context_line":"        self.password \u003d config.blazar_password"},{"line_number":64,"context_line":"        self.user_domain_name \u003d config.blazar_user_domain_name"},{"line_number":65,"context_line":"        self.project_name \u003d config.blazar_project_name"},{"line_number":66,"context_line":"        self.project_domain_name \u003d config.blazar_project_domain_name"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_reservation(self, values):"},{"line_number":69,"context_line":"        \"\"\"Create reservation.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_45674625","line":66,"range":{"start_line":62,"start_character":0,"end_line":66,"end_character":68},"updated":"2017-02-28 07:01:47.000000000","message":"It\u0027s better to pass these configs to NovaClientWrapper class as arguments of __init__(). same for climate/plugins/oshosts/nova_inventory.py and climate/plugins/oshosts/reservation_pool.py.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Used by nova client"},{"line_number":61,"context_line":"        config \u003d CONF[plugin.RESOURCE_TYPE]"},{"line_number":62,"context_line":"        self.username \u003d config.blazar_username"},{"line_number":63,"context_line":"        self.password \u003d config.blazar_password"},{"line_number":64,"context_line":"        self.user_domain_name \u003d config.blazar_user_domain_name"},{"line_number":65,"context_line":"        self.project_name \u003d config.blazar_project_name"},{"line_number":66,"context_line":"        self.project_domain_name \u003d config.blazar_project_domain_name"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def create_reservation(self, values):"},{"line_number":69,"context_line":"        \"\"\"Create reservation.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_5e5383e1","line":66,"range":{"start_line":62,"start_character":0,"end_line":66,"end_character":68},"in_reply_to":"da36d5c6_45674625","updated":"2017-03-07 18:53:11.000000000","message":"Done","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"}],"climate/utils/openstack/nova.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class NovaClientWrapper(object):"},{"line_number":159,"context_line":"    def __init__(self):"},{"line_number":160,"context_line":"        self.username \u003d None"},{"line_number":161,"context_line":"        self.password \u003d None"},{"line_number":162,"context_line":"        self.project_name \u003d None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @property"},{"line_number":165,"context_line":"    def nova(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_85d5beba","line":162,"range":{"start_line":159,"start_character":16,"end_line":162,"end_character":32},"updated":"2017-02-28 07:01:47.000000000","message":"It\u0027s better to define the variables as argument of __init__() with a default value. Developers can understand subclass of this class need to have these instance variables.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"class NovaClientWrapper(object):"},{"line_number":159,"context_line":"    def __init__(self):"},{"line_number":160,"context_line":"        self.username \u003d None"},{"line_number":161,"context_line":"        self.password \u003d None"},{"line_number":162,"context_line":"        self.project_name \u003d None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @property"},{"line_number":165,"context_line":"    def nova(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_fedd1771","line":162,"range":{"start_line":159,"start_character":16,"end_line":162,"end_character":32},"in_reply_to":"da36d5c6_85d5beba","updated":"2017-03-07 18:53:11.000000000","message":"Done","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        nova \u003d ClimateNovaClient(ctx\u003dctx,"},{"line_number":168,"context_line":"                                 username\u003dself.username,"},{"line_number":169,"context_line":"                                 password\u003dself.password,"},{"line_number":170,"context_line":"                                 user_domain_name\u003dself.user_domain_name,"},{"line_number":171,"context_line":"                                 project_name\u003dself.project_name,"},{"line_number":172,"context_line":"                                 project_domain_name\u003dself.project_domain_name)"},{"line_number":173,"context_line":"        return nova"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_a56c8237","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":72},"updated":"2017-02-28 07:01:47.000000000","message":"If the warpper class wants to have user_domain_name and project_domain_name as an instance variable, the two vars are needed to define in __init__(). Because subclass of this class couldn\u0027t find out the vars are required.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        nova \u003d ClimateNovaClient(ctx\u003dctx,"},{"line_number":168,"context_line":"                                 username\u003dself.username,"},{"line_number":169,"context_line":"                                 password\u003dself.password,"},{"line_number":170,"context_line":"                                 user_domain_name\u003dself.user_domain_name,"},{"line_number":171,"context_line":"                                 project_name\u003dself.project_name,"},{"line_number":172,"context_line":"                                 project_domain_name\u003dself.project_domain_name)"},{"line_number":173,"context_line":"        return nova"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_5ee54335","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":72},"in_reply_to":"da36d5c6_a56c8237","updated":"2017-03-07 18:53:11.000000000","message":"Done","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"}],"devstack/plugin.sh":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_username $BLAZAR_USER_NAME"},{"line_number":61,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_password $SERVICE_PASSWORD"},{"line_number":62,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_user_domain_name \"Default\""},{"line_number":63,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_name $SERVICE_TENANT_NAME"},{"line_number":64,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_domain_name \"Default\""},{"line_number":65,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host aggregate_freepool_name $BLAZAR_FREEPOOL_NAME"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da36d5c6_656c4a09","line":62,"range":{"start_line":62,"start_character":67,"end_line":62,"end_character":76},"updated":"2017-02-28 07:01:47.000000000","message":"devstack has the config in stackrc. we should use it.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_username $BLAZAR_USER_NAME"},{"line_number":61,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_password $SERVICE_PASSWORD"},{"line_number":62,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_user_domain_name \"Default\""},{"line_number":63,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_name $SERVICE_TENANT_NAME"},{"line_number":64,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_domain_name \"Default\""},{"line_number":65,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host aggregate_freepool_name $BLAZAR_FREEPOOL_NAME"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a30ddce_5ebc6305","line":62,"range":{"start_line":62,"start_character":67,"end_line":62,"end_character":76},"in_reply_to":"da36d5c6_656c4a09","updated":"2017-03-07 18:53:11.000000000","message":"I could find a default value for the domain ID, but not for domain name. Other services using domain name also hardcode \"Default\".","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"9d4572c1b238b40f6f82fc8129ff80c9fe1ad24a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_password $SERVICE_PASSWORD"},{"line_number":62,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_user_domain_name \"Default\""},{"line_number":63,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_name $SERVICE_TENANT_NAME"},{"line_number":64,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_domain_name \"Default\""},{"line_number":65,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host aggregate_freepool_name $BLAZAR_FREEPOOL_NAME"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT host $HOST_IP"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da36d5c6_85713ee3","line":64,"range":{"start_line":64,"start_character":70,"end_line":64,"end_character":79},"updated":"2017-02-28 07:01:47.000000000","message":"same as above.","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3fb3438cf4e4ec3f5c75406a6c2308d4037608f0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_password $SERVICE_PASSWORD"},{"line_number":62,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_user_domain_name \"Default\""},{"line_number":63,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_name $SERVICE_TENANT_NAME"},{"line_number":64,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_domain_name \"Default\""},{"line_number":65,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host aggregate_freepool_name $BLAZAR_FREEPOOL_NAME"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT host $HOST_IP"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a30ddce_9e3c1b95","line":64,"range":{"start_line":64,"start_character":70,"end_line":64,"end_character":79},"in_reply_to":"da36d5c6_85713ee3","updated":"2017-03-07 18:53:11.000000000","message":"I could find a default value for the domain ID, but not for domain name. Other services using domain name also hardcode \"Default\".","commit_id":"1f2dc84b2152db0a00b04b4d266440a40c25cb46"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"f1743175d595c19aeda8cf7d206fee162b52bc92","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_username $BLAZAR_USER_NAME"},{"line_number":61,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_password $SERVICE_PASSWORD"},{"line_number":62,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_user_domain_name \"Default\""},{"line_number":63,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_name $SERVICE_TENANT_NAME"},{"line_number":64,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_domain_name \"Default\""},{"line_number":65,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host aggregate_freepool_name $BLAZAR_FREEPOOL_NAME"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_3b36ca52","line":62,"range":{"start_line":62,"start_character":67,"end_line":62,"end_character":76},"updated":"2017-03-08 06:15:31.000000000","message":"SERVICE_DOMAIN_NAME is used for the config[1].\n\n1. https://github.com/openstack-dev/devstack/blob/master/lib/keystone#L107","commit_id":"6f3ee51a785f09706ac4ec0f10826a68efb03525"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8d092d5c8e644fdc9ee1069c6498e0511c5d24a2","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_username $BLAZAR_USER_NAME"},{"line_number":61,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_password $SERVICE_PASSWORD"},{"line_number":62,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_user_domain_name \"Default\""},{"line_number":63,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_name $SERVICE_TENANT_NAME"},{"line_number":64,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host blazar_project_domain_name \"Default\""},{"line_number":65,"context_line":"    iniset $BLAZAR_CONF_FILE physical:host aggregate_freepool_name $BLAZAR_FREEPOOL_NAME"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_0a319205","line":62,"range":{"start_line":62,"start_character":67,"end_line":62,"end_character":76},"in_reply_to":"9a30ddce_3b36ca52","updated":"2017-03-08 22:21:41.000000000","message":"I didn\u0027t notice that, thanks!","commit_id":"6f3ee51a785f09706ac4ec0f10826a68efb03525"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"a8ac98040e4b6cb3573dbeac665a8fc738b63293","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"$SERVICE_PASSWORD\" \"default\" \"blazar@example.com\")"},{"line_number":119,"context_line":"    get_or_add_user_project_role $ADMIN_ROLE $BLAZAR_USER_ID $SERVICE_TENANT"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    BLAZAR_ADMIN_USER_ID\u003d$(get_or_create_user $BLAZAR_USER_NAME \\"},{"line_number":122,"context_line":"        \"$SERVICE_PASSWORD\" \"default\" \"blazar@example.com\")"},{"line_number":123,"context_line":"    get_or_add_user_project_role $ADMIN_ROLE $BLAZAR_ADMIN_USER_ID $SERVICE_TENANT"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    BLAZAR_SERVICE\u003d$(get_or_create_service \"blazar\" \\"},{"line_number":126,"context_line":"        \"reservation\" \"Blazar Reservations Service\")"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_dec76110","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":82},"updated":"2017-03-08 02:54:53.000000000","message":"Why do you create a new user \u0027blazar_admin\u0027?\nThe user \u0027blazar\u0027 has an admin role so that he can be used for physical:host operations.","commit_id":"6f3ee51a785f09706ac4ec0f10826a68efb03525"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"f1743175d595c19aeda8cf7d206fee162b52bc92","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"$SERVICE_PASSWORD\" \"default\" \"blazar@example.com\")"},{"line_number":119,"context_line":"    get_or_add_user_project_role $ADMIN_ROLE $BLAZAR_USER_ID $SERVICE_TENANT"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    BLAZAR_ADMIN_USER_ID\u003d$(get_or_create_user $BLAZAR_USER_NAME \\"},{"line_number":122,"context_line":"        \"$SERVICE_PASSWORD\" \"default\" \"blazar@example.com\")"},{"line_number":123,"context_line":"    get_or_add_user_project_role $ADMIN_ROLE $BLAZAR_ADMIN_USER_ID $SERVICE_TENANT"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    BLAZAR_SERVICE\u003d$(get_or_create_service \"blazar\" \\"},{"line_number":126,"context_line":"        \"reservation\" \"Blazar Reservations Service\")"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a30ddce_5be1befd","line":123,"range":{"start_line":121,"start_character":0,"end_line":123,"end_character":82},"in_reply_to":"9a30ddce_dec76110","updated":"2017-03-08 06:15:31.000000000","message":"I agree Hiroaki. \u0027blazar\u0027 user is enough to do this.","commit_id":"6f3ee51a785f09706ac4ec0f10826a68efb03525"}]}
