)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"36910c68f287c0b1aa3f1bde4bab367c9531c61d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-04-27 11:30:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change keystone_authtoken configs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c8728593ecf503b23d742a5f464af8a2a6e5253"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5ff73747_5a11bd5c","line":8,"updated":"2017-04-27 17:47:59.000000000","message":"It\u0027s better to describe what the patch changes as details.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"19888b1dd84d60e0d6d70e16793611aecb39963e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-04-27 11:30:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change keystone_authtoken configs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7c8728593ecf503b23d742a5f464af8a2a6e5253"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5ff73747_a1a75fbd","line":8,"in_reply_to":"5ff73747_5a11bd5c","updated":"2017-04-28 10:45:22.000000000","message":"I\u0027ve added details","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"}],"blazar/config.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"36910c68f287c0b1aa3f1bde4bab367c9531c61d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                     \u0027headers and bodies\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027os_auth_protocol\u0027,"},{"line_number":35,"context_line":"               default\u003d\u0027http\u0027,"},{"line_number":36,"context_line":"               help\u003d\u0027Protocol used to access OpenStack Identity service\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_3a595134","line":33,"updated":"2017-04-27 17:47:59.000000000","message":"why only 2 configs, os_auth_port and os_auth_version, are marked as deprecated?  I thought all of the 8 configs defined here is deprecated since the configs move to keystone_authtoken section as you removed all config generations from plugin.sh .","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"19888b1dd84d60e0d6d70e16793611aecb39963e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                     \u0027headers and bodies\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os_opts \u003d ["},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027os_auth_protocol\u0027,"},{"line_number":35,"context_line":"               default\u003d\u0027http\u0027,"},{"line_number":36,"context_line":"               help\u003d\u0027Protocol used to access OpenStack Identity service\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_c1902b46","line":33,"in_reply_to":"5ff73747_3a595134","updated":"2017-04-28 10:45:22.000000000","message":"os_auth_protocol and os_auth_host are also no more used and so I deprecated them too. However, os_admin_username, os_admin_password and os_admin_project_name are still needed because these value is used to get trusts by using keystoneclient.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"36910c68f287c0b1aa3f1bde4bab367c9531c61d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027os_auth_port\u0027,"},{"line_number":42,"context_line":"               default\u003d\u002735357\u0027,"},{"line_number":43,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":44,"context_line":"               deprecated_reason\u003d\u0027No longer used\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Port of OpenStack Identity service\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027This OpenStack user is used to verify provided tokens. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_57a8788a","line":45,"range":{"start_line":44,"start_character":15,"end_line":45,"end_character":56},"updated":"2017-04-27 17:47:59.000000000","message":"deprecated_reason should describe why the config value is deprecated.  In this case, \"the definition of this config moves under keystone_authtoken section\" or something.\n\nAdditionally, it\u0027s better to write the fact in help that the config value is ignored even if user defines this value.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"19888b1dd84d60e0d6d70e16793611aecb39963e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027os_auth_port\u0027,"},{"line_number":42,"context_line":"               default\u003d\u002735357\u0027,"},{"line_number":43,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":44,"context_line":"               deprecated_reason\u003d\u0027No longer used\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Port of OpenStack Identity service\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027This OpenStack user is used to verify provided tokens. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_c1b94bcc","line":45,"range":{"start_line":44,"start_character":15,"end_line":45,"end_character":56},"in_reply_to":"5ff73747_57a8788a","updated":"2017-04-28 10:45:22.000000000","message":"Done","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"36910c68f287c0b1aa3f1bde4bab367c9531c61d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"               help\u003d\u0027Name of project where the user is admin\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027v2.0\u0027,"},{"line_number":59,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":60,"context_line":"               deprecated_reason\u003d\u0027No longer used\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using.\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_978ba01d","line":60,"range":{"start_line":59,"start_character":15,"end_line":60,"end_character":50},"updated":"2017-04-27 17:47:59.000000000","message":"same as above.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"19888b1dd84d60e0d6d70e16793611aecb39963e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"               help\u003d\u0027Name of project where the user is admin\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027v2.0\u0027,"},{"line_number":59,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":60,"context_line":"               deprecated_reason\u003d\u0027No longer used\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using.\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_81afc37b","line":60,"range":{"start_line":59,"start_character":15,"end_line":60,"end_character":50},"in_reply_to":"5ff73747_978ba01d","updated":"2017-04-28 10:45:22.000000000","message":"Done","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"36910c68f287c0b1aa3f1bde4bab367c9531c61d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":60,"context_line":"               deprecated_reason\u003d\u0027No longer used\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using.\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027URI of OpenStack Identity service.\u0027),"},{"line_number":65,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_3a115105","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":29},"updated":"2017-04-27 17:47:59.000000000","message":"I\u0027m not sure why the config is newly introduced. same config is defined in keystone_authtoken section.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"19888b1dd84d60e0d6d70e16793611aecb39963e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":60,"context_line":"               deprecated_reason\u003d\u0027No longer used\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using.\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027URI of OpenStack Identity service.\u0027),"},{"line_number":65,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_e1de87d8","line":62,"range":{"start_line":62,"start_character":15,"end_line":62,"end_character":29},"in_reply_to":"5ff73747_3a115105","updated":"2017-04-28 10:45:22.000000000","message":"This value is needed to get trasts by using keystoneclient and is not for authentification of keystonemiddleware. We cannot use keystone_authtoken.auth_uri configs because blazar-managar does not load keystonemiddleware and cannot access configs of [keystone_authtoken] section. Therefore, auth_uri is needed in [Default] section.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt(\u0027os_auth_protocol\u0027,"},{"line_number":35,"context_line":"               default\u003d\u0027http\u0027,"},{"line_number":36,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":37,"context_line":"               deprecated_reason\u003d\u0027The definition of this value is moved to \u0027"},{"line_number":38,"context_line":"                                 \u0027[keystone_authtoken] section and this value \u0027"},{"line_number":39,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Protocol used to access OpenStack Identity service. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_4b6c169b","line":37,"range":{"start_line":37,"start_character":34,"end_line":37,"end_character":62},"updated":"2017-04-30 15:06:14.000000000","message":"s/The definition of this value/This config/","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt(\u0027os_auth_protocol\u0027,"},{"line_number":35,"context_line":"               default\u003d\u0027http\u0027,"},{"line_number":36,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":37,"context_line":"               deprecated_reason\u003d\u0027The definition of this value is moved to \u0027"},{"line_number":38,"context_line":"                                 \u0027[keystone_authtoken] section and this value \u0027"},{"line_number":39,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Protocol used to access OpenStack Identity service. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_0b24b75c","line":37,"range":{"start_line":37,"start_character":34,"end_line":37,"end_character":62},"in_reply_to":"5ff73747_4b6c169b","updated":"2017-05-02 02:44:18.000000000","message":"Done","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":57,"context_line":"               help\u003d\u0027Port of OpenStack Identity service. This value is \u0027"},{"line_number":58,"context_line":"                    \u0027deprecated and ignored even if defined.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027This OpenStack user is used to treat trusts. \u0027"},{"line_number":62,"context_line":"                    \u0027The user must have admin role in \u003cos_admin_project_name\u003e \u0027"},{"line_number":63,"context_line":"                    \u0027project.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027os_admin_password\u0027,"},{"line_number":65,"context_line":"               default\u003d\u0027blazar\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Password of the admin user to treat trusts.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027os_admin_project_name\u0027,"},{"line_number":68,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":69,"context_line":"               help\u003d\u0027Name of project where the user is admin. \u0027"},{"line_number":70,"context_line":"                    \u0027This value is used to treat trusts.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"},{"line_number":72,"context_line":"               default\u003d\u0027v2.0\u0027,"},{"line_number":73,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_2bd42ae8","line":70,"range":{"start_line":59,"start_character":1,"end_line":70,"end_character":59},"updated":"2017-04-30 15:06:14.000000000","message":"The configs in keystone_authtoken section can be accessed by importing the group like following. \n\n    cfg.CONF.import_group(\u0027keystone_authtoken\u0027, \u0027keystonemiddleware.auth_token\u0027)\n\nhttps://docs.openstack.org/developer/oslo.config/configopts.html#oslo_config.cfg.ConfigOpts.import_group","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":57,"context_line":"               help\u003d\u0027Port of OpenStack Identity service. This value is \u0027"},{"line_number":58,"context_line":"                    \u0027deprecated and ignored even if defined.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027This OpenStack user is used to treat trusts. \u0027"},{"line_number":62,"context_line":"                    \u0027The user must have admin role in \u003cos_admin_project_name\u003e \u0027"},{"line_number":63,"context_line":"                    \u0027project.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027os_admin_password\u0027,"},{"line_number":65,"context_line":"               default\u003d\u0027blazar\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Password of the admin user to treat trusts.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027os_admin_project_name\u0027,"},{"line_number":68,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":69,"context_line":"               help\u003d\u0027Name of project where the user is admin. \u0027"},{"line_number":70,"context_line":"                    \u0027This value is used to treat trusts.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"},{"line_number":72,"context_line":"               default\u003d\u0027v2.0\u0027,"},{"line_number":73,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_cbfb6f44","line":70,"range":{"start_line":59,"start_character":1,"end_line":70,"end_character":59},"in_reply_to":"5ff73747_2bd42ae8","updated":"2017-05-02 02:44:18.000000000","message":"As you mentioned, we can use configs in keystone_authtoken section by using cfg.CONF.import_group. However, username and password are option configs for \"password auth plugin\" of keystonemiddleware and these values can\u0027t be loaded simply by using cfg.CONF.import_group. We can access these value by using keystoneauth1.loading.get_auth_plugin_conf_options(\u0027password\u0027), but IMO we should not use these value to access keystoneclient in Blazar because these configs may not defined depending on auth plugins and so I leave these values (e.g. if auth_type\u003dtoken, username and password are not required for keystonemiddleware.auth_token). I think Blazar should use same authentification method in keystonemiddleware.auth_token and keystoneclient but these changes are out of scope of this patch.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               deprecated_reason\u003d\u0027The definition of this value is moved to \u0027"},{"line_number":75,"context_line":"                                 \u0027[keystone_authtoken] section and this value \u0027"},{"line_number":76,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":77,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using. This value is \u0027"},{"line_number":78,"context_line":"                    \u0027deprecated and ignored even if defined.\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":80,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_4bf2d69b","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":23},"updated":"2017-04-30 15:06:14.000000000","message":"s/We/Blazar/","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               deprecated_reason\u003d\u0027The definition of this value is moved to \u0027"},{"line_number":75,"context_line":"                                 \u0027[keystone_authtoken] section and this value \u0027"},{"line_number":76,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":77,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using. This value is \u0027"},{"line_number":78,"context_line":"                    \u0027deprecated and ignored even if defined.\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":80,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_8bc0c7e2","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":23},"in_reply_to":"5ff73747_4bf2d69b","updated":"2017-05-02 02:44:18.000000000","message":"Done","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":77,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using. This value is \u0027"},{"line_number":78,"context_line":"                    \u0027deprecated and ignored even if defined.\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":80,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":81,"context_line":"               help\u003d\u0027URI of OpenStack Identity service to treat trusts.\u0027),"},{"line_number":82,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_8bfc5e70","line":79,"range":{"start_line":79,"start_character":15,"end_line":79,"end_character":28},"updated":"2017-04-30 15:06:14.000000000","message":"we can use configs in keystone_authtoken section as described above. The value isn\u0027t needed.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                 \u0027is no longer used.\u0027,"},{"line_number":77,"context_line":"               help\u003d\u0027We use API v3 to allow trusts using. This value is \u0027"},{"line_number":78,"context_line":"                    \u0027deprecated and ignored even if defined.\u0027),"},{"line_number":79,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":80,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":81,"context_line":"               help\u003d\u0027URI of OpenStack Identity service to treat trusts.\u0027),"},{"line_number":82,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_ab526333","line":79,"range":{"start_line":79,"start_character":15,"end_line":79,"end_character":28},"in_reply_to":"5ff73747_8bfc5e70","updated":"2017-05-02 02:44:18.000000000","message":"Done","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"622d7abf259c5ce019ee86cb38148e193f12eb5e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Name of project where the user is admin. \u0027"},{"line_number":67,"context_line":"                    \u0027This value is used to treat trusts.\u0027),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027URI of OpenStack Identity service to treat trusts.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_8c01fd07","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":27},"updated":"2017-05-02 05:04:48.000000000","message":"On second thoughts, Blazar still needs their own auth_uri definition because auth_uri and auth_url in keystone_authtoken section are also optional and may not be defined depending on auth plugins. So I\u0027ve re-added this config.","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"5349a8c2da2095fd792a227f5170d3358b88679a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Name of project where the user is admin. \u0027"},{"line_number":67,"context_line":"                    \u0027This value is used to treat trusts.\u0027),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027URI of OpenStack Identity service to treat trusts.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_3a309a56","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":27},"in_reply_to":"3f044301_8b7a52ee","updated":"2017-05-16 08:31:14.000000000","message":"First of all, I\u0027ve wrote incorrect help messages. Depricated confs in the previous patch are replaced with auth_url instead of being moved to [keystone_authtoken] section. Maybe this mistake caused gaps between our opinions.\n\nThe main point here is that blazar should support auth url with prefixes such as \"http://127.0.0.1/identity\" and to do so, I think adding \"os_auth_prefix\" conf in blazar is better than adding \"os_auth_uri\" from the viewpoint of backward compatibility. So I\u0027ve added \"os_auth_prefix\", reuse other \"os_\" confs and removed \"os_auth_uri\" in next patch.","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a790ed7d285c51682e57f9eef0440f6b1dffcebd","unresolved":false,"context_lines":[{"line_number":65,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Name of project where the user is admin. \u0027"},{"line_number":67,"context_line":"                    \u0027This value is used to treat trusts.\u0027),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027os_auth_uri\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027http://127.0.0.1:5000\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027URI of OpenStack Identity service to treat trusts.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027os_auth_version\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_8b7a52ee","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":27},"in_reply_to":"5ff73747_8c01fd07","updated":"2017-05-11 21:27:35.000000000","message":"I\u0027m still unclear the new config value is required.  trusts.py uses this config value instead of generating auth_url from os_auth_protocol, os_auth_host and os_auth_port.  The help messages of the three config say \u0027this config is moved to [keystone_authtoken] section\u0027 but same values are written in os_auth_uri.\n\nAs a default behavior of oslo config, it uses a default value for the optional config if the config is not overwritten by a config file.\n\nAdditionally, you said its depending on auth plugin type, but this patch requires keystone service must support password auth since this patch uses password strategy by defining os_admin_password and etc. I think it means password auth plugin would be used in keystone_authtoken and the plugin has definition of auth_url in it, right?","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"fd9affb767c5d02cbc09b94c60977e5fd795e273","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027os_auth_port\u0027,"},{"line_number":42,"context_line":"               default\u003d\u002735357\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Port of OpenStack Identity service.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027os_auth_prefix\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Prefix of URL to access OpenStack Identity service.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_1d8398ce","line":44,"range":{"start_line":44,"start_character":24,"end_line":44,"end_character":30},"updated":"2017-05-16 08:59:23.000000000","message":"postfix?","commit_id":"8706c8b7fcd93ef159c5f20e054c782cfcc5481d"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"b6361fbcb01bc4f4fb8dbfdc964d66e5d1060493","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027os_auth_port\u0027,"},{"line_number":42,"context_line":"               default\u003d\u002735357\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Port of OpenStack Identity service.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027os_auth_prefix\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Prefix of URL to access OpenStack Identity service.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_130f09e2","line":44,"range":{"start_line":44,"start_character":24,"end_line":44,"end_character":30},"in_reply_to":"1f013ff3_1d8398ce","updated":"2017-05-16 10:00:20.000000000","message":"I named this conf from the same conf in keystonemiddleware and so might be better to use \"prefix\".","commit_id":"8706c8b7fcd93ef159c5f20e054c782cfcc5481d"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"fd9affb767c5d02cbc09b94c60977e5fd795e273","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u002735357\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Port of OpenStack Identity service.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027os_auth_prefix\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Prefix of URL to access OpenStack Identity service.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027This OpenStack user is used to treat trusts. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_fd60ec34","line":45,"updated":"2017-05-16 08:59:23.000000000","message":"what\u0027s the default value of this config? None or 0 byte string?","commit_id":"8706c8b7fcd93ef159c5f20e054c782cfcc5481d"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"b6361fbcb01bc4f4fb8dbfdc964d66e5d1060493","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u002735357\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Port of OpenStack Identity service.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027os_auth_prefix\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Prefix of URL to access OpenStack Identity service.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027os_admin_username\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027This OpenStack user is used to treat trusts. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_73740d36","line":45,"in_reply_to":"1f013ff3_fd60ec34","updated":"2017-05-16 10:00:20.000000000","message":"the default of this config should be 0 byte string. So I\u0027ve added \"default\u003d\u0027\u0027\".","commit_id":"8706c8b7fcd93ef159c5f20e054c782cfcc5481d"}],"blazar/utils/openstack/keystone.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.exceptions \u003d keystone_exception"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def complement_auth_url(self, auth_url, version):"},{"line_number":127,"context_line":"        \"\"\"Return auth_url with api version."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        This method only support complementing auth_url to v3 api url"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_2b154ae5","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":53},"updated":"2017-04-30 15:06:14.000000000","message":"To be clarified, what is the purpose of the method?  The method\u0027s comment says it\u0027s kind of validation method, but I can\u0027t fine any codes for validation. \n\nFor examples,\n*  if the auth_url \u003d\u003d http://localhost/identity and version \u003d\u003d v2, what is the right behavior of the method?\n* if the auth_url \u003d\u003d http://localhost/identity/v33, what is the return value?","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.exceptions \u003d keystone_exception"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def complement_auth_url(self, auth_url, version):"},{"line_number":127,"context_line":"        \"\"\"Return auth_url with api version."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        This method only support complementing auth_url to v3 api url"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_eb0aab23","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":53},"in_reply_to":"5ff73747_2b154ae5","updated":"2017-05-02 02:44:18.000000000","message":"I\u0027ve added method\u0027s comments and unit tests for this method. Please recheck.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        since we use keystone v3 api to treat trusts."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        if re.search(r\u0027/v3\u0027, auth_url) is None:"},{"line_number":134,"context_line":"            # Create api version from major number of keystoneclient version."},{"line_number":135,"context_line":"            # keystone client version may take forms of \"3\", \"v3\" or \"3.0\"."},{"line_number":136,"context_line":"            version \u003d version.lstrip(\u0027v\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_4bef76e8","line":133,"range":{"start_line":133,"start_character":11,"end_line":133,"end_character":38},"updated":"2017-04-30 15:06:14.000000000","message":"The regular expression matches wrong url.  For instance, http://www.cloud.com/v301/keystone could match the expression.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        since we use keystone v3 api to treat trusts."},{"line_number":131,"context_line":"        \"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        if re.search(r\u0027/v3\u0027, auth_url) is None:"},{"line_number":134,"context_line":"            # Create api version from major number of keystoneclient version."},{"line_number":135,"context_line":"            # keystone client version may take forms of \"3\", \"v3\" or \"3.0\"."},{"line_number":136,"context_line":"            version \u003d version.lstrip(\u0027v\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_ab002303","line":133,"range":{"start_line":133,"start_character":11,"end_line":133,"end_character":38},"in_reply_to":"5ff73747_4bef76e8","updated":"2017-05-02 02:44:18.000000000","message":"Done","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        if re.search(r\u0027/v3\u0027, auth_url) is None:"},{"line_number":134,"context_line":"            # Create api version from major number of keystoneclient version."},{"line_number":135,"context_line":"            # keystone client version may take forms of \"3\", \"v3\" or \"3.0\"."},{"line_number":136,"context_line":"            version \u003d version.lstrip(\u0027v\u0027)"},{"line_number":137,"context_line":"            version \u003d \u0027v\u0027 + str(int(float(version)))"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_ab103a01","line":135,"range":{"start_line":135,"start_character":56,"end_line":135,"end_character":74},"updated":"2017-04-30 15:06:14.000000000","message":"Why does this method support the three format?","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        if re.search(r\u0027/v3\u0027, auth_url) is None:"},{"line_number":134,"context_line":"            # Create api version from major number of keystoneclient version."},{"line_number":135,"context_line":"            # keystone client version may take forms of \"3\", \"v3\" or \"3.0\"."},{"line_number":136,"context_line":"            version \u003d version.lstrip(\u0027v\u0027)"},{"line_number":137,"context_line":"            version \u003d \u0027v\u0027 + str(int(float(version)))"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_063eeebf","line":135,"range":{"start_line":135,"start_character":56,"end_line":135,"end_character":74},"in_reply_to":"5ff73747_ab103a01","updated":"2017-05-02 02:44:18.000000000","message":"Because \"3\", \"v3\" and \"3.0\" are valid values to pass to keystoneclient.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"aea3d21114c1b8e61e07903d6ebf4358b84bd5f9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if re.search(r\u0027/v3\u0027, auth_url) is None:"},{"line_number":134,"context_line":"            # Create api version from major number of keystoneclient version."},{"line_number":135,"context_line":"            # keystone client version may take forms of \"3\", \"v3\" or \"3.0\"."},{"line_number":136,"context_line":"            version \u003d version.lstrip(\u0027v\u0027)"},{"line_number":137,"context_line":"            version \u003d \u0027v\u0027 + str(int(float(version)))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            auth_url \u003d auth_url + \u0027/\u0027 + version"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        return auth_url"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_cbdb864c","line":139,"range":{"start_line":136,"start_character":0,"end_line":139,"end_character":47},"updated":"2017-04-30 15:06:14.000000000","message":"I\u0027m not sure why it\u0027 so complex?  The comment says \u0027version\u0027 may take \"3\", \"v3\" or \"3.0\" and auth_url is assigned with autu_url + \u0027/\u0027 + \u0027v3\u0027 anyhow.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"bb824ed43fd7b66793535982ceb0a0b6a28d48c1","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if re.search(r\u0027/v3\u0027, auth_url) is None:"},{"line_number":134,"context_line":"            # Create api version from major number of keystoneclient version."},{"line_number":135,"context_line":"            # keystone client version may take forms of \"3\", \"v3\" or \"3.0\"."},{"line_number":136,"context_line":"            version \u003d version.lstrip(\u0027v\u0027)"},{"line_number":137,"context_line":"            version \u003d \u0027v\u0027 + str(int(float(version)))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            auth_url \u003d auth_url + \u0027/\u0027 + version"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        return auth_url"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_86eb1e11","line":139,"range":{"start_line":136,"start_character":0,"end_line":139,"end_character":47},"in_reply_to":"5ff73747_cbdb864c","updated":"2017-05-02 02:44:18.000000000","message":"Because I want to convert keystoneclient version to keystone api verison. Therefore, I extract major version number from keystoneclient version. In this patch, there were no validations for the extracted version and the received auth_url and so I\u0027ve added these validations in next patch.","commit_id":"96816a825e0aa0668fd61649be09b5af10ea4f42"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"995e2cf38e837c83d5b4ca99c4646a7a8cf25cd8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def complement_auth_url(self, auth_url, version):"},{"line_number":128,"context_line":"        \"\"\"Return auth_url with api version."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        This method checks wether auth_url cotains api version info."},{"line_number":131,"context_line":"        If api version info is not contained in auth_url, this method"},{"line_number":132,"context_line":"        complements version info to auth_url. This method only support"},{"line_number":133,"context_line":"        complementing auth_url to v3 api url since we use keystone v3"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_c6fd166f","line":130,"range":{"start_line":130,"start_character":43,"end_line":130,"end_character":50},"updated":"2017-05-10 09:50:52.000000000","message":"contains","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"995e2cf38e837c83d5b4ca99c4646a7a8cf25cd8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def complement_auth_url(self, auth_url, version):"},{"line_number":128,"context_line":"        \"\"\"Return auth_url with api version."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        This method checks wether auth_url cotains api version info."},{"line_number":131,"context_line":"        If api version info is not contained in auth_url, this method"},{"line_number":132,"context_line":"        complements version info to auth_url. This method only support"},{"line_number":133,"context_line":"        complementing auth_url to v3 api url since we use keystone v3"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_06089e8f","line":130,"range":{"start_line":130,"start_character":27,"end_line":130,"end_character":33},"updated":"2017-05-10 09:50:52.000000000","message":"nit /wether/whether/","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"5349a8c2da2095fd792a227f5170d3358b88679a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def complement_auth_url(self, auth_url, version):"},{"line_number":128,"context_line":"        \"\"\"Return auth_url with api version."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        This method checks wether auth_url cotains api version info."},{"line_number":131,"context_line":"        If api version info is not contained in auth_url, this method"},{"line_number":132,"context_line":"        complements version info to auth_url. This method only support"},{"line_number":133,"context_line":"        complementing auth_url to v3 api url since we use keystone v3"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_26eaca74","line":130,"range":{"start_line":130,"start_character":27,"end_line":130,"end_character":33},"in_reply_to":"3f044301_06089e8f","updated":"2017-05-16 08:31:14.000000000","message":"done","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"5349a8c2da2095fd792a227f5170d3358b88679a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def complement_auth_url(self, auth_url, version):"},{"line_number":128,"context_line":"        \"\"\"Return auth_url with api version."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        This method checks wether auth_url cotains api version info."},{"line_number":131,"context_line":"        If api version info is not contained in auth_url, this method"},{"line_number":132,"context_line":"        complements version info to auth_url. This method only support"},{"line_number":133,"context_line":"        complementing auth_url to v3 api url since we use keystone v3"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_06efce84","line":130,"range":{"start_line":130,"start_character":43,"end_line":130,"end_character":50},"in_reply_to":"3f044301_c6fd166f","updated":"2017-05-16 08:31:14.000000000","message":"done","commit_id":"9351e8e8d4e1f51c6948b88409f47e5b653c8362"}],"blazar/utils/trusts.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"36910c68f287c0b1aa3f1bde4bab367c9531c61d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def create_trust():"},{"line_number":27,"context_line":"    \"\"\"Creates trust via Keystone API v3 to use in plugins.\"\"\""},{"line_number":28,"context_line":"    auth_url \u003d \"%s/v3\" % (CONF.os_auth_uri)"},{"line_number":29,"context_line":"    client \u003d keystone.BlazarKeystoneClient(auth_url\u003dauth_url)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    trustee_id \u003d keystone.BlazarKeystoneClient("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_7a9b5917","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":43},"updated":"2017-04-27 17:47:59.000000000","message":"It looks like the root cause is auth_url generated in BlazarKeystoneClient.__init__() [1] doesn\u0027t have version info.  IMO, if it\u0027s true, we should add keystone API version info in there since we need to define auth_url anywhere when we create BlazarKeystoneClinet instances.\n\n1. https://github.com/openstack/blazar/blob/master/blazar/utils/openstack/keystone.py#L116","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"19888b1dd84d60e0d6d70e16793611aecb39963e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def create_trust():"},{"line_number":27,"context_line":"    \"\"\"Creates trust via Keystone API v3 to use in plugins.\"\"\""},{"line_number":28,"context_line":"    auth_url \u003d \"%s/v3\" % (CONF.os_auth_uri)"},{"line_number":29,"context_line":"    client \u003d keystone.BlazarKeystoneClient(auth_url\u003dauth_url)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    trustee_id \u003d keystone.BlazarKeystoneClient("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_9c05ea13","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":43},"in_reply_to":"5ff73747_7a9b5917","updated":"2017-04-28 10:45:22.000000000","message":"There are two causes:\n1. blazar does not support uri with prefixes.\n2. blazar does not add keystone api version info in BlazarKeystoneClient as you mentioned.\nand I\u0027ve added helper method to complement keystone API version info in BlazarKeystoneClient.","commit_id":"4946a77e45e115a2875debbe24cd6360e117a2e0"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"fd9affb767c5d02cbc09b94c60977e5fd795e273","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        project_name\u003dCONF.os_admin_project_name,"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    auth_url \u003d \"%s://%s:%s\" % (CONF.os_auth_protocol,"},{"line_number":59,"context_line":"                               CONF.os_auth_host,"},{"line_number":60,"context_line":"                               CONF.os_auth_port)"},{"line_number":61,"context_line":"    if CONF.os_auth_prefix:"},{"line_number":62,"context_line":"        auth_url \u003d \"%s/%s\" % (auth_url, CONF.os_auth_prefix)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    client \u003d keystone.BlazarKeystoneClient("},{"line_number":65,"context_line":"        password\u003dCONF.os_admin_password,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_1d0ef88c","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":60},"updated":"2017-05-16 08:59:23.000000000","message":"I think it\u0027s ok to do like following if default value of os_auth_prefix is \u0027\u0027.\n\n  auth_url \u003d \"%s://%s:%s/%s\" % (os_auth_protocol, os_auth_host, os_auth_port, os_auth_prefix)","commit_id":"8706c8b7fcd93ef159c5f20e054c782cfcc5481d"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"b6361fbcb01bc4f4fb8dbfdc964d66e5d1060493","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        project_name\u003dCONF.os_admin_project_name,"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    auth_url \u003d \"%s://%s:%s\" % (CONF.os_auth_protocol,"},{"line_number":59,"context_line":"                               CONF.os_auth_host,"},{"line_number":60,"context_line":"                               CONF.os_auth_port)"},{"line_number":61,"context_line":"    if CONF.os_auth_prefix:"},{"line_number":62,"context_line":"        auth_url \u003d \"%s/%s\" % (auth_url, CONF.os_auth_prefix)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    client \u003d keystone.BlazarKeystoneClient("},{"line_number":65,"context_line":"        password\u003dCONF.os_admin_password,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_f3eb7dad","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":60},"in_reply_to":"1f013ff3_1d0ef88c","updated":"2017-05-16 10:00:20.000000000","message":"It seems smarter. I\u0027ve adopted your suggestion.","commit_id":"8706c8b7fcd93ef159c5f20e054c782cfcc5481d"}],"devstack/plugin.sh":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"101748981b7d1624ac086d44d64800b5598a7399","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    touch $BLAZAR_CONF_FILE"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_auth_version v3"},{"line_number":47,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_auth_port $KEYSTONE_SERVICE_PORT"},{"line_number":48,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_auth_uri $KEYSTONE_SERVICE_URI"},{"line_number":49,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_admin_password $SERVICE_PASSWORD"},{"line_number":50,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_admin_username blazar"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ff73747_5bc0b52a","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":72},"updated":"2017-04-27 09:59:05.000000000","message":"Are these line needed? And it\u0027s better to deprecate these configs.","commit_id":"d2e274dea76cee4b2815eda55f02075b0d178fed"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"3658444c5bbe9c7f5cd0d27deef8c4e515a71f98","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    touch $BLAZAR_CONF_FILE"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_auth_version v3"},{"line_number":47,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_auth_port $KEYSTONE_SERVICE_PORT"},{"line_number":48,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_auth_uri $KEYSTONE_SERVICE_URI"},{"line_number":49,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_admin_password $SERVICE_PASSWORD"},{"line_number":50,"context_line":"    iniset $BLAZAR_CONF_FILE DEFAULT os_admin_username blazar"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ff73747_24326660","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":72},"in_reply_to":"5ff73747_5bc0b52a","updated":"2017-04-27 11:29:36.000000000","message":"Agree. I\u0027ve deprecated them in config.py","commit_id":"d2e274dea76cee4b2815eda55f02075b0d178fed"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"101748981b7d1624ac086d44d64800b5598a7399","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # Create cache dir"},{"line_number":106,"context_line":"        create_blazar_cache_dir"},{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":"    "},{"line_number":109,"context_line":"    configure_auth_token_middleware $conf_file $BLAZAR_USER_NAME $BLAZAR_AUTH_CACHE_DIR $section"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ff73747_db3846ef","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":4},"updated":"2017-04-27 09:59:05.000000000","message":"unexpected space","commit_id":"d2e274dea76cee4b2815eda55f02075b0d178fed"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"3658444c5bbe9c7f5cd0d27deef8c4e515a71f98","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # Create cache dir"},{"line_number":106,"context_line":"        create_blazar_cache_dir"},{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":"    "},{"line_number":109,"context_line":"    configure_auth_token_middleware $conf_file $BLAZAR_USER_NAME $BLAZAR_AUTH_CACHE_DIR $section"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ff73747_e437de4c","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":4},"in_reply_to":"5ff73747_db3846ef","updated":"2017-04-27 11:29:36.000000000","message":"Done","commit_id":"d2e274dea76cee4b2815eda55f02075b0d178fed"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"101748981b7d1624ac086d44d64800b5598a7399","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# create_blazar_cache_dir() - Part of the _blazar_setup_keystone process"},{"line_number":113,"context_line":"function create_blazar_cache_dir {"},{"line_number":114,"context_line":"    # Create cache dir"},{"line_number":115,"context_line":"    sudo mkdir -p $BLAZAR_AUTH_CACHE_DIR"},{"line_number":116,"context_line":"    sudo chown $STACK_USER $BLAZAR_AUTH_CACHE_DIR"},{"line_number":117,"context_line":"    rm -f $BLAZAR_AUTH_CACHE_DIR/*"},{"line_number":118,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ff73747_3bbe09d5","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":40},"updated":"2017-04-27 09:59:05.000000000","message":"Shouldn\u0027t it be set mode \u0027700\u0027? The following WARNING is shown in [1]:\n  - keystonemiddleware.auth_token [-] signing_dir mode is 0755 instead of 0700\n\n[1] http://logs.openstack.org/30/460430/2/check/gate-blazar-devstack-dsvm/c6d8b19/logs/screen-blazar-a.txt.gz","commit_id":"d2e274dea76cee4b2815eda55f02075b0d178fed"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"3658444c5bbe9c7f5cd0d27deef8c4e515a71f98","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# create_blazar_cache_dir() - Part of the _blazar_setup_keystone process"},{"line_number":113,"context_line":"function create_blazar_cache_dir {"},{"line_number":114,"context_line":"    # Create cache dir"},{"line_number":115,"context_line":"    sudo mkdir -p $BLAZAR_AUTH_CACHE_DIR"},{"line_number":116,"context_line":"    sudo chown $STACK_USER $BLAZAR_AUTH_CACHE_DIR"},{"line_number":117,"context_line":"    rm -f $BLAZAR_AUTH_CACHE_DIR/*"},{"line_number":118,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ff73747_84e25a9f","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":40},"in_reply_to":"5ff73747_3bbe09d5","updated":"2017-04-27 11:29:36.000000000","message":"I\u0027ve added \"-m\" option to change dir mode.","commit_id":"d2e274dea76cee4b2815eda55f02075b0d178fed"}]}
