)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4d42c73ad1aecb97b905b1bb21c03af72d5715c6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Eventlet monkey patching needs to be done as early as possible,"},{"line_number":10,"context_line":"otherwise previous library imports are not patched correctly. This fixes"},{"line_number":11,"context_line":"issues with concurrent requests triggering the following exception in"},{"line_number":12,"context_line":"the Blazar API process:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    AttributeError: \u0027function\u0027 object has no attribute \u0027get\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f201791_577f4214","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":66},"updated":"2017-06-27 02:51:14.000000000","message":"It\u0027s better to describe how the exception affects user side. For instance, some of requests will get 500 response code when users call the Blazar API concurrently, or etc.","commit_id":"602c7cfc1282064cae3584f071e1a2a07ad7fd44"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f6f3aaff6350bb9ccea91b74aa3814e09072fe9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Eventlet monkey patching needs to be done as early as possible,"},{"line_number":10,"context_line":"otherwise previous library imports are not patched correctly. This fixes"},{"line_number":11,"context_line":"issues with concurrent requests triggering the following exception in"},{"line_number":12,"context_line":"the Blazar API process:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    AttributeError: \u0027function\u0027 object has no attribute \u0027get\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f1d235d_fb0eaae3","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":66},"in_reply_to":"5f201791_577f4214","updated":"2017-06-30 17:17:17.000000000","message":"Done","commit_id":"602c7cfc1282064cae3584f071e1a2a07ad7fd44"}],"contrib/tempest/tempest/scenario/test_host_reservation.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4d42c73ad1aecb97b905b1bb21c03af72d5715c6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":141,"context_line":"                                       server[\u0027id\u0027], \u0027ERROR\u0027,"},{"line_number":142,"context_line":"                                       raise_on_error\u003dFalse)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # run lease-list requests in parallel to check service concurrency"},{"line_number":145,"context_line":"        def list_leases(reservation_client):"},{"line_number":146,"context_line":"            lease_list \u003d reservation_client.list_lease()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_ba7c3b83","line":143,"updated":"2017-06-27 02:51:14.000000000","message":"Can you separate the test to a different method?  The test doesn\u0027t need to be sequential to above test. And if the exception affects response code or something, it\u0027s good to assert the error.","commit_id":"602c7cfc1282064cae3584f071e1a2a07ad7fd44"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f6f3aaff6350bb9ccea91b74aa3814e09072fe9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        waiters.wait_for_server_status(self.os_admin.servers_client,"},{"line_number":141,"context_line":"                                       server[\u0027id\u0027], \u0027ERROR\u0027,"},{"line_number":142,"context_line":"                                       raise_on_error\u003dFalse)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # run lease-list requests in parallel to check service concurrency"},{"line_number":145,"context_line":"        def list_leases(reservation_client):"},{"line_number":146,"context_line":"            lease_list \u003d reservation_client.list_lease()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_fb27ca63","line":143,"in_reply_to":"5f201791_ba7c3b83","updated":"2017-06-30 17:17:17.000000000","message":"I have moved the test to a new scenario because it is not related either to host or instance reservation. However, I don\u0027t understand your comment about the exception and response code. The test checks that there is no error by verifying that the list_lease request returned the expected answer.","commit_id":"602c7cfc1282064cae3584f071e1a2a07ad7fd44"}],"contrib/tempest/tempest/scenario/test_reservation_concurrency.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"d360c0898d4041fdf7d3085a634c3fd14b5bf226","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        pool.join()"},{"line_number":41,"context_line":"        results \u003d [r.get() for r in results]"},{"line_number":42,"context_line":"        for r in results:"},{"line_number":43,"context_line":"            self.assertEqual(r.get(\u0027leases\u0027), [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_6aaa7171","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":49},"updated":"2017-07-05 01:45:19.000000000","message":"Tempest concurrently calls some tempest tests. So the result doesn\u0027t always have an empty list.\n\nIMO, it\u0027s ok to check whether the results get a response correctly without 500 error instead of checking whether the response body of results is empty or not.","commit_id":"69d71b0969214687e59ae591585f8c9acd34bb5f"}]}