)]}'
{"blazar/plugins/instances/instance_plugin.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"4795f5289f9b23041a81317a1c54ea5591f2222f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            return event[1][resource_type]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        events_list \u003d []"},{"line_number":64,"context_line":"        for r in reservations:"},{"line_number":65,"context_line":"            fetched_events \u003d db_api.event_get_all_sorted_by_filters("},{"line_number":66,"context_line":"                sort_key\u003d\u0027time\u0027, sort_dir\u003d\u0027asc\u0027,"},{"line_number":67,"context_line":"                filters\u003d{\u0027lease_id\u0027: r[\u0027lease_id\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_8901f807","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":30},"updated":"2017-07-07 07:44:30.000000000","message":"Let me just confirm my understanding. It seems an event can be double counted if a lease has multiple reservations. I thinks it\u0027s no problem, right?","commit_id":"a95d056ca8f3d6797aa2e2d56bdc12aad8d00fbd"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"92f13f5f946093855bc58a711b4718c434afc9ea","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            return event[1][resource_type]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        events_list \u003d []"},{"line_number":64,"context_line":"        for r in reservations:"},{"line_number":65,"context_line":"            fetched_events \u003d db_api.event_get_all_sorted_by_filters("},{"line_number":66,"context_line":"                sort_key\u003d\u0027time\u0027, sort_dir\u003d\u0027asc\u0027,"},{"line_number":67,"context_line":"                filters\u003d{\u0027lease_id\u0027: r[\u0027lease_id\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_3a97b93d","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":30},"in_reply_to":"3f1d235d_8901f807","updated":"2017-07-07 13:27:56.000000000","message":"Yes, it double-counts an event if a lease have multi reservations. This method needs to count up all usages regardless of reservations belonging to one lease.","commit_id":"a95d056ca8f3d6797aa2e2d56bdc12aad8d00fbd"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"4795f5289f9b23041a81317a1c54ea5591f2222f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            fetched_events \u003d db_api.event_get_all_sorted_by_filters("},{"line_number":66,"context_line":"                sort_key\u003d\u0027time\u0027, sort_dir\u003d\u0027asc\u0027,"},{"line_number":67,"context_line":"                filters\u003d{\u0027lease_id\u0027: r[\u0027lease_id\u0027]})"},{"line_number":68,"context_line":"            events_list.extend([[e, r] for e in fetched_events])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        events_list.sort(key\u003dlambda x: x[0][\u0027time\u0027])"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_2958a42e","line":68,"range":{"start_line":68,"start_character":32,"end_line":68,"end_character":38},"updated":"2017-07-07 07:44:30.000000000","message":"I think using dictionary like {\u0027event\u0027: e, \u0027reservation\u0027: r} is better for understanding the other parts (L61, L70, 76, 86).","commit_id":"a95d056ca8f3d6797aa2e2d56bdc12aad8d00fbd"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"92f13f5f946093855bc58a711b4718c434afc9ea","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            fetched_events \u003d db_api.event_get_all_sorted_by_filters("},{"line_number":66,"context_line":"                sort_key\u003d\u0027time\u0027, sort_dir\u003d\u0027asc\u0027,"},{"line_number":67,"context_line":"                filters\u003d{\u0027lease_id\u0027: r[\u0027lease_id\u0027]})"},{"line_number":68,"context_line":"            events_list.extend([[e, r] for e in fetched_events])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        events_list.sort(key\u003dlambda x: x[0][\u0027time\u0027])"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_5abb95c3","line":68,"range":{"start_line":68,"start_character":32,"end_line":68,"end_character":38},"in_reply_to":"3f1d235d_2958a42e","updated":"2017-07-07 13:27:56.000000000","message":"Done","commit_id":"a95d056ca8f3d6797aa2e2d56bdc12aad8d00fbd"}]}