)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bae0fc9424633fbd7e2a8c8ed81c74c51ec48f43","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle general exceptions raised in the reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Fixes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_6e97baed","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2017-07-07 11:32:48.000000000","message":"Closes-Bug?","commit_id":"5baadf0d2cad77b4245a19ca0512892fb8228cfd"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"362f900d8906dfb79d499885005e8514cd201393","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle general exceptions raised in the reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Fixes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_9b02333e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"3f1d235d_6e97baed","updated":"2017-07-10 01:01:06.000000000","message":"Oh, sorry... :-)","commit_id":"5baadf0d2cad77b4245a19ca0512892fb8228cfd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"190211b9b9c1084aac3b52fff63791a39b574886","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroaki Kobayashi \u003ckobayashi.hiroaki@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-13 17:28:57 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle more exceptions raised in the reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Fixes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_fa7cdd72","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":36},"updated":"2017-07-18 16:27:27.000000000","message":"You can remove \"the\".","commit_id":"d253afbcd827ad631a6bb1ae9e2ce23cfa36692a"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"dd732c3f2e03f639aab7cd8166d6bd45f3c86afa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroaki Kobayashi \u003ckobayashi.hiroaki@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-13 17:28:57 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle more exceptions raised in the reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Fixes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_ccc3a1ec","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":36},"in_reply_to":"1f1a1f67_fa7cdd72","updated":"2017-07-19 02:24:06.000000000","message":"Done","commit_id":"d253afbcd827ad631a6bb1ae9e2ce23cfa36692a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"190211b9b9c1084aac3b52fff63791a39b574886","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle more exceptions raised in the reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Fixes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_5ab99112","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2017-07-18 16:27:27.000000000","message":"As Masahito said, please use Closes-Bug.","commit_id":"d253afbcd827ad631a6bb1ae9e2ce23cfa36692a"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"dd732c3f2e03f639aab7cd8166d6bd45f3c86afa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle more exceptions raised in the reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Fixes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f1a1f67_acb62589","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"1f1a1f67_5ab99112","updated":"2017-07-19 02:24:06.000000000","message":"Done","commit_id":"d253afbcd827ad631a6bb1ae9e2ce23cfa36692a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7fc438c9dc030dad9be7e5efb2caaa0d155a0f7e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-07-25 08:20:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle more exceptions raised in reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Closes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df3967d1_aa39fa41","line":8,"updated":"2017-07-31 14:37:12.000000000","message":"Add as a second paragraph:\n\nThis commit also moves parameter validation to a separate function.","commit_id":"4cda25d7f1954a4a8704d0f16921373fc55f0904"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"5823090d64d9fb26d0c73c830a1de1093eb86104","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-07-25 08:20:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle more exceptions raised in reserve_resource()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic1382873ddd819535254b738b17176981ba771e6"},{"line_number":10,"context_line":"Closes-Bug: #1702853"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"df3967d1_b22b9ee9","line":8,"in_reply_to":"df3967d1_aa39fa41","updated":"2017-08-01 07:05:02.000000000","message":"Done","commit_id":"4cda25d7f1954a4a8704d0f16921373fc55f0904"}],"blazar/manager/service.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a4ffbadb38300cf1a39c2c38bdd7f10b046faf57","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                except (exceptions.UnsupportedResourceType,"},{"line_number":268,"context_line":"                        exceptions.MalformedParameter,"},{"line_number":269,"context_line":"                        common_ex.BlazarException,"},{"line_number":270,"context_line":"                        Exception):"},{"line_number":271,"context_line":"                    LOG.exception(\"Failed to create reservation for a lease. \""},{"line_number":272,"context_line":"                                  \"Rollback the lease and associated \""},{"line_number":273,"context_line":"                                  \"reservations\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_6379e92d","line":270,"updated":"2017-07-21 02:25:48.000000000","message":"The \u0027Exception\u0027 class covers all exceptions defined in blazar repo. Is it needed to list Blazar related exceptions?","commit_id":"5586a4114da1b7a935655becdf831a1321cadb78"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"97b3f866b26386f3396f9f36baa078c7daa4b4b8","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                except (exceptions.UnsupportedResourceType,"},{"line_number":268,"context_line":"                        exceptions.MalformedParameter,"},{"line_number":269,"context_line":"                        common_ex.BlazarException,"},{"line_number":270,"context_line":"                        Exception):"},{"line_number":271,"context_line":"                    LOG.exception(\"Failed to create reservation for a lease. \""},{"line_number":272,"context_line":"                                  \"Rollback the lease and associated \""},{"line_number":273,"context_line":"                                  \"reservations\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_ff6d6b98","line":270,"in_reply_to":"1f1a1f67_6379e92d","updated":"2017-07-25 06:07:38.000000000","message":"Done","commit_id":"5586a4114da1b7a935655becdf831a1321cadb78"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a4ffbadb38300cf1a39c2c38bdd7f10b046faf57","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                values[\u0027start_date\u0027],"},{"line_number":84,"context_line":"                values[\u0027end_date\u0027],"},{"line_number":85,"context_line":"            )"},{"line_number":86,"context_line":"        except KeyError:"},{"line_number":87,"context_line":"            raise manager_ex.MalformedParameter"},{"line_number":88,"context_line":"        if not host_ids:"},{"line_number":89,"context_line":"            raise manager_ex.NotEnoughHostsAvailable()"},{"line_number":90,"context_line":"        pool \u003d nova.ReservationPool()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_43fcad3d","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":47},"updated":"2017-07-21 02:25:48.000000000","message":"It\u0027s better to separate the parameter checking code with _matching_hosts since it\u0027s easy to remove the validation later.","commit_id":"5586a4114da1b7a935655becdf831a1321cadb78"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"97b3f866b26386f3396f9f36baa078c7daa4b4b8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                values[\u0027start_date\u0027],"},{"line_number":84,"context_line":"                values[\u0027end_date\u0027],"},{"line_number":85,"context_line":"            )"},{"line_number":86,"context_line":"        except KeyError:"},{"line_number":87,"context_line":"            raise manager_ex.MalformedParameter"},{"line_number":88,"context_line":"        if not host_ids:"},{"line_number":89,"context_line":"            raise manager_ex.NotEnoughHostsAvailable()"},{"line_number":90,"context_line":"        pool \u003d nova.ReservationPool()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_a43476fc","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":47},"in_reply_to":"1f1a1f67_43fcad3d","updated":"2017-07-25 06:07:38.000000000","message":"I\u0027ve separated parameter checks into a _check_params() method.","commit_id":"5586a4114da1b7a935655becdf831a1321cadb78"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7fc438c9dc030dad9be7e5efb2caaa0d155a0f7e","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        else:"},{"line_number":390,"context_line":"            raise manager_ex.InvalidRange()"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        values[\u0027count_range\u0027] \u003d count_range"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if \u0027hypervisor_properties\u0027 not in values:"},{"line_number":395,"context_line":"            raise manager_ex.MissingParameter(param\u003d\u0027hypervisor_properties\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df3967d1_aa60da33","line":392,"updated":"2017-07-31 14:37:12.000000000","message":"You can merge this line with line 388.","commit_id":"4cda25d7f1954a4a8704d0f16921373fc55f0904"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"5823090d64d9fb26d0c73c830a1de1093eb86104","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        else:"},{"line_number":390,"context_line":"            raise manager_ex.InvalidRange()"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        values[\u0027count_range\u0027] \u003d count_range"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if \u0027hypervisor_properties\u0027 not in values:"},{"line_number":395,"context_line":"            raise manager_ex.MissingParameter(param\u003d\u0027hypervisor_properties\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df3967d1_720e568e","line":392,"in_reply_to":"df3967d1_aa60da33","updated":"2017-08-01 07:05:02.000000000","message":"Done","commit_id":"4cda25d7f1954a4a8704d0f16921373fc55f0904"}]}
