)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Totad \u003ckiran.totad@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-21 03:35:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack oslo_utils has a generate_uuid function for generating"},{"line_number":10,"context_line":"uuids. We should use that function when generating uuids for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff346bd7_dbd3d437","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":50},"updated":"2017-07-25 09:36:50.000000000","message":"Use \"()\" in both places or don\u0027t use at all.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran Totad \u003ckiran.totad@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-21 03:35:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack oslo_utils has a generate_uuid function for generating"},{"line_number":10,"context_line":"uuids. We should use that function when generating uuids for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff346bd7_bb3130a5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2017-07-25 09:36:50.000000000","message":"s/Replaces/Replace/","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack oslo_utils has a generate_uuid function for generating"},{"line_number":10,"context_line":"uuids. We should use that function when generating uuids for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff346bd7_3b6f8093","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":9},"updated":"2017-07-25 09:36:50.000000000","message":"This should be spelled \"OpenStack\", but really you don\u0027t need to mention it, we know the project :-)","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack oslo_utils has a generate_uuid function for generating"},{"line_number":10,"context_line":"uuids. We should use that function when generating uuids for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibf36852e71d716a52a9e231ca2054dd6988771c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff346bd7_3bcb0073","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":56},"updated":"2017-07-25 09:36:50.000000000","message":"s/uuids/UUIDs/","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack oslo_utils has a generate_uuid function for generating"},{"line_number":10,"context_line":"uuids. We should use that function when generating uuids for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibf36852e71d716a52a9e231ca2054dd6988771c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff346bd7_bbbff0ce","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2017-07-25 09:36:50.000000000","message":"s/uuids/UUIDs/","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace uuid.uuid4() with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenStack oslo_utils has a generate_uuid function for"},{"line_number":10,"context_line":"generating UUIDs. We should use that function when"},{"line_number":11,"context_line":"generating UUIDs for consistency."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff346bd7_dbf4f189","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":20},"updated":"2017-07-25 11:20:28.000000000","message":"Oslo libraries are generally referred to by their \".\" name, i.e. oslo.utils rather than oslo_utils. Also no need to mention \"OpenStack\".","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace uuid.uuid4() with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenStack oslo_utils has a generate_uuid function for"},{"line_number":10,"context_line":"generating UUIDs. We should use that function when"},{"line_number":11,"context_line":"generating UUIDs for consistency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibf36852e71d716a52a9e231ca2054dd6988771c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff346bd7_9bee69b2","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"updated":"2017-07-25 11:20:28.000000000","message":"You can make your lines longer, up to 72 characters, for better readability.","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"}],"blazar/db/migration/alembic_migrations/versions/0_1_initial.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b93a3dc4e9ce0851ba6add2e0db48c6c407721be","unresolved":false,"context_lines":[{"line_number":26,"context_line":"down_revision \u003d None"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import uuid"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from alembic import op"},{"line_number":31,"context_line":"import sqlalchemy as sa"},{"line_number":32,"context_line":"from sqlalchemy.dialects.mysql import MEDIUMTEXT"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_a349418c","side":"PARENT","line":29,"updated":"2017-07-21 02:31:09.000000000","message":"We shouldn\u0027t modify this file because this file was automatically generated by oslo.db.","commit_id":"4de8370c022704e1f4ea4a4db44aabe71214962c"}],"blazar/db/sqlalchemy/models.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from sqlalchemy.orm import relationship"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from blazar.db.sqlalchemy import model_base as mb"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":"# FIXME: https://bugs.launchpad.net/climate/+bug/1300132"},{"line_number":26,"context_line":"# LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_fb99f878","line":24,"updated":"2017-07-25 09:36:50.000000000","message":"This import should be placed with other external packages.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# FIXME: https://bugs.launchpad.net/climate/+bug/1300132"},{"line_number":18,"context_line":"# from oslo_log import log as logging"},{"line_number":19,"context_line":"from oslo_utils import uuidutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import sqlalchemy as sa"},{"line_number":22,"context_line":"from sqlalchemy.dialects.mysql import MEDIUMTEXT"},{"line_number":23,"context_line":"from sqlalchemy.orm import relationship"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_5ba481b9","line":20,"updated":"2017-07-25 11:20:28.000000000","message":"Remove the empty line here. oslo_utils is part of external packages like sqlalchemy.","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"}],"blazar/tests/api/__init__.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from blazar.manager.oshosts import rpcapi as hosts_rpcapi"},{"line_number":27,"context_line":"from blazar.manager import rpcapi"},{"line_number":28,"context_line":"from blazar import tests"},{"line_number":29,"context_line":"from oslo_utils import uuidutils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"PATH_PREFIX \u003d \u0027/v2\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_db8ab419","line":29,"updated":"2017-07-25 09:36:50.000000000","message":"This import should be placed with other external packages.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Base classes for API tests.\"\"\""},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from keystonemiddleware import fixture"},{"line_number":20,"context_line":"import pecan"},{"line_number":21,"context_line":"import pecan.testing"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from blazar.api import context as api_context"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_7b8aa51b","line":22,"range":{"start_line":17,"start_character":0,"end_line":22,"end_character":10},"updated":"2017-07-25 11:20:28.000000000","message":"oslo_utils needs to be with the other external package imports, in alphabetic order.","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a14b4d26549ba55c16029ce1ed3b95d23c4dc79d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"class APITest(tests.TestCase):"},{"line_number":34,"context_line":"    \"\"\"Used for unittests tests of Pecan controllers.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    ADMIN_TOKEN \u003d uuidutils.generate_uuid()"},{"line_number":37,"context_line":"    MEMBER_TOKEN \u003d uuidutils.generate_uuid()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # SOURCE_DATA \u003d {\u0027test_source\u0027: {\u0027somekey\u0027: \u0027666\u0027}}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff346bd7_de397f3f","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":44},"updated":"2017-07-25 11:56:56.000000000","message":"I am not sure if this matters, but there is a behaviour change here: uuid.uuid4().hex produces a UUID without dashes, while uuidutils.generate_uuid() includes them.","commit_id":"fe65d209957a5003025034b2fdc8df2a89efac52"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d1e1023fa730f91cf61227296b42cb6908b237cb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Base classes for API tests.\"\"\""},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"from keystonemiddleware import fixture"},{"line_number":19,"context_line":"import pecan"},{"line_number":20,"context_line":"import pecan.testing"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from blazar.api import context as api_context"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff346bd7_37fe50ae","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":10},"updated":"2017-07-26 05:15:43.000000000","message":"You have lost the alphabetic order here.","commit_id":"f3fbcc1f3aa2daeb10fd42878413b3192e71a14a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7bf19af2eae37fc9ae92bd05a5824460ae55c61b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import pecan"},{"line_number":20,"context_line":"import pecan.testing"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from blazar.api import context as api_context"},{"line_number":25,"context_line":"from blazar import context"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff346bd7_374410b7","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":0},"updated":"2017-07-26 05:30:17.000000000","message":"While you\u0027re working on this patch, can you remove the duplicate new line between these two blocks? It should be only one empty line (the issue was already present, it is not caused by your patch).","commit_id":"4e30a14df2b5eb06bb988bbf9ce03b61a51a3ef1"}],"blazar/tests/api/v2/test_hosts.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from blazar.tests import api"},{"line_number":23,"context_line":"from blazar.utils import trusts"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def fake_computehost(**kw):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_9b842c0e","line":24,"updated":"2017-07-25 09:36:50.000000000","message":"This import should be placed with other external packages.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Tests for API /os-hosts/ methods"},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_3b841d0c","line":19,"updated":"2017-07-25 11:20:28.000000000","message":"Remove empty line.","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"}],"blazar/tests/api/v2/test_leases.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from blazar.tests import api"},{"line_number":22,"context_line":"from blazar.utils import trusts"},{"line_number":23,"context_line":"from oslo_utils import uuidutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def fake_lease(**kw):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_3b79c02e","line":23,"updated":"2017-07-25 09:36:50.000000000","message":"This import should be placed with other external packages.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Tests for API /leases/ methods"},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_fb7d751c","line":19,"updated":"2017-07-25 11:20:28.000000000","message":"Remove empty line.","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"}],"blazar/tests/db/sqlalchemy/test_sqlalchemy_api.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from blazar.db.sqlalchemy import models"},{"line_number":22,"context_line":"from blazar.plugins import oshosts as host_plugin"},{"line_number":23,"context_line":"from blazar import tests"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _get_fake_random_uuid():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_9b99cc6f","line":24,"updated":"2017-07-25 09:36:50.000000000","message":"This import should be placed inside a section for external packages.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"464b3d904523fd67f94cb574ce5e696bbf3fa896","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import operator"},{"line_number":18,"context_line":"from oslo_utils import uuidutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from blazar.db import exceptions as db_exceptions"},{"line_number":21,"context_line":"from blazar.db.sqlalchemy import api as db_api"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff346bd7_9ba789a8","line":18,"updated":"2017-07-25 11:20:28.000000000","message":"Add an empty line above oslo_utils to separate from standard library imports.","commit_id":"01bbe198b50e1b17c5f2f090058f340c0696ba8d"}],"blazar/tests/db/sqlalchemy/test_utils.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12358f29c88b4b257ba4b20f5931bb4f4e2b8261","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from blazar.db.sqlalchemy import api as db_api"},{"line_number":22,"context_line":"from blazar.db.sqlalchemy import utils as db_utils"},{"line_number":23,"context_line":"from blazar import tests"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _get_fake_random_uuid():"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff346bd7_7b9ce85c","line":24,"updated":"2017-07-25 09:36:50.000000000","message":"This import should be placed with other external packages.","commit_id":"2e6cc66092ef39f1581ef018c43d10261956f7ae"}]}