)]}'
{"blazar/db/migration/alembic_migrations/versions/ba75b766b64e_add_before_end_into_computhost_.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"53ae84256777fe7cc1594c519cbc5d5e402c7fbf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Add before_end into computhost_reservations table"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: ba75b766b64e"},{"line_number":19,"context_line":"Revises: 8805be233864"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_691617f4","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":46},"updated":"2017-08-03 08:45:10.000000000","message":"computehost_reservations","commit_id":"54089ca585aaf24391b5a079c59453249197661b"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"f0d5bcca5e24bd064a592c7beee86874971d0aab","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Add before_end into computhost_reservations table"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: ba75b766b64e"},{"line_number":19,"context_line":"Revises: 8805be233864"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_c9050348","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":46},"in_reply_to":"df3967d1_691617f4","updated":"2017-08-03 09:01:12.000000000","message":"Done","commit_id":"54089ca585aaf24391b5a079c59453249197661b"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"53ae84256777fe7cc1594c519cbc5d5e402c7fbf","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        if \u0027resource_properties\u0027 not in values:"},{"line_number":416,"context_line":"            raise manager_ex.MissingParameter(param\u003d\u0027resource_properties\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        if \u0027before_end\u0027 not in values:"},{"line_number":419,"context_line":"            values[\u0027before_end\u0027] \u003d CONF[plugin.RESOURCE_TYPE].before_end"},{"line_number":420,"context_line":"        if values[\u0027before_end\u0027] not in self.before_end_options():"},{"line_number":421,"context_line":"            raise manager_ex.MalformedParameter(param\u003d\u0027before_end\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_e99b2763","line":419,"range":{"start_line":418,"start_character":0,"end_line":419,"end_character":72},"updated":"2017-08-03 08:45:10.000000000","message":"If I understand correctly the behaviour, this means that if before_end is not defined by the user, it will be set from the configuration at lease creation time. If the administrator changes the configuration later, it won\u0027t apply to existing leases. Is this the behaviour we want?","commit_id":"54089ca585aaf24391b5a079c59453249197661b"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"f0d5bcca5e24bd064a592c7beee86874971d0aab","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        if \u0027resource_properties\u0027 not in values:"},{"line_number":416,"context_line":"            raise manager_ex.MissingParameter(param\u003d\u0027resource_properties\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        if \u0027before_end\u0027 not in values:"},{"line_number":419,"context_line":"            values[\u0027before_end\u0027] \u003d CONF[plugin.RESOURCE_TYPE].before_end"},{"line_number":420,"context_line":"        if values[\u0027before_end\u0027] not in self.before_end_options():"},{"line_number":421,"context_line":"            raise manager_ex.MalformedParameter(param\u003d\u0027before_end\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_a923dfbc","line":419,"range":{"start_line":418,"start_character":0,"end_line":419,"end_character":72},"in_reply_to":"df3967d1_e99b2763","updated":"2017-08-03 09:01:12.000000000","message":"You\u0027re right. The latest config value should be applied. I\u0027ve introduced \u0027default\u0027 and made the plugin to take configured action if the before_end is set \u0027default\u0027. Thanks!","commit_id":"54089ca585aaf24391b5a079c59453249197661b"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"7205e1e2fd2296f93d7c303d04ffe6a47852b148","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                        search_opts\u003d{\"host\": host, \"all_tenants\": 1}):"},{"line_number":189,"context_line":"                        client.servers.create_image(server\u003dserver)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def before_end_options(self):"},{"line_number":192,"context_line":"        return [\u0027\u0027, \u0027snapshot\u0027, \u0027default\u0027]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def on_end(self, resource_id):"},{"line_number":195,"context_line":"        \"\"\"Remove the hosts from the pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_9834604c","line":192,"range":{"start_line":191,"start_character":0,"end_line":192,"end_character":42},"updated":"2017-08-07 10:40:13.000000000","message":"please define this kind of definition as module variable at outside of the class.","commit_id":"fcb3d08c1a49f24a8000a1292ff2b8f2fdc72023"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"0ea09f33a4327d2b51d557b1ab57f1d72f10dc45","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                        search_opts\u003d{\"host\": host, \"all_tenants\": 1}):"},{"line_number":189,"context_line":"                        client.servers.create_image(server\u003dserver)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def before_end_options(self):"},{"line_number":192,"context_line":"        return [\u0027\u0027, \u0027snapshot\u0027, \u0027default\u0027]"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def on_end(self, resource_id):"},{"line_number":195,"context_line":"        \"\"\"Remove the hosts from the pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_f2dba67a","line":192,"range":{"start_line":191,"start_character":0,"end_line":192,"end_character":42},"in_reply_to":"bf3e73b7_9834604c","updated":"2017-08-08 01:36:26.000000000","message":"Done","commit_id":"fcb3d08c1a49f24a8000a1292ff2b8f2fdc72023"}],"doc/source/restapi/rest_api_v1.0.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6993b4e686566be4305c01066e9bb7714d6b4b93","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                        \"resource_properties\": \"\","},{"line_number":390,"context_line":"                        \"id\": \"087bc740-6d2d-410b-9d47-c7b2b55a9d36\","},{"line_number":391,"context_line":"                        \"resource_type\": \"physical:host\","},{"line_number":392,"context_line":"                        \"bevore_end\": \"\""},{"line_number":393,"context_line":"                    }"},{"line_number":394,"context_line":"                ],"},{"line_number":395,"context_line":"                \"created_at\": \"2017-02-21 14:50:38\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf3e73b7_b8bcc4bb","line":392,"range":{"start_line":392,"start_character":25,"end_line":392,"end_character":35},"updated":"2017-08-07 10:37:39.000000000","message":"before_end","commit_id":"fcb3d08c1a49f24a8000a1292ff2b8f2fdc72023"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"0ea09f33a4327d2b51d557b1ab57f1d72f10dc45","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                        \"resource_properties\": \"\","},{"line_number":390,"context_line":"                        \"id\": \"087bc740-6d2d-410b-9d47-c7b2b55a9d36\","},{"line_number":391,"context_line":"                        \"resource_type\": \"physical:host\","},{"line_number":392,"context_line":"                        \"bevore_end\": \"\""},{"line_number":393,"context_line":"                    }"},{"line_number":394,"context_line":"                ],"},{"line_number":395,"context_line":"                \"created_at\": \"2017-02-21 14:50:38\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"9f436f4f_affc993e","line":392,"range":{"start_line":392,"start_character":25,"end_line":392,"end_character":35},"in_reply_to":"bf3e73b7_b8bcc4bb","updated":"2017-08-08 01:36:26.000000000","message":"Done","commit_id":"fcb3d08c1a49f24a8000a1292ff2b8f2fdc72023"}]}