)]}'
{"blazar/manager/service.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"06dc654f66963c6bb8e8c68ce6c4900bfe4ee481","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        lease \u003d self.get_lease(lease_id)"},{"line_number":421,"context_line":"        if (datetime.datetime.utcnow() \u003e\u003d lease[\u0027start_date\u0027] and"},{"line_number":422,"context_line":"                datetime.datetime.utcnow() \u003c\u003d lease[\u0027end_date\u0027]):"},{"line_number":423,"context_line":"            start_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":424,"context_line":"                \u0027lease_id\u0027,"},{"line_number":425,"context_line":"                \u0027asc\u0027,"},{"line_number":426,"context_line":"                {"},{"line_number":427,"context_line":"                    \u0027lease_id\u0027: lease_id,"},{"line_number":428,"context_line":"                    \u0027event_type\u0027: \u0027start_lease\u0027,"},{"line_number":429,"context_line":"                    \u0027status\u0027: \u0027DONE\u0027"},{"line_number":430,"context_line":"                }"},{"line_number":431,"context_line":"            )"},{"line_number":432,"context_line":"            if (start_event[\u0027status\u0027] !\u003d \u0027DONE\u0027 and"},{"line_number":433,"context_line":"                    start_event[\u0027status\u0027] !\u003d \u0027ERROR\u0027):"},{"line_number":434,"context_line":"                raise common_ex.BlazarException(\u0027Invalid event status\u0027)"},{"line_number":435,"context_line":"            end_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":436,"context_line":"                \u0027lease_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_79878211","line":433,"range":{"start_line":423,"start_character":0,"end_line":433,"end_character":54},"updated":"2017-09-01 14:50:19.000000000","message":"The call to event_get_first_sorted_by_filters() is requesting only events with DONE status, so 1) you could have no events, which would make the code at lines 432-433 throw a KeyError exception 2) we are guaranteed to have a status equal to DONE so lines 432-433 don\u0027t make sense to me.","commit_id":"8d9a33e44fabd0ca348d6d9d94960b293a83bfba"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"5834864ada2eba9a5d2e8e39547f803bf6ac5a91","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        lease \u003d self.get_lease(lease_id)"},{"line_number":421,"context_line":"        if (datetime.datetime.utcnow() \u003e\u003d lease[\u0027start_date\u0027] and"},{"line_number":422,"context_line":"                datetime.datetime.utcnow() \u003c\u003d lease[\u0027end_date\u0027]):"},{"line_number":423,"context_line":"            start_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":424,"context_line":"                \u0027lease_id\u0027,"},{"line_number":425,"context_line":"                \u0027asc\u0027,"},{"line_number":426,"context_line":"                {"},{"line_number":427,"context_line":"                    \u0027lease_id\u0027: lease_id,"},{"line_number":428,"context_line":"                    \u0027event_type\u0027: \u0027start_lease\u0027,"},{"line_number":429,"context_line":"                    \u0027status\u0027: \u0027DONE\u0027"},{"line_number":430,"context_line":"                }"},{"line_number":431,"context_line":"            )"},{"line_number":432,"context_line":"            if (start_event[\u0027status\u0027] !\u003d \u0027DONE\u0027 and"},{"line_number":433,"context_line":"                    start_event[\u0027status\u0027] !\u003d \u0027ERROR\u0027):"},{"line_number":434,"context_line":"                raise common_ex.BlazarException(\u0027Invalid event status\u0027)"},{"line_number":435,"context_line":"            end_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":436,"context_line":"                \u0027lease_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d472a27c","line":433,"range":{"start_line":423,"start_character":0,"end_line":433,"end_character":54},"in_reply_to":"7f287b81_79878211","updated":"2017-09-04 01:00:00.000000000","message":"Oh, sorry. I intended to remove L429 but made a mistake somewhere. I\u0027ll fix it.","commit_id":"8d9a33e44fabd0ca348d6d9d94960b293a83bfba"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4e6cbe297b224ecc816dfcff9ce6613372df501e","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    \u0027event_type\u0027: \u0027start_lease\u0027"},{"line_number":429,"context_line":"                }"},{"line_number":430,"context_line":"            )"},{"line_number":431,"context_line":"            if (start_event[\u0027status\u0027] !\u003d \u0027DONE\u0027 and"},{"line_number":432,"context_line":"                    start_event[\u0027status\u0027] !\u003d \u0027ERROR\u0027):"},{"line_number":433,"context_line":"                raise common_ex.BlazarException(\u0027Invalid event status\u0027)"},{"line_number":434,"context_line":"            end_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":435,"context_line":"                \u0027lease_id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_2a673a28","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":53},"updated":"2017-09-04 08:09:23.000000000","message":"status_event[\u0027status\u0027] not in [\u0027Done\u0027, \u0027ERROR\u0027] is more pythonic.","commit_id":"b078721f4355757ad1b43982567805686e75eee0"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"7eca30d913739f32a231df6b8462798cf1f209a7","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    \u0027event_type\u0027: \u0027start_lease\u0027"},{"line_number":429,"context_line":"                }"},{"line_number":430,"context_line":"            )"},{"line_number":431,"context_line":"            if (start_event[\u0027status\u0027] !\u003d \u0027DONE\u0027 and"},{"line_number":432,"context_line":"                    start_event[\u0027status\u0027] !\u003d \u0027ERROR\u0027):"},{"line_number":433,"context_line":"                raise common_ex.BlazarException(\u0027Invalid event status\u0027)"},{"line_number":434,"context_line":"            end_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":435,"context_line":"                \u0027lease_id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b78c9f35","line":432,"range":{"start_line":431,"start_character":0,"end_line":432,"end_character":53},"in_reply_to":"7f287b81_2a673a28","updated":"2017-09-05 07:32:14.000000000","message":"Nice! Done.","commit_id":"b078721f4355757ad1b43982567805686e75eee0"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"84e85707d96efc2e0ba85c75e8640d9142df7e19","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    \u0027event_type\u0027: \u0027start_lease\u0027"},{"line_number":429,"context_line":"                }"},{"line_number":430,"context_line":"            )"},{"line_number":431,"context_line":"            if start_event[\u0027status\u0027] not in [\u0027DONE\u0027, \u0027ERROR\u0027]:"},{"line_number":432,"context_line":"                raise common_ex.BlazarException(\u0027Invalid event status\u0027)"},{"line_number":433,"context_line":"            end_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":434,"context_line":"                \u0027lease_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_140da33d","line":431,"updated":"2017-09-05 15:40:33.000000000","message":"I think we should test for \"if not start_event\" too, if the lease is still being created or if something went wrong in the database and the event is missing.","commit_id":"58455bb491eee1f69b05508b38e52989f0482770"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"942fe7cfc81edae640c7c0d94979fd6798d4ce35","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    \u0027event_type\u0027: \u0027start_lease\u0027"},{"line_number":429,"context_line":"                }"},{"line_number":430,"context_line":"            )"},{"line_number":431,"context_line":"            if start_event[\u0027status\u0027] not in [\u0027DONE\u0027, \u0027ERROR\u0027]:"},{"line_number":432,"context_line":"                raise common_ex.BlazarException(\u0027Invalid event status\u0027)"},{"line_number":433,"context_line":"            end_event \u003d db_api.event_get_first_sorted_by_filters("},{"line_number":434,"context_line":"                \u0027lease_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_67bf89fb","line":431,"in_reply_to":"7f287b81_140da33d","updated":"2017-09-06 01:55:04.000000000","message":"Done","commit_id":"58455bb491eee1f69b05508b38e52989f0482770"}]}