)]}'
{"blazar/manager/service.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"0fae9c19bcacde79b245d5a3731cb7dea3f95999","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                         date_format\u003ddate_format)"},{"line_number":167,"context_line":"        return date"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def validate_params(self, values, marshall_attributes):"},{"line_number":170,"context_line":"        if isinstance(marshall_attributes, list):"},{"line_number":171,"context_line":"            marshall_attributes \u003d set(marshall_attributes)"},{"line_number":172,"context_line":"        missing_attr \u003d marshall_attributes - set(values.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_c7d0aafa","line":169,"range":{"start_line":169,"start_character":38,"end_line":169,"end_character":57},"updated":"2017-09-25 02:31:39.000000000","message":"What is this name comes from? Is it a common name for such a use case? I\u0027m sorry but I\u0027m not familiar with it.","commit_id":"e7b623a88b4e4b826203b87fdb0bfdb1c38066f4"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"8915c983e6c37bf39ca7b380281f1bcfbec1e830","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                         date_format\u003ddate_format)"},{"line_number":167,"context_line":"        return date"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def validate_params(self, values, marshall_attributes):"},{"line_number":170,"context_line":"        if isinstance(marshall_attributes, list):"},{"line_number":171,"context_line":"            marshall_attributes \u003d set(marshall_attributes)"},{"line_number":172,"context_line":"        missing_attr \u003d marshall_attributes - set(values.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_9279c494","line":169,"range":{"start_line":169,"start_character":38,"end_line":169,"end_character":57},"in_reply_to":"3f4b6375_c4ffbe32","updated":"2017-10-20 06:12:32.000000000","message":"OK, I changed it to required_params.","commit_id":"e7b623a88b4e4b826203b87fdb0bfdb1c38066f4"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"5d4a0210c7cfa7161e77754b225926076f720981","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                         date_format\u003ddate_format)"},{"line_number":167,"context_line":"        return date"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def validate_params(self, values, marshall_attributes):"},{"line_number":170,"context_line":"        if isinstance(marshall_attributes, list):"},{"line_number":171,"context_line":"            marshall_attributes \u003d set(marshall_attributes)"},{"line_number":172,"context_line":"        missing_attr \u003d marshall_attributes - set(values.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e95814fb","line":169,"range":{"start_line":169,"start_character":38,"end_line":169,"end_character":57},"in_reply_to":"7f515b1d_c7d0aafa","updated":"2017-10-05 09:13:52.000000000","message":"I think it\u0027s kind of variable name. I used same variable name with https://github.com/openstack/blazar/blob/b1c5d6636f2ed0c2041f5fe2e5bec4e449487091/blazar/plugins/instances/instance_plugin.py#L205\n\nIf it\u0027s not good I\u0027m ok to change it. What\u0027s more easy to read?","commit_id":"e7b623a88b4e4b826203b87fdb0bfdb1c38066f4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"2f9d4532d0130546a970b702e95ed373805b2fe0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                         date_format\u003ddate_format)"},{"line_number":167,"context_line":"        return date"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def validate_params(self, values, marshall_attributes):"},{"line_number":170,"context_line":"        if isinstance(marshall_attributes, list):"},{"line_number":171,"context_line":"            marshall_attributes \u003d set(marshall_attributes)"},{"line_number":172,"context_line":"        missing_attr \u003d marshall_attributes - set(values.keys())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c4ffbe32","line":169,"range":{"start_line":169,"start_character":38,"end_line":169,"end_character":57},"in_reply_to":"7f515b1d_e95814fb","updated":"2017-10-18 05:29:40.000000000","message":"Got it. I don\u0027t have a strong preference but how about required_attributes or required_params?","commit_id":"e7b623a88b4e4b826203b87fdb0bfdb1c38066f4"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"1ac637712dda3a33ae9ead53639c82412f0f0b0d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # Remove and keep event and reservation values"},{"line_number":195,"context_line":"        events \u003d lease_values.pop(\"events\", [])"},{"line_number":196,"context_line":"        # Create the lease without the reservations"},{"line_number":197,"context_line":"        reservations \u003d lease_values.pop(\"reservations\", [])"},{"line_number":198,"context_line":"        for res in reservations:"},{"line_number":199,"context_line":"            self.validate_params(res, [\u0027resource_type\u0027])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        start_date \u003d lease_values[\u0027start_date\u0027]"},{"line_number":202,"context_line":"        end_date \u003d lease_values[\u0027end_date\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_973cefbf","line":199,"range":{"start_line":197,"start_character":1,"end_line":199,"end_character":56},"updated":"2017-10-23 01:19:01.000000000","message":"Why this part was moved to below L196? Though the comment at L194 describes what this part does.","commit_id":"5d9d0b72bc59e0092342f3308f056011ab1bbfca"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b8623d30dfc4d420b176d58eb0f90b5a306a6200","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # Remove and keep event and reservation values"},{"line_number":195,"context_line":"        events \u003d lease_values.pop(\"events\", [])"},{"line_number":196,"context_line":"        # Create the lease without the reservations"},{"line_number":197,"context_line":"        reservations \u003d lease_values.pop(\"reservations\", [])"},{"line_number":198,"context_line":"        for res in reservations:"},{"line_number":199,"context_line":"            self.validate_params(res, [\u0027resource_type\u0027])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        start_date \u003d lease_values[\u0027start_date\u0027]"},{"line_number":202,"context_line":"        end_date \u003d lease_values[\u0027end_date\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_b480e547","line":199,"range":{"start_line":197,"start_character":1,"end_line":199,"end_character":56},"in_reply_to":"3f4b6375_973cefbf","updated":"2017-10-24 04:40:23.000000000","message":"Oops, just a mistake. I\u0027ll take it back.","commit_id":"5d9d0b72bc59e0092342f3308f056011ab1bbfca"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c674cef682b330a77f95dd17879cd6fbb316f37f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            required_params \u003d set(required_params)"},{"line_number":172,"context_line":"        missing_attr \u003d required_params - set(values.keys())"},{"line_number":173,"context_line":"        if missing_attr:"},{"line_number":174,"context_line":"            raise exceptions.MissingParameter(param\u003d\u0027,\u0027.join(missing_attr))"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def get_lease(self, lease_id):"},{"line_number":177,"context_line":"        return db_api.lease_get(lease_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_7cbd48b5","line":174,"range":{"start_line":174,"start_character":52,"end_line":174,"end_character":55},"updated":"2017-10-27 10:01:56.000000000","message":"Please use \u0027, \u0027 to better format the exception message.","commit_id":"3c7e5c4d5ea27dae634c8935af691a5f9362d964"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"54bb64c6c3eba7c2a12468ec0de6a9102249812e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            required_params \u003d set(required_params)"},{"line_number":172,"context_line":"        missing_attr \u003d required_params - set(values.keys())"},{"line_number":173,"context_line":"        if missing_attr:"},{"line_number":174,"context_line":"            raise exceptions.MissingParameter(param\u003d\u0027,\u0027.join(missing_attr))"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def get_lease(self, lease_id):"},{"line_number":177,"context_line":"        return db_api.lease_get(lease_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_e74a9faa","line":174,"range":{"start_line":174,"start_character":52,"end_line":174,"end_character":55},"in_reply_to":"3f4b6375_7cbd48b5","updated":"2017-10-30 05:07:26.000000000","message":"You\u0027re right. Done.","commit_id":"3c7e5c4d5ea27dae634c8935af691a5f9362d964"}]}
