)]}'
{"blazar/manager/monitor.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_dbc86f23","line":1,"updated":"2017-11-24 09:22:50.000000000","message":"As I comment in manager/service.py, the monitor classes could be separated from blazar-manager. It\u0027s ok to move this file to blazar/monitor.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_66a2b1fe","line":1,"in_reply_to":"ff82abbf_dbc86f23","updated":"2017-11-28 02:31:37.000000000","message":"Done","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def start_monitoring(self):"},{"line_number":28,"context_line":"        LOG.debug(\u0027Starting monitoring resources...\u0027)"},{"line_number":29,"context_line":"        try:"},{"line_number":30,"context_line":"            self.monitor.start()"},{"line_number":31,"context_line":"        except Exception as e:"},{"line_number":32,"context_line":"            LOG.error(\u0027Failed to start monitoring. (%s)\u0027, e.message)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_26529edf","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"updated":"2017-11-24 09:22:50.000000000","message":"Please raise NotImplemented error or assign nope function/class to self.monitor here because This class doesn\u0027t have __init__ class.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def start_monitoring(self):"},{"line_number":28,"context_line":"        LOG.debug(\u0027Starting monitoring resources...\u0027)"},{"line_number":29,"context_line":"        try:"},{"line_number":30,"context_line":"            self.monitor.start()"},{"line_number":31,"context_line":"        except Exception as e:"},{"line_number":32,"context_line":"            LOG.error(\u0027Failed to start monitoring. (%s)\u0027, e.message)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_46dbed7a","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"in_reply_to":"ff82abbf_26529edf","updated":"2017-11-28 02:31:37.000000000","message":"Agree. I\u0027ve decorated it with \u0027abstractmethod\u0027.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class NotificationMonitor(BaseMonitor):"},{"line_number":43,"context_line":"    \"\"\"A notification based monitor.\"\"\""},{"line_number":44,"context_line":"    def __init__(self, plugins):"},{"line_number":45,"context_line":"        \"\"\"Initialize a monitor (notification listener).\"\"\""},{"line_number":46,"context_line":"        LOG.debug(\u0027Initializing a resource monitor...\u0027)"},{"line_number":47,"context_line":"        for plugin in plugins:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_26337ef8","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":30},"updated":"2017-11-24 09:22:50.000000000","message":"It\u0027s better to rename the variable. At least, I was confused with reservation plugin and monitoring plugin. How about monitor_plugins, m_plugins, etc?","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class NotificationMonitor(BaseMonitor):"},{"line_number":43,"context_line":"    \"\"\"A notification based monitor.\"\"\""},{"line_number":44,"context_line":"    def __init__(self, plugins):"},{"line_number":45,"context_line":"        \"\"\"Initialize a monitor (notification listener).\"\"\""},{"line_number":46,"context_line":"        LOG.debug(\u0027Initializing a resource monitor...\u0027)"},{"line_number":47,"context_line":"        for plugin in plugins:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_26c7c998","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":30},"in_reply_to":"ff82abbf_26337ef8","updated":"2017-11-28 02:31:37.000000000","message":"Sorry for confusing name. I\u0027ve renamed it monitor_plugins.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\"Initialize a monitor (notification listener).\"\"\""},{"line_number":46,"context_line":"        LOG.debug(\u0027Initializing a resource monitor...\u0027)"},{"line_number":47,"context_line":"        for plugin in plugins:"},{"line_number":48,"context_line":"            plugin.notification_handler \u003d ("},{"line_number":49,"context_line":"                lambda event_type, message: self.update_statuses("},{"line_number":50,"context_line":"                    plugin.notification_callback, event_type, message))"},{"line_number":51,"context_line":"        self.monitor \u003d notification_listener.Listener("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_fb20d3ae","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":39},"updated":"2017-11-24 09:22:50.000000000","message":"I can\u0027t see notification_handler in neither BaseMonitorPlugin and PhysicalHostMonitorPlugin.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\"Initialize a monitor (notification listener).\"\"\""},{"line_number":46,"context_line":"        LOG.debug(\u0027Initializing a resource monitor...\u0027)"},{"line_number":47,"context_line":"        for plugin in plugins:"},{"line_number":48,"context_line":"            plugin.notification_handler \u003d ("},{"line_number":49,"context_line":"                lambda event_type, message: self.update_statuses("},{"line_number":50,"context_line":"                    plugin.notification_callback, event_type, message))"},{"line_number":51,"context_line":"        self.monitor \u003d notification_listener.Listener("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_a638b99f","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":39},"in_reply_to":"ff82abbf_fb20d3ae","updated":"2017-11-28 02:31:37.000000000","message":"Done","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            # reservations. Depends on the state-machine blueprint."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Update flags of related leases and reservations."},{"line_number":72,"context_line":"        lease_ids \u003d []"},{"line_number":73,"context_line":"        for reservation_id, flags in reservation_flags.items():"},{"line_number":74,"context_line":"            db_api.reservation_update(reservation_id, flags)"},{"line_number":75,"context_line":"            reservation \u003d db_api.reservation_get(reservation_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_d82cf503","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":22},"updated":"2017-11-24 09:22:50.000000000","message":"If lease_ids is set([]), it\u0027s not need to cast to set object at L77.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            # reservations. Depends on the state-machine blueprint."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Update flags of related leases and reservations."},{"line_number":72,"context_line":"        lease_ids \u003d []"},{"line_number":73,"context_line":"        for reservation_id, flags in reservation_flags.items():"},{"line_number":74,"context_line":"            db_api.reservation_update(reservation_id, flags)"},{"line_number":75,"context_line":"            reservation \u003d db_api.reservation_get(reservation_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_663e318c","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":22},"in_reply_to":"ff82abbf_d82cf503","updated":"2017-11-28 02:31:37.000000000","message":"Done","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            LOG.error(\u0027Failed to start monitoring. (%s)\u0027, e.message)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"class PollingMonitorService(service.Service):"},{"line_number":101,"context_line":"    def __init__(self, plugins\u003dNone):"},{"line_number":102,"context_line":"        super(PollingMonitorService, self).__init__()"},{"line_number":103,"context_line":"        self.plugins \u003d plugins"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_f8c459f7","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":45},"updated":"2017-11-24 09:22:50.000000000","message":"oslo_service.service.Service is not a thread but a Service run on hosts, e.g blazar-api, blazar-maager.  It should be oslo_service.threadgroup or eventlet.greenthread.\n\nhttps://docs.openstack.org/oslo.service/latest/","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            LOG.error(\u0027Failed to start monitoring. (%s)\u0027, e.message)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"class PollingMonitorService(service.Service):"},{"line_number":101,"context_line":"    def __init__(self, plugins\u003dNone):"},{"line_number":102,"context_line":"        super(PollingMonitorService, self).__init__()"},{"line_number":103,"context_line":"        self.plugins \u003d plugins"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_064f2534","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":45},"in_reply_to":"ff82abbf_f8c459f7","updated":"2017-11-28 02:31:37.000000000","message":"I\u0027m sorry I misunderstood usage. It uses oslo_service.threadgroup now.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            # TODO(hiro-kobayashi): update statuses of related leases and"},{"line_number":128,"context_line":"            # reservations. Depends on the state-machine blueprint."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # Update flags of related leases and reservations."},{"line_number":131,"context_line":"        lease_ids \u003d []"},{"line_number":132,"context_line":"        for reservation_id, flags in reservation_flags.items():"},{"line_number":133,"context_line":"            db_api.reservation_update(reservation_id, flags)"},{"line_number":134,"context_line":"            reservation \u003d db_api.reservation_get(reservation_id)"},{"line_number":135,"context_line":"            lease_ids.append(reservation[\u0027lease_id\u0027])"},{"line_number":136,"context_line":"        for lease_id in set(lease_ids):"},{"line_number":137,"context_line":"            db_api.lease_update(lease_id, {\u0027degraded\u0027: True})"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_66d18623","line":137,"range":{"start_line":130,"start_character":0,"end_line":137,"end_character":61},"updated":"2017-11-24 09:22:50.000000000","message":"The logic can be moved to BaseMonitor, can\u0027t it?  I imagine the reason the codes is not in PollingMonitor class is PollingMonitorService is implemented as a service.Service.  But as I commented above, this should be greenthread and I think the update_statuses() can be moved to PollingMonitor class.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            # TODO(hiro-kobayashi): update statuses of related leases and"},{"line_number":128,"context_line":"            # reservations. Depends on the state-machine blueprint."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        # Update flags of related leases and reservations."},{"line_number":131,"context_line":"        lease_ids \u003d []"},{"line_number":132,"context_line":"        for reservation_id, flags in reservation_flags.items():"},{"line_number":133,"context_line":"            db_api.reservation_update(reservation_id, flags)"},{"line_number":134,"context_line":"            reservation \u003d db_api.reservation_get(reservation_id)"},{"line_number":135,"context_line":"            lease_ids.append(reservation[\u0027lease_id\u0027])"},{"line_number":136,"context_line":"        for lease_id in set(lease_ids):"},{"line_number":137,"context_line":"            db_api.lease_update(lease_id, {\u0027degraded\u0027: True})"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_665711cc","line":137,"range":{"start_line":130,"start_character":0,"end_line":137,"end_character":61},"in_reply_to":"ff82abbf_66d18623","updated":"2017-11-28 02:31:37.000000000","message":"I\u0027ve moved it to the BaseMonitor class.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"}],"blazar/manager/service.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Setup resource monitors.\"\"\""},{"line_number":130,"context_line":"        monitors \u003d []"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Setup a notification monitor"},{"line_number":133,"context_line":"        notification_plugins \u003d []"},{"line_number":134,"context_line":"        for plugin in plugins.values():"},{"line_number":135,"context_line":"            if plugin.monitor:"},{"line_number":136,"context_line":"                if plugin.monitor.is_notification_enabled():"},{"line_number":137,"context_line":"                    notification_plugins.append(plugin.monitor)"},{"line_number":138,"context_line":"        monitors.append(monitor.NotificationMonitor(notification_plugins))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Setup a polling monitor"},{"line_number":141,"context_line":"        polling_plugins \u003d []"},{"line_number":142,"context_line":"        for plugin in plugins.values():"},{"line_number":143,"context_line":"            if plugin.monitor:"},{"line_number":144,"context_line":"                if plugin.monitor.is_polling_enabled():"},{"line_number":145,"context_line":"                    polling_plugins.append(plugin.monitor)"},{"line_number":146,"context_line":"        monitors.append(monitor.PollingMonitor(polling_plugins))"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return monitors"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_7b260318","line":146,"range":{"start_line":132,"start_character":0,"end_line":146,"end_character":64},"updated":"2017-11-24 09:22:50.000000000","message":"I don\u0027t think it\u0027s a good approach that blazar-m figures out the difference of Polling or Notification.  As we do for reservation plugin to make the manager simple and general, reservation plugins should return monitor class instances, then blazar-m registers the instances and starts it later.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \"\"\"Setup resource monitors.\"\"\""},{"line_number":130,"context_line":"        monitors \u003d []"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Setup a notification monitor"},{"line_number":133,"context_line":"        notification_plugins \u003d []"},{"line_number":134,"context_line":"        for plugin in plugins.values():"},{"line_number":135,"context_line":"            if plugin.monitor:"},{"line_number":136,"context_line":"                if plugin.monitor.is_notification_enabled():"},{"line_number":137,"context_line":"                    notification_plugins.append(plugin.monitor)"},{"line_number":138,"context_line":"        monitors.append(monitor.NotificationMonitor(notification_plugins))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Setup a polling monitor"},{"line_number":141,"context_line":"        polling_plugins \u003d []"},{"line_number":142,"context_line":"        for plugin in plugins.values():"},{"line_number":143,"context_line":"            if plugin.monitor:"},{"line_number":144,"context_line":"                if plugin.monitor.is_polling_enabled():"},{"line_number":145,"context_line":"                    polling_plugins.append(plugin.monitor)"},{"line_number":146,"context_line":"        monitors.append(monitor.PollingMonitor(polling_plugins))"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return monitors"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_e6ffa1a8","line":146,"range":{"start_line":132,"start_character":0,"end_line":146,"end_character":64},"in_reply_to":"ff82abbf_7b260318","updated":"2017-11-28 02:31:37.000000000","message":"Agree. I\u0027ve added a load method in blazar.monitor. The manager can use both of NotificationMonitor and PollingMonitor through the unified BaseMonitor interfaces.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"}],"blazar/monitor/base.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"014f8c33a4f0013a72dca695977feea723d42eca","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # e.g. {\u0027dummyid\u0027: {\u0027missing_resources\u0027: True}}"},{"line_number":44,"context_line":"            reservation_flags \u003d callback(*args, **kwargs)"},{"line_number":45,"context_line":"        except Exception as e:"},{"line_number":46,"context_line":"            LOG.error(\u0027Caught an exception while executing a callback. %s\u0027,"},{"line_number":47,"context_line":"                      e.message)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            # TODO(hiro-kobayashi): update statuses of related leases and"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_4fbae0c0","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":21},"updated":"2017-11-30 07:37:30.000000000","message":"Use LOG.exception. It outputs traceback automatically.  And same for other changes.","commit_id":"adf7069a02f669898fd8264280b62ce59cf044ac"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"640191216668e3d520f35cdf3809b25382f86ca6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # e.g. {\u0027dummyid\u0027: {\u0027missing_resources\u0027: True}}"},{"line_number":44,"context_line":"            reservation_flags \u003d callback(*args, **kwargs)"},{"line_number":45,"context_line":"        except Exception as e:"},{"line_number":46,"context_line":"            LOG.error(\u0027Caught an exception while executing a callback. %s\u0027,"},{"line_number":47,"context_line":"                      e.message)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            # TODO(hiro-kobayashi): update statuses of related leases and"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_1afcfc3c","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":21},"in_reply_to":"ff82abbf_4fbae0c0","updated":"2017-12-01 02:37:52.000000000","message":"Done","commit_id":"adf7069a02f669898fd8264280b62ce59cf044ac"}],"blazar/monitor/notification_monitor.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"014f8c33a4f0013a72dca695977feea723d42eca","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                    lambda e_type, message: self.update_statuses("},{"line_number":92,"context_line":"                        plugin.notification_callback, e_type, message))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        return [NotificationEndpoint(handlers)]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class NotificationEndpoint(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_8f48e85b","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":47},"updated":"2017-11-30 07:37:30.000000000","message":"NotificationMonitor class should keep the handlers variable as its instance variable since it\u0027s easy to add/update/remove handler if needed.\n\n\u0027self\u0027 instance can be passed to other class in python like following.  Then a NotificationEndpoint keeps a reference to the NotificationMonitor to call handlers in handle_notification().\n\nreturn [NotificationEndpoint(self)]","commit_id":"adf7069a02f669898fd8264280b62ce59cf044ac"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"640191216668e3d520f35cdf3809b25382f86ca6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                    lambda e_type, message: self.update_statuses("},{"line_number":92,"context_line":"                        plugin.notification_callback, e_type, message))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        return [NotificationEndpoint(handlers)]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class NotificationEndpoint(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_ada838db","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":47},"in_reply_to":"ff82abbf_8f48e85b","updated":"2017-12-01 02:37:52.000000000","message":"Agree. Done.","commit_id":"adf7069a02f669898fd8264280b62ce59cf044ac"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"014f8c33a4f0013a72dca695977feea723d42eca","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def handle_notification(self, priority, ctxt, publisher_id, event_type,"},{"line_number":122,"context_line":"                            payload, metadata):"},{"line_number":123,"context_line":"        LOG.info(\u0027Receive a notification: priority: %s\\npublisher id: %s\\n\u0027"},{"line_number":124,"context_line":"                 \u0027event type: %s\\npayload: %s\u0027, priority, publisher_id,"},{"line_number":125,"context_line":"                 event_type, json.dumps(payload, indent\u003d4))"},{"line_number":126,"context_line":"        for handler in self.handlers[str(event_type)]:"},{"line_number":127,"context_line":"            handler(event_type, payload)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_afb12c46","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":47},"updated":"2017-11-30 07:37:30.000000000","message":"From my experience, it\u0027s better to separate values \u0027,\u0027 instead of \u0027\\n\u0027 for making one line log message. It\u0027s easy for operators to match log messages since they use regular expressions to filter log they want to observe.","commit_id":"adf7069a02f669898fd8264280b62ce59cf044ac"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"640191216668e3d520f35cdf3809b25382f86ca6","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def handle_notification(self, priority, ctxt, publisher_id, event_type,"},{"line_number":122,"context_line":"                            payload, metadata):"},{"line_number":123,"context_line":"        LOG.info(\u0027Receive a notification: priority: %s\\npublisher id: %s\\n\u0027"},{"line_number":124,"context_line":"                 \u0027event type: %s\\npayload: %s\u0027, priority, publisher_id,"},{"line_number":125,"context_line":"                 event_type, json.dumps(payload, indent\u003d4))"},{"line_number":126,"context_line":"        for handler in self.handlers[str(event_type)]:"},{"line_number":127,"context_line":"            handler(event_type, payload)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_2db42835","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":47},"in_reply_to":"ff82abbf_afb12c46","updated":"2017-12-01 02:37:52.000000000","message":"Done","commit_id":"adf7069a02f669898fd8264280b62ce59cf044ac"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def handle_notification(self, priority, ctxt, publisher_id, event_type,"},{"line_number":121,"context_line":"                            payload, metadata):"},{"line_number":122,"context_line":"        LOG.info(\u0027Receive a notification: priority: %s, publisher id: %s, \u0027"},{"line_number":123,"context_line":"                 \u0027event type: %s, payload: %s\u0027, priority, publisher_id,"},{"line_number":124,"context_line":"                 event_type, payload)"},{"line_number":125,"context_line":"        for handler in self.monitor.handlers[str(event_type)]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_dc79d7c4","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":25},"updated":"2017-12-12 10:40:50.000000000","message":"Received","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def handle_notification(self, priority, ctxt, publisher_id, event_type,"},{"line_number":121,"context_line":"                            payload, metadata):"},{"line_number":122,"context_line":"        LOG.info(\u0027Receive a notification: priority: %s, publisher id: %s, \u0027"},{"line_number":123,"context_line":"                 \u0027event type: %s, payload: %s\u0027, priority, publisher_id,"},{"line_number":124,"context_line":"                 event_type, payload)"},{"line_number":125,"context_line":"        for handler in self.monitor.handlers[str(event_type)]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_102072b0","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":25},"in_reply_to":"df87a7cf_dc79d7c4","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"}],"blazar/notification/listener.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"a96f121387ad5b81f1a1c77dc5fbc3bee7dad401","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def handle_notification(self, priority, ctxt, publisher_id, event_type,"},{"line_number":117,"context_line":"                            payload, metadata):"},{"line_number":118,"context_line":"        LOG.info(\u0027Receive a notification: priority: %s\u0027, priority)"},{"line_number":119,"context_line":"        LOG.info(\u0027Receive a notification: publisher id: %s\u0027, publisher_id)"},{"line_number":120,"context_line":"        LOG.info(\u0027Receive a notification: event type: %s\u0027, event_type)"},{"line_number":121,"context_line":"        LOG.info(\u0027Receive a notification: payload: %s\u0027, json.dumps(payload,"},{"line_number":122,"context_line":"                                                                   indent\u003d4))"},{"line_number":123,"context_line":"        for handler in self.handlers[str(event_type)]:"},{"line_number":124,"context_line":"            handler(event_type, payload)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_fb90d34c","line":122,"range":{"start_line":118,"start_character":0,"end_line":122,"end_character":77},"updated":"2017-11-24 09:22:50.000000000","message":"It\u0027s better to merge the four messages to one message. If multi hypervisors send notification in parallel, it\u0027s hard to trace the message dependencies.","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"3d875bf602b261fd8a1b1b9a6c0ce079e60c5055","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def handle_notification(self, priority, ctxt, publisher_id, event_type,"},{"line_number":117,"context_line":"                            payload, metadata):"},{"line_number":118,"context_line":"        LOG.info(\u0027Receive a notification: priority: %s\u0027, priority)"},{"line_number":119,"context_line":"        LOG.info(\u0027Receive a notification: publisher id: %s\u0027, publisher_id)"},{"line_number":120,"context_line":"        LOG.info(\u0027Receive a notification: event type: %s\u0027, event_type)"},{"line_number":121,"context_line":"        LOG.info(\u0027Receive a notification: payload: %s\u0027, json.dumps(payload,"},{"line_number":122,"context_line":"                                                                   indent\u003d4))"},{"line_number":123,"context_line":"        for handler in self.handlers[str(event_type)]:"},{"line_number":124,"context_line":"            handler(event_type, payload)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_06fde5af","line":122,"range":{"start_line":118,"start_character":0,"end_line":122,"end_character":77},"in_reply_to":"ff82abbf_fb90d34c","updated":"2017-11-28 02:31:37.000000000","message":"Done","commit_id":"211ca4cb39a20cf677667ac41f9de8599829ea06"}],"blazar/plugins/base.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @abc.abstractmethod"},{"line_number":104,"context_line":"    def get_notification_topics(self):"},{"line_number":105,"context_line":"        \"\"\"Get a list of topics of notification to subscribe.\"\"\""},{"line_number":106,"context_line":"        pass"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_3c448373","line":105,"range":{"start_line":105,"start_character":48,"end_line":105,"end_character":60},"updated":"2017-12-12 10:40:50.000000000","message":"to subscribe to","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @abc.abstractmethod"},{"line_number":104,"context_line":"    def get_notification_topics(self):"},{"line_number":105,"context_line":"        \"\"\"Get a list of topics of notification to subscribe.\"\"\""},{"line_number":106,"context_line":"        pass"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_30125664","line":105,"range":{"start_line":105,"start_character":48,"end_line":105,"end_character":60},"in_reply_to":"df87a7cf_3c448373","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                    \u0027the lease\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027enable_notification_monitor\u0027,"},{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d\u0027Enable a notification based resource monitoring. \u0027"},{"line_number":55,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states of \u0027"},{"line_number":56,"context_line":"                     \u0027compute hosts by subscribing notifications of Nova.\u0027),"},{"line_number":57,"context_line":"    cfg.ListOpt(\u0027notification_topics\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_1c5dff45","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":49},"updated":"2017-12-12 10:40:50.000000000","message":"notification-based","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                    \u0027the lease\u0027),"},{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027enable_notification_monitor\u0027,"},{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d\u0027Enable a notification based resource monitoring. \u0027"},{"line_number":55,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states of \u0027"},{"line_number":56,"context_line":"                     \u0027compute hosts by subscribing notifications of Nova.\u0027),"},{"line_number":57,"context_line":"    cfg.ListOpt(\u0027notification_topics\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_b0050617","line":54,"range":{"start_line":54,"start_character":29,"end_line":54,"end_character":49},"in_reply_to":"df87a7cf_1c5dff45","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d\u0027Enable a notification based resource monitoring. \u0027"},{"line_number":55,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states of \u0027"},{"line_number":56,"context_line":"                     \u0027compute hosts by subscribing notifications of Nova.\u0027),"},{"line_number":57,"context_line":"    cfg.ListOpt(\u0027notification_topics\u0027,"},{"line_number":58,"context_line":"                default\u003d[\u0027notifications\u0027, \u0027versioned_notifications\u0027],"},{"line_number":59,"context_line":"                help\u003d\u0027Notification topics to subscribe.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_9c36ef02","line":56,"range":{"start_line":56,"start_character":36,"end_line":56,"end_character":72},"updated":"2017-12-12 10:40:50.000000000","message":"by subscribing to notifications from Nova","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d\u0027Enable a notification based resource monitoring. \u0027"},{"line_number":55,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states of \u0027"},{"line_number":56,"context_line":"                     \u0027compute hosts by subscribing notifications of Nova.\u0027),"},{"line_number":57,"context_line":"    cfg.ListOpt(\u0027notification_topics\u0027,"},{"line_number":58,"context_line":"                default\u003d[\u0027notifications\u0027, \u0027versioned_notifications\u0027],"},{"line_number":59,"context_line":"                help\u003d\u0027Notification topics to subscribe.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_7bfd1f07","line":56,"range":{"start_line":56,"start_character":36,"end_line":56,"end_character":72},"in_reply_to":"df87a7cf_9c36ef02","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                     \u0027compute hosts by subscribing notifications of Nova.\u0027),"},{"line_number":57,"context_line":"    cfg.ListOpt(\u0027notification_topics\u0027,"},{"line_number":58,"context_line":"                default\u003d[\u0027notifications\u0027, \u0027versioned_notifications\u0027],"},{"line_number":59,"context_line":"                help\u003d\u0027Notification topics to subscribe.\u0027),"},{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_polling_monitor\u0027,"},{"line_number":61,"context_line":"                default\u003dTrue,"},{"line_number":62,"context_line":"                help\u003d\u0027Enable a polling based resource monitoring. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_3c39e3f0","line":59,"range":{"start_line":59,"start_character":42,"end_line":59,"end_character":54},"updated":"2017-12-12 10:40:50.000000000","message":"to subscribe to","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                     \u0027compute hosts by subscribing notifications of Nova.\u0027),"},{"line_number":57,"context_line":"    cfg.ListOpt(\u0027notification_topics\u0027,"},{"line_number":58,"context_line":"                default\u003d[\u0027notifications\u0027, \u0027versioned_notifications\u0027],"},{"line_number":59,"context_line":"                help\u003d\u0027Notification topics to subscribe.\u0027),"},{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_polling_monitor\u0027,"},{"line_number":61,"context_line":"                default\u003dTrue,"},{"line_number":62,"context_line":"                help\u003d\u0027Enable a polling based resource monitoring. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_9b026309","line":59,"range":{"start_line":59,"start_character":42,"end_line":59,"end_character":54},"in_reply_to":"df87a7cf_3c39e3f0","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                help\u003d\u0027Notification topics to subscribe.\u0027),"},{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_polling_monitor\u0027,"},{"line_number":61,"context_line":"                default\u003dTrue,"},{"line_number":62,"context_line":"                help\u003d\u0027Enable a polling based resource monitoring. \u0027"},{"line_number":63,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states \u0027"},{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_1c22dfb9","line":62,"range":{"start_line":62,"start_character":29,"end_line":62,"end_character":44},"updated":"2017-12-12 10:40:50.000000000","message":"polling-based","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                help\u003d\u0027Notification topics to subscribe.\u0027),"},{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_polling_monitor\u0027,"},{"line_number":61,"context_line":"                default\u003dTrue,"},{"line_number":62,"context_line":"                help\u003d\u0027Enable a polling based resource monitoring. \u0027"},{"line_number":63,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states \u0027"},{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_fb104f52","line":62,"range":{"start_line":62,"start_character":29,"end_line":62,"end_character":44},"in_reply_to":"df87a7cf_1c22dfb9","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                default\u003dTrue,"},{"line_number":62,"context_line":"                help\u003d\u0027Enable a polling based resource monitoring. \u0027"},{"line_number":63,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states \u0027"},{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d60,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval (seconds) of pooling for helth checking.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_bc2c13ac","line":64,"range":{"start_line":64,"start_character":50,"end_line":64,"end_character":58},"updated":"2017-12-12 10:40:50.000000000","message":"the Nova API","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                default\u003dTrue,"},{"line_number":62,"context_line":"                help\u003d\u0027Enable a polling based resource monitoring. \u0027"},{"line_number":63,"context_line":"                     \u0027If it is enabled, the blazar-manager monitors states \u0027"},{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d60,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval (seconds) of pooling for helth checking.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_db178b45","line":64,"range":{"start_line":64,"start_character":50,"end_line":64,"end_character":58},"in_reply_to":"df87a7cf_bc2c13ac","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d60,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval (seconds) of pooling for helth checking.\u0027),"},{"line_number":68,"context_line":"]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_3c124363","line":67,"range":{"start_line":67,"start_character":55,"end_line":67,"end_character":60},"updated":"2017-12-12 10:40:50.000000000","message":"health","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d60,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval (seconds) of pooling for helth checking.\u0027),"},{"line_number":68,"context_line":"]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_dc2797c6","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":50},"updated":"2017-12-12 10:40:50.000000000","message":"polling","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d60,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval (seconds) of pooling for helth checking.\u0027),"},{"line_number":68,"context_line":"]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_3b20f79b","line":67,"range":{"start_line":67,"start_character":55,"end_line":67,"end_character":60},"in_reply_to":"df87a7cf_3c124363","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                     \u0027of compute hosts by polling Nova API.\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027,"},{"line_number":66,"context_line":"               default\u003d60,"},{"line_number":67,"context_line":"               help\u003d\u0027Interval (seconds) of pooling for helth checking.\u0027),"},{"line_number":68,"context_line":"]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_fb392fd8","line":67,"range":{"start_line":67,"start_character":43,"end_line":67,"end_character":50},"in_reply_to":"df87a7cf_dc2797c6","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        return [\u0027service.update\u0027]"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def get_notification_topics(self):"},{"line_number":548,"context_line":"        \"\"\"Get topics of notification to subscribe.\"\"\""},{"line_number":549,"context_line":"        return CONF[plugin.RESOURCE_TYPE].notification_topics"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def notification_callback(self, event_type, message):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_5c15c747","line":548,"range":{"start_line":548,"start_character":38,"end_line":548,"end_character":50},"updated":"2017-12-12 10:40:50.000000000","message":"to subscribe to","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        return [\u0027service.update\u0027]"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def get_notification_topics(self):"},{"line_number":548,"context_line":"        \"\"\"Get topics of notification to subscribe.\"\"\""},{"line_number":549,"context_line":"        return CONF[plugin.RESOURCE_TYPE].notification_topics"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def notification_callback(self, event_type, message):"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_9b50230d","line":548,"range":{"start_line":548,"start_character":38,"end_line":548,"end_character":50},"in_reply_to":"df87a7cf_5c15c747","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"220b2c2716b305be7879aff5602e334a189a6d05","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    def notification_callback(self, event_type, message):"},{"line_number":552,"context_line":"        \"\"\"Handle a notification message."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        It is used as a callback of a notification based resource monitor."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        :param event_type: an event type of message."},{"line_number":557,"context_line":"        :param message: a message passed by monitors."}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_fc0ffb33","line":554,"range":{"start_line":554,"start_character":38,"end_line":554,"end_character":56},"updated":"2017-12-12 10:40:50.000000000","message":"notification-based","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ca18daf7e5899e836db51332be386f4db3fa1da6","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    def notification_callback(self, event_type, message):"},{"line_number":552,"context_line":"        \"\"\"Handle a notification message."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        It is used as a callback of a notification based resource monitor."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        :param event_type: an event type of message."},{"line_number":557,"context_line":"        :param message: a message passed by monitors."}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_1b3c13be","line":554,"range":{"start_line":554,"start_character":38,"end_line":554,"end_character":56},"in_reply_to":"df87a7cf_fc0ffb33","updated":"2017-12-13 02:43:14.000000000","message":"Done","commit_id":"5065c82b74054c393330e5d4c7abcb151a73b19c"}]}
