)]}'
{"blazar/plugins/instances/instance_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"cd0962dd75a1793501357eb7343b7e91a2bcb4aa","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            [\"\u003e\u003d\", \"$local_gb\", str(disk)],"},{"line_number":124,"context_line":"            ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        filters \u003d [\u0027reservable \u003d\u003d 1\u0027]"},{"line_number":127,"context_line":"        filters +\u003d plugins_utils.convert_requirements(flavor_definitions)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        hosts \u003d db_api.host_get_all_by_queries(filters)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_1b9c7e5b","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":73},"updated":"2017-11-27 03:05:25.000000000","message":"\u0027reservable\u0027 is a general flag. So it\u0027s good to put the logic in utils module, then this plugin just calls a util method in the module.","commit_id":"2400e2d693bfdefd0ff6a3220b8f5d267e15022e"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"173f18f03479133468c474195eed7981f0064fa0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            [\"\u003e\u003d\", \"$local_gb\", str(disk)],"},{"line_number":124,"context_line":"            ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        filters \u003d [\u0027reservable \u003d\u003d 1\u0027]"},{"line_number":127,"context_line":"        filters +\u003d plugins_utils.convert_requirements(flavor_definitions)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        hosts \u003d db_api.host_get_all_by_queries(filters)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_c67ffddd","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":73},"in_reply_to":"ff82abbf_1b9c7e5b","updated":"2017-11-28 02:49:45.000000000","message":"Do you propose to add this logic into the convert_requirements? I think it\u0027s better to keep this  method general so that it can be used for searching both of reservable and unreservable hosts.","commit_id":"2400e2d693bfdefd0ff6a3220b8f5d267e15022e"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"5f4a1a795e310d5099e388beaa55055eb9b3b7e1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            [\"\u003e\u003d\", \"$local_gb\", str(disk)],"},{"line_number":124,"context_line":"            ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        filters \u003d [\u0027reservable \u003d\u003d 1\u0027]"},{"line_number":127,"context_line":"        filters +\u003d plugins_utils.convert_requirements(flavor_definitions)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        hosts \u003d db_api.host_get_all_by_queries(filters)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_9bfb5245","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":73},"in_reply_to":"ff82abbf_c67ffddd","updated":"2017-11-30 01:54:30.000000000","message":"Sorry, my comment was not clear.  I mean it\u0027s good to define utility function instead of direct insertion of [\u0027reservable \u003d\u003d 1\u0027] like following:\n\n filters +\u003d plugin_utils.reservable_flag()","commit_id":"2400e2d693bfdefd0ff6a3220b8f5d267e15022e"}]}
