)]}'
{"blazar/monitor/base.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        for plugin in self.monitor_plugins:"},{"line_number":47,"context_line":"            healing_interval \u003d plugin.get_healing_interval()"},{"line_number":48,"context_line":"            self.healing_timers.append("},{"line_number":49,"context_line":"                self.tg.add_timer(healing_interval * 60,"},{"line_number":50,"context_line":"                                  self.call_monitor_plugin,"},{"line_number":51,"context_line":"                                  None,"},{"line_number":52,"context_line":"                                  plugin.heal,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_cd7acdb8","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":55},"updated":"2018-03-30 00:51:21.000000000","message":"Why this timer is 60 times?","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        for plugin in self.monitor_plugins:"},{"line_number":47,"context_line":"            healing_interval \u003d plugin.get_healing_interval()"},{"line_number":48,"context_line":"            self.healing_timers.append("},{"line_number":49,"context_line":"                self.tg.add_timer(healing_interval * 60,"},{"line_number":50,"context_line":"                                  self.call_monitor_plugin,"},{"line_number":51,"context_line":"                                  None,"},{"line_number":52,"context_line":"                                  plugin.heal,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_0890cc49","line":49,"range":{"start_line":49,"start_character":34,"end_line":49,"end_character":55},"in_reply_to":"bf659307_cd7acdb8","updated":"2018-04-12 01:25:32.000000000","message":"It if for converting time from minutes to seconds. I renamed the \u0027healing_interval\u0027 \u0027healing_interval_mins\u0027.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def stop_periodic_healing(self):"},{"line_number":56,"context_line":"        \"\"\"Stop periodic healing process.\"\"\""},{"line_number":57,"context_line":"        for timer in self.healing_timers:"},{"line_number":58,"context_line":"            self.tg.timer_done(timer)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def call_monitor_plugin(self, callback, *args, **kwargs):"},{"line_number":61,"context_line":"        \"\"\"Call a callback and update lease/reservation flags.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_8df61563","line":58,"updated":"2018-03-30 00:51:21.000000000","message":"The periodic healing is a fundamental function of Monitor class. Both of the method should start in start_monitoring and stop_monitoring of this class. And child classes, NotificatonMonitor and PollingMonitor, just call its parent\u0027s method.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def stop_periodic_healing(self):"},{"line_number":56,"context_line":"        \"\"\"Stop periodic healing process.\"\"\""},{"line_number":57,"context_line":"        for timer in self.healing_timers:"},{"line_number":58,"context_line":"            self.tg.timer_done(timer)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def call_monitor_plugin(self, callback, *args, **kwargs):"},{"line_number":61,"context_line":"        \"\"\"Call a callback and update lease/reservation flags.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_087f6ce0","line":58,"in_reply_to":"bf659307_8df61563","updated":"2018-04-12 01:25:32.000000000","message":"Agree. Done.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"}],"blazar/monitor/polling_monitor.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"44ee18f4e8d87cb7dd8fd980d86c733406a04a1d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            for timer in self.polling_timers:"},{"line_number":52,"context_line":"                self.tg.timer_done(timer)"},{"line_number":53,"context_line":"            super(PollingMonitor, self).stopmonitoring()"},{"line_number":54,"context_line":"        except Exception as e:"},{"line_number":55,"context_line":"            LOG.exception(\u0027Failed to stop a polling monitor. (%s)\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_467bd3f3","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":56},"updated":"2018-04-13 06:34:22.000000000","message":"s/stopmonitoring/stop_monitoring","commit_id":"dd35fe78f7cbc906a35a2e6852f1cf31f472bfa8"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"6c1a2724ba67ea9e49845af8635293a2aa3fbe1a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            for timer in self.polling_timers:"},{"line_number":52,"context_line":"                self.tg.timer_done(timer)"},{"line_number":53,"context_line":"            super(PollingMonitor, self).stopmonitoring()"},{"line_number":54,"context_line":"        except Exception as e:"},{"line_number":55,"context_line":"            LOG.exception(\u0027Failed to stop a polling monitor. (%s)\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_63824d52","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":56},"in_reply_to":"bf659307_467bd3f3","updated":"2018-04-16 05:59:36.000000000","message":"Done","commit_id":"dd35fe78f7cbc906a35a2e6852f1cf31f472bfa8"}],"blazar/plugins/base.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        pass"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @abc.abstractmethod"},{"line_number":160,"context_line":"    def heal(self, start_date\u003dNone, end_date\u003dNone, period\u003dNone):"},{"line_number":161,"context_line":"        \"\"\"Heal suffering reservations in the specified period."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        It heals reservations which overlap with the period from start_date"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_789c9dbf","line":160,"range":{"start_line":160,"start_character":19,"end_line":160,"end_character":64},"updated":"2018-03-30 00:51:21.000000000","message":"The argument is really needed? Each monitor plugin can calculate beginning and end in its heal method. As I commented below, the default behavior is also bit strange.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        pass"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @abc.abstractmethod"},{"line_number":160,"context_line":"    def heal(self, start_date\u003dNone, end_date\u003dNone, period\u003dNone):"},{"line_number":161,"context_line":"        \"\"\"Heal suffering reservations in the specified period."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        It heals reservations which overlap with the period from start_date"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_b3a7b650","line":160,"range":{"start_line":160,"start_character":19,"end_line":160,"end_character":64},"in_reply_to":"bf659307_789c9dbf","updated":"2018-04-12 01:25:32.000000000","message":"I introduced these parameter for flexibly change healing time. However, current use cases of the heal() use only configured healing time. So, I think these parameters are not needed now. To simplify implementation, I removed these parameters.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Heal suffering reservations in the specified period."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        It heals reservations which overlap with the period from start_date"},{"line_number":164,"context_line":"        to end_date. If start_date parameter is None, the period starts now."},{"line_number":165,"context_line":"        If end_date parameter is None, the length of the period is specified"},{"line_number":166,"context_line":"        by the period parameter."},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_18ad61e8","line":164,"range":{"start_line":164,"start_character":21,"end_line":164,"end_character":76},"updated":"2018-03-30 00:51:21.000000000","message":"This behavior looks strange because of following two things.\n\n1. This method is declared as an abstractmethod but the description defines the default behavior here and implemented method needs to follow this.\n2. In python, the assigned value for argument is a default value. In this case, now should be assigned.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Heal suffering reservations in the specified period."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        It heals reservations which overlap with the period from start_date"},{"line_number":164,"context_line":"        to end_date. If start_date parameter is None, the period starts now."},{"line_number":165,"context_line":"        If end_date parameter is None, the length of the period is specified"},{"line_number":166,"context_line":"        by the period parameter."},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_73635e1b","line":164,"range":{"start_line":164,"start_character":21,"end_line":164,"end_character":76},"in_reply_to":"bf659307_18ad61e8","updated":"2018-04-12 01:25:32.000000000","message":"Good suggestion. I\u0027ve changed implementation.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"}],"blazar/plugins/instances/instance_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"f684cce98414ccbb98f1f7938c49f32796bc893d","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        # Remove the failed host from the aggregate."},{"line_number":520,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":521,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":522,"context_line":"            self.nova.aggregates.remove_host(reservation[\u0027aggregate_id\u0027],"},{"line_number":523,"context_line":"                                             host[\u0027service_name\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Allocate an alternative host."},{"line_number":526,"context_line":"        values \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_766b6e1d","line":523,"range":{"start_line":522,"start_character":1,"end_line":523,"end_character":66},"updated":"2018-04-20 07:37:08.000000000","message":"Why this doesn\u0027t use pool?","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b60365d5599858d6c11672ba145b6d3e8dbea06c","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        # Remove the failed host from the aggregate."},{"line_number":520,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":521,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":522,"context_line":"            self.nova.aggregates.remove_host(reservation[\u0027aggregate_id\u0027],"},{"line_number":523,"context_line":"                                             host[\u0027service_name\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Allocate an alternative host."},{"line_number":526,"context_line":"        values \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_2e98fa19","line":523,"range":{"start_line":522,"start_character":1,"end_line":523,"end_character":66},"in_reply_to":"9f6a8fd7_3852853c","updated":"2018-04-24 10:17:53.000000000","message":"I understand the situation where you hit. The root cause is the methods of ReservaitonPool class are Procedural, not Declarative.","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ffe2980b88fb0e2c4bd1c8a7ff30e40a449f5cab","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        # Remove the failed host from the aggregate."},{"line_number":520,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":521,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":522,"context_line":"            self.nova.aggregates.remove_host(reservation[\u0027aggregate_id\u0027],"},{"line_number":523,"context_line":"                                             host[\u0027service_name\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Allocate an alternative host."},{"line_number":526,"context_line":"        values \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_3852853c","line":523,"range":{"start_line":522,"start_character":1,"end_line":523,"end_character":66},"in_reply_to":"9f6a8fd7_766b6e1d","updated":"2018-04-24 04:18:11.000000000","message":"I didn\u0027t use the the remove_computehost() of the ReservationPool because it tried to add the removed host to the freepool and it caused an exception. However, now that I think this problem should be handled in the remove_computehost(). I\u0027ve updated the remov_computehost() not to try to return the host if it\u0027s already in the freepool. And I updated here to use remove_computehost().","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":68,"context_line":"               help\u003d\u0027Interval (seconds) of polling for health checking.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027healing_interval\u0027,"},{"line_number":70,"context_line":"               default\u003d60,"},{"line_number":71,"context_line":"               help\u003d\u0027Interval (minutes) of reservation healing.\u0027),"},{"line_number":72,"context_line":"]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_78a25db0","line":71,"updated":"2018-03-30 00:51:21.000000000","message":"What happens when healing_interval is configured to \"0\" or minus? \n\nTo enable operators to heal all reservation when a resource fails, I suggest 0 means heal all reservation. Does it make sense?","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"               help\u003d\u0027Interval (seconds) of polling for health checking.\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027healing_interval\u0027,"},{"line_number":70,"context_line":"               default\u003d60,"},{"line_number":71,"context_line":"               help\u003d\u0027Interval (minutes) of reservation healing.\u0027),"},{"line_number":72,"context_line":"]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_3e47064f","line":71,"in_reply_to":"bf659307_78a25db0","updated":"2018-04-12 01:25:32.000000000","message":"Sounds good! I implemented it.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        except manager_ex.AggregateNotFound:"},{"line_number":214,"context_line":"            pass"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def heal_reservations(self, failed_resources, start_date, end_date):"},{"line_number":217,"context_line":"        \"\"\"Heal reservations which suffer from resource failures."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        :param: failed_resources: a list of failed hosts."}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_58ad1999","line":216,"range":{"start_line":216,"start_character":49,"end_line":216,"end_character":70},"updated":"2018-03-30 00:51:21.000000000","message":"start_date and end_date are confusing with lease\u0027s start_data and end_data. How about interval_beginning and interval_end?","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        except manager_ex.AggregateNotFound:"},{"line_number":214,"context_line":"            pass"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def heal_reservations(self, failed_resources, start_date, end_date):"},{"line_number":217,"context_line":"        \"\"\"Heal reservations which suffer from resource failures."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        :param: failed_resources: a list of failed hosts."}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_5e443a47","line":216,"range":{"start_line":216,"start_character":49,"end_line":216,"end_character":70},"in_reply_to":"bf659307_58ad1999","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            if reservation[\u0027resource_type\u0027] !\u003d plugin.RESOURCE_TYPE:"},{"line_number":235,"context_line":"                continue"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"            for allocation in [allocation for allocation"},{"line_number":238,"context_line":"                               in reservation[\u0027computehost_allocations\u0027]"},{"line_number":239,"context_line":"                               if allocation[\u0027compute_host_id\u0027] in host_ids]:"},{"line_number":240,"context_line":"                if self._reallocate(allocation):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_9853b117","line":237,"range":{"start_line":237,"start_character":0,"end_line":237,"end_character":56},"updated":"2018-03-30 00:51:21.000000000","message":"It\u0027s not good to use same variable name to different position.  It could cause bugs because of referring to unexpected objects as well as it\u0027s not good readability.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            if reservation[\u0027resource_type\u0027] !\u003d plugin.RESOURCE_TYPE:"},{"line_number":235,"context_line":"                continue"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"            for allocation in [allocation for allocation"},{"line_number":238,"context_line":"                               in reservation[\u0027computehost_allocations\u0027]"},{"line_number":239,"context_line":"                               if allocation[\u0027compute_host_id\u0027] in host_ids]:"},{"line_number":240,"context_line":"                if self._reallocate(allocation):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_1ed80279","line":237,"range":{"start_line":237,"start_character":0,"end_line":237,"end_character":56},"in_reply_to":"bf659307_9853b117","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        \"\"\"Get interval of reservation healing.\"\"\""},{"line_number":775,"context_line":"        return CONF[plugin.RESOURCE_TYPE].healing_interval"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    def heal(self, start_date\u003dNone, end_date\u003dNone, period\u003dNone):"},{"line_number":778,"context_line":"        \"\"\"Heal suffering reservations in the specified period."},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        It heals reservations which overlap with the period from start_date"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_9890914c","line":777,"range":{"start_line":777,"start_character":17,"end_line":777,"end_character":62},"updated":"2018-03-30 00:51:21.000000000","message":"As I commented in BaseMonitorPlugin, I don\u0027t think the three argument are needed.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        \"\"\"Get interval of reservation healing.\"\"\""},{"line_number":775,"context_line":"        return CONF[plugin.RESOURCE_TYPE].healing_interval"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    def heal(self, start_date\u003dNone, end_date\u003dNone, period\u003dNone):"},{"line_number":778,"context_line":"        \"\"\"Heal suffering reservations in the specified period."},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        It heals reservations which overlap with the period from start_date"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_7ec6de9c","line":777,"range":{"start_line":777,"start_character":17,"end_line":777,"end_character":62},"in_reply_to":"bf659307_9890914c","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        reservation_flags \u003d {}"},{"line_number":791,"context_line":"        hosts \u003d db_api.unreservable_host_get_all_by_queries([])"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        if start_date is None:"},{"line_number":794,"context_line":"            start_date \u003d datetime.datetime.utcnow()"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        if end_date is None:"},{"line_number":797,"context_line":"            if period is None:"},{"line_number":798,"context_line":"                period \u003d self.get_healing_interval()"},{"line_number":799,"context_line":"            end_date \u003d start_date + datetime.timedelta(minutes\u003dperiod)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        if start_date \u003e\u003d end_date:"},{"line_number":802,"context_line":"            LOG.exception(\u0027The end_date must be later than the start_date.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_d8712946","line":799,"range":{"start_line":793,"start_character":0,"end_line":799,"end_character":70},"updated":"2018-03-30 00:51:21.000000000","message":"To support interval \u003d\u003d 0 or minus, calculating start_data and end_data based on interval here looks good.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        reservation_flags \u003d {}"},{"line_number":791,"context_line":"        hosts \u003d db_api.unreservable_host_get_all_by_queries([])"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        if start_date is None:"},{"line_number":794,"context_line":"            start_date \u003d datetime.datetime.utcnow()"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        if end_date is None:"},{"line_number":797,"context_line":"            if period is None:"},{"line_number":798,"context_line":"                period \u003d self.get_healing_interval()"},{"line_number":799,"context_line":"            end_date \u003d start_date + datetime.timedelta(minutes\u003dperiod)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        if start_date \u003e\u003d end_date:"},{"line_number":802,"context_line":"            LOG.exception(\u0027The end_date must be later than the start_date.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_1e3d628e","line":799,"range":{"start_line":793,"start_character":0,"end_line":799,"end_character":70},"in_reply_to":"bf659307_d8712946","updated":"2018-04-12 01:25:32.000000000","message":"What do you think of current implementation?","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"f684cce98414ccbb98f1f7938c49f32796bc893d","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Remove the old host from the aggregate."},{"line_number":270,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":271,"context_line":"            h_reservation \u003d db_api.host_reservation_get("},{"line_number":272,"context_line":"                reservation[\u0027resource_id\u0027])"},{"line_number":273,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":274,"context_line":"            pool \u003d nova.ReservationPool()"},{"line_number":275,"context_line":"            pool.remove_computehost(h_reservation[\u0027aggregate_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_36f89647","line":272,"range":{"start_line":271,"start_character":28,"end_line":272,"end_character":43},"updated":"2018-04-20 07:37:08.000000000","message":"It\u0027s good to move this query to L264 because of possibility for a race condition. If the allocation starts between L277 and L296, h_reservation[\u0027aggregate_id\u0027] is None.","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ffe2980b88fb0e2c4bd1c8a7ff30e40a449f5cab","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Remove the old host from the aggregate."},{"line_number":270,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":271,"context_line":"            h_reservation \u003d db_api.host_reservation_get("},{"line_number":272,"context_line":"                reservation[\u0027resource_id\u0027])"},{"line_number":273,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":274,"context_line":"            pool \u003d nova.ReservationPool()"},{"line_number":275,"context_line":"            pool.remove_computehost(h_reservation[\u0027aggregate_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_233a5a98","line":272,"range":{"start_line":271,"start_character":28,"end_line":272,"end_character":43},"in_reply_to":"9f6a8fd7_36f89647","updated":"2018-04-24 04:18:11.000000000","message":"Thanks for pointing it out! I\u0027ve updated here following your comment.","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"f684cce98414ccbb98f1f7938c49f32796bc893d","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            h_reservation \u003d db_api.host_reservation_get("},{"line_number":272,"context_line":"                reservation[\u0027resource_id\u0027])"},{"line_number":273,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":274,"context_line":"            pool \u003d nova.ReservationPool()"},{"line_number":275,"context_line":"            pool.remove_computehost(h_reservation[\u0027aggregate_id\u0027],"},{"line_number":276,"context_line":"                                    host[\u0027service_name\u0027])"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_d6bfda5e","line":274,"range":{"start_line":274,"start_character":0,"end_line":274,"end_character":41},"updated":"2018-04-20 07:37:08.000000000","message":"same as above.","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ffe2980b88fb0e2c4bd1c8a7ff30e40a449f5cab","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            h_reservation \u003d db_api.host_reservation_get("},{"line_number":272,"context_line":"                reservation[\u0027resource_id\u0027])"},{"line_number":273,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":274,"context_line":"            pool \u003d nova.ReservationPool()"},{"line_number":275,"context_line":"            pool.remove_computehost(h_reservation[\u0027aggregate_id\u0027],"},{"line_number":276,"context_line":"                                    host[\u0027service_name\u0027])"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f6a8fd7_e33f8284","line":274,"range":{"start_line":274,"start_character":0,"end_line":274,"end_character":41},"in_reply_to":"9f6a8fd7_d6bfda5e","updated":"2018-04-24 04:18:11.000000000","message":"Done","commit_id":"3d74282e9fe380a02f293f772673c2445f1ffdb6"}],"doc/source/user/resource-monitoring.rst":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In addition, the monitor periodically checks validity of reservations and"},{"line_number":43,"context_line":"heals invalid reservations."},{"line_number":44,"context_line":"Therefore, even though the failed resource does not recover in the expected"},{"line_number":45,"context_line":"time, reservations are healed by this periodic healing."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The healing flow is as follows:"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_8d6615c1","line":45,"range":{"start_line":44,"start_character":63,"end_line":45,"end_character":55},"updated":"2018-03-30 00:51:21.000000000","message":"the last interval, the periodic task heal the invalid reservations which will start in next interval.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In addition, the monitor periodically checks validity of reservations and"},{"line_number":43,"context_line":"heals invalid reservations."},{"line_number":44,"context_line":"Therefore, even though the failed resource does not recover in the expected"},{"line_number":45,"context_line":"time, reservations are healed by this periodic healing."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The healing flow is as follows:"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_33372601","line":45,"range":{"start_line":44,"start_character":63,"end_line":45,"end_character":55},"in_reply_to":"bf659307_8d6615c1","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":49,"context_line":"1. Resource A is reserved for the *Reservation-1*, *Reservation-2* and"},{"line_number":50,"context_line":"   *Reservation-3* as shown in the following diagram."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"2. At the point 1, the monitor checks if there is any reservation to heal and"},{"line_number":53,"context_line":"   there is not."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"3. At the point 2, the manager detects a failure of the resource A. Then, it"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_8d0b75d4","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":30},"updated":"2018-03-30 00:51:21.000000000","message":"The periodic task in the manager","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"1. Resource A is reserved for the *Reservation-1*, *Reservation-2* and"},{"line_number":50,"context_line":"   *Reservation-3* as shown in the following diagram."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"2. At the point 1, the monitor checks if there is any reservation to heal and"},{"line_number":53,"context_line":"   there is not."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"3. At the point 2, the manager detects a failure of the resource A. Then, it"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_b32a568e","line":52,"range":{"start_line":52,"start_character":19,"end_line":52,"end_character":30},"in_reply_to":"bf659307_8d0b75d4","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":50,"context_line":"   *Reservation-3* as shown in the following diagram."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"2. At the point 1, the monitor checks if there is any reservation to heal and"},{"line_number":53,"context_line":"   there is not."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"3. At the point 2, the manager detects a failure of the resource A. Then, it"},{"line_number":56,"context_line":"   heals active reservations and reservations which will start in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_4d11dd03","line":53,"updated":"2018-03-30 00:51:21.000000000","message":"it detects there is not.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"   *Reservation-3* as shown in the following diagram."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"2. At the point 1, the monitor checks if there is any reservation to heal and"},{"line_number":53,"context_line":"   there is not."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"3. At the point 2, the manager detects a failure of the resource A. Then, it"},{"line_number":56,"context_line":"   heals active reservations and reservations which will start in the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_931f126b","line":53,"in_reply_to":"bf659307_4d11dd03","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   *healing interval*. In this case, *Reservation-1* and *Reservation-2* are"},{"line_number":58,"context_line":"   healed immediately."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"4. At the point 3, the monitor checks if there is any reservation to heal."},{"line_number":61,"context_line":"   In this case, the resource has not yet recovered but no reservation to"},{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_2d25895c","line":60,"range":{"start_line":60,"start_character":19,"end_line":60,"end_character":30},"updated":"2018-03-30 00:51:21.000000000","message":"The periodic task","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   *healing interval*. In this case, *Reservation-1* and *Reservation-2* are"},{"line_number":58,"context_line":"   healed immediately."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"4. At the point 3, the monitor checks if there is any reservation to heal."},{"line_number":61,"context_line":"   In this case, the resource has not yet recovered but no reservation to"},{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_fe409537","line":60,"range":{"start_line":60,"start_character":19,"end_line":60,"end_character":30},"in_reply_to":"bf659307_2d25895c","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":58,"context_line":"   healed immediately."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"4. At the point 3, the monitor checks if there is any reservation to heal."},{"line_number":61,"context_line":"   In this case, the resource has not yet recovered but no reservation to"},{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"5. At the point 4, the monitor checks if there is any reservation to heal."},{"line_number":65,"context_line":"   In this case, the resource has not yet recovered and *Reservation-3* is"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_8dc29558","line":62,"range":{"start_line":61,"start_character":17,"end_line":62,"end_character":8},"updated":"2018-03-30 00:51:21.000000000","message":"the task finds out there is no reservation to heal because the resource has not yet recovered and no reservation will start in next interval. Reservation-2 has been already healed in step2.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"   healed immediately."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"4. At the point 3, the monitor checks if there is any reservation to heal."},{"line_number":61,"context_line":"   In this case, the resource has not yet recovered but no reservation to"},{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"5. At the point 4, the monitor checks if there is any reservation to heal."},{"line_number":65,"context_line":"   In this case, the resource has not yet recovered and *Reservation-3* is"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_5e23c1a7","line":62,"range":{"start_line":61,"start_character":17,"end_line":62,"end_character":8},"in_reply_to":"bf659307_8dc29558","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":61,"context_line":"   In this case, the resource has not yet recovered but no reservation to"},{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"5. At the point 4, the monitor checks if there is any reservation to heal."},{"line_number":65,"context_line":"   In this case, the resource has not yet recovered and *Reservation-3* is"},{"line_number":66,"context_line":"   healed because it will start in the next *healing interval*."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_adc67967","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":30},"updated":"2018-03-30 00:51:21.000000000","message":"the periodic task checks if there is any reservation to heal again.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"   In this case, the resource has not yet recovered but no reservation to"},{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"5. At the point 4, the monitor checks if there is any reservation to heal."},{"line_number":65,"context_line":"   In this case, the resource has not yet recovered and *Reservation-3* is"},{"line_number":66,"context_line":"   healed because it will start in the next *healing interval*."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_7e4d6570","line":64,"range":{"start_line":64,"start_character":19,"end_line":64,"end_character":30},"in_reply_to":"bf659307_adc67967","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"5. At the point 4, the monitor checks if there is any reservation to heal."},{"line_number":65,"context_line":"   In this case, the resource has not yet recovered and *Reservation-3* is"},{"line_number":66,"context_line":"   healed because it will start in the next *healing interval*."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"6. Before the point 5, the manager detects a recovery of the resource."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_cd988d76","line":65,"updated":"2018-03-30 00:51:21.000000000","message":"the task finds out *Reservation-3* needs to be healed because  it will start in the next interval and the resource has not recovered yet.","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   heal."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"5. At the point 4, the monitor checks if there is any reservation to heal."},{"line_number":65,"context_line":"   In this case, the resource has not yet recovered and *Reservation-3* is"},{"line_number":66,"context_line":"   healed because it will start in the next *healing interval*."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"6. Before the point 5, the manager detects a recovery of the resource."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_5e58a12f","line":65,"in_reply_to":"bf659307_cd988d76","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dd47beeb5f035818214f36fe6375c9b7aaf8f568","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"6. Before the point 5, the manager detects a recovery of the resource."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"7. At the point 5, there is no failed resource and the manager has nothing to do."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. image:: ../images/healing_flow.png"},{"line_number":73,"context_line":"   :align: center"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_6d8b811e","line":70,"updated":"2018-03-30 00:51:21.000000000","message":"the periodic task finds out there is no ..\u003csnip\u003e..","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"b6a56e5e3495c6d48acc87a6dcc9f1945d8de0b9","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"6. Before the point 5, the manager detects a recovery of the resource."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"7. At the point 5, there is no failed resource and the manager has nothing to do."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. image:: ../images/healing_flow.png"},{"line_number":73,"context_line":"   :align: center"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_9e7b998a","line":70,"in_reply_to":"bf659307_6d8b811e","updated":"2018-04-12 01:25:32.000000000","message":"Done","commit_id":"98ed063121dfc4e6a0d2d390da13a4a294adbaea"}]}
