)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masahito Muroi \u003cmuroi.masahito@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-14 17:06:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent the host update API from updating in-used extra capabilities"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The host update API allows cloud admins to update extra capabilities"},{"line_number":10,"context_line":"even though the host reservation or the instance reservation requested"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_d6f6bdd7","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":49},"updated":"2018-05-14 17:22:48.000000000","message":"in-use","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masahito Muroi \u003cmuroi.masahito@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-14 17:06:29 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent the host update API from updating in-used extra capabilities"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The host update API allows cloud admins to update extra capabilities"},{"line_number":10,"context_line":"even though the host reservation or the instance reservation requested"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_48589df8","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":49},"in_reply_to":"5f7c97a3_d6f6bdd7","updated":"2018-05-16 08:26:00.000000000","message":"Done for all comments.","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The host update API allows cloud admins to update extra capabilities"},{"line_number":10,"context_line":"even though the host reservation or the instance reservation requested"},{"line_number":11,"context_line":"the capabilities. It causes unmatch between requested resource_properties"},{"line_number":12,"context_line":"of reservations and extra_capabilities registered in Blazar."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch stops the API to update extra capabilities if the key is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_f6265968","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":73},"updated":"2018-05-14 17:22:48.000000000","message":"This line is too long.","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The host update API allows cloud admins to update extra capabilities"},{"line_number":10,"context_line":"even though the host reservation or the instance reservation requested"},{"line_number":11,"context_line":"the capabilities. It causes unmatch between requested resource_properties"},{"line_number":12,"context_line":"of reservations and extra_capabilities registered in Blazar."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch stops the API to update extra capabilities if the key is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_5634ed92","line":11,"range":{"start_line":11,"start_character":28,"end_line":11,"end_character":35},"updated":"2018-05-14 17:22:48.000000000","message":"a mismatch","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the capabilities. It causes unmatch between requested resource_properties"},{"line_number":12,"context_line":"of reservations and extra_capabilities registered in Blazar."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch stops the API to update extra capabilities if the key is"},{"line_number":15,"context_line":"refered in resource_properties."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I78a9dc7f448a29f31fb95432cf4eee66c865aa70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_d61f9d05","line":14,"range":{"start_line":14,"start_character":25,"end_line":14,"end_character":34},"updated":"2018-05-14 17:22:48.000000000","message":"from updating","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the capabilities. It causes unmatch between requested resource_properties"},{"line_number":12,"context_line":"of reservations and extra_capabilities registered in Blazar."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch stops the API to update extra capabilities if the key is"},{"line_number":15,"context_line":"refered in resource_properties."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I78a9dc7f448a29f31fb95432cf4eee66c865aa70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_162af52a","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":16},"updated":"2018-05-14 17:22:48.000000000","message":"prevents","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"of reservations and extra_capabilities registered in Blazar."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch stops the API to update extra capabilities if the key is"},{"line_number":15,"context_line":"refered in resource_properties."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I78a9dc7f448a29f31fb95432cf4eee66c865aa70"},{"line_number":18,"context_line":"Implements: blueprint flavors-extra-specs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_761a4917","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"updated":"2018-05-14 17:22:48.000000000","message":"referred to","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f21693ee5fba5696b54689b8edff4ffd03e8945b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"resource_properties of reservations and extra_capabilities"},{"line_number":13,"context_line":"registered in Blazar."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch prevents the API from updating extra capabilities if the key is"},{"line_number":16,"context_line":"refered to resource_properties."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I78a9dc7f448a29f31fb95432cf4eee66c865aa70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_836cd836","line":15,"updated":"2018-05-24 03:16:22.000000000","message":"This line is too long.","commit_id":"8a0d85a5eff94deb2269d9c19c2cb8b414ec1b2c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"c0d0971be22e8ac611ee337bac8e21fea351f0b9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"resource_properties of reservations and extra_capabilities"},{"line_number":13,"context_line":"registered in Blazar."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch prevents the API from updating extra capabilities if the key is"},{"line_number":16,"context_line":"refered to resource_properties."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I78a9dc7f448a29f31fb95432cf4eee66c865aa70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_03f976c6","line":15,"in_reply_to":"5f7c97a3_836cd836","updated":"2018-05-29 09:45:40.000000000","message":"Done","commit_id":"8a0d85a5eff94deb2269d9c19c2cb8b414ec1b2c"}],"blazar/db/sqlalchemy/utils.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"9e27ee9191ab9aa45a1e91dbed498f3c5593804b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    return query.all()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def get_plugin_reservations(resource_type, resource_id):"},{"line_number":92,"context_line":"    if resource_type \u003d\u003d host_plugin.RESOURCE_TYPE:"},{"line_number":93,"context_line":"        return api.host_reservation_get(resource_id)"},{"line_number":94,"context_line":"    elif resource_type \u003d\u003d instance_plugin.RESOURCE_TYPE:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0c72f549","line":91,"range":{"start_line":91,"start_character":15,"end_line":91,"end_character":27},"updated":"2018-05-14 03:07:39.000000000","message":"I prefer the singular noun \u0027reservation\u0027 because it returns a single reservation.","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"1cdf4461148967e923e8ccfd153d2a4059040661","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    return query.all()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def get_plugin_reservations(resource_type, resource_id):"},{"line_number":92,"context_line":"    if resource_type \u003d\u003d host_plugin.RESOURCE_TYPE:"},{"line_number":93,"context_line":"        return api.host_reservation_get(resource_id)"},{"line_number":94,"context_line":"    elif resource_type \u003d\u003d instance_plugin.RESOURCE_TYPE:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d9ed9cf0","line":91,"range":{"start_line":91,"start_character":15,"end_line":91,"end_character":27},"in_reply_to":"5f7c97a3_0c72f549","updated":"2018-05-14 08:06:56.000000000","message":"Done","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"}],"blazar/db/utils.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"9e27ee9191ab9aa45a1e91dbed498f3c5593804b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return IMPL.get_reservations_by_host_ids(host_ids, start_date, end_date)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def get_plugin_reservations(resource_type, resource_id):"},{"line_number":115,"context_line":"    return IMPL.get_plugin_reservations(resource_type, resource_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ac90a144","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":27},"updated":"2018-05-14 03:07:39.000000000","message":"I prefer the single noun \u0027reservation\u0027.","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"1cdf4461148967e923e8ccfd153d2a4059040661","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return IMPL.get_reservations_by_host_ids(host_ids, start_date, end_date)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"def get_plugin_reservations(resource_type, resource_id):"},{"line_number":115,"context_line":"    return IMPL.get_plugin_reservations(resource_type, resource_id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_79b808e4","line":114,"range":{"start_line":114,"start_character":15,"end_line":114,"end_character":27},"in_reply_to":"5f7c97a3_ac90a144","updated":"2018-05-14 08:06:56.000000000","message":"Done","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"9e27ee9191ab9aa45a1e91dbed498f3c5593804b","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("},{"line_number":399,"context_line":"                plugin_reservation[\u0027resource_properties\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"            # NOTE(masahito): If all the reservation using the extra_capability"},{"line_number":402,"context_line":"            # can be re-allocated it\u0027s okay to update the extra_capability"},{"line_number":403,"context_line":"            for expression in expression_array:"},{"line_number":404,"context_line":"                # An expression forms \"key op value\" as string"},{"line_number":405,"context_line":"                if expression.split(\" \")[0] \u003d\u003d capability[\u0027capability_name\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0cdf55d6","line":402,"range":{"start_line":401,"start_character":0,"end_line":402,"end_character":74},"updated":"2018-05-14 03:07:39.000000000","message":"What is the purpose of this comment?\nCurrent implementation does NOT allow the extra_capability to be updated if it is used by any reservation even though all the reservation using use the extra_capability can be re-allocated, right?","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"1cdf4461148967e923e8ccfd153d2a4059040661","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("},{"line_number":399,"context_line":"                plugin_reservation[\u0027resource_properties\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"            # NOTE(masahito): If all the reservation using the extra_capability"},{"line_number":402,"context_line":"            # can be re-allocated it\u0027s okay to update the extra_capability"},{"line_number":403,"context_line":"            for expression in expression_array:"},{"line_number":404,"context_line":"                # An expression forms \"key op value\" as string"},{"line_number":405,"context_line":"                if expression.split(\" \")[0] \u003d\u003d capability[\u0027capability_name\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1996b44d","line":402,"range":{"start_line":401,"start_character":0,"end_line":402,"end_character":74},"in_reply_to":"5f7c97a3_0cdf55d6","updated":"2018-05-14 08:06:56.000000000","message":"This is about what we discussed in the weekly meeting. \u0027TODO\u0027 comment is much suite here. I revised it.","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"9e27ee9191ab9aa45a1e91dbed498f3c5593804b","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        updated_keys \u003d set(values.keys()) \u0026 set(previous_capabilities.keys())"},{"line_number":417,"context_line":"        new_keys \u003d set(values.keys()) - set(previous_capabilities.keys())"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        for value in updated_keys:"},{"line_number":420,"context_line":"            raw_capability \u003d next(iter("},{"line_number":421,"context_line":"                db_api.host_extra_capability_get_all_per_name(host_id, value)))"},{"line_number":422,"context_line":"            capability \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8c37e54d","line":419,"range":{"start_line":419,"start_character":12,"end_line":419,"end_character":17},"updated":"2018-05-14 03:07:39.000000000","message":"When I read L421, I misunderstood that the argument \u0027value\u0027 is the value of an extra capability key-value pair. However, the \u0027value\u0027 is actually the key of the key-value pair.\nFor the same reason, I felt L423-424 are not intuitive.\nTo prevent such a misunderstanding, I thinks it\u0027s better to change the variable name \u0027value\u0027 to \u0027key\u0027 or something.","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"1cdf4461148967e923e8ccfd153d2a4059040661","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        updated_keys \u003d set(values.keys()) \u0026 set(previous_capabilities.keys())"},{"line_number":417,"context_line":"        new_keys \u003d set(values.keys()) - set(previous_capabilities.keys())"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        for value in updated_keys:"},{"line_number":420,"context_line":"            raw_capability \u003d next(iter("},{"line_number":421,"context_line":"                db_api.host_extra_capability_get_all_per_name(host_id, value)))"},{"line_number":422,"context_line":"            capability \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f9989875","line":419,"range":{"start_line":419,"start_character":12,"end_line":419,"end_character":17},"in_reply_to":"5f7c97a3_8c37e54d","updated":"2018-05-14 08:06:56.000000000","message":"Done","commit_id":"d2320acfb3ded0826160d53f1951727f1d5d2e98"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            datetime.date.max)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        for r in reservations:"},{"line_number":395,"context_line":"            plugin_reservation \u003d db_utils.get_plugin_reservations("},{"line_number":396,"context_line":"                r[\u0027resource_type\u0027], r[\u0027resource_id\u0027])"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d6cebd58","line":395,"range":{"start_line":395,"start_character":42,"end_line":395,"end_character":65},"updated":"2018-05-14 17:22:48.000000000","message":"The function is now named get_plugin_reservation. Since tests are passing, it may indicate that they are not testing enough.","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            datetime.date.max)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        for r in reservations:"},{"line_number":395,"context_line":"            plugin_reservation \u003d db_utils.get_plugin_reservations("},{"line_number":396,"context_line":"                r[\u0027resource_type\u0027], r[\u0027resource_id\u0027])"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_62ac9a9e","line":395,"range":{"start_line":395,"start_character":42,"end_line":395,"end_character":65},"in_reply_to":"5f7c97a3_d6cebd58","updated":"2018-05-16 08:26:00.000000000","message":"Nice caught!! Looks like some other tests are needed. I added some tests.","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            plugin_reservation \u003d db_utils.get_plugin_reservations("},{"line_number":396,"context_line":"                r[\u0027resource_type\u0027], r[\u0027resource_id\u0027])"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("},{"line_number":399,"context_line":"                plugin_reservation[\u0027resource_properties\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"            # TODO(masahito): If all the reservation using the extra_capability"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_762009f8","line":398,"range":{"start_line":398,"start_character":12,"end_line":398,"end_character":28},"updated":"2018-05-14 17:22:48.000000000","message":"This might be better named as requirements_queries (the term queries comes from blazar/db/sqlalchemy/api.py).","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            plugin_reservation \u003d db_utils.get_plugin_reservations("},{"line_number":396,"context_line":"                r[\u0027resource_type\u0027], r[\u0027resource_id\u0027])"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("},{"line_number":399,"context_line":"                plugin_reservation[\u0027resource_properties\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"            # TODO(masahito): If all the reservation using the extra_capability"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_22922258","line":398,"range":{"start_line":398,"start_character":12,"end_line":398,"end_character":28},"in_reply_to":"5f7c97a3_762009f8","updated":"2018-05-16 08:26:00.000000000","message":"Done","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("},{"line_number":399,"context_line":"                plugin_reservation[\u0027resource_properties\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"            # TODO(masahito): If all the reservation using the extra_capability"},{"line_number":402,"context_line":"            # can be re-allocated it\u0027s okay to update the extra_capability"},{"line_number":403,"context_line":"            for expression in expression_array:"},{"line_number":404,"context_line":"                # An expression forms \"key op value\" as string"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1602f56f","line":401,"range":{"start_line":401,"start_character":41,"end_line":401,"end_character":52},"updated":"2018-05-14 17:22:48.000000000","message":"reservations","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            expression_array \u003d plugins_utils.convert_requirements("},{"line_number":399,"context_line":"                plugin_reservation[\u0027resource_properties\u0027])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"            # TODO(masahito): If all the reservation using the extra_capability"},{"line_number":402,"context_line":"            # can be re-allocated it\u0027s okay to update the extra_capability"},{"line_number":403,"context_line":"            for expression in expression_array:"},{"line_number":404,"context_line":"                # An expression forms \"key op value\" as string"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c29c8e6b","line":401,"range":{"start_line":401,"start_character":41,"end_line":401,"end_character":52},"in_reply_to":"5f7c97a3_1602f56f","updated":"2018-05-16 08:26:00.000000000","message":"Done","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # TODO(masahito): If all the reservation using the extra_capability"},{"line_number":402,"context_line":"            # can be re-allocated it\u0027s okay to update the extra_capability"},{"line_number":403,"context_line":"            for expression in expression_array:"},{"line_number":404,"context_line":"                # An expression forms \"key op value\" as string"},{"line_number":405,"context_line":"                if expression.split(\" \")[0] \u003d\u003d capability[\u0027capability_name\u0027]:"},{"line_number":406,"context_line":"                    return False"},{"line_number":407,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_362e11fb","line":404,"range":{"start_line":404,"start_character":32,"end_line":404,"end_character":37},"updated":"2018-05-14 17:22:48.000000000","message":"is of the form","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # TODO(masahito): If all the reservation using the extra_capability"},{"line_number":402,"context_line":"            # can be re-allocated it\u0027s okay to update the extra_capability"},{"line_number":403,"context_line":"            for expression in expression_array:"},{"line_number":404,"context_line":"                # An expression forms \"key op value\" as string"},{"line_number":405,"context_line":"                if expression.split(\" \")[0] \u003d\u003d capability[\u0027capability_name\u0027]:"},{"line_number":406,"context_line":"                    return False"},{"line_number":407,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_828c5636","line":404,"range":{"start_line":404,"start_character":32,"end_line":404,"end_character":37},"in_reply_to":"5f7c97a3_362e11fb","updated":"2018-05-16 08:26:00.000000000","message":"Done","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                    cant_update_extra_capability.append("},{"line_number":432,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":433,"context_line":"            else:"},{"line_number":434,"context_line":"                LOG.info(\"The key %s can\u0027t be updated because \""},{"line_number":435,"context_line":"                         \"some reseravtions request the key\","},{"line_number":436,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":437,"context_line":"                cant_update_extra_capability.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_769d6964","line":434,"range":{"start_line":434,"start_character":26,"end_line":434,"end_character":33},"updated":"2018-05-14 17:22:48.000000000","message":"Capability","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                    cant_update_extra_capability.append("},{"line_number":432,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":433,"context_line":"            else:"},{"line_number":434,"context_line":"                LOG.info(\"The key %s can\u0027t be updated because \""},{"line_number":435,"context_line":"                         \"some reseravtions request the key\","},{"line_number":436,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":437,"context_line":"                cant_update_extra_capability.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_028046f4","line":434,"range":{"start_line":434,"start_character":26,"end_line":434,"end_character":33},"in_reply_to":"5f7c97a3_769d6964","updated":"2018-05-16 08:26:00.000000000","message":"Done","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":433,"context_line":"            else:"},{"line_number":434,"context_line":"                LOG.info(\"The key %s can\u0027t be updated because \""},{"line_number":435,"context_line":"                         \"some reseravtions request the key\","},{"line_number":436,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":437,"context_line":"                cant_update_extra_capability.append("},{"line_number":438,"context_line":"                    raw_capability[\u0027capability_name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_368db131","line":435,"range":{"start_line":435,"start_character":56,"end_line":435,"end_character":59},"updated":"2018-05-14 17:22:48.000000000","message":"capability","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6b6ee5ff619dd219e98863337e234e531bd7f07b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":433,"context_line":"            else:"},{"line_number":434,"context_line":"                LOG.info(\"The key %s can\u0027t be updated because \""},{"line_number":435,"context_line":"                         \"some reseravtions request the key\","},{"line_number":436,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":437,"context_line":"                cant_update_extra_capability.append("},{"line_number":438,"context_line":"                    raw_capability[\u0027capability_name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b6978148","line":435,"range":{"start_line":435,"start_character":26,"end_line":435,"end_character":51},"updated":"2018-05-14 17:22:48.000000000","message":"existing reservations require","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"bec836337364a09c9f33c12dbf163ed29dbd4f6b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":433,"context_line":"            else:"},{"line_number":434,"context_line":"                LOG.info(\"The key %s can\u0027t be updated because \""},{"line_number":435,"context_line":"                         \"some reseravtions request the key\","},{"line_number":436,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":437,"context_line":"                cant_update_extra_capability.append("},{"line_number":438,"context_line":"                    raw_capability[\u0027capability_name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_227b0228","line":435,"range":{"start_line":435,"start_character":26,"end_line":435,"end_character":51},"in_reply_to":"5f7c97a3_b6978148","updated":"2018-05-16 08:26:00.000000000","message":"Done","commit_id":"945c012a37bc48636c5d2cf9be8b45dd4af8ff76"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f21693ee5fba5696b54689b8edff4ffd03e8945b","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":434,"context_line":"            else:"},{"line_number":435,"context_line":"                LOG.info(\"Capability %s can\u0027t be updated because \""},{"line_number":436,"context_line":"                         \"existing reservations requre the capability.\","},{"line_number":437,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":438,"context_line":"                cant_update_extra_capability.append("},{"line_number":439,"context_line":"                    raw_capability[\u0027capability_name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_63717c0c","line":436,"range":{"start_line":436,"start_character":48,"end_line":436,"end_character":69},"updated":"2018-05-24 03:16:22.000000000","message":"require it","commit_id":"8a0d85a5eff94deb2269d9c19c2cb8b414ec1b2c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"c0d0971be22e8ac611ee337bac8e21fea351f0b9","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                        raw_capability[\u0027capability_name\u0027])"},{"line_number":434,"context_line":"            else:"},{"line_number":435,"context_line":"                LOG.info(\"Capability %s can\u0027t be updated because \""},{"line_number":436,"context_line":"                         \"existing reservations requre the capability.\","},{"line_number":437,"context_line":"                         raw_capability[\u0027capability_name\u0027])"},{"line_number":438,"context_line":"                cant_update_extra_capability.append("},{"line_number":439,"context_line":"                    raw_capability[\u0027capability_name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_23f6f2d8","line":436,"range":{"start_line":436,"start_character":48,"end_line":436,"end_character":69},"in_reply_to":"5f7c97a3_63717c0c","updated":"2018-05-29 09:45:40.000000000","message":"Done","commit_id":"8a0d85a5eff94deb2269d9c19c2cb8b414ec1b2c"}],"blazar/tests/db/sqlalchemy/test_utils.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"91f2081130247f1ff3642d9059067213e2d41759","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _get_fake_inst_reservation_values(lease_id\u003d_get_fake_lease_uuid(),"},{"line_number":46,"context_line":"                                      resource_id\u003dNone):"},{"line_number":47,"context_line":"    return {\u0027lease_id\u0027: lease_id,"},{"line_number":48,"context_line":"            \u0027resource_id\u0027: \u00275678\u0027 if not resource_id else resource_id,"},{"line_number":49,"context_line":"            \u0027resource_type\u0027: \u0027virtual:instance\u0027}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_8c9d2e59","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":70},"updated":"2018-06-05 16:53:47.000000000","message":"Why not use as keyword argument:\n\n    resource_id\u003d\u00275678\u0027\n\nand set the dict with:\n\n    \u0027resource_id\u0027: resource_id","commit_id":"9b68e44fa87b2cb3504a3506756548950e65abf9"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4e394cbfd1b47bcbc2de207f5423458f2b4fe8d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _get_fake_inst_reservation_values(lease_id\u003d_get_fake_lease_uuid(),"},{"line_number":46,"context_line":"                                      resource_id\u003dNone):"},{"line_number":47,"context_line":"    return {\u0027lease_id\u0027: lease_id,"},{"line_number":48,"context_line":"            \u0027resource_id\u0027: \u00275678\u0027 if not resource_id else resource_id,"},{"line_number":49,"context_line":"            \u0027resource_type\u0027: \u0027virtual:instance\u0027}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_ca33dcf5","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":70},"in_reply_to":"5f7c97a3_8c9d2e59","updated":"2018-06-07 06:48:18.000000000","message":"Not much reason. Just a copy\u0026paste from _get_fake_phys_reservation_values().\n\nI updated the method to use keyword argument.","commit_id":"9b68e44fa87b2cb3504a3506756548950e65abf9"}]}