)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check time order between start_date and end_date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_384d8ac3","line":9,"range":{"start_line":9,"start_character":54,"end_line":9,"end_character":64},"updated":"2018-05-31 18:08:45.000000000","message":"start_date","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ac18851e2d7dab105ad693f49f0948a6174da6c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check time order between start_date and end_date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d68c2737","line":9,"range":{"start_line":9,"start_character":54,"end_line":9,"end_character":64},"in_reply_to":"5f7c97a3_384d8ac3","updated":"2018-06-05 05:40:41.000000000","message":"Done","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check time order between start_date and end_date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b8ce7a2a","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":33},"updated":"2018-05-31 18:08:45.000000000","message":"\"a user\" or \"users\"","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check time order between start_date and end_date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_584886b1","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":12},"updated":"2018-05-31 18:08:45.000000000","message":"end_date","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check time order between start_date and end_date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d8d1f6cd","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":60},"updated":"2018-05-31 18:08:45.000000000","message":"that end","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ac18851e2d7dab105ad693f49f0948a6174da6c6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check time order between start_date and end_date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_768193fb","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":60},"in_reply_to":"5f7c97a3_d8d1f6cd","updated":"2018-06-05 05:40:41.000000000","message":"Done","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"},{"line_number":14,"context_line":"Partial-Bug: #1747560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_78dc62e3","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":13},"updated":"2018-05-31 18:08:45.000000000","message":"they start","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ac18851e2d7dab105ad693f49f0948a6174da6c6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The create lease API doesn\u0027t check time order between start_data"},{"line_number":10,"context_line":"and end_data. This allows an user to create leases that ends"},{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"},{"line_number":14,"context_line":"Partial-Bug: #1747560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_9686af13","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":13},"in_reply_to":"5f7c97a3_78dc62e3","updated":"2018-06-05 05:40:41.000000000","message":"Done","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e0bbb3a6f950a14a09e82d6d30200b74c201fd97","unresolved":false,"context_lines":[{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"},{"line_number":14,"context_line":"Partial-Bug: #1747560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1868cef2","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":21},"updated":"2018-05-31 18:11:16.000000000","message":"Also this doesn\u0027t seem to be a related bug.","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ac18851e2d7dab105ad693f49f0948a6174da6c6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"before starts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I90b0559f22cbde9e68727de73958cc778a84d698"},{"line_number":14,"context_line":"Partial-Bug: #1747560"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_367b1b2a","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":21},"in_reply_to":"5f7c97a3_1868cef2","updated":"2018-06-05 05:40:41.000000000","message":"Done","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"}],"blazar/manager/service.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        end_date \u003d self._date_from_string(end_date)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if start_date \u003c now:"},{"line_number":252,"context_line":"            raise common_ex.InvalidInput("},{"line_number":253,"context_line":"                \u0027Start date must be later than current date\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if end_date \u003c start_date:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_189a0e13","line":252,"range":{"start_line":252,"start_character":28,"end_line":252,"end_character":40},"updated":"2018-05-31 18:08:45.000000000","message":"This is probably a better exception, but will this cause a change of HTTP return code?","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ac18851e2d7dab105ad693f49f0948a6174da6c6","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        end_date \u003d self._date_from_string(end_date)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if start_date \u003c now:"},{"line_number":252,"context_line":"            raise common_ex.InvalidInput("},{"line_number":253,"context_line":"                \u0027Start date must be later than current date\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if end_date \u003c start_date:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_361f9b0a","line":252,"range":{"start_line":252,"start_character":28,"end_line":252,"end_character":40},"in_reply_to":"5f7c97a3_189a0e13","updated":"2018-06-05 05:40:41.000000000","message":"Yes, it changes its return code 403 to 400.  403 means \"Not Authorized\". It\u0027s hard for client to understand the error reason.","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a80b034e95ffe4d368f1e747d2512a40e5b5eb38","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            raise common_ex.InvalidInput("},{"line_number":253,"context_line":"                \u0027Start date must be later than current date\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if end_date \u003c start_date:"},{"line_number":256,"context_line":"            raise common_ex.InvalidInput("},{"line_number":257,"context_line":"                \u0027End date must be later than start date.\u0027)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_58f6465f","line":255,"updated":"2018-05-31 18:08:45.000000000","message":"This allows end_date \u003d\u003d start_date. I don\u0027t think it makes sense to have a lease with duration of 0. What about checking for:\n\n    if end_date \u003c\u003d start_date:","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ac18851e2d7dab105ad693f49f0948a6174da6c6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            raise common_ex.InvalidInput("},{"line_number":253,"context_line":"                \u0027Start date must be later than current date\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if end_date \u003c start_date:"},{"line_number":256,"context_line":"            raise common_ex.InvalidInput("},{"line_number":257,"context_line":"                \u0027End date must be later than start date.\u0027)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_561c9712","line":255,"in_reply_to":"5f7c97a3_58f6465f","updated":"2018-06-05 05:40:41.000000000","message":"You\u0027re right. Updated.","commit_id":"a31b0cdb88ea54c192e13e5d581c3d2f2a977afe"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"cc6d1ec9d3e944d6250d84ab65ddb6856ffc6fba","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        if (lease[\u0027start_date\u0027] \u003e now and"},{"line_number":386,"context_line":"                values[\u0027start_date\u0027] \u003c now):"},{"line_number":387,"context_line":"            raise common_ex.NotAuthorized("},{"line_number":388,"context_line":"                \u0027Start date must be later than current date\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        if lease[\u0027end_date\u0027] \u003c now:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8d9f3e64","line":387,"range":{"start_line":387,"start_character":28,"end_line":387,"end_character":41},"updated":"2018-06-07 08:14:32.000000000","message":"Agreed with 400 is better, so this sounds a good opportunity to port the fix to update_lease() method, too, doesn\u0027t it?","commit_id":"25153a84b3a032b473813fbece0ec1bc9aa6d733"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"7ed30ed79542c5137c584b6f433a2c0d51c6adf0","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        if (lease[\u0027start_date\u0027] \u003e now and"},{"line_number":386,"context_line":"                values[\u0027start_date\u0027] \u003c now):"},{"line_number":387,"context_line":"            raise common_ex.NotAuthorized("},{"line_number":388,"context_line":"                \u0027Start date must be later than current date\u0027)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        if lease[\u0027end_date\u0027] \u003c now:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_716861b9","line":387,"range":{"start_line":387,"start_character":28,"end_line":387,"end_character":41},"in_reply_to":"5f7c97a3_8d9f3e64","updated":"2018-06-08 09:39:03.000000000","message":"Nice catch!  Changing all the response code looks different context. I separated the fix.","commit_id":"25153a84b3a032b473813fbece0ec1bc9aa6d733"}]}