)]}'
{"blazar/tests/db/migration/__init__.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"549d0c49e00fe418e071a5670df96747b995c2fb","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # the previous (higher numbered) migration."},{"line_number":572,"context_line":"        if with_data:"},{"line_number":573,"context_line":"            post_downgrade \u003d getattr("},{"line_number":574,"context_line":"                self, \"_post_downgrade_%s\" % next_version, self._do_nothing)"},{"line_number":575,"context_line":"            if post_downgrade is not self._do_nothing:"},{"line_number":576,"context_line":"                post_downgrade(engine)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f0bbb0c0","line":575,"range":{"start_line":574,"start_character":0,"end_line":575,"end_character":53},"updated":"2018-06-13 06:57:12.000000000","message":"This change, adding _do_nothing(),  aims to pass a test, it\u0027s not a meaningful change. I\u0027m not a favor of this type of update.\n\nHow about using hasattr() or `if post_downgrade is not None:` ?","commit_id":"1e7e81d9e51407ecc721fd3d9f7f24718e475880"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"6fd7365728bcff7b40cfa5b5bb896719ee423ee1","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # the previous (higher numbered) migration."},{"line_number":572,"context_line":"        if with_data:"},{"line_number":573,"context_line":"            post_downgrade \u003d getattr("},{"line_number":574,"context_line":"                self, \"_post_downgrade_%s\" % next_version, self._do_nothing)"},{"line_number":575,"context_line":"            if post_downgrade is not self._do_nothing:"},{"line_number":576,"context_line":"                post_downgrade(engine)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4b091b29","line":575,"range":{"start_line":574,"start_character":0,"end_line":575,"end_character":53},"in_reply_to":"5f7c97a3_0b1fa4b7","updated":"2018-06-19 07:14:09.000000000","message":"Done","commit_id":"1e7e81d9e51407ecc721fd3d9f7f24718e475880"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"3f19cb8693bd9ae5126aa6a3de3bc3f3597ad56b","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # the previous (higher numbered) migration."},{"line_number":572,"context_line":"        if with_data:"},{"line_number":573,"context_line":"            post_downgrade \u003d getattr("},{"line_number":574,"context_line":"                self, \"_post_downgrade_%s\" % next_version, self._do_nothing)"},{"line_number":575,"context_line":"            if post_downgrade is not self._do_nothing:"},{"line_number":576,"context_line":"                post_downgrade(engine)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0b1fa4b7","line":575,"range":{"start_line":574,"start_character":0,"end_line":575,"end_character":53},"in_reply_to":"5f7c97a3_f006d985","updated":"2018-06-19 07:03:42.000000000","message":"You\u0027re right. I tested this in my local and can reproduce the error.\n\nCould you add a tiny comment for _do_nothing() to reduce the confusion in the future?","commit_id":"1e7e81d9e51407ecc721fd3d9f7f24718e475880"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"a9a23a97e78079ecb4808f707ef451bb9db328dd","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # the previous (higher numbered) migration."},{"line_number":572,"context_line":"        if with_data:"},{"line_number":573,"context_line":"            post_downgrade \u003d getattr("},{"line_number":574,"context_line":"                self, \"_post_downgrade_%s\" % next_version, self._do_nothing)"},{"line_number":575,"context_line":"            if post_downgrade is not self._do_nothing:"},{"line_number":576,"context_line":"                post_downgrade(engine)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f006d985","line":575,"range":{"start_line":574,"start_character":0,"end_line":575,"end_character":53},"in_reply_to":"5f7c97a3_f0bbb0c0","updated":"2018-06-19 06:09:19.000000000","message":"I completely agree with your opinion but I don\u0027t have another solution. I tried them (using hasattr() or `if post_downgrade is not None:`) before but \u0027post_downgrade is not callable (not-callable)\u0027 error was raised. This may be because the pylint does not correctly consider the if statement in L575. That\u0027s why I applied this workaround.","commit_id":"1e7e81d9e51407ecc721fd3d9f7f24718e475880"}]}
