)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0e6df2f17c1dee4847dd844037421dffc32617b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Note that it does not actually change start/end_lease time, but just"},{"line_number":14,"context_line":"takes into account the margin when looking for available resources."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially Implements: blueprint cleaning-time-allowance"},{"line_number":17,"context_line":"Change-Id: I7de05a65c2221c1eb7c5b2f65bec58d6a48b2085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_f6034c0b","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2018-07-12 15:56:16.000000000","message":"What else is needed to fully implement?","commit_id":"7b73cbfc28cd32f49a0c7d111ad10c371cd7aa7e"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"1ae5f1d0eafa1843f2f3cac2a45b1f019e8039d5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Note that it does not actually change start/end_lease time, but just"},{"line_number":14,"context_line":"takes into account the margin when looking for available resources."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially Implements: blueprint cleaning-time-allowance"},{"line_number":17,"context_line":"Change-Id: I7de05a65c2221c1eb7c5b2f65bec58d6a48b2085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_ec9eaf53","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"5f7c97a3_f6034c0b","updated":"2018-07-18 00:48:23.000000000","message":"It has completed. I\u0027ve changed it to \"Implements\". thanks!","commit_id":"7b73cbfc28cd32f49a0c7d111ad10c371cd7aa7e"}],"blazar/config.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b3f32d504dd61faa692748c1fb83bd44eb4a541f","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"lease_opts \u003d ["},{"line_number":76,"context_line":"    cfg.IntOpt(\u0027cleaning_time\u0027,"},{"line_number":77,"context_line":"               default\u003d5,"},{"line_number":78,"context_line":"               help\u003d\u0027The minimum interval [minutes] between the end of a \u0027"},{"line_number":79,"context_line":"                    \u0027lease and the start of the next lease for the same \u0027"},{"line_number":80,"context_line":"                    \u0027resource. This interval is used for cleanup.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_70ebc411","line":77,"updated":"2018-06-18 08:12:43.000000000","message":"Add min option here. This allows cloud admin to set minus value as a cleaning_time.  The minus value causes overlap for the two leases.\n\nhttps://docs.openstack.org/oslo.config/latest/reference/opts.html#oslo_config.cfg.IntOpt","commit_id":"68e27f7c09c94c0e902738dc328e79f1665bacaf"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"cb5e7944c5c28ce98bfe4970ccd024072a16ff49","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"lease_opts \u003d ["},{"line_number":76,"context_line":"    cfg.IntOpt(\u0027cleaning_time\u0027,"},{"line_number":77,"context_line":"               default\u003d5,"},{"line_number":78,"context_line":"               help\u003d\u0027The minimum interval [minutes] between the end of a \u0027"},{"line_number":79,"context_line":"                    \u0027lease and the start of the next lease for the same \u0027"},{"line_number":80,"context_line":"                    \u0027resource. This interval is used for cleanup.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_704e49c3","line":77,"in_reply_to":"5f7c97a3_70ebc411","updated":"2018-06-19 06:17:56.000000000","message":"Done","commit_id":"68e27f7c09c94c0e902738dc328e79f1665bacaf"},{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"0c888447775221abb01b4384879ce5e83583736f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    \u0027lease and the start of the next lease for the same \u0027"},{"line_number":81,"context_line":"                    \u0027resource. This interval is used for cleanup.\u0027)"},{"line_number":82,"context_line":"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"CONF \u003d cfg.CONF"},{"line_number":85,"context_line":"CONF.register_cli_opts(cli_opts)"},{"line_number":86,"context_line":"CONF.register_opts(os_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ee24b510","line":83,"updated":"2018-06-19 08:35:10.000000000","message":"Is there a scenario with VMs where this is also required?  Or is it specifically for working with bare metal?  If there\u0027s no equivalent requirement for VMs, consider setting the default to 0, not 5.","commit_id":"9d87586a9675ece90a4a2f585e393f034241592f"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"72a468017b10897c1e9f37e8bf62ac7b76859767","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    \u0027lease and the start of the next lease for the same \u0027"},{"line_number":81,"context_line":"                    \u0027resource. This interval is used for cleanup.\u0027)"},{"line_number":82,"context_line":"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"CONF \u003d cfg.CONF"},{"line_number":85,"context_line":"CONF.register_cli_opts(cli_opts)"},{"line_number":86,"context_line":"CONF.register_opts(os_opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b627e2c7","line":83,"in_reply_to":"5f7c97a3_ee24b510","updated":"2018-06-20 02:36:39.000000000","message":"VMs also require this cleaning time. Let\u0027s consider the situation where reservation A ends 12:00, reservation B starts 12:00 and these reservations use the same compute resource. For current Blazar, clean up of reservation A and starting of reservation B can be triggered at the same time and there is a possibility for reservation B to fail to start.\n\nSo I set the non-zero default value.\n\nAs you commented, non-zero default value can confuse operators who upgrade from the previous version. However, I think it does not affect existing reservations because the cleaning-time is applied only for new reservations.","commit_id":"9d87586a9675ece90a4a2f585e393f034241592f"}],"blazar/plugins/instances/instance_plugin.py":[{"author":{"_account_id":10910,"name":"Stig Telfer","email":"stig.openstack@telfer.org","username":"stigtelfer"},"change_message_id":"0c888447775221abb01b4384879ce5e83583736f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            hosts,"},{"line_number":139,"context_line":"            start_date - datetime.timedelta(minutes\u003dCONF.cleaning_time),"},{"line_number":140,"context_line":"            end_date + datetime.timedelta(minutes\u003dCONF.cleaning_time),"},{"line_number":141,"context_line":"            excludes_res)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        available_hosts \u003d []"},{"line_number":144,"context_line":"        for host_info in reserved_hosts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6eed058d","line":141,"updated":"2018-06-19 08:35:10.000000000","message":"Would it make sense to take the cleaning time out of the reservation time?  I\u0027m thinking, people will make reservations for (say) 1 hour.  If this becomes 1h 5m due to cleaning time, then the nodes will soon lose alignment with their reservation time boundaries.  That could make it hard to pack reservations in closely.","commit_id":"9d87586a9675ece90a4a2f585e393f034241592f"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"72a468017b10897c1e9f37e8bf62ac7b76859767","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            hosts,"},{"line_number":139,"context_line":"            start_date - datetime.timedelta(minutes\u003dCONF.cleaning_time),"},{"line_number":140,"context_line":"            end_date + datetime.timedelta(minutes\u003dCONF.cleaning_time),"},{"line_number":141,"context_line":"            excludes_res)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        available_hosts \u003d []"},{"line_number":144,"context_line":"        for host_info in reserved_hosts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4a9c9ebe","line":141,"in_reply_to":"5f7c97a3_6eed058d","updated":"2018-06-20 02:36:39.000000000","message":"The cleaning time is out of the reservation time. A user makes a reservation from 9:00 to 12:00, then the cleaning time is from 12:00 to 12:05. This 5 mins is not included in the reservation time but considered when Blazar looks for reservable resources.","commit_id":"9d87586a9675ece90a4a2f585e393f034241592f"}],"releasenotes/notes/cleaning-time-825d148b704b0c56.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c8f65beb3496057fb4faba519a418f3eb231e1ce","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    **cleaning_time** in the [DEFAULT] section."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    Default value for the new configuration option **cleaning_time** is 5"},{"line_number":13,"context_line":"    (minutes). It does not affect existing leases but the cleaning time is"},{"line_number":14,"context_line":"    considered when creating or updating a lease."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_f7142eec","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":49},"updated":"2018-07-05 23:32:10.000000000","message":"Like Stig, I am not sure how wise it is to introduce a new default like this. We should at least document how to get back to the previous behavior (which is to set cleaning_time \u003d 0).","commit_id":"917a7543da392b72eb607cf34eb3821f3f1d3544"}]}
