)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1a85d59531f70f0ed3c8a6df61f9d5e8ea65e55c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support query parameters in list APIs this patch enables"},{"line_number":10,"context_line":"the Flask Blueprint to pass the parameters to its handler method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially Implements: blueprint resource-availability-api"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I47cbded4eb8531dab2aa8cbb8e43a68caa535fc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c1f3e8e7","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":53},"updated":"2018-07-12 16:43:53.000000000","message":"I changed the blueprint name, you can change to use \"allocation\" instead.","commit_id":"83b45ec13947a398c30f921603d39bf5eda536b5"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"d6ed02cb4e527acabdb8eebef86799a9148dbf94","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support query parameters in list APIs this patch enables"},{"line_number":10,"context_line":"the Flask Blueprint to pass the parameters to its handler method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially Implements: blueprint resource-availability-api"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I47cbded4eb8531dab2aa8cbb8e43a68caa535fc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_a3e4a643","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":53},"in_reply_to":"5f7c97a3_c1f3e8e7","updated":"2018-07-13 03:05:19.000000000","message":"Thanks, I\u0027ll change it.","commit_id":"83b45ec13947a398c30f921603d39bf5eda536b5"}],"blazar/api/v1/oshosts/service.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e06c46c040e4ddab783c463d5372198d83a88ea7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @policy.authorize(\u0027oshosts\u0027, \u0027get\u0027)"},{"line_number":26,"context_line":"    def get_computehosts(self, query):"},{"line_number":27,"context_line":"        \"\"\"List all existing computehosts.\"\"\""},{"line_number":28,"context_line":"        return self.manager_rpcapi.list_computehosts(query)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @policy.authorize(\u0027oshosts\u0027, \u0027post\u0027)"},{"line_number":31,"context_line":"    @trusts.use_trust_auth()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a022da00","line":28,"range":{"start_line":28,"start_character":53,"end_line":28,"end_character":58},"updated":"2018-11-26 17:00:32.000000000","message":"What about using a keyword argument (query\u003dquery) to match list_leases?","commit_id":"ee921c9c504159070d440f90f2d27656ae727542"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"183367a0078ffdc892f02978a58d844dd19ce702","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @policy.authorize(\u0027oshosts\u0027, \u0027get\u0027)"},{"line_number":26,"context_line":"    def get_computehosts(self, query):"},{"line_number":27,"context_line":"        \"\"\"List all existing computehosts.\"\"\""},{"line_number":28,"context_line":"        return self.manager_rpcapi.list_computehosts(query)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @policy.authorize(\u0027oshosts\u0027, \u0027post\u0027)"},{"line_number":31,"context_line":"    @trusts.use_trust_auth()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_a0bbe5db","line":28,"range":{"start_line":28,"start_character":53,"end_line":28,"end_character":58},"in_reply_to":"3f79a3b5_a022da00","updated":"2018-12-06 08:59:49.000000000","message":"Done","commit_id":"ee921c9c504159070d440f90f2d27656ae727542"}],"blazar/api/v1/oshosts/v1_0.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"28aed9bd06f08ca2a9f5a59f895f24c9c3cabbbd","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@rest.get(\u0027/\u003chost_id\u003e\u0027)"},{"line_number":41,"context_line":"@validation.check_exists(_api.get_computehost, host_id\u003d\u0027host_id\u0027)"},{"line_number":42,"context_line":"def computehosts_get(host_id, query):"},{"line_number":43,"context_line":"    \"\"\"Get computehost by its ID.\"\"\""},{"line_number":44,"context_line":"    return api_utils.render(host\u003d_api.get_computehost(host_id))"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_eeba3e6f","line":42,"range":{"start_line":42,"start_character":28,"end_line":42,"end_character":35},"updated":"2018-07-17 07:39:58.000000000","message":"Is it needed?","commit_id":"86d556fa87228724ce332f4991d7fb3db448a5de"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"146325bdd480ac08a9e7f9a868d1a9fbfe906c64","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@rest.get(\u0027/\u003chost_id\u003e\u0027)"},{"line_number":41,"context_line":"@validation.check_exists(_api.get_computehost, host_id\u003d\u0027host_id\u0027)"},{"line_number":42,"context_line":"def computehosts_get(host_id, query):"},{"line_number":43,"context_line":"    \"\"\"Get computehost by its ID.\"\"\""},{"line_number":44,"context_line":"    return api_utils.render(host\u003d_api.get_computehost(host_id))"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8ba47db9","line":42,"range":{"start_line":42,"start_character":28,"end_line":42,"end_character":35},"in_reply_to":"5f7c97a3_eeba3e6f","updated":"2018-07-20 08:20:12.000000000","message":"Done","commit_id":"86d556fa87228724ce332f4991d7fb3db448a5de"}],"blazar/api/v1/utils.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1a85d59531f70f0ed3c8a6df61f9d5e8ea65e55c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                if flask.request.method in [\u0027GET\u0027]:"},{"line_number":74,"context_line":"                    params \u003d {k: v for k, v in get_request_args().items()}"},{"line_number":75,"context_line":"                    kwargs[\u0027query\u0027] \u003d params"},{"line_number":76,"context_line":"                    LOG.debug(\"Query parameters: %s\", params)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"                with context.ctx_from_headers(flask.request.headers):"},{"line_number":79,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_81689088","line":76,"updated":"2018-07-12 16:43:53.000000000","message":"Do we want to include this logging? It will increase the amount of information to sift through when debugging, is it really useful for operators?","commit_id":"83b45ec13947a398c30f921603d39bf5eda536b5"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"d6ed02cb4e527acabdb8eebef86799a9148dbf94","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                if flask.request.method in [\u0027GET\u0027]:"},{"line_number":74,"context_line":"                    params \u003d {k: v for k, v in get_request_args().items()}"},{"line_number":75,"context_line":"                    kwargs[\u0027query\u0027] \u003d params"},{"line_number":76,"context_line":"                    LOG.debug(\"Query parameters: %s\", params)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"                with context.ctx_from_headers(flask.request.headers):"},{"line_number":79,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e38cde81","line":76,"in_reply_to":"5f7c97a3_81689088","updated":"2018-07-13 03:05:19.000000000","message":"I just added it to show up the parsed query because of no way to check it. I\u0027ll remove this logging and if needed the API services which support query can show the param instead of here.","commit_id":"83b45ec13947a398c30f921603d39bf5eda536b5"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"28aed9bd06f08ca2a9f5a59f895f24c9c3cabbbd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if flask.request.method in [\u0027POST\u0027, \u0027PUT\u0027]:"},{"line_number":71,"context_line":"                    kwargs[\u0027data\u0027] \u003d request_data()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"                if flask.request.method in [\u0027GET\u0027]:"},{"line_number":74,"context_line":"                    params \u003d {k: v for k, v in get_request_args().items()}"},{"line_number":75,"context_line":"                    kwargs[\u0027query\u0027] \u003d params"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"                with context.ctx_from_headers(flask.request.headers):"},{"line_number":78,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5163d7ab","line":75,"range":{"start_line":73,"start_character":15,"end_line":75,"end_character":44},"updated":"2018-07-17 07:39:58.000000000","message":"I think here should distinguish the List APIs (e.g. GET /reservation/v1/leases) from Show detail APIs (e.g. GET /reservation/v1/leases/{lease_id}) because the latter does not accept query parameters.","commit_id":"86d556fa87228724ce332f4991d7fb3db448a5de"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"146325bdd480ac08a9e7f9a868d1a9fbfe906c64","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                if flask.request.method in [\u0027POST\u0027, \u0027PUT\u0027]:"},{"line_number":71,"context_line":"                    kwargs[\u0027data\u0027] \u003d request_data()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"                if flask.request.method in [\u0027GET\u0027]:"},{"line_number":74,"context_line":"                    params \u003d {k: v for k, v in get_request_args().items()}"},{"line_number":75,"context_line":"                    kwargs[\u0027query\u0027] \u003d params"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"                with context.ctx_from_headers(flask.request.headers):"},{"line_number":78,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cb8cb52f","line":75,"range":{"start_line":73,"start_character":15,"end_line":75,"end_character":44},"in_reply_to":"5f7c97a3_5163d7ab","updated":"2018-07-20 08:20:12.000000000","message":"To avoid show details lease/host API to have query parameter, endpoint parameter is used here. Please check the new patch.","commit_id":"86d556fa87228724ce332f4991d7fb3db448a5de"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"802f72ea144ab08a723c262f9cb225f62fffef55","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":37,"context_line":"        super(Rest, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":"        self.query_support_route \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def index(self, rule, status_code\u003d200):"},{"line_number":41,"context_line":"        return self._mroute(\u0027GET\u0027, rule, status_code, query\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_48eba210","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":32},"updated":"2018-08-02 21:32:07.000000000","message":"If I understanding correctly what you\u0027re doing in this file, this variable should really be called routes_with_query_support.","commit_id":"6817e3db04192bb4d64e88dd564ad99a843ff0e7"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"565fba959c91db4c32aa4f3444e512e5d3f1a0ba","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":37,"context_line":"        super(Rest, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":"        self.query_support_route \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def index(self, rule, status_code\u003d200):"},{"line_number":41,"context_line":"        return self._mroute(\u0027GET\u0027, rule, status_code, query\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_89121fb1","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":32},"in_reply_to":"5f7c97a3_48eba210","updated":"2018-08-06 01:56:46.000000000","message":"Done","commit_id":"6817e3db04192bb4d64e88dd564ad99a843ff0e7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"802f72ea144ab08a723c262f9cb225f62fffef55","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(Rest, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":"        self.query_support_route \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def index(self, rule, status_code\u003d200):"},{"line_number":41,"context_line":"        return self._mroute(\u0027GET\u0027, rule, status_code, query\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get(self, rule, status_code\u003d200):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a8e6f648","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":13},"updated":"2018-08-02 21:32:07.000000000","message":"What\u0027s the reasoning behind naming this new decorator \"index\"? What about something more explicit like get_with_query? Or, could we make get accept a keyword argument directly?","commit_id":"6817e3db04192bb4d64e88dd564ad99a843ff0e7"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"4c4a09ad0abd3ecbeba38bdd8ac1d91db7ea8288","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(Rest, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":"        self.query_support_route \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def index(self, rule, status_code\u003d200):"},{"line_number":41,"context_line":"        return self._mroute(\u0027GET\u0027, rule, status_code, query\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get(self, rule, status_code\u003d200):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8334334c","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":13},"in_reply_to":"3f79a3b5_89bc5f6a","updated":"2018-08-06 12:25:58.000000000","message":"Well, I personally like the simple way better written in PS2 to be honest. We can just get the query parameters anyway and we can just ignore(don\u0027t use) the parameters if the API doesn\u0027t support the query.... Thoughts?","commit_id":"6817e3db04192bb4d64e88dd564ad99a843ff0e7"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"565fba959c91db4c32aa4f3444e512e5d3f1a0ba","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(Rest, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":"        self.query_support_route \u003d []"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def index(self, rule, status_code\u003d200):"},{"line_number":41,"context_line":"        return self._mroute(\u0027GET\u0027, rule, status_code, query\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get(self, rule, status_code\u003d200):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_89bc5f6a","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":13},"in_reply_to":"5f7c97a3_a8e6f648","updated":"2018-08-06 01:56:46.000000000","message":"The reason I introduced the index beside of the get is to distinguish list API from show API. As Hiroaki commented in previous patch set, the show type API doesn\u0027t need to support query parameters. How do you think?","commit_id":"6817e3db04192bb4d64e88dd564ad99a843ff0e7"}],"blazar/api/v1/v1_0.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"28aed9bd06f08ca2a9f5a59f895f24c9c3cabbbd","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@rest.get(\u0027/leases/\u003clease_id\u003e\u0027)"},{"line_number":44,"context_line":"@validation.check_exists(_api.get_lease, lease_id\u003d\u0027lease_id\u0027)"},{"line_number":45,"context_line":"def leases_get(lease_id, query):"},{"line_number":46,"context_line":"    \"\"\"Get lease by its ID.\"\"\""},{"line_number":47,"context_line":"    return api_utils.render(lease\u003d_api.get_lease(lease_id))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f13303c3","line":45,"range":{"start_line":45,"start_character":23,"end_line":45,"end_character":30},"updated":"2018-07-17 07:39:58.000000000","message":"Is it needed?","commit_id":"86d556fa87228724ce332f4991d7fb3db448a5de"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"146325bdd480ac08a9e7f9a868d1a9fbfe906c64","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"@rest.get(\u0027/leases/\u003clease_id\u003e\u0027)"},{"line_number":44,"context_line":"@validation.check_exists(_api.get_lease, lease_id\u003d\u0027lease_id\u0027)"},{"line_number":45,"context_line":"def leases_get(lease_id, query):"},{"line_number":46,"context_line":"    \"\"\"Get lease by its ID.\"\"\""},{"line_number":47,"context_line":"    return api_utils.render(lease\u003d_api.get_lease(lease_id))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4b92e559","line":45,"range":{"start_line":45,"start_character":23,"end_line":45,"end_character":30},"in_reply_to":"5f7c97a3_f13303c3","updated":"2018-07-20 08:20:12.000000000","message":"Done","commit_id":"86d556fa87228724ce332f4991d7fb3db448a5de"}],"blazar/manager/oshosts/rpcapi.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e06c46c040e4ddab783c463d5372198d83a88ea7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Get detailed info about some computehost.\"\"\""},{"line_number":38,"context_line":"        return self.call(\u0027physical:host:get_computehost\u0027, host_id\u003dhost_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def list_computehosts(self, query):"},{"line_number":41,"context_line":"        \"\"\"List all computehosts.\"\"\""},{"line_number":42,"context_line":"        return self.call(\u0027physical:host:list_computehosts\u0027, query\u003dquery)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_606da22e","line":40,"range":{"start_line":40,"start_character":32,"end_line":40,"end_character":37},"updated":"2018-11-26 17:00:32.000000000","message":"If we change blazar/api/v1/oshosts/service.py to use a keyword argument, we would need to change it here too.","commit_id":"ee921c9c504159070d440f90f2d27656ae727542"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"183367a0078ffdc892f02978a58d844dd19ce702","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Get detailed info about some computehost.\"\"\""},{"line_number":38,"context_line":"        return self.call(\u0027physical:host:get_computehost\u0027, host_id\u003dhost_id)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def list_computehosts(self, query):"},{"line_number":41,"context_line":"        \"\"\"List all computehosts.\"\"\""},{"line_number":42,"context_line":"        return self.call(\u0027physical:host:list_computehosts\u0027, query\u003dquery)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_409a1175","line":40,"range":{"start_line":40,"start_character":32,"end_line":40,"end_character":37},"in_reply_to":"3f79a3b5_606da22e","updated":"2018-12-06 08:59:49.000000000","message":"Done","commit_id":"ee921c9c504159070d440f90f2d27656ae727542"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e06c46c040e4ddab783c463d5372198d83a88ea7","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        else:"},{"line_number":307,"context_line":"            return host"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def list_computehosts(self, query):"},{"line_number":310,"context_line":"        raw_host_list \u003d db_api.host_list()"},{"line_number":311,"context_line":"        host_list \u003d []"},{"line_number":312,"context_line":"        for host in raw_host_list:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_205d6a7b","line":309,"updated":"2018-11-26 17:00:32.000000000","message":"If we change blazar/api/v1/oshosts/service.py to use a keyword argument, we would need to change it here too.","commit_id":"ee921c9c504159070d440f90f2d27656ae727542"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"183367a0078ffdc892f02978a58d844dd19ce702","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        else:"},{"line_number":307,"context_line":"            return host"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def list_computehosts(self, query):"},{"line_number":310,"context_line":"        raw_host_list \u003d db_api.host_list()"},{"line_number":311,"context_line":"        host_list \u003d []"},{"line_number":312,"context_line":"        for host in raw_host_list:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_20a595b3","line":309,"in_reply_to":"3f79a3b5_205d6a7b","updated":"2018-12-06 08:59:49.000000000","message":"Done","commit_id":"ee921c9c504159070d440f90f2d27656ae727542"}]}
