)]}'
{"api-ref/source/v1/hosts.inc":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dcc8c2ee54f37a36aaf9dec12a6e7c55e3fc5c3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"List Allocations"},{"line_number":252,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":".. rest_method:: GET v1/os-hosts/reservations"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"List allocations on all hosts."},{"line_number":257,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f79a3b5_3beefb89","line":254,"range":{"start_line":254,"start_character":33,"end_line":254,"end_character":45},"updated":"2018-11-26 17:53:44.000000000","message":"I know this implements what was described in the spec, but looking at it afresh, it strikes me that the naming of API endpoints and fields can be confusing.\n\nWe talk about allocation everywhere, shouldn\u0027t we be naming the endpoint v1/os-hosts/allocations instead?","commit_id":"3a9dfa28e99b0c3f68f0e8c8657596987f385d3b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dcc8c2ee54f37a36aaf9dec12a6e7c55e3fc5c3","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  - reservations: reservation_allocations"},{"line_number":276,"context_line":"  - id: host_id"},{"line_number":277,"context_line":"  - allocations: allocations"},{"line_number":278,"context_line":"  - allocation.id: reservation_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f79a3b5_9bfe2f37","line":275,"range":{"start_line":275,"start_character":2,"end_line":275,"end_character":41},"updated":"2018-11-26 17:53:44.000000000","message":"Same comment as above for this field.","commit_id":"3a9dfa28e99b0c3f68f0e8c8657596987f385d3b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dcc8c2ee54f37a36aaf9dec12a6e7c55e3fc5c3","unresolved":false,"context_lines":[{"line_number":273,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  - reservations: reservation_allocations"},{"line_number":276,"context_line":"  - id: host_id"},{"line_number":277,"context_line":"  - allocations: allocations"},{"line_number":278,"context_line":"  - allocation.id: reservation_id"},{"line_number":279,"context_line":"  - allocation.lease_id: lease_id"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f79a3b5_5bf41756","line":276,"range":{"start_line":276,"start_character":2,"end_line":276,"end_character":15},"updated":"2018-11-26 17:53:44.000000000","message":"This is also confusing: if the listed objects are allocations, an `id` field may imply that it is the allocation ID, not the compute host ID. What about naming the field `host_id` or `computehost_id`?","commit_id":"3a9dfa28e99b0c3f68f0e8c8657596987f385d3b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dcc8c2ee54f37a36aaf9dec12a6e7c55e3fc5c3","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"  - reservations: reservation_allocations"},{"line_number":276,"context_line":"  - id: host_id"},{"line_number":277,"context_line":"  - allocations: allocations"},{"line_number":278,"context_line":"  - allocation.id: reservation_id"},{"line_number":279,"context_line":"  - allocation.lease_id: lease_id"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f79a3b5_db9587e3","line":277,"range":{"start_line":277,"start_character":2,"end_line":277,"end_character":28},"updated":"2018-11-26 17:53:44.000000000","message":"And here this could be reservations instead.","commit_id":"3a9dfa28e99b0c3f68f0e8c8657596987f385d3b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dcc8c2ee54f37a36aaf9dec12a6e7c55e3fc5c3","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"  - reservation: reservation_allocation"},{"line_number":313,"context_line":"  - id: host_id"},{"line_number":314,"context_line":"  - allocations: allocations"},{"line_number":315,"context_line":"  - allocation.id: reservation_id"},{"line_number":316,"context_line":"  - allocation.lease_id: lease_id"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"**Example of List Allocations Response**"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f79a3b5_5b8977c5","line":316,"range":{"start_line":312,"start_character":0,"end_line":316,"end_character":33},"updated":"2018-11-26 17:53:44.000000000","message":"Same comments as above.","commit_id":"3a9dfa28e99b0c3f68f0e8c8657596987f385d3b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dcc8c2ee54f37a36aaf9dec12a6e7c55e3fc5c3","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  - allocation.id: reservation_id"},{"line_number":316,"context_line":"  - allocation.lease_id: lease_id"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"**Example of List Allocations Response**"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":".. literalinclude:: ../../../doc/api_samples/hosts/allocation-get-resp.json"},{"line_number":321,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":8,"id":"3f79a3b5_1bb9bf7a","line":318,"range":{"start_line":318,"start_character":13,"end_line":318,"end_character":17},"updated":"2018-11-26 17:53:44.000000000","message":"s/List/Get","commit_id":"3a9dfa28e99b0c3f68f0e8c8657596987f385d3b"}],"blazar/api/v1/oshosts/service.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"32740447b6924ad5a3f812e4c5593054a6efae4b","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @policy.authorize(\u0027oshosts\u0027, \u0027get_allocations\u0027)"},{"line_number":80,"context_line":"    def get_allocations(self, host_id, query):"},{"line_number":81,"context_line":"        \"\"\"List all allocations on all computehosts."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param host_id: ID of the computehost in Blazar DB."},{"line_number":84,"context_line":"        :type host_id: str"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_88fe0005","line":81,"range":{"start_line":81,"start_character":34,"end_line":81,"end_character":51},"updated":"2018-10-25 07:59:44.000000000","message":"a specified computehsot","commit_id":"e66b4a2dadd98e81fc45fef0dc9e51eae8e3eda9"}],"blazar/policies/oshosts.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c27db70580f33d04cc9ed449f2f4eea3357e2c10","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        description\u003d\u0027Policy rule for List/Get Host(s) Allocations API.\u0027,"},{"line_number":72,"context_line":"        operations\u003d["},{"line_number":73,"context_line":"            {"},{"line_number":74,"context_line":"                \u0027path\u0027: \u0027/{api_version}/os-hosts/reservations\u0027,"},{"line_number":75,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":76,"context_line":"            },"},{"line_number":77,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffd0ebdf_2ce68fea","line":74,"range":{"start_line":74,"start_character":49,"end_line":74,"end_character":61},"updated":"2019-01-03 09:59:30.000000000","message":"allocations","commit_id":"da785a2d7d5a5eba5155a4c6ce443736febdab02"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"aaf12220f02ff8cfaac0bd38e1336623a30120e6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        description\u003d\u0027Policy rule for List/Get Host(s) Allocations API.\u0027,"},{"line_number":72,"context_line":"        operations\u003d["},{"line_number":73,"context_line":"            {"},{"line_number":74,"context_line":"                \u0027path\u0027: \u0027/{api_version}/os-hosts/reservations\u0027,"},{"line_number":75,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":76,"context_line":"            },"},{"line_number":77,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_79d99681","line":74,"range":{"start_line":74,"start_character":49,"end_line":74,"end_character":61},"in_reply_to":"ffd0ebdf_2ce68fea","updated":"2019-01-08 12:36:10.000000000","message":"Done","commit_id":"da785a2d7d5a5eba5155a4c6ce443736febdab02"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c27db70580f33d04cc9ed449f2f4eea3357e2c10","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":76,"context_line":"            },"},{"line_number":77,"context_line":"            {"},{"line_number":78,"context_line":"                \u0027path\u0027: \u0027/{api_version}/os-hosts/{host_id}/reservations\u0027,"},{"line_number":79,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":80,"context_line":"            }"},{"line_number":81,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffd0ebdf_0ccdcb5c","line":78,"range":{"start_line":78,"start_character":59,"end_line":78,"end_character":71},"updated":"2019-01-03 09:59:30.000000000","message":"allocation","commit_id":"da785a2d7d5a5eba5155a4c6ce443736febdab02"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"aaf12220f02ff8cfaac0bd38e1336623a30120e6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":76,"context_line":"            },"},{"line_number":77,"context_line":"            {"},{"line_number":78,"context_line":"                \u0027path\u0027: \u0027/{api_version}/os-hosts/{host_id}/reservations\u0027,"},{"line_number":79,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":80,"context_line":"            }"},{"line_number":81,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dfd5e7cf_39e30e36","line":78,"range":{"start_line":78,"start_character":59,"end_line":78,"end_character":71},"in_reply_to":"ffd0ebdf_0ccdcb5c","updated":"2019-01-08 12:36:10.000000000","message":"Done","commit_id":"da785a2d7d5a5eba5155a4c6ce443736febdab02"}]}
