)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fe591085e68f177dd65e8ea287f1e1f1f43ee472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f79a3b5_29af649d","line":13,"updated":"2018-10-16 20:20:53.000000000","message":"I guess you should add `Blueprint: placement-api` here, like in the other commit messages.","commit_id":"0b89a24be8fd64482ad9ffbc7d34788dc1100d3a"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"629710a262899c856214407fac1578d2a5d96b30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3f79a3b5_98befcac","line":13,"in_reply_to":"3f79a3b5_29af649d","updated":"2018-10-17 03:08:49.000000000","message":"Good catch! Thanks!","commit_id":"0b89a24be8fd64482ad9ffbc7d34788dc1100d3a"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"0a3f1cd205a8153e61a9f24a84216468146fb85a","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            if any([len(key) \u003e 64 for key in extra_capabilities_keys]):"},{"line_number":348,"context_line":"                raise manager_ex.ExtraCapabilityTooLong()"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            self.placement_client.create_reservation_provider("},{"line_number":351,"context_line":"                host_details[\u0027service_name\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            pool \u003d nova.ReservationPool()"},{"line_number":354,"context_line":"            pool.add_computehost(self.freepool_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a2691bc1","line":351,"range":{"start_line":350,"start_character":11,"end_line":351,"end_character":45},"updated":"2018-07-24 05:43:42.000000000","message":"I agree with creating the reservation provider for a new host here. But when is the reservation provider created for existing hosts?","commit_id":"47d2e836c5fc00a1e7a5f7ad6100c3b3b0f4129f"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"0a3f1cd205a8153e61a9f24a84216468146fb85a","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                # transactions"},{"line_number":367,"context_line":"                pool.remove_computehost(self.freepool_name,"},{"line_number":368,"context_line":"                                        host_details[\u0027service_name\u0027])"},{"line_number":369,"context_line":"                self.placement_client.delete_reservation_provider("},{"line_number":370,"context_line":"                    host_details[\u0027service_name\u0027])"},{"line_number":371,"context_line":"            if host:"},{"line_number":372,"context_line":"                for key in extra_capabilities:"},{"line_number":373,"context_line":"                    values \u003d {\u0027computehost_id\u0027: host[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_82373fdc","line":370,"range":{"start_line":369,"start_character":16,"end_line":370,"end_character":49},"updated":"2018-07-24 05:43:42.000000000","message":"There would be a situation where the host does not have the reservation provider. So, it\u0027s better to use try-except here.","commit_id":"47d2e836c5fc00a1e7a5f7ad6100c3b3b0f4129f"}],"blazar/tests/plugins/test_physical_host_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"af067321da4fa3ae614f9249afbb1a7ee0b8d51c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \"parent_provider_uuid\": \"542df8ed-9be2-49b9-b4db-6d3183ff8ec8\","},{"line_number":184,"context_line":"            \"root_provider_uuid\": \"542df8ed-9be2-49b9-b4db-6d3183ff8ec8\""},{"line_number":185,"context_line":"        }"},{"line_number":186,"context_line":"        self.prov_create \u003d self.patch(self.placement.BlazarPlacementClient,"},{"line_number":187,"context_line":"                                      \u0027delete_reservation_provider\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.fake_phys_plugin.setup(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_61ca41a1","line":186,"range":{"start_line":186,"start_character":13,"end_line":186,"end_character":24},"updated":"2018-07-23 06:06:54.000000000","message":"prov_delete?  It\u0027s good to use the new variables in any of test cases at least once.","commit_id":"aa2e5c4b8a6c2e5b146c5f9d2ea28cea2e816f27"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"b12061f785b6e99b4e1f59fd82146a84849be187","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \"parent_provider_uuid\": \"542df8ed-9be2-49b9-b4db-6d3183ff8ec8\","},{"line_number":184,"context_line":"            \"root_provider_uuid\": \"542df8ed-9be2-49b9-b4db-6d3183ff8ec8\""},{"line_number":185,"context_line":"        }"},{"line_number":186,"context_line":"        self.prov_create \u003d self.patch(self.placement.BlazarPlacementClient,"},{"line_number":187,"context_line":"                                      \u0027delete_reservation_provider\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.fake_phys_plugin.setup(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2acb99a4","line":186,"range":{"start_line":186,"start_character":13,"end_line":186,"end_character":24},"in_reply_to":"5f7c97a3_61ca41a1","updated":"2018-07-24 12:32:36.000000000","message":"Done","commit_id":"aa2e5c4b8a6c2e5b146c5f9d2ea28cea2e816f27"}],"blazar/utils/openstack/placement.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"78384680451dd7f7d1afd1a0c34e76b67dad4974","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        rp \u003d self.get_resource_provider(rp_name)"},{"line_number":195,"context_line":"        rp_uuid \u003d rp[\u0027uuid\u0027]"},{"line_number":196,"context_line":"        self.delete_resource_provider(rp_uuid)"},{"line_number":197,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a94db43c","line":197,"updated":"2018-10-16 20:18:27.000000000","message":"You don\u0027t need a return statement if you\u0027re not returning anything.","commit_id":"0b89a24be8fd64482ad9ffbc7d34788dc1100d3a"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"629710a262899c856214407fac1578d2a5d96b30","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        rp \u003d self.get_resource_provider(rp_name)"},{"line_number":195,"context_line":"        rp_uuid \u003d rp[\u0027uuid\u0027]"},{"line_number":196,"context_line":"        self.delete_resource_provider(rp_uuid)"},{"line_number":197,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_eef08adc","line":197,"in_reply_to":"3f79a3b5_a94db43c","updated":"2018-10-17 03:08:49.000000000","message":"Done","commit_id":"0b89a24be8fd64482ad9ffbc7d34788dc1100d3a"}]}
