)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"4efb2b86a55e53d9923bd3383460b85cf0c64427","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  - updates the on_end() of to remove the custom resource from"},{"line_number":19,"context_line":"    the reservation provider inventory and delete the class itself."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Do not merge this patch until nova is updated to use placement 1.29"},{"line_number":22,"context_line":"microversion, which enables getting allocation candidates from"},{"line_number":23,"context_line":"placement with nested awareness."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I41b9a9fba22830e391799fa2763e4e845959f37c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_2e13b7b9","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":31},"updated":"2018-07-24 05:09:40.000000000","message":"This is now being under construction, https://review.openstack.org/#/c/527728/","commit_id":"11135a487e61b530f29436c01f7ecb706bda6b2d"}],"blazar/plugins/instances/instance_plugin.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"d26473c57550abaa384af90a34cbd530635f4b2e","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":470,"context_line":"            pool.add_computehost(instance_reservation[\u0027aggregate_id\u0027],"},{"line_number":471,"context_line":"                                 host[\u0027service_name\u0027], stay_in\u003dTrue)"},{"line_number":472,"context_line":"            self.placement_client.update_reservation_inventory("},{"line_number":473,"context_line":"                host[\u0027service_name\u0027], reservation_id, 1)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def on_end(self, resource_id):"},{"line_number":476,"context_line":"        instance_reservation \u003d db_api.instance_reservation_get(resource_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_bdbba3bc","line":473,"range":{"start_line":472,"start_character":0,"end_line":473,"end_character":56},"updated":"2018-10-17 07:53:23.000000000","message":"IMO, this and following inventory managements should be in nova.ReservationPool class. It can cover all codes in the blazar repo. For example, the patch misses the change for _reallocation().\n\nHow do you think?","commit_id":"a9102b35c4c758d44690a09454669cff7e67c112"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"98acfcf4fbf03369ff3554e5d6fa226526890a25","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":470,"context_line":"            pool.add_computehost(instance_reservation[\u0027aggregate_id\u0027],"},{"line_number":471,"context_line":"                                 host[\u0027service_name\u0027], stay_in\u003dTrue)"},{"line_number":472,"context_line":"            self.placement_client.update_reservation_inventory("},{"line_number":473,"context_line":"                host[\u0027service_name\u0027], reservation_id, 1)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def on_end(self, resource_id):"},{"line_number":476,"context_line":"        instance_reservation \u003d db_api.instance_reservation_get(resource_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_7ec7c166","line":473,"range":{"start_line":472,"start_character":0,"end_line":473,"end_character":56},"in_reply_to":"3f79a3b5_1fe619e9","updated":"2018-11-06 06:32:51.000000000","message":"Thanks. The reasons are right.  The placement client and the nova client shouldn\u0027t be mixed.\n\nMy point was once the placement changes and the Pool use are encapsulated in one class you don\u0027t need to care of this instance_plugin class and only forcus on the new class.","commit_id":"a9102b35c4c758d44690a09454669cff7e67c112"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"ebac41e47ae1ef168cb4f4294defd5892622243d","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":470,"context_line":"            pool.add_computehost(instance_reservation[\u0027aggregate_id\u0027],"},{"line_number":471,"context_line":"                                 host[\u0027service_name\u0027], stay_in\u003dTrue)"},{"line_number":472,"context_line":"            self.placement_client.update_reservation_inventory("},{"line_number":473,"context_line":"                host[\u0027service_name\u0027], reservation_id, 1)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def on_end(self, resource_id):"},{"line_number":476,"context_line":"        instance_reservation \u003d db_api.instance_reservation_get(resource_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_e86cfb9f","line":473,"range":{"start_line":472,"start_character":0,"end_line":473,"end_character":56},"in_reply_to":"3f79a3b5_bdbba3bc","updated":"2018-10-17 08:36:00.000000000","message":"Ah, good idea. Will fix.","commit_id":"a9102b35c4c758d44690a09454669cff7e67c112"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"4305d9bf0bfdc2447c6b6cfdc95d8fdb3bdbe724","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":470,"context_line":"            pool.add_computehost(instance_reservation[\u0027aggregate_id\u0027],"},{"line_number":471,"context_line":"                                 host[\u0027service_name\u0027], stay_in\u003dTrue)"},{"line_number":472,"context_line":"            self.placement_client.update_reservation_inventory("},{"line_number":473,"context_line":"                host[\u0027service_name\u0027], reservation_id, 1)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def on_end(self, resource_id):"},{"line_number":476,"context_line":"        instance_reservation \u003d db_api.instance_reservation_get(resource_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_1fe619e9","line":473,"range":{"start_line":472,"start_character":0,"end_line":473,"end_character":56},"in_reply_to":"3f79a3b5_e86cfb9f","updated":"2018-10-19 04:31:02.000000000","message":"[later] Yeah, this could merge into pool.add_computehost() but I didn\u0027t since (A) add_computehost is used in plugin.create_computehost() to put the host into the blazar free_pool and we don\u0027t want to update any inventory there, and (B) nova.ReservationPool is nova client method and I don\u0027t think it is good to mix placement client methods there.\n\nI\u0027ve updated the cases one by one.","commit_id":"a9102b35c4c758d44690a09454669cff7e67c112"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7abbf7c6b62deab1888f63a10a75c652c5a215ec","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        for allocation in allocations:"},{"line_number":491,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":492,"context_line":"            db_api.host_allocation_destroy(allocation[\u0027id\u0027])"},{"line_number":493,"context_line":"            try:"},{"line_number":494,"context_line":"                self.placement_client.delete_reservation_inventory("},{"line_number":495,"context_line":"                    host[\u0027service_name\u0027], reservation_id)"},{"line_number":496,"context_line":"            except openstack_ex.ResourceProviderNotFound:"},{"line_number":497,"context_line":"                pass"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        for server in self.nova.servers.list(search_opts\u003d{"},{"line_number":500,"context_line":"                \u0027flavor\u0027: reservation_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_e1ac54a9","line":497,"range":{"start_line":493,"start_character":0,"end_line":497,"end_character":20},"updated":"2018-11-26 19:08:01.000000000","message":"Just checking, is it OK to do this before deleting the servers?","commit_id":"6f4c8a84cb85743ff1a97ea50b72779578408030"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"8e533b950b09a8e006091e243f98afe7cf3a610f","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        for allocation in allocations:"},{"line_number":491,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":492,"context_line":"            db_api.host_allocation_destroy(allocation[\u0027id\u0027])"},{"line_number":493,"context_line":"            try:"},{"line_number":494,"context_line":"                self.placement_client.delete_reservation_inventory("},{"line_number":495,"context_line":"                    host[\u0027service_name\u0027], reservation_id)"},{"line_number":496,"context_line":"            except openstack_ex.ResourceProviderNotFound:"},{"line_number":497,"context_line":"                pass"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        for server in self.nova.servers.list(search_opts\u003d{"},{"line_number":500,"context_line":"                \u0027flavor\u0027: reservation_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_c7ca7e16","line":497,"range":{"start_line":493,"start_character":0,"end_line":497,"end_character":20},"in_reply_to":"3f79a3b5_e1ac54a9","updated":"2018-11-27 10:15:44.000000000","message":"Yes, because having the reservation inventory doesn\u0027t affect other scheduling VMs that doesn\u0027t need the reservation inventory.\n\nWe could move the whole chunk of Blazar DB+placement management in L488-497 after deleting the server, but as I don\u0027t see any problems, I leave this.","commit_id":"6f4c8a84cb85743ff1a97ea50b72779578408030"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7abbf7c6b62deab1888f63a10a75c652c5a215ec","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        # Remove the failed host from the aggregate."},{"line_number":556,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":557,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":558,"context_line":"            pool.remove_computehost(reservation[\u0027aggregate_id\u0027],"},{"line_number":559,"context_line":"                                    host[\u0027service_name\u0027])"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        # Allocate an alternative host."},{"line_number":562,"context_line":"        values \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_21b7acfa","line":559,"range":{"start_line":558,"start_character":0,"end_line":559,"end_character":57},"updated":"2018-11-26 19:08:01.000000000","message":"Isn\u0027t it needed to deleted the inventory here?","commit_id":"6f4c8a84cb85743ff1a97ea50b72779578408030"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"8e533b950b09a8e006091e243f98afe7cf3a610f","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        # Remove the failed host from the aggregate."},{"line_number":556,"context_line":"        if reservation[\u0027status\u0027] \u003d\u003d status.reservation.ACTIVE:"},{"line_number":557,"context_line":"            host \u003d db_api.host_get(allocation[\u0027compute_host_id\u0027])"},{"line_number":558,"context_line":"            pool.remove_computehost(reservation[\u0027aggregate_id\u0027],"},{"line_number":559,"context_line":"                                    host[\u0027service_name\u0027])"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        # Allocate an alternative host."},{"line_number":562,"context_line":"        values \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_52f38ae8","line":559,"range":{"start_line":558,"start_character":0,"end_line":559,"end_character":57},"in_reply_to":"3f79a3b5_21b7acfa","updated":"2018-11-27 10:15:44.000000000","message":"Good catch. Thanks. Done.","commit_id":"6f4c8a84cb85743ff1a97ea50b72779578408030"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"67e1a9a0e15d1d4dd7dc598d527c5a81ebc514c3","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            try:"},{"line_number":561,"context_line":"                self.placement_client.delete_reservation_inventory("},{"line_number":562,"context_line":"                    host[\u0027service_name\u0027], reservation[\u0027id\u0027])"},{"line_number":563,"context_line":"                self.placement_client.delete_reservation_provider("},{"line_number":564,"context_line":"                    host[\u0027service_name\u0027])"},{"line_number":565,"context_line":"            except openstack_ex.ResourceProviderNotFound:"},{"line_number":566,"context_line":"                pass"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_c89a8ac1","line":564,"range":{"start_line":563,"start_character":0,"end_line":564,"end_character":41},"updated":"2018-12-10 11:00:12.000000000","message":"Thanks for adding the `delete_reservation_inventory` call. However, I don\u0027t understand why you\u0027re calling `delete_reservation_provider`: it is normally only called when the admin does a host-delete, and similarly, create_reservation_provider is only called when the admin does a host-create.","commit_id":"c658d18d5a344ee69957005adf080bd6287d3967"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"96446b31c8290ae195347b442d048fa9343df26e","unresolved":false,"context_lines":[{"line_number":560,"context_line":"            try:"},{"line_number":561,"context_line":"                self.placement_client.delete_reservation_inventory("},{"line_number":562,"context_line":"                    host[\u0027service_name\u0027], reservation[\u0027id\u0027])"},{"line_number":563,"context_line":"                self.placement_client.delete_reservation_provider("},{"line_number":564,"context_line":"                    host[\u0027service_name\u0027])"},{"line_number":565,"context_line":"            except openstack_ex.ResourceProviderNotFound:"},{"line_number":566,"context_line":"                pass"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_4221fc4d","line":564,"range":{"start_line":563,"start_character":0,"end_line":564,"end_character":41},"in_reply_to":"3f79a3b5_c89a8ac1","updated":"2018-12-15 07:29:56.000000000","message":"Good catch, again. Thanks.","commit_id":"c658d18d5a344ee69957005adf080bd6287d3967"}]}
