)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masahito Muroi \u003cmuroi.masahito@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-08 18:58:48 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_9d769506","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":29},"updated":"2018-08-08 17:17:03.000000000","message":"s/host/hosts/","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4c641d5d2d983ec18329a3974bf04c3f1487860","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masahito Muroi \u003cmuroi.masahito@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-08 18:58:48 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ff03f640","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":29},"in_reply_to":"3f79a3b5_9d769506","updated":"2018-08-09 02:30:52.000000000","message":"Done","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_3d5f4173","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":54},"updated":"2018-08-08 17:17:03.000000000","message":"s/host/hosts/","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_7d65b944","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":21},"updated":"2018-08-08 17:17:03.000000000","message":"s/misses/fails/","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1d5cc57c","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":37},"updated":"2018-08-08 17:17:03.000000000","message":"s/number/the number/","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4c641d5d2d983ec18329a3974bf04c3f1487860","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_1fffd234","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":21},"in_reply_to":"3f79a3b5_7d65b944","updated":"2018-08-09 02:30:52.000000000","message":"Done","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8b436a4a3b40a0d3005d03dcd5af465dd10f088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_9d4f75bc","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":18},"updated":"2018-08-08 17:17:03.000000000","message":"s/update_reservation/the update_reservation/","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4c641d5d2d983ec18329a3974bf04c3f1487860","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8b436a4a3b40a0d3005d03dcd5af465dd10f088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_bffd7e3b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":18},"in_reply_to":"3f79a3b5_9d4f75bc","updated":"2018-08-09 02:30:52.000000000","message":"Done","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8b436a4a3b40a0d3005d03dcd5af465dd10f088"},{"line_number":14,"context_line":"Closes-Bug: #1786007"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_bddfd1d4","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":49},"updated":"2018-08-08 17:17:03.000000000","message":"It wrongly succeeds to update the instance reservation via the Lease Update API.","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4c641d5d2d983ec18329a3974bf04c3f1487860","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check number of replaced host in update_reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"InstancePlugin misses to check number of replaced host in"},{"line_number":10,"context_line":"update_reservation method. It causes wrong reservation update sccess"},{"line_number":11,"context_line":"in Lease Update API for the instance reservation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8b436a4a3b40a0d3005d03dcd5af465dd10f088"},{"line_number":14,"context_line":"Closes-Bug: #1786007"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_7f95a6e3","line":11,"range":{"start_line":10,"start_character":27,"end_line":11,"end_character":49},"in_reply_to":"3f79a3b5_bddfd1d4","updated":"2018-08-09 02:30:52.000000000","message":"Done","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"}],"blazar/plugins/instances/instance_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                       \"active status.\")"},{"line_number":421,"context_line":"            raise mgr_exceptions.CantUpdateParameter(err_msg)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if (reservation[\u0027amount\u0027] - new_values[\u0027amount\u0027] !\u003d"},{"line_number":424,"context_line":"           (len(changed_hosts[\u0027removed\u0027]) - len(changed_hosts[\u0027added\u0027]))):"},{"line_number":425,"context_line":"            raise mgr_exceptions.NotEnoughHostsAvailable()"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        db_api.instance_reservation_update("},{"line_number":428,"context_line":"            reservation[\u0027resource_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fd39c93e","line":425,"range":{"start_line":423,"start_character":0,"end_line":425,"end_character":58},"updated":"2018-08-08 17:17:03.000000000","message":"I think it is more understandable to invert the logic:\n\n    if (new_values[\u0027amount\u0027] - reservation[\u0027amount\u0027] !\u003d\n       (len(changed_hosts[\u0027added\u0027]) - len(changed_hosts[\u0027removed\u0027]))):","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4c641d5d2d983ec18329a3974bf04c3f1487860","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                       \"active status.\")"},{"line_number":421,"context_line":"            raise mgr_exceptions.CantUpdateParameter(err_msg)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if (reservation[\u0027amount\u0027] - new_values[\u0027amount\u0027] !\u003d"},{"line_number":424,"context_line":"           (len(changed_hosts[\u0027removed\u0027]) - len(changed_hosts[\u0027added\u0027]))):"},{"line_number":425,"context_line":"            raise mgr_exceptions.NotEnoughHostsAvailable()"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        db_api.instance_reservation_update("},{"line_number":428,"context_line":"            reservation[\u0027resource_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7ff04668","line":425,"range":{"start_line":423,"start_character":0,"end_line":425,"end_character":58},"in_reply_to":"3f79a3b5_fd39c93e","updated":"2018-08-09 02:30:52.000000000","message":"Done","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"}],"blazar/tests/plugins/instances/test_instance_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"66f4abfa56d83f00f694b8b6981b68d5eeb3467b","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                                                  \u0027reservation-id1\u0027)"},{"line_number":761,"context_line":"        mock_update_resource.assert_called_once_with(\u0027reservation-id1\u0027)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_update_reservation_less_hosts(self):"},{"line_number":764,"context_line":"        plugin \u003d instance_plugin.VirtualInstancePlugin()"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        old_reservation \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5d147da0","line":763,"range":{"start_line":763,"start_character":8,"end_line":763,"end_character":42},"updated":"2018-08-08 17:17:03.000000000","message":"s/less/not_enough/","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"e4c641d5d2d983ec18329a3974bf04c3f1487860","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                                                  \u0027reservation-id1\u0027)"},{"line_number":761,"context_line":"        mock_update_resource.assert_called_once_with(\u0027reservation-id1\u0027)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_update_reservation_less_hosts(self):"},{"line_number":764,"context_line":"        plugin \u003d instance_plugin.VirtualInstancePlugin()"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        old_reservation \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9ff3e273","line":763,"range":{"start_line":763,"start_character":8,"end_line":763,"end_character":42},"in_reply_to":"3f79a3b5_5d147da0","updated":"2018-08-09 02:30:52.000000000","message":"Done","commit_id":"bb447a69d97f46fba72c0c062562adec654905ef"}]}
