)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fb05b519661fdeb2e2cf9dc9b4e886a58cda5549","unresolved":false,"context_lines":[{"line_number":10,"context_line":"IP API shouldn\u0027t delete the floating IP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch changes the delete floating IP API to check allocations"},{"line_number":13,"context_line":"associated to the floating IP, then if there\u0027re allocation the API"},{"line_number":14,"context_line":"doesn\u0027t delete the floating IP."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0c48eaa4084ea65b658cb568358b4c9bcf5178f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_755d6913","line":13,"range":{"start_line":13,"start_character":39,"end_line":13,"end_character":58},"updated":"2019-01-31 18:07:17.000000000","message":"there is any allocation","commit_id":"4feb46cb1b50ecebad901e3c344cf1401a5d02a8"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"41e447e08dde2a9f5dfd1c3286a55ccc3b6fa628","unresolved":false,"context_lines":[{"line_number":10,"context_line":"IP API shouldn\u0027t delete the floating IP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch changes the delete floating IP API to check allocations"},{"line_number":13,"context_line":"associated to the floating IP, then if there\u0027re allocation the API"},{"line_number":14,"context_line":"doesn\u0027t delete the floating IP."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0c48eaa4084ea65b658cb568358b4c9bcf5178f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_00efb087","line":13,"range":{"start_line":13,"start_character":39,"end_line":13,"end_character":58},"in_reply_to":"9fdfeff1_755d6913","updated":"2019-02-06 04:53:28.000000000","message":"Done","commit_id":"4feb46cb1b50ecebad901e3c344cf1401a5d02a8"}],"blazar/plugins/floatingips/floatingip_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fb05b519661fdeb2e2cf9dc9b4e886a58cda5549","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        allocations \u003d db_api.fip_allocation_get_all_by_values("},{"line_number":276,"context_line":"            floatingip_id\u003dfip_id)"},{"line_number":277,"context_line":"        if allocations:"},{"line_number":278,"context_line":"            message \u003d \u0027Floating IP id %s is reserved by reservations.\u0027 % fip_id"},{"line_number":279,"context_line":"            LOG.info(message)"},{"line_number":280,"context_line":"            raise manager_ex.CantDeleteFloatingIP(floatingip\u003dfip_id,"},{"line_number":281,"context_line":"                                                  msg\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_95b1ed49","line":278,"range":{"start_line":278,"start_character":44,"end_line":278,"end_character":52},"updated":"2019-01-31 18:07:17.000000000","message":"\"is allocated\" would read better","commit_id":"4feb46cb1b50ecebad901e3c344cf1401a5d02a8"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"41e447e08dde2a9f5dfd1c3286a55ccc3b6fa628","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        allocations \u003d db_api.fip_allocation_get_all_by_values("},{"line_number":276,"context_line":"            floatingip_id\u003dfip_id)"},{"line_number":277,"context_line":"        if allocations:"},{"line_number":278,"context_line":"            message \u003d \u0027Floating IP id %s is reserved by reservations.\u0027 % fip_id"},{"line_number":279,"context_line":"            LOG.info(message)"},{"line_number":280,"context_line":"            raise manager_ex.CantDeleteFloatingIP(floatingip\u003dfip_id,"},{"line_number":281,"context_line":"                                                  msg\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_60e0fc97","line":278,"range":{"start_line":278,"start_character":44,"end_line":278,"end_character":52},"in_reply_to":"9fdfeff1_95b1ed49","updated":"2019-02-06 04:53:28.000000000","message":"Done","commit_id":"4feb46cb1b50ecebad901e3c344cf1401a5d02a8"}],"blazar/tests/plugins/floatingips/test_floatingip_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d247332bc5aa84697446108228346c9344bd051e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        patch_fip_alloc.return_value \u003d ["},{"line_number":170,"context_line":"            {"},{"line_number":171,"context_line":"                \u0027id\u0027: \u0027alloc-id1\u0027,"},{"line_number":172,"context_line":"                \u0027floatingip_id\u0027: \u0027172.24.4.100\u0027,"},{"line_number":173,"context_line":"                \u0027reservation_id\u0027: \u0027reservations-id1\u0027"},{"line_number":174,"context_line":"            }"},{"line_number":175,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_803b09e8","line":172,"updated":"2019-02-27 15:28:33.000000000","message":"Shouldn\u0027t this be \u0027fip-id\u0027 instead of the actual IP address?","commit_id":"968e99a479480073f8f37e5af13602e3a2e7d1de"}]}