)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"37247e80d115595f634d2a28a5e520d3c77e51e5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds microversion support so that it\u0027s possible to make"},{"line_number":10,"context_line":"minor changes to the APIs as required to fix LP bug 1740091."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7ea48be72897a77fc8424a57f4ce2d4798daf4eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5faad753_61246dc7","line":11,"updated":"2019-09-09 11:12:43.000000000","message":"nit: Good to have a link to the bug like:\n\nRelated-Bug: #1740091","commit_id":"41692680f583097d636e5682a3e934698734e330"},{"author":{"_account_id":29278,"name":"Asmita Singh","email":"Asmita.Singh@nttdata.com","username":"asmita.singh"},"change_message_id":"71c193412af83a53af64413350a6516b42569b76","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds microversion support so that it\u0027s possible to make"},{"line_number":10,"context_line":"minor changes to the APIs as required to fix LP bug 1740091."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7ea48be72897a77fc8424a57f4ce2d4798daf4eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5faad753_b6ecd629","line":11,"in_reply_to":"5faad753_61246dc7","updated":"2019-09-10 07:02:10.000000000","message":"Done. Added release note as well.","commit_id":"41692680f583097d636e5682a3e934698734e330"}],"blazar/api/v1/api_version_request.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"438f6541952ff9eddd7cfeaec006a5788e90b050","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2019 NTT DATA"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_2fb50832","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":29},"updated":"2019-06-04 08:53:09.000000000","message":"Given how much this has in common with Nova\u0027s api_version_request.py, I think the original copyright should stay.","commit_id":"f5ed3a2699ecc8a2e23594d1fa8158961d579080"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"438f6541952ff9eddd7cfeaec006a5788e90b050","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# You must update the API version history string below with a one or"},{"line_number":40,"context_line":"# two line description as well as update rest_api_version_history.rst"},{"line_number":41,"context_line":"REST_API_VERSION_HISTORY \u003d \"\"\""},{"line_number":42,"context_line":"       REST API Version History:"},{"line_number":43,"context_line":"       * 1.0 - Includes all V1 APIs and extensions. V2 API is deprecated."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_af82584e","line":40,"range":{"start_line":40,"start_character":41,"end_line":40,"end_character":69},"updated":"2019-06-04 08:53:09.000000000","message":"This file wasn\u0027t created.","commit_id":"f5ed3a2699ecc8a2e23594d1fa8158961d579080"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"438f6541952ff9eddd7cfeaec006a5788e90b050","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    return APIVersionRequest(MAX_API_VERSION)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def is_supported(req, min_version\u003dMIN_API_VERSION,"},{"line_number":75,"context_line":"                 max_version\u003dMAX_API_VERSION):"},{"line_number":76,"context_line":"    \"\"\"Check if API request version satisfies version restrictions."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    :param req: request object"},{"line_number":79,"context_line":"    :param min_version: minimal version of API needed for correct"},{"line_number":80,"context_line":"           request processing"},{"line_number":81,"context_line":"    :param max_version: maximum version of API needed for correct"},{"line_number":82,"context_line":"           request processing"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    :returns: True if request satisfies minimal and maximum API version"},{"line_number":85,"context_line":"             requirements. False in other case."},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":"    return (APIVersionRequest(max_version) \u003e\u003d req \u003e\u003d"},{"line_number":88,"context_line":"            APIVersionRequest(min_version))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class APIVersionRequest(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ef3b7099","line":88,"range":{"start_line":74,"start_character":0,"end_line":88,"end_character":43},"updated":"2019-06-04 08:53:09.000000000","message":"Looks like this function isn\u0027t used anywhere?","commit_id":"f5ed3a2699ecc8a2e23594d1fa8158961d579080"}],"blazar/api/v1/app.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"062dc06f0b2652eac930c5414e329b46a8aa9fa1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"versions\": ["},{"line_number":56,"context_line":"            {\"id\": \"v1.0\","},{"line_number":57,"context_line":"             \"status\": \"CURRENT\","},{"line_number":58,"context_line":"             \"links\": [{\"href\": \"{0}v1\".format(flask.request.host_url),"},{"line_number":59,"context_line":"                        \"rel\": \"self\"}],"},{"line_number":60,"context_line":"             \"min_version\": api_version_request.MIN_API_VERSION,"},{"line_number":61,"context_line":"             \"max_version\": api_version_request.MAX_API_VERSION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_58cfb6af","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":71},"updated":"2019-09-11 02:26:42.000000000","message":"This is not a fault of this patch, but in my env this says the link is:\n\n\"http://192.168.56.101/v1\"\n\nbut I think \"http://192.168.56.101/reservation/v1\" is more appropriate :(","commit_id":"520005b13dc47bf78db33a526c1947e4b2c0d681"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bb0c364095a00344ce3fc13f630e54e7938bc720","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"versions\": ["},{"line_number":56,"context_line":"            {\"id\": \"v1.0\","},{"line_number":57,"context_line":"             \"status\": \"CURRENT\","},{"line_number":58,"context_line":"             \"links\": [{\"href\": \"{0}v1\".format(flask.request.host_url),"},{"line_number":59,"context_line":"                        \"rel\": \"self\"}],"},{"line_number":60,"context_line":"             \"min_version\": api_version_request.MIN_API_VERSION,"},{"line_number":61,"context_line":"             \"max_version\": api_version_request.MAX_API_VERSION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_daccf0bd","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":71},"in_reply_to":"5faad753_58cfb6af","updated":"2019-09-11 12:59:58.000000000","message":"Well spotted. I opened a bug: https://bugs.launchpad.net/blazar/+bug/1843586","commit_id":"520005b13dc47bf78db33a526c1947e4b2c0d681"}],"blazar/api/v1/rest_api_version_history.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"eb0b04f280960ab7f431df7dd2d7aa694733ca79","unresolved":false,"context_lines":[{"line_number":10,"context_line":"---\r"},{"line_number":11,"context_line":"\r"},{"line_number":12,"context_line":"This is the initial version of the v1.0 API which supports\r"},{"line_number":13,"context_line":"microversions. The V1.0 API is from the REST API users\u0027s point of\r"},{"line_number":14,"context_line":"view exactly the same as v1 except with strong input validation.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"A user can specify a header in the API request::\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_fcc4a361","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":23},"updated":"2019-06-17 19:07:08.000000000","message":"Nit: v1.0 to match capitalisation of the previous sentence.","commit_id":"c09b5f8373689bbed7418db8aa971dc50ba728f1"}],"doc/requirements.txt":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"eb0b04f280960ab7f431df7dd2d7aa694733ca79","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later.\r"},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD\r"},{"line_number":5,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2;python_version\u003e\u003d\u00273.4\u0027  # BSD\r"},{"line_number":6,"context_line":"sphinxcontrib-actdiag\u003e\u003d0.8.5 # BSD\r"},{"line_number":7,"context_line":"sphinxcontrib-seqdiag\u003e\u003d0.8.4 # BSD\r"},{"line_number":8,"context_line":"sphinx-feature-classification\u003e\u003d0.2.0 # Apache-2.0\r"}],"source_content_type":"text/plain","patch_set":3,"id":"9fb8cfa7_319202a0","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":49},"updated":"2019-06-17 19:07:08.000000000","message":"Why are you adding these requirements? If you were trying to fix the requirements-check job failure, check if https://review.opendev.org/#/c/663946 has passed.","commit_id":"66eb072f5cddeb8119840c6b9cdadff701bb5712"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"eb0b04f280960ab7f431df7dd2d7aa694733ca79","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2;python_version\u003e\u003d\u00273.4\u0027  # BSD"},{"line_number":6,"context_line":"sphinxcontrib-actdiag\u003e\u003d0.8.5 # BSD"},{"line_number":7,"context_line":"sphinxcontrib-seqdiag\u003e\u003d0.8.4 # BSD"},{"line_number":8,"context_line":"sphinx-feature-classification\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":9,"context_line":"os-api-ref\u003e\u003d1.4.0 # Apache-2.0"},{"line_number":10,"context_line":"openstackdocstheme\u003e\u003d1.19.0 # Apache-2.0"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# releasenotes"}],"source_content_type":"text/plain","patch_set":5,"id":"9fb8cfa7_dc9c3f6c","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":30},"updated":"2019-06-17 19:07:08.000000000","message":"I still don\u0027t understand why you\u0027re adding these requirements. As far as I know this patch doesn\u0027t use them.","commit_id":"c09b5f8373689bbed7418db8aa971dc50ba728f1"}],"releasenotes/notes/api-microversioning-141e473bff34aad2.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d84d28afd7ac0cbf284ae5dd5ceecd452132fc0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    The API version is specified in the OpenStack-API-Version HTTP header."},{"line_number":7,"context_line":"    To view the mininum and maximum supported versions by API,"},{"line_number":8,"context_line":"    access \u0027/\u0027 and \u0027/versions\u0027 resource."},{"line_number":9,"context_line":"    Blazar API will return the information in the headers of the response."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5faad753_2435fe46","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":73},"updated":"2019-09-10 16:59:34.000000000","message":"If you are referring to where the minimum and maximum versions are returned, I think this should say response data, as they are not returned in headers.\n\nI\u0027ll push an updated release notes with some other rewording, let me know if I am mistaken.","commit_id":"d6e58a1001388ec0e7d0709055c9ae83b2577026"}]}