)]}'
{"blazar/db/sqlalchemy/utils.py":[{"author":{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},"change_message_id":"43369c59b7d6bed2c9fda384d975420bced1383e","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def get_reservation_allocations_by_host_ids("},{"line_number":99,"context_line":"        host_ids, lease_id\u003dNone, reservation_id\u003dNone):"},{"line_number":100,"context_line":"    session \u003d get_session()"},{"line_number":101,"context_line":"    query \u003d (session.query(models.Reservation.id,"},{"line_number":102,"context_line":"                           models.Reservation.lease_id,"},{"line_number":103,"context_line":"                           models.ComputeHostAllocation.compute_host_id)"},{"line_number":104,"context_line":"             .join(models.Lease).join(models.ComputeHostAllocation)"},{"line_number":105,"context_line":"             .filter(models.ComputeHostAllocation.compute_host_id"},{"line_number":106,"context_line":"                     .in_(host_ids))"},{"line_number":107,"context_line":"             .filter(sa.or_("},{"line_number":108,"context_line":"                 models.Lease.status \u003d\u003d status.lease.ACTIVE,"},{"line_number":109,"context_line":"                 models.Lease.status \u003d\u003d status.lease.PENDING))"},{"line_number":110,"context_line":"             .filter(sa.or_("},{"line_number":111,"context_line":"                 models.Reservation.status \u003d\u003d status.reservation.ACTIVE,"},{"line_number":112,"context_line":"                 models.Reservation.status \u003d\u003d status.reservation.PENDING)))"},{"line_number":113,"context_line":"    if lease_id:"},{"line_number":114,"context_line":"        query \u003d query.filter(models.Reservation.lease_id \u003d\u003d lease_id)"},{"line_number":115,"context_line":"    if reservation_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_95809e8d","line":112,"range":{"start_line":100,"start_character":27,"end_line":112,"end_character":75},"updated":"2019-09-10 19:57:32.000000000","message":"I think a lot of providers would still need the border filter if they are retaining lease and reservation data that spans years and multiple versions of Blazar. They will have leases and reservations that would not be filtered out by lease and reservation status alone.\n\nI think the changes you suggested in https://review.opendev.org/#/c/678755 would be preferable.","commit_id":"69942faa733baec7238815276c31685d26b261dc"}]}