)]}'
{"id":"openstack%2Fblazar~679935","triplet_id":"openstack%2Fblazar~master~I988f5abf319e094eecf99e3cee2ebb1900bc47ab","project":"openstack/blazar","branch":"master","topic":"bug/1838025","hashtags":[],"change_id":"I988f5abf319e094eecf99e3cee2ebb1900bc47ab","subject":"Use status matching to avoid time comparison","status":"ABANDONED","created":"2019-09-04 08:38:39.000000000","updated":"2019-09-11 01:36:12.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1573016f54a2b7d4fb42904efa958f9080d8d964","_number":679935,"virtual_id_number":679935,"owner":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},{"value":1,"date":"2019-09-04 09:40:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},"all":[{"value":-1,"date":"2019-09-10 19:57:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-04 09:40:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-10 19:57:32.000000000","updated_by":{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},"reviewer":{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},"state":"REVIEWER"}],"messages":[{"id":"acb0772e869844783f731de58b9234af6142bdc1","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-09-04 08:38:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"982d1caa3fec507c50e0e3d5156317d3095c7d8e","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-09-04 08:46:35.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"fb8c223e5082d65bdee19d8f2f2a24a2e1a64192","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-04 09:40:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/37316001bc9143e584ccbe6398150f62 : SUCCESS in 5m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/863a235343424590a90d9fb7cc70bead : SUCCESS in 5m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bfbd603f07474c9b86a8adcc3c17e718 : SUCCESS in 5m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/012a39bca43141758770751b03add530 : SUCCESS in 5m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/26867f3080ce44a69880766947df8e5e : SUCCESS in 6m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e737b976e0474f27a7a639b14a378ad8 : SUCCESS in 5m 38s\n- blazar-devstack-dsvm https://zuul.opendev.org/t/openstack/build/b616fc82d50f4fb9ad7c50f4701f9445 : SUCCESS in 44m 13s\n- blazar-devstack-dsvm-py35 https://zuul.opendev.org/t/openstack/build/e041fba160b24ded8edc26f65e37cddc : SUCCESS in 42m 35s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/2acb97d127ec4fd1a7cca71a33213176 : SUCCESS in 7m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"43369c59b7d6bed2c9fda384d975420bced1383e","author":{"_account_id":29270,"name":"Jacob Colleran","email":"jakecoll@uchicago.edu","username":"jakecoll2"},"date":"2019-09-10 19:57:32.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"75061952d40c2e7117025af1e853f2b9ce152471","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-09-11 01:36:12.000000000","message":"Abandoned\n\nAbandon for the reason Jacob described above.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"69942faa733baec7238815276c31685d26b261dc","revisions":{"6a2fa23ed75185fc6e7d76c72704abefed1333d3":{"kind":"REWORK","_number":1,"created":"2019-09-04 08:38:39.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/35/679935/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/blazar","ref":"refs/changes/35/679935/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/blazar refs/changes/35/679935/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/blazar refs/changes/35/679935/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/blazar refs/changes/35/679935/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/blazar refs/changes/35/679935/1"}}},"commit":{"parents":[{"commit":"0ba24e5a8b6746105492ab01af6d01e7880e42c9","subject":"Select only necessary columns in allocation API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/0ba24e5a8b6746105492ab01af6d01e7880e42c9"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-08-31 15:37:07.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-09-04 08:37:41.000000000","tz":0},"subject":"Use status matching to avoid time comparison","message":"Use status matching to avoid time comparison\n\nTo get leases that has been not ended, we checked if each lease end\ntime is later than now, but if we go this way it costs to join\nall the reservation records since in reservation table has no column\nto describe when it starts or ends.\n\nTo reduce reservation records to join, we add exact status string\nmatchig instead time comparison.\n\nChange-Id: I988f5abf319e094eecf99e3cee2ebb1900bc47ab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/6a2fa23ed75185fc6e7d76c72704abefed1333d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/6a2fa23ed75185fc6e7d76c72704abefed1333d3"}]},"branch":"refs/heads/master"},"69942faa733baec7238815276c31685d26b261dc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-09-04 08:46:35.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/35/679935/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/blazar","ref":"refs/changes/35/679935/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/blazar refs/changes/35/679935/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/blazar refs/changes/35/679935/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/blazar refs/changes/35/679935/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/blazar refs/changes/35/679935/2"}}},"commit":{"parents":[{"commit":"0ba24e5a8b6746105492ab01af6d01e7880e42c9","subject":"Select only necessary columns in allocation API","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/0ba24e5a8b6746105492ab01af6d01e7880e42c9"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-08-31 15:37:07.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-09-04 08:46:16.000000000","tz":0},"subject":"Use status matching to avoid time comparison","message":"Use status matching to avoid time comparison\n\nTo get leases that has been not ended, we checked if each lease end\ntime is later than now, but if we go this way it costs to join\nall the reservation records since in reservation table has no column\nto describe when it starts or ends.\n\nTo reduce reservation records to join, we add exact status string\nmatchig instead time comparison.\n\nCo-Authored-By: Jacob Colleran \u003cjakecoll@uchicago.edu\u003e\nChange-Id: I988f5abf319e094eecf99e3cee2ebb1900bc47ab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/69942faa733baec7238815276c31685d26b261dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/69942faa733baec7238815276c31685d26b261dc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
