)]}'
{"blazar/plugins/floatingips/floatingip_plugin.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"4594eaff41bf6161d9fd7dedb1815648b11c7949","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                \u0027reservation_id\u0027: reservation_id})"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # Create new floating IPs if reservation is active"},{"line_number":101,"context_line":"        if reservation_status \u003d\u003d status.reservation.ACTIVE:"},{"line_number":102,"context_line":"            ctx \u003d context.current()"},{"line_number":103,"context_line":"            fip_pool \u003d neutron.FloatingIPPool(fip_reservation[\u0027network_id\u0027])"},{"line_number":104,"context_line":"            for fip_id in fip_ids_to_add:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_896859b9","line":101,"updated":"2019-09-24 08:14:56.000000000","message":"Adding LOG.debug() would be nice here.","commit_id":"f6f2a8cea2daa0958224c8ca785c9acf86ba0253"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0f556cd30498cb97b6c460caf56180e307b22484","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                \u0027reservation_id\u0027: reservation_id})"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # Create new floating IPs if reservation is active"},{"line_number":101,"context_line":"        if reservation_status \u003d\u003d status.reservation.ACTIVE:"},{"line_number":102,"context_line":"            ctx \u003d context.current()"},{"line_number":103,"context_line":"            fip_pool \u003d neutron.FloatingIPPool(fip_reservation[\u0027network_id\u0027])"},{"line_number":104,"context_line":"            for fip_id in fip_ids_to_add:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_342c15ab","line":101,"in_reply_to":"3fa7e38b_896859b9","updated":"2019-09-24 12:01:06.000000000","message":"Done","commit_id":"f6f2a8cea2daa0958224c8ca785c9acf86ba0253"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"4594eaff41bf6161d9fd7dedb1815648b11c7949","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                fip \u003d db_api.floatingip_get(fip_id)"},{"line_number":106,"context_line":"                fip_pool.create_reserved_floatingip("},{"line_number":107,"context_line":"                    fip[\u0027subnet_id\u0027], fip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                    ctx.project_id, fip_reservation[\u0027reservation_id\u0027])"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        for allocation in allocs_to_remove:"},{"line_number":111,"context_line":"            LOG.debug(\u0027Removing floating IP {} from reservation {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2948455a","line":108,"updated":"2019-09-24 08:14:56.000000000","message":"I feel this can block should be before L93-L98 because if fip_pool.create_reserved_floatingip() fails somehow we want to revert the following creation of fip allocations, don\u0027t we? \n\n    db_api.fip_allocation_create({\n                \u0027floatingip_id\u0027: fip_id,\n                \u0027reservation_id\u0027: reservation_id})","commit_id":"f6f2a8cea2daa0958224c8ca785c9acf86ba0253"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0f556cd30498cb97b6c460caf56180e307b22484","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                fip \u003d db_api.floatingip_get(fip_id)"},{"line_number":106,"context_line":"                fip_pool.create_reserved_floatingip("},{"line_number":107,"context_line":"                    fip[\u0027subnet_id\u0027], fip[\u0027floating_ip_address\u0027],"},{"line_number":108,"context_line":"                    ctx.project_id, fip_reservation[\u0027reservation_id\u0027])"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        for allocation in allocs_to_remove:"},{"line_number":111,"context_line":"            LOG.debug(\u0027Removing floating IP {} from reservation {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_54299198","line":108,"in_reply_to":"3fa7e38b_2948455a","updated":"2019-09-24 12:01:06.000000000","message":"Done","commit_id":"f6f2a8cea2daa0958224c8ca785c9acf86ba0253"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"a215d3f7003c01f8a987e913d251c99fc08e58c9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        fip[\u0027subnet_id\u0027], fip[\u0027floating_ip_address\u0027],"},{"line_number":106,"context_line":"                        ctx.project_id, reservation_id)"},{"line_number":107,"context_line":"                    created_fips.append(fip[\u0027floating_ip_address\u0027])"},{"line_number":108,"context_line":"                except Exception as e:"},{"line_number":109,"context_line":"                    for fip_address in created_fips:"},{"line_number":110,"context_line":"                        fip_pool.delete_reserved_floatingip(fip_address)"},{"line_number":111,"context_line":"                    err_msg \u003d \u0027Failed to create floating IP: {}\u0027.format(str(e))"},{"line_number":112,"context_line":"                    raise manager_ex.NeutronClientError(err_msg)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e6cec580","line":110,"range":{"start_line":108,"start_character":16,"end_line":110,"end_character":72},"updated":"2019-09-25 04:21:48.000000000","message":"++! nice error handling, thanks.","commit_id":"5da05941256c45d5795467abd890ac8d99d85456"}]}