)]}'
{"climate/tests/db/sqlalchemy/test_sqlalchemy_api.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"1d2a3b21c6e4cb4b4822224ca076958d9db13b0d","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                          host_allocation_id)"},{"line_number":561,"context_line":"        self.assertIsNone(db_api.host_allocation_get(host_allocation_id))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    # #Event"},{"line_number":564,"context_line":"    def test_event_create(self):"},{"line_number":565,"context_line":"        fake_event_type \u003d \u0027test_event\u0027"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fiys%3D","line":563,"updated":"2014-02-12 13:40:39.000000000","message":"Extra #?","commit_id":"3205af62c744fdb300e549d7161efa284e322aff"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"a7c0f5a1bc7721a49bfef3453520b7eba1d120c7","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        self.assertNotEqual("},{"line_number":545,"context_line":"            host_allocation.compute_host_id,"},{"line_number":546,"context_line":"            new_host_allocation.compute_host_id)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def test_host_allocation_destroy_for_host(self):"},{"line_number":549,"context_line":"        host_allocation \u003d db_api.host_allocation_create("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2FifM%3D","line":546,"updated":"2014-02-12 14:30:18.000000000","message":"Maybe do you need to test that was updated correctly.\nBTW, here you are updating the id too. Please try to make optional the id in _get_fake_host_allocation_values","commit_id":"a75391c65a129ccff31fc4a9241af88447d41ea8"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"a7c0f5a1bc7721a49bfef3453520b7eba1d120c7","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        self.assertRaises(RuntimeError, db_api.host_allocation_destroy,"},{"line_number":560,"context_line":"                          host_allocation_id)"},{"line_number":561,"context_line":"        self.assertIsNone(db_api.host_allocation_get(host_allocation_id))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    # Event"},{"line_number":564,"context_line":"    def test_event_create(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Fic8%3D","line":561,"updated":"2014-02-12 14:30:18.000000000","message":"I think it would be better move this line before the assertRaises.","commit_id":"a75391c65a129ccff31fc4a9241af88447d41ea8"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return {\u0027id\u0027: id,"},{"line_number":53,"context_line":"            \u0027lease_id\u0027: lease_id,"},{"line_number":54,"context_line":"            \u0027event_type\u0027: event_type,"},{"line_number":55,"context_line":"            \u0027time\u0027: _get_datetime(\u00272030-03-01 00:00\u0027),"},{"line_number":56,"context_line":"            \u0027status\u0027: status}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2FuU%3D","line":55,"updated":"2014-02-17 18:56:18.000000000","message":"If you put this harcoded, you wont be able to test properly the methods that sort records using this column.\nThis value should be a parameter of _get_fake_event_values()","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertFalse(db_api.event_get(\u00271\u0027))"},{"line_number":618,"context_line":"        self.assertRaises(RuntimeError, db_api.event_destroy, \u00271\u0027)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def test_event_get_first_sorted_by_event_type_filter(self):"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        fake_event_type \u003d \u0027test_event\u0027"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Fz0%3D","line":620,"updated":"2014-02-17 18:56:18.000000000","message":"This test will pass even if the filter isn\u0027t filtering. For example: if the code that does the filter is removed, the test will pass because the event \u00271\u0027 is still the first returned (due time is sort asc).\nI think that will be better if you add first an event with a type X and then two with type Y. Then, when you filter by Y, if you assert that the event 2 is the returned, you will be sure that the filter is working.","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        self.assertEqual(fake_event_type, filtered_events.event_type)"},{"line_number":639,"context_line":"        self.assertEqual(\u00271\u0027, filtered_events.id)"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def test_event_get_first_sorted_by_status_filter(self):"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        fake_status \u003d \u0027test_status\u0027"},{"line_number":644,"context_line":"        db_api.event_create(_get_fake_event_values("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Fzc%3D","line":641,"updated":"2014-02-17 18:56:18.000000000","message":"Same as before.","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        self.assertEqual(fake_status, filtered_events.status)"},{"line_number":659,"context_line":"        self.assertEqual(\u00271\u0027, filtered_events.id)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_event_get_first_sorted_by_lease_id_filter(self):"},{"line_number":662,"context_line":"        fake_lease_id \u003d \u00271234\u0027"},{"line_number":663,"context_line":"        db_api.event_create(_get_fake_event_values("},{"line_number":664,"context_line":"            id\u003d\u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2FzQ%3D","line":661,"updated":"2014-02-17 18:56:18.000000000","message":"Same as before.","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        self.assertEqual(fake_lease_id, filtered_events.lease_id)"},{"line_number":678,"context_line":"        self.assertEqual(\u00271\u0027, filtered_events.id)"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def test_event_get_sorted_by_event_type_filter(self):"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"        fake_event_type \u003d \u0027test_event\u0027"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2Fyc%3D","line":680,"updated":"2014-02-17 18:56:18.000000000","message":"This should test the sort too. Please add more events with the same event_type. Don\u0027t forget the previous comment.","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        self.assertEqual(1, len(filtered_events))"},{"line_number":698,"context_line":"        self.assertEqual(fake_event_type, filtered_events[0].event_type)"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def test_event_get_sorted_by_status_filter(self):"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        fake_status \u003d \u0027test_status\u0027"},{"line_number":703,"context_line":"        db_api.event_create(_get_fake_event_values("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2FyM%3D","line":700,"updated":"2014-02-17 18:56:18.000000000","message":"Same as before.","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"fea012f36f87f05c3e5215328be37e80bc683ad2","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        self.assertEqual(1, len(filtered_events))"},{"line_number":717,"context_line":"        self.assertEqual(fake_status, filtered_events[0].status)"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def test_event_get_sorted_by_lease_id_filter(self):"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        fake_lease_id \u003d \u00271234\u0027"},{"line_number":722,"context_line":"        db_api.event_create(_get_fake_event_values("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B%2FyA%3D","line":719,"updated":"2014-02-17 18:56:18.000000000","message":"Same as before.","commit_id":"65d1b7f4df98dd98858c6eab9f847e156a66c5c5"}]}